D25670: Synchronize decorations buttons order in GTK headerbars

apol added a comment. This looks like it's trying to change configurations from other sources. This feels wrong. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25670 To: gikari, #vdg, cblack, #plasma Cc: apol, GB_2, broulik, plasma-devel,

D26035: battery: Improve the brightness responsiveness

apol updated this revision to Diff 71743. apol added a comment. Use a more meaningful step size for the screen. Having steps of 1 in a 1 to 7000 slider was awkward. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26035?vs=71643=71743 BRANCH

D26069: Fix usage of deprecated QSet/QList methods

apol added a comment. Will all of this build on Qt 5.12? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26069 To: alexeymin Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D26051: Fix GHNS bug when we add a cursor theme you can't delete it or choose cursor size

apol added inline comments. INLINE COMMENTS > kcmcursortheme.cpp:458 > } > -m_themeModel->addTheme(list.join(QLatin1Char('/'))); > + > m_themeModel->addTheme(QString("/%1").arg(list.join(QLatin1Char('/'; >

D26035: battery: Improve the brightness responsiveness

apol created this revision. apol added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Use QQC2.Slider, so that we have a moved signal. This way we can only issue new brightnesses

D25967: Emit panelTakesFocus for other plamsashell types

apol added a comment. I'm not sure that I'm misunderstanding, does this mean that notifications might steal focus? REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D25967 To: davidedmundson, #plasma Cc: apol, plasma-devel,

D25978: Don't hardcode the margin of the CardsListView

This revision was automatically updated to reflect the committed changes. Closed by commit R169:2757a17bb089: Dont hardcode the margin of the CardsListView (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25978?vs=71491=71504 REVISION

D25978: Don't hardcode the margin of the CardsListView

apol added a comment. The path is private but the class is directly inherited. 路 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25978 To: apol, #kirigami Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, mart,

D25978: Don't hardcode the margin of the CardsListView

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Use the left/rightMargin properties with a default value, in case it makes sense to override it.

D25944: Let the other components grow if there's more things on the header

This revision was automatically updated to reflect the committed changes. Closed by commit R169:3aa7f59f9ebe: Let the other components grow if theres more things on the header (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D25942: Instead of just delaying, compress calls to update

apol abandoned this revision. apol added a comment. It was quite wrong REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25942 To: apol, #kirigami Cc: mart, ngraham, broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson,

D25944: Let the other components grow if there's more things on the header

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D25944 AFFECTED FILES

D25942: Instead of just delaying, compress calls to update

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Fixes an issue I was seeing where the size kept changing between updates. TEST PLAN Now the

D25908: Lock screen by default, on mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R122:0f75d80f23e8: Lock screen by default, on mobile (authored by apol). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25908?vs=71320=71414 REVISION DETAIL

D25908: Lock screen by default, on mobile

apol created this revision. apol added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY At the moment it will do the same thing as the desktop: show the logout dialog countdown, which

D25863: Remove traces of old GTK configs

apol added inline comments. INLINE COMMENTS > appearancegtk2.cpp:146 > { > -m_settings = QMap { > -{"toolbar_style", "GTK_TOOLBAR_ICONS"}, > -{"show_icons_buttons", "0"}, > -{"show_icons_menus", "0"}, > -{"primary_button_warps_slider", "false"} > -}; > +

D25860: [plasmoid] Show device battery percentage

apol added a comment. +1 cool! Really missed it. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D25860 To: broulik, #plasma, #vdg, drosca Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D25836: Remove redundant finder

This revision was automatically updated to reflect the committed changes. Closed by commit R99:0b815d1a88d5: Remove redundant finder (authored by apol). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25836?vs=71163=71164 REVISION DETAIL

D25836: Remove redundant finder

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It's already available in upstream cmake TEST PLAN built kde-gtk-config REPOSITORY R99 KDE Gtk Configuration Tool BRANCH master

D25826: [emojier] disable session manager

apol added a comment. In D25826#574375 , @ngraham wrote: > Hmm, I want this thing to be restored if the window was open when I restarted the machine though, right? Why? In case you forgot to choose an emoji? REPOSITORY R119 Plasma

D25823: Support locales with fallbacks

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f7f68c677b40: Support locales with fallbacks (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25823?vs=71130=71131 REVISION DETAIL

D25823: Support locales with fallbacks

apol updated this revision to Diff 71130. apol added a comment. Address things REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25823?vs=71129=71130 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25823 AFFECTED FILES

D25823: Support locales with fallbacks

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Jonathan uses en_GB.dict that diverges slightly from en.dict. They both should be taken into account

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

apol added a comment. Plasma master can depend on kf5 master. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D11748: Assign notification area category

apol added a comment. Already landed https://cgit.kde.org/kdeplasma-addons.git/commit/?id=d744370117bef4384bbd0e92fbcee4805169acaa REPOSITORY R134 Discover Software Store BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc: apol,

D11748: Assign notification area category

apol added a comment. Yes, I'd say so. wsdfhjxc, can you please give us your name to properly track the copyright of the line? REPOSITORY R134 Discover Software Store BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc: apol,

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4bdbd44facf0: Make startplasma more flexible so it can be leveraged by plasma mobile (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25750?vs=70920=70951#toc REPOSITORY

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > bshah wrote in main.cpp:93 > On second thought, scratch all this. For completion, this was already doable as is. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > alexeymin wrote in startplasma-wayland.cpp:91 > Currently I can edit simple shell script (kwinwrapper) and remove the > argument to kwin_wayland. If this is going to be hardcoded in the executable, > it cannot

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > alexeymin wrote in startplasma-wayland.cpp:91 > having `--xwayland` always by default will unfortunately break my device port > (xwayland crashes for me for some reason) This is not changing, --xwayland is

D25745: Showcase KConfig Issue with CamelCase keys on ManagedConfigModule

apol commandeered this revision. apol added a reviewer: tcanabrava. apol added a comment. This can be closed now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25745 To: apol, ervin, tcanabrava Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

apol created this revision. apol added reviewers: Plasma, bshah. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Allows specifying the shell through an environment variable. Allows forwarding command line

D25744: support userBackgroundhints in the scripting ui

apol added inline comments. INLINE COMMENTS > widget.h:71 > +QString userBackgroundHints() const; > +void setUserBackgroundHints(QString hint); > + const& or should it be Plasma::Types::BackgroundHints? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25709: Make it compile against qt5.14 without deprecated method

apol added inline comments. INLINE COMMENTS > kquickstyleitem.cpp:112 > +#else > +qmlRegisterAnonymousType("org.kde.qqc2-desktop-style", 1); > +#endif Maybe use `org.kde.qqc2desktopstyle.private` which we are already using? Also shouldn't we be registering the types and the plugin class

D25694: Port away from DesktopIcon

apol added a comment. The change looks good to me, can you provide a screenshot of before/after? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25694 To: nicolasfella, #plasma Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25671: Fix git builds against Qt 5.14

This revision was automatically updated to reflect the committed changes. Closed by commit R129:771ed0c4f8c2: Fix git builds against Qt 5.14 (authored by apol). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25671?vs=70706=70734 REVISION

D25671: Fix git builds against Qt 5.14

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It's not really acceptable to just error on everything since some of the solutions (like in this

D25617: MenuIcon: fix warnings when the drawer isn't initialized

This revision was automatically updated to reflect the committed changes. Closed by commit R169:1f56aba8449a: MenuIcon: fix warnings when the drawer isnt initialized (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25617?vs=70586=70686

D25618: Account for a mnemonic label to go back to ""

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e649887194f5: Account for a mnemonic label to go back to (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25618?vs=70587=70685 REVISION DETAIL

D25637: Port away from kglobalsettings

apol added inline comments. INLINE COMMENTS > componentchooserterminal.cpp:87 > Kdelibs4SharedConfig::syncConfigGroup(QLatin1String("General"), > "kdeglobals"); > > QDBusMessage message = > QDBusMessage::createMethodCall(QStringLiteral("org.kde.klauncher5"), No need to

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

apol added a comment. Maybe you can install one with the typo and one without, so Plasma and whatever else can be ported and start doing things properly. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D23005 To: kossebau, mart, broulik

D25618: Account for a mnemonic label to go back to ""

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY We are discarding the value if there's no weights which meant that when setting a button to "",

D25617: MenuIcon: fix warnings when the drawer isn't initialized

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Have a plan for when drawer isn't initialized TEST PLAN I don't get all the warnings from

D25612: Simplify load of locale variables

This revision was automatically updated to reflect the committed changes. Closed by commit R120:26284d73cf94: Simplify load of locale variables (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25612?vs=70568=70573 REVISION DETAIL

D25613: Remove generation of plasma-locale-settings.sh

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f5ab71acc03b: Remove generation of plasma-locale-settings.sh (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25613?vs=70572=70574

D25613: Remove generation of plasma-locale-settings.sh

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It's being addressed with D25612 TEST PLAN Builds, makes sense.

D25612: Simplify load of locale variables

apol updated this revision to Diff 70567. apol added a comment. Address david comment, merge all of the LANG things REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25612?vs=70555=70567 BRANCH master REVISION DETAIL

D25612: Simplify load of locale variables

apol updated this revision to Diff 70568. apol added a comment. Remember to sync REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25612?vs=70567=70568 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25612 AFFECTED FILES

D25612: Simplify load of locale variables

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Load l10n values using kconfig instead of sourcing a generated shell script from the kcm. TEST PLAN

D25604: Properly add data root to XDG_DATA_DIRS and only when necessary

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > startplasma.cpp:188 > > -// Make sure that the KDE prefix is first in XDG_DATA_DIRS and that it's > set at all. > -// The spec allows XDG_DATA_DIRS to

Re: New Gesture Implementation

Hi Leonardo, Reaching out to the Plasma developers mailing list, since it's where I guess this would be developed. Providing more details into how this could be included in Plasma would be useful to decide how your project would integrate. Aleix On Thu, Nov 28, 2019 at 9:24 AM Leonardo Pennino

Re: KInit - Current state and benchmarks

On Tue, Nov 26, 2019 at 8:57 AM Milian Wolff wrote: > > On Montag, 25. November 2019 22:57:11 CET Albert Astals Cid wrote: > > El dissabte, 23 de novembre de 2019, a les 11:47:40 CET, Milian Wolff va > escriure: > > > On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote: > > > > El

D22967: Let KDBusService deal with the replace option

This revision was automatically updated to reflect the committed changes. Closed by commit R120:569a303ba9a0: Let KDBusService deal with the replace option (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22967?vs=69146=70257

D25426: use the new GlobalDrawer header property

apol added inline comments. INLINE COMMENTS > DiscoverDrawer.qml:158 > } > - > -states: [ How's that related? at least the drawerOpen bit should stay. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25426 To: mart,

D25430: fix layout of overlaysheet

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Change looks good to me. Please resolve the comments before landing. INLINE COMMENTS > DummyTransaction.cpp:52 > setProgress(qBound(0, progress()+(KRandom::random()%30), 100)); > -

D25398: Check values have changed before setting the model

apol added a comment. The commit message looks wrong, maybe you meant PolicyKit? PackageKit should be irrelevant. Other than that +1 REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D25398 To: meven, #plasma Cc: apol, plasma-devel, LeGast00n,

D25185: Icon: solve threading issue on when the source is http

This revision was automatically updated to reflect the committed changes. Closed by commit R169:5cc8be3cd1fd: Icon: solve threading issue on when the source is http (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69422=69957

Re: Translate software

On Wed, Nov 13, 2019 at 9:38 AM David Rebolo Magariños wrote: > > Hello there, > > I was wondering if Plasma Mobile has an official site for translators to > translate their ROM to our respective languages? If so, what is it call? > > > > > Thank you for answering my question, > > > David Rebolo

D25227: Document Kirigami.Theme Better

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks like an improvement. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25227 To: zanny, apol Cc: apol, mart, plasma-devel, gennad, fbampaloukas, GB_2, domson,

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69422. apol edited the summary of this revision. apol added a comment. simplify connect REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69421=69422 BRANCH apol/iconthreading REVISION DETAIL

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69421. apol added a comment. Update commit text REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69420=69421 BRANCH apol/iconthreading REVISION DETAIL https://phabricator.kde.org/D25185 AFFECTED FILES

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69420. apol added a comment. Simplify the multithread situation with updatePolish REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69372=69420 BRANCH apol/iconthreading REVISION DETAIL

D25196: Perform KNS searches from the Featured page again

apol added a comment. How about we target master for this? INLINE COMMENTS > KNSBackend.cpp:507 > return stream; > -} else if ((m_hasApplications && !filter.category) // If there is no > category defined, we are searching in the root, and should include only > application

D25185: Icon: solve threading issue on when the source is http

apol added a comment. In D25185#559486 , @anthonyfieroni wrote: > Can we just use queued connection, it'll avoid mutex weirdness. Well, no. In fact, m_source is being accessed too unguarded from the different threads. REPOSITORY R169

D25185: Icon: solve threading issue on when the source is http

apol updated this revision to Diff 69372. apol added a comment. deadlock REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25185?vs=69371=69372 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25185 AFFECTED FILES src/icon.cpp src/icon.h

D25185: Icon: solve threading issue on when the source is http

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY For starters, QQmlEngine::networkAccessManager is not reentrant and would give us a warning

D25179: Don't move the drawer collapse button if there's no icon or image

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Otherwise it moves but the content doesn't extend because there's no images and it looks off.

D25174: Fix binding loop on toobig

This revision was automatically updated to reflect the committed changes. Closed by commit R169:1f7d5ff90879: Fix binding loop on toobig (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25174?vs=69350=69361 REVISION DETAIL

D25174: Fix binding loop on toobig

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Otherwise the buttons would not be shown in some cases TEST PLAN Now I can update with

D25124: Make env in plasma-sourceenv.sh call portable

apol added a comment. Can you add a comment about this? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25124 To: swills, fvogt, adridg, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D25100: Mark all wallpaper plugins as addons

apol added a comment. > But the distro-provided version (openSUSE Tumbleweed) does not: Yes, this happens because distros don't take plasma-workspace as a dependency, but in your computer you do have plasma-workspace installed. REPOSITORY R114 Plasma Addons REVISION DETAIL

D25100: Mark all wallpaper plugins as addons

apol added a comment. I just looked into it, the problem is that `plasma_packagestructure_wallpaper.so` is installed by plasma-workspace, which isn't a dependency of kdeplasma-addons. One thing we could do is update this patch to have `X-KDE-ParentApp=org.kde.plasmashell` instead of

D22967: Let KDBusService deal with the replace option

apol updated this revision to Diff 69146. apol added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22967?vs=63186=69146 BRANCH arcpatch-D22967 REVISION DETAIL https://phabricator.kde.org/D22967 AFFECTED FILES

D25100: Mark all wallpaper plugins as addons

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Yes, it's the wrong fix. For reference, it's not about discover, it's about generating the appstream file properly. Will try to provide a patch next week. REPOSITORY R114

D25093: ksmserver: remove unused explicit dependency to Phonon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ae130775e865: ksmserver: remove unused explicit dependency to Phonon (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25093: ksmserver: remove unused explicit dependency to Phonon

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It may be used through KNotifications TEST PLAN Builds REPOSITORY R120 Plasma Workspace BRANCH

D25086: [WIP] Port to KGlobalAccel

apol added inline comments. INLINE COMMENTS > globalaccel.cpp:50 > + > +QKeySequence GlobalAccel::getMenuEntryShortcut(const QString ) > +{ Why just return one if it can be a list? > globalaccel.h:27 > +public: > +static QKeySequence getMenuEntryShortcut(const QString ); > +static void

D25045: kimpanel: don't crash when ibus is already loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R119:299f298d168f: kimpanel: dont crash when ibus is already loaded (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25045?vs=68980=69108

D24856: Add a .desktop file to ksplashqml

apol added inline comments. INLINE COMMENTS > ksplashqml.desktop.cmake:7 > +Type=Application > +X-KDE-Wayland-Interfaces=org_kde_plasma_window_management > + Are you sure the wayland interface is required? It seems like the warning is broken, so we could just as well remove it. REPOSITORY

D25045: kimpanel: don't crash when ibus is already loaded

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY No need to replace the current engine if we already have an acceptable one set. Otherwise it confuses Qt and it asserts in Qt. 7

D25002: disable bug report when there are signs of an update

apol added inline comments. INLINE COMMENTS > drkonqibackends.cpp:172 > + > +a->m_deletedFiles = deletedPaths; > + Maybe we don't need to store all of them? I only see it used as "isEmpty()". REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D25002 To: sitter,

D24985: [wallpapers/image] Seed random number generator

apol added a comment. Let's use KCoreAddons/KRandom? These things don't happen there. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24985 To: davidedmundson, #plasma, ngraham Cc: apol, anthonyfieroni, plasma-devel, LeGast00n,

D24945: [ksmserver] Signal session management state to kwin directly

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in org.kde.KWin.Session.xml:7 > There was a third option I considered. Have N methods > > startSave > startQuit > saveCancelled > > and then make the state change an implicit part of the invokable action we > need to do on

D24945: [ksmserver] Signal session management state to kwin directly

apol added a comment. Looks good to me overall. It's better to use dbus. INLINE COMMENTS > org.kde.KWin.Session.xml:7 > + > + > + Here it recommends using uint for such things: https://dbus.freedesktop.org/doc/dbus-api-design.html#interface-files REPOSITORY

D24935: Fix search field focus, both initial and on-demand

apol added a comment. Sure, it makes sense. It's not really changing much, only removing the loader. The loader did make things slightly more complex so I can imagine this working better. The whole `Component.onCompleted: {` bit is what gives it the focus. Having the focus

D24935: Fix search field focus, both initial and on-demand

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Let's give it a try, merge to master, this could have side-effects. INLINE COMMENTS > DiscoverDrawer.qml:85 > +id: searchField > +focus: true > This

D24894: notifier: Make action buttons translatable

apol accepted this revision. apol added a comment. Good catch! I wonder how that happened :/ REPOSITORY R134 Discover Software Store BRANCH notifier-i18n REVISION DETAIL https://phabricator.kde.org/D24894 To: aspotashev, apol, broulik Cc: broulik, plasma-devel, LeGast00n,

D24733: feedback kcm: Make it about Plasma

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2dd40cfb21b4: feedback kcm: Make it about Plasma (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68620=68621 REVISION DETAIL

D24733: feedback kcm: Make it about Plasma

apol added a comment. I integrated David's idea to move this patch forward, but I think here we should look into move this text elsewhere: https://cgit.kde.org/kuserfeedback.git/tree/src/provider/core/feedbackconfiguicontroller.cpp#n188 In this text we are talking about why to enable

D24733: feedback kcm: Make it about Plasma

apol updated this revision to Diff 68620. apol added a comment. Integrate David's feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68184=68620 BRANCH nokillswitch REVISION DETAIL https://phabricator.kde.org/D24733 AFFECTED

D24733: feedback kcm: Make it about Plasma

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:116 > I don't understand this top line Yeah... feedbackController.telemetryDescription() function depends on applicationName, but since it's a function we don't have a way to

D24890: Report windowing system

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:30 > -Notifications IdleTime) > -if(APPLE) > -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS WindowSystem) Do we know why this was done? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D24890

D24888: Rename kded Networkmanagement -> Network Management

This revision was automatically updated to reflect the committed changes. Closed by commit R116:13272821d3c3: Rename kded Networkmanagement - Network Management (authored by apol). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D24888: Rename kded Networkmanagement -> Network Management

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. apol requested review of this revision. REVISION SUMMARY This is a user-visible string and it reads very weird as is REPOSITORY

D24879: [ComboBox] Follow focusPolicy

apol added a comment. Wouldn't it make more sense to not accept the event then? INLINE COMMENTS > ComboBox.qml:79 > onPressed: { > +if ((controlRoot.focusPolicy & Qt.ClickFocus) === Qt.ClickFocus) > { > +controlRoot.forceActiveFocus(); `if

D24877: RFC: Move shortcuts out of ksmserver into kglobalaccel

apol added a comment. +1 conceptually. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24877 To: davidedmundson, #plasma Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf,

D24832: Re-add category display to app delegates

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Let's try and see what it feels like INLINE COMMENTS > ApplicationDelegate.qml:77 > +level: delegateArea.compact ? 3 : 2 > +Layout.fillWidth:

D24785: Store stashed model index as QPersistentModelIndex

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes a lot of sense. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D24785 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel,

Re: Discover and KSysGuard in kde.org/applications?

hey're standalone > apps that can be installed without Plasma, after all. > > Nate > > > > On 10/18/19 3:03 PM, Aleix Pol wrote: > > On Fri, Oct 18, 2019 at 2:11 PM Jonathan Riddell wrote: > >> > >> Would Plasma team like these listed on the KDE Apps webp

Re: Discover and KSysGuard in kde.org/applications?

On Fri, Oct 18, 2019 at 2:11 PM Jonathan Riddell wrote: > > Would Plasma team like these listed on the KDE Apps webpage? So far I've not > had them because Plasma is a product of KDE that is not a standalone app. Hi Jonathan, I would say it's okay that they are not, I agree with your resoning.

<    1   2   3   4   5   6   7   8   9   10   >