D24766: Revert change to make the notification persistent

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land.  REPOSITORY R134 Discover Software Store BRANCH revert-sticky-notifications (branched from Plasma/5.17) REVISION DETAIL https://phabricator.kde.org/D24766 To: ngraham, apol, broulik,

D24766: Revert change to make the notification persistent

apol added a comment. Other than that, LGTM INLINE COMMENTS > DiscoverNotifier.cpp:67 > KRun::runCommand(QStringLiteral("plasma-discover"), nullptr); > -if (m_updatesAvailableNotification) { > m_updatesAvailableNotification->close(); } > } I wouldn't remove these. It's good that

D24733: feedback kcm: Make it about Plasma

apol added a comment. Oh, I see what you mean, this text is entirely coming from KUserFeedback. Maybe it's something we can tackle there: https://phabricator.kde.org/source/kuserfeedback/browse/master/src/provider/core/feedbackconfiguicontroller.cpp$187 REPOSITORY R120 Plasma Workspace

D24733: feedback kcm: Make it about Plasma

apol updated this revision to Diff 68184. apol added a comment. update the description with the applicationName change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68181=68184 BRANCH nokillswitch REVISION DETAIL

D24733: feedback kcm: Make it about Plasma

apol updated this revision to Diff 68181. apol added a comment. Ehm... REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68153=68181 BRANCH nokillswitch REVISION DETAIL https://phabricator.kde.org/D24733 AFFECTED FILES

D24733: feedback kcm: Make it about Plasma

apol added a comment. In D24733#549186 , @ngraham wrote: > In D24733#549185 , @apol wrote: > > > It's changed in the last iteration of the patch. You probably enabled the kill switch on the present

D24733: feedback kcm: Make it about Plasma

apol added a comment. It's changed in the last iteration of the patch. You probably enabled the kill switch on the present version of the kcm. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24733 To: apol, #plasma, vkrause, davidedmundson, ngraham Cc:

D24732: Rewrite AppChooser dialog

apol added a comment. +1 looks much better REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24733: feedback kcm: Make it about Plasma

apol updated this revision to Diff 68153. apol marked an inline comment as done. apol added a comment. Remove duplicated text, disable when the kill switch is on REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68135=68153 BRANCH

D24733: feedback kcm: Make it about Plasma

apol created this revision. apol added reviewers: Plasma, vkrause, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY At the moment we were merging two different concepts into a same KCM and

D24712: [Updates page] Add text to the checkbox instead of putting it in a separate label

apol added a comment. You can test using `--backends dummy`. To enable the build of the dummy backend, you pass -DBUILD_DummyBackend=ON to cmake. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24712 To: ngraham, apol, #discover_software_store Cc:

D24564: Fix warning when we're not hovering a Control

This revision was automatically updated to reflect the committed changes. Closed by commit R858:bcc30eb31a27: Fix warning when were not hovering a Control (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D24503: Integrate the normal keyboard layout switcher

apol added a comment. > Can that work be resumed/used? See D14796 . It seems like the original author is MIA. I rebased the patch, seems to work but adopting it will set us back as the ibus backend was never implemented. REPOSITORY R119 Plasma

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

apol added a comment. I'll insist, this KCM is distributed by Plasma. An Okular user on Windows won't have it available, this makes for tendentious data. Even with Plasma users, the process of explaining people "you have to go to enable it in system settings, then you go to enable it

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

apol added a comment. > Ok, just tried this out. The problem is that the global on/off switch that's presented to the user is still reversed from what it should be: instead of saying, "forbid KDE software from bla bla bla", it should say "allow KDE software to bla bla bla". Otherwise the

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

apol added a comment. So I decided to rebase the patch onto current master. I pushed it rebased into a branch called `apol/D14796` because I didn't know whether to take over this review. I would appreciate it if someone could help me tell why it wasn't merged. I see: > It needs a

D24503: Integrate the normal keyboard layout switcher

apol added a comment. This got landed by arc together with another patch. I didn't mean to land it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24503 To: apol, #plasma Cc: hein, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24653: discover: check package status before trying to install/update it

This revision was automatically updated to reflect the committed changes. Closed by commit R134:dd9ba961d7e9: discover: check package status before trying to install/update it (authored by alnikiforov, committed by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D24653: discover: check package status before trying to install/update it

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Please submit to master. INLINE COMMENTS > PackageKitBackend.cpp:586 > > +if ((info == PackageKit::Transaction::InfoRemoving) || (info == > PackageKit::Transaction::InfoObsoleting)) { >

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

apol added a comment. In D24635#547136 , @ngraham wrote: > Thanks. Can we just surface that then? We'd show a UI for the global on/off switch and than additionally allow turning telemetry on or off for apps and Plasma. That seems like it might

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Show the kill switch as such. It's about fordbidding all applications to submit data. They will be

D24470: feedback kcm: Use a horizontal slider like GammaRay does

This revision was automatically updated to reflect the committed changes. Closed by commit R120:42511d6f404b: feedback kcm: Use a horizontal slider like GammaRay does (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24470?vs=67472=67902#toc REPOSITORY R120 Plasma

D24503: Integrate the normal keyboard layout switcher

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:f2e579f9b366: Integrate the normal keyboard layout switcher (authored by apol). REPOSITORY R119 Plasma Desktop

D24454: Include an emoji picker

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1449633fccfa: Include an emoji picker (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67730=67897 REVISION DETAIL

D24454: Include an emoji picker

apol added a comment. In D24454#546320 , @davidedmundson wrote: > > Why isn't it managing to send the paste data to klipper before quitting? > > How? > > 1. We announce "I have some new data" to X. > 2. Then klipper sees that, then

D24601: [mobile/wifi] Use network name as title for settings page

apol added inline comments. INLINE COMMENTS > ConnectionItemDelegate.qml:114 > onTriggered: { > -kcm.push("NetworkSettings.qml", {path: ConnectionPath}) > +kcm.push("NetworkSettings.qml", {path: ConnectionPath, name: > ItemUniqueName}) >

D24454: Include an emoji picker

apol added a comment. In D24454#545964 , @hein wrote: > If I understand right, the emoji workflow this implements is via copy-paste, it can't directly insert into the text fields via the IME bus. Do you have a plan for that? It has the

D24503: Integrate the normal keyboard layout switcher

apol added a comment. I don't claim to solve the whole problem, it's just a step forward. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24503 To: apol, #plasma Cc: hein, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24580: Fix minor EBN issues

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24580 To: yurchor, #plasma, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24454: Include an emoji picker

apol updated this revision to Diff 67730. apol added a comment. Fix on wayland (and x11?) Don't ever close the process, leave it on background REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67726=67730 BRANCH arcpatch-D24454_1

D24564: Fix warning when we're not hovering a Control

apol created this revision. apol added reviewers: Kirigami, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Also remove hardcoded value that has a setting TEST PLAN Manual test REPOSITORY R858 Qt

D24454: Include an emoji picker

apol updated this revision to Diff 67726. apol added a comment. Don't always show the search field REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67725=67726 BRANCH arcpatch-D24454_1 REVISION DETAIL https://phabricator.kde.org/D24454

D24454: Include an emoji picker

apol updated this revision to Diff 67725. apol added a comment. Move search field REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67724=67725 BRANCH arcpatch-D24454_1 REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED FILES

D24454: Include an emoji picker

apol updated this revision to Diff 67724. apol added a comment. Make the main function more similar to discover's REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67717=67724 BRANCH arcpatch-D24454_1 REVISION DETAIL

D24454: Include an emoji picker

apol added a comment. In D24454#545454 , @ngraham wrote: > A few more: > > - List the categories in a more common order rather than alphabetical (i.e. first smilies, then nature, then food & drink, etc. Basically copy the mobile emoji

D24454: Include an emoji picker

apol updated this revision to Diff 67717. apol added a comment. Fix & REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67716=67717 BRANCH arcpatch-D24454_1 REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED FILES

D24454: Include an emoji picker

apol updated this revision to Diff 67716. apol added a comment. Address Nate and GB comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67711=67716 BRANCH arcpatch-D24454_1 REVISION DETAIL https://phabricator.kde.org/D24454

D24454: Include an emoji picker

apol added a comment. In D24454#545324 , @ngraham wrote: > How can I test this out? Do I need to have IBus set up? You just need to make sure it's installed, here we're only using it as a library. Then run the `ibus-ui-emojier-plasma`

D24454: Include an emoji picker

apol updated this revision to Diff 67711. apol added a comment. Address marco's comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67511=67711 BRANCH arcpatch-D24454_1 REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED

D24474: Show menu items tooltip text

This revision was automatically updated to reflect the committed changes. Closed by commit R169:0993c1c70678: Show menu items tooltip text (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24474?vs=67449=67583#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D24503: Integrate the normal keyboard layout switcher

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in layout.js:38 > Do we also need a plasma upgrade script if we remove the SNI from kded/kwin I'd say so. We can do it when we deprecate the SNI though, unless you really want it now. I've never done it so I'll have to research

D24503: Integrate the normal keyboard layout switcher

apol updated this revision to Diff 67514. apol added a comment. Send a sensible font size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24503?vs=67513=67514 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24503 AFFECTED FILES

D24503: Integrate the normal keyboard layout switcher

apol updated this revision to Diff 67513. apol added a comment. Remove unused function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24503?vs=67512=67513 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24503 AFFECTED FILES

D24503: Integrate the normal keyboard layout switcher

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This deprecates the SNI from KWin in favour of this plasmoid that will allow doing the same as well as

D24454: Include an emoji picker

apol updated this revision to Diff 67511. apol added a comment. Forgot to add these files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67486=67511 BRANCH arcpatch-D24454 REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED

D24501: Use MenuItem's action property directly in ActionMenuItem

apol added a comment. +1 INLINE COMMENTS > ActionMenuItem.qml:26 > > -property QtObject ourAction > - > -text: ourAction.text > -visible: ourAction.visible !== undefined ? ourAction.visible : true > -enabled: ourAction.enabled > -checkable: ourAction.checkable > -

D24498: Properly check enabled state of Action for ActionToolBar buttons

apol added a comment. +1 otherwise INLINE COMMENTS > ActionToolBar.qml:126 > opacity: x + width <= parent.width > -enabled: opacity > +enabled: opacity && modelData.enabled > I'd do the enabled && opacity, it feels very wrong

D5961: Adoption of KUserFeedback for Discover

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f1f1597f4f2e: Adoption of KUserFeedback for Discover (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5961?vs=67448=67487#toc REPOSITORY R134 Discover Software Store

D24454: Include an emoji picker

apol marked an inline comment as done. apol added a comment. In D24454#543560 , @davidedmundson wrote: > From my POV, +1, though it would be worth outlining your longer term plans after this initial step. > > Right now it doesn't really use

D24454: Include an emoji picker

apol updated this revision to Diff 67486. apol added a comment. Add window title REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67485=67486 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED FILES

D24454: Include an emoji picker

apol updated this revision to Diff 67485. apol added a comment. Icon for recent REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67484=67485 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED FILES

D24454: Include an emoji picker

apol updated this revision to Diff 67484. apol added a comment. Include a recent category, other comments addressed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67413=67484 BRANCH master REVISION DETAIL

D24470: feedback kcm: Use a horizontal slider like GammaRay does

apol updated this revision to Diff 67472. apol added a comment. ehm, typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24470?vs=67471=67472 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24470 AFFECTED FILES

D24470: feedback kcm: Use a horizontal slider like GammaRay does

apol updated this revision to Diff 67471. apol added a comment. Address kai's comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24470?vs=67435=67471 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24470 AFFECTED FILES

D24474: Show menu items tooltip text

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Displays a tooltip with the action's tooltip text TEST PLAN Manually REPOSITORY R169 Kirigami

D5961: Adoption of KUserFeedback for Discover

apol updated this revision to Diff 67448. apol added a comment. ++verbosity WRT the server error, I'd like to have the patch in before configuring the server to acknowledge Discover. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D5961: Adoption of KUserFeedback for Discover

apol updated this revision to Diff 67441. apol added a comment. oops sources page title REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=67423=67441 BRANCH arcpatch-D5961_3 REVISION DETAIL https://phabricator.kde.org/D5961

D5961: Adoption of KUserFeedback for Discover

apol added a comment. In D5961#543062 , @ngraham wrote: > So close! The Settings page still says "Sources" in its header rather than "Settings." > > Also it might be nice to have the actions visible on the toolbar when there's room rather

D24470: feedback kcm: Use a horizontal slider like GammaRay does

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Instead of a combo box, which is a bit harder on the wording. Also get more texts from kuserfeedback

D24452: Un-break remote input portal

This revision was automatically updated to reflect the committed changes. Closed by commit R838:91793221302e: Un-break remote input portal (authored by apol). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D5961: Adoption of KUserFeedback for Discover

apol updated this revision to Diff 67423. apol added a comment. Move options to Sources, rename Sources back to Settings REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=67200=67423 BRANCH arcpatch-D5961_2 REVISION DETAIL

D24454: Include an emoji picker

apol updated this revision to Diff 67413. apol added a comment. Remove unused empty file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67412=67413 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED FILES

D24454: Include an emoji picker

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Shows all emoji in categories, it will save the new emoji into the clipboard. TEST PLAN Manual

D24414: No need to keep ibus 1.4.* compatibility anymore

This revision was automatically updated to reflect the committed changes. Closed by commit R119:95c8ae371483: No need to keep ibus 1.4.* compatibility anymore (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24414?vs=67325=67411

D24452: Un-break remote input portal

apol created this revision. apol added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Have it document that it will be using the fake keys protocol TEST PLAN Tested manually

D24414: No need to keep ibus 1.4.* compatibility anymore

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY 1.5 was first released in July 2014, I don't see why keep it around. TEST PLAN Still builds REPOSITORY

D24414: No need to keep ibus 1.4.* compatibility anymore

apol updated this revision to Diff 67325. apol added a comment. Remove unneeded if REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24414?vs=67323=67325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24414 AFFECTED FILES

D24408: Use the right icon depending on the layout

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f9fef4eb5c8f: Use the right icon depending on the layout (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24408?vs=67296=67322 REVISION

D24408: Use the right icon depending on the layout

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY If we're showing the icons in a horizontal layout, the < and > buttons feel like it should be selecting

D24393: Switch from naked KConfig to KConfigXT

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24393 To: ervin, #plasma, mart, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D5961: Adoption of KUserFeedback for Discover

apol added a comment. In D5961#540955 , @ngraham wrote: > So this patch adds a semi-hidden menu item on the About page that opens the User Feedback KCM in a KCMShell window. I think this needs a better UX: > > 1. We finally need a real

D5961: Adoption of KUserFeedback for Discover

apol updated this revision to Diff 67200. apol added a comment. Fix build REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=66322=67200 BRANCH arcpatch-D5961 REVISION DETAIL https://phabricator.kde.org/D5961 AFFECTED FILES

D24011: Provide a telemetrics kcm module for Plasma

This revision was automatically updated to reflect the committed changes. Closed by commit R120:15dd744a3ba4: Provide a telemetrics kcm module for Plasma (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24011?vs=67184=67192#toc REPOSITORY R120 Plasma Workspace

D24011: Provide a telemetrics kcm module for Plasma

apol added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:68 > These strings still need to be re-worded, and possibly collapsed, and > possible the whole UI needs to be re-thought. What if I want to submit > detailed system information but only basic usage information? Maybe we

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 67184. apol added a comment. Better looking margins REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=67130=67184 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011 AFFECTED FILES

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 67130. apol added a comment. move panelsourcecount into a separate file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66475=67130 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011

D24156: Don't require QtGui for the PaginateModel test

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I'm not sure what we're winning, but sure. REPOSITORY R134 Discover Software Store BRANCH dont-require-qtgui-for-paginatemodel-test (branched from master) REVISION DETAIL

D24080: Fix copying urls to the clipboard

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:296fa55e21c0: Fix copying urls to the clipboard (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66475. apol added a comment. Polish REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66467=66475 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011 AFFECTED FILES CMakeLists.txt

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66467. apol added a comment. Iterated with Nate's feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66351=66467 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011 AFFECTED

D24080: Fix copying urls to the clipboard

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Addresses an original porting issue. TEST PLAN Addresses the issue in the feedback kcm I've been

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66351. apol added a comment. Include a provider for plasmashell REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66342=66351 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011 AFFECTED

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66342. apol marked an inline comment as done. apol added a comment. Don't use "telemetry" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66298=66342 BRANCH master REVISION DETAIL

D24011: Provide a telemetrics kcm module for Plasma

apol marked 2 inline comments as done. apol added inline comments. INLINE COMMENTS > aspotashev wrote in feedback.cpp:41 > "telemetry" is also ambiguous. These are also telemetries: > > 1. Ksysguard daemon, > 2. GPS and altitude measurements being received from a UAV. He was suggesting moving

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol updated this revision to Diff 66322. apol added a comment. Use KDE's server REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=66273=66322 BRANCH arcpatch-D5961_1 REVISION DETAIL https://phabricator.kde.org/D5961 AFFECTED

D24011: Provide a telemetrics kcm module for Plasma

apol added a comment. Hey @ngraham, I introduced many of your points to the proposal. Here's some thoughts on the rest: > Apps that collect information I don't think we can do this, at least not right now, easily. Non-Plasma products (dolphin, krita) will need to have their own KCM

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol added a comment. > Shouldn't these be in Kirigami, then? Let's see what it ends up looking like, we've already moved half this patch to plasma-workspace. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5961 To: apol, #plasma, vkrause Cc:

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66298. apol added a comment. Improve how we display plasma settings REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66292=66298 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66292. apol added a comment. Copyrights REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66291=66292 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011 AFFECTED FILES CMakeLists.txt

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 66291. apol added a comment. Include the policy, KUserfeedback decides the setting default, polishing. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=66272=66291 BRANCH master REVISION DETAIL

D24011: Provide a telemetrics kcm module for Plasma

apol added a comment. F7368902: Screenshot_20190917_142756.png Screenshot, I thought I'd uploaded it already. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24011 To: apol, #plasma, vkrause Cc: davidedmundson,

D24011: Provide a telemetrics kcm module for Plasma

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in feedback.cpp:16 > Is including kdeglobals here deliberate? > > KUserFeedback won't read it..but maybe it makes sense? This setting needs to be read by every Plasma component, these can

D24011: Provide a telemetrics kcm module for Plasma

apol added a comment. In D24011#533038 , @broulik wrote: > Should we make it already a "Privacy" KCM just in case? No, I don't think this will undermine our users' privacy. If it did, I (we?) wouldn't be adding telemetry at all. This

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol updated this revision to Diff 66273. apol added a comment. Remove the dialog and read the settings globally for Plasma. Moved the feedback settings to the About page. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=65968=66273

D24011: Provide a telemetrics kcm module for Plasma

apol created this revision. apol added reviewers: Plasma, vkrause. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It offers 2 main features: - Configure the system-wide KUserFeedback kill-switch - Provide

D24005: Show a new version string description for updates where the old and new versions are identical

apol added a comment. Having 3 identical labels with slightly different conditions feels odd, maybe we should just take it into account if when assigning the property? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24005 To: ngraham, #vdg,

D23727: Provide a simple test tool to see what autostart will look like

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e7cc46fad0c2: Provide a simple test tool to see what autostart will look like (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23727?vs=65441=66224#toc REPOSITORY R120

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol updated this revision to Diff 65968. apol added a comment. Rename property REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=65967=65968 BRANCH arcpatch-D5961_1 REVISION DETAIL https://phabricator.kde.org/D5961 AFFECTED

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol updated this revision to Diff 65967. apol added a comment. Rebase REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=32897=65967 BRANCH arcpatch-D5961_1 REVISION DETAIL https://phabricator.kde.org/D5961 AFFECTED FILES

D23784: Remove custom content item from ActionMenu separator

apol added a comment. Other than that, LGTM +1 INLINE COMMENTS > ActionsMenu.qml:32 > property Component itemDelegate: Component {ActionMenuItem {}} > -property Component separatorDelegate: Component { > -Controls.MenuSeparator { > -contentItem: Rectangle { > -

<    1   2   3   4   5   6   7   8   9   10   >