[Differential] [Commented On] D4171: [Task Manager] Remove arbitrary sizes from tooltip

anthonyfieroni added a comment. OK i see it's doubled. So one of those must accepted, current situation is completely frustrating. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4171 EMAIL PREFERENCES

[Differential] [Request, 17 lines] D4491: Let make taskmanager tooltip readable again

anthonyfieroni created this revision. anthonyfieroni added reviewers: Plasma, Plasma: Design. anthonyfieroni added subscribers: davidedmundson, hein, subdiff. anthonyfieroni set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

anthonyfieroni added a comment. In work i'm on 5.8 :) I don't know what you want to see in screenshot when we talk to pixel density i.e. it depends on diagonal inches. I will update patch with heading levels instead of labels and no magic numbers, later this night :) REPOSITORY R119

[Differential] [Planned Changes To] D4491: Let make taskmanager tooltip readable again

anthonyfieroni planned changes to this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4491 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, #plasma:_design Cc: broulik, subdiff, hein,

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Ян. 22, 2017, 6:19 след обяд, Martin Gräßlin wrote: > > Marco quite recently implemented this: > > > > https://cgit.kde.org/plasma-desktop.git/commit/kcms/lookandfeel?id=81be6962b1e43ea4da7caa038fa87d84a3129937 > > Anthony Fieroni wrote: > Maybe

Re: Review Request 129868: [lookandfeel] Complete breeze look and feel

marked as submitted. Review request for Plasma, Hugo Pereira Da Costa and Marco Martin. Changes --- Submitted with commit 35b1ac0fcda5eea4d49b290ba346105343f422a9 by Anthony Fieroni to branch Plasma/5.9. Repository: plasma-workspace Description --- Apply window decoration Diffs

Re: Review Request 129872: [lookandfeel] Support changing window decoration

d to 5.8? - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102179 --- On Ян. 22, 2017, 3:05 след обяд,

Re: Review Request 129869: Complete breeze-dark look and feel

marked as submitted. Review request for Plasma, Hugo Pereira Da Costa and Marco Martin. Changes --- Submitted with commit 15710ad10f8bf69dd268e5d36f423e392e0c4a9d by Anthony Fieroni to branch Plasma/5.9. Repository: breeze Description --- Apply breeze window decoration Diffs

Re: Review Request 129867: Complete oxygen look and feel

--- Thanks, Anthony Fieroni

Review Request 129875: [kcm] Fix reset logic

reset button 4. It'll able to save changes again Thanks, Anthony Fieroni

Re: Review Request 129872: [lookandfeel] Support changing window decoration

/lookandfeel/kcm.h c27b7f3d kcms/lookandfeel/kcm.cpp 6ea3d050 Diff: https://git.reviewboard.kde.org/r/129872/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129872: [lookandfeel] Support changing window decoration

/lookandfeel/kcm.h c27b7f3d kcms/lookandfeel/kcm.cpp 6ea3d050 Diff: https://git.reviewboard.kde.org/r/129872/diff/ Testing --- Thanks, Anthony Fieroni

[Differential] [Commented On] D4301: [System Tray] SNI fallback to context menu on failing Activate

anthonyfieroni added a comment. > - Guard code execution in `StatusNotifierItemSource::activate` against deleted `m_statusNotifierItemInterface` by comparing it to the old pointer value You can't do that in this way, do this QPointer snii = m_statusNotifierItemInterface; if

Re: Review Request 129872: [lookandfeel] Support changing window decoration

/lookandfeel/kcm.cpp 6ea3d050 Diff: https://git.reviewboard.kde.org/r/129872/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129872: [lookandfeel] Support changing window decoration

is this method for, your change nowhere calls it? Same as above. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102292 ---

Re: Review Request 129872: [lookandfeel] Support changing window decoration

eel/autotests/lookandfeel/contents/defaults ef3165de kcms/lookandfeel/kcm.h c27b7f3d kcms/lookandfeel/kcm.cpp 6ea3d050 Diff: https://git.reviewboard.kde.org/r/129872/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129872: [lookandfeel] Support changing window decoration

5de kcms/lookandfeel/kcm.h c27b7f3d kcms/lookandfeel/kcm.cpp 6ea3d050 Diff: https://git.reviewboard.kde.org/r/129872/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129835: [IconDialog] Set proper icons group

> On Ян. 21, 2017, 7:24 преди обяд, Anthony Fieroni wrote: > > All IconDialogs from QML are with small and hard to visible icons e.g. > > Kicker (right click -> change icon -> small icons) Ping - Anthony --- Thi

Review Request 129867: Complete oxygen look and feel

Description --- Applying oxygen in lookandfeel kcm should set desktop theme and decorations to oxygen Diffs - lookandfeel/contents/defaults 571a7c65 Diff: https://git.reviewboard.kde.org/r/129867/diff/ Testing --- Thanks, Anthony Fieroni

Review Request 129868: [lookandfeel] Complete breeze look and feel

-workspace Description --- Apply window decoration Diffs - lookandfeel/contents/defaults 4b05b92f Diff: https://git.reviewboard.kde.org/r/129868/diff/ Testing --- Thanks, Anthony Fieroni

Review Request 129869: Complete breeze-dark look and feel

Description --- Apply breeze window decoration Diffs - lookandfeel.dark/contents/defaults b491d470 Diff: https://git.reviewboard.kde.org/r/129869/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129867: Complete oxygen look and feel

on. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129867/#review102169 --- On Ян. 22, 2017, 7:42 преди обяд, Anthon

Re: Review Request 129867: Complete oxygen look and feel

--- Thanks, Anthony Fieroni

Re: Review Request 129868: [lookandfeel] Complete breeze look and feel

Pereira Da Costa and Marco Martin. Repository: plasma-workspace Description --- Apply window decoration Diffs - lookandfeel/contents/defaults 4b05b92f Diff: https://git.reviewboard.kde.org/r/129868/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129835: [IconDialog] Set proper icons group

icons e.g. Kicker (right click -> change icon -> small icons) - Anthony Fieroni On Ян. 15, 2017, 12:27 след обяд, Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Ян. 25, 2017, 11:30 преди обяд, Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) > > Martin Gräßlin wrote:

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 25, 2017, 11:30 a.m., Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) > > Martin Gräßlin wrote: > Bu

Re: Review Request 129835: [IconDialog] Set proper icons group

> On Jan. 21, 2017, 7:24 a.m., Anthony Fieroni wrote: > > All IconDialogs from QML are with small and hard to visible icons e.g. > > Kicker (right click -> change icon -> small icons) > > Anthony Fieroni wrote: > Ping Marco, did you think this approa

Re: Review Request 129872: [lookandfeel] Support changing window decoration

> On Jan. 25, 2017, 11:30 a.m., Martin Gräßlin wrote: > > I don't understand. We already have support for this in 5.9?!? > > Anthony Fieroni wrote: > I made in same approach like other roles and i commit defaults (in blocks) > > Martin Gräßlin wrote: > Bu

Re: Review Request 129872: [lookandfeel] Support changing window decoration

on line 371 - Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102285 --- On Jan. 24, 2017, 10 p.m., Antho

Re: Review Request 129872: [lookandfeel] Support changing window decoration

- Anthony --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102237 --- On Ян. 24, 2017, 10 след обяд, Anthony Fier

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

anthonyfieroni added a comment. I'm a bit pretty harsh, add other private variable and handcopy newly plugin e.g. sudo cp libtaskmanagerplugin.so $(locate private/taskmanager/libtaskmanagerplugin.so) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4667

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

anthonyfieroni added a comment. diff --git a/applets/taskmanager/plugin/backend.h b/applets/taskmanager/plugin/backend.h index 87037c6..ef47344 100644 --- a/applets/taskmanager/plugin/backend.h +++ b/applets/taskmanager/plugin/backend.h @@ -104,6 +104,7 @@ class Backend :

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

anthonyfieroni added a comment. Move mouse over taskmanager :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4667 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, davidedmundson, dfaure, sitter

[Differential] [Request, 3 lines] D4667: [applet] Let specify a version for applets private plugins

anthonyfieroni created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is an attempt to start versioning plrivate applet plugins, as a beginning i provide only one example if it's accepted i'll

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

anthonyfieroni added a comment. > @sitter: **BUT** the user can still add (potentially new) applets to the shell which in turn is then broken because of the module Plasma refuses to load because of version-locking. I think that's not a problem, old plasma can load only old plugins, user

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

anthonyfieroni added a comment. Let try to better clarification, we breaking abi like this (https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9=dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e) running update from 5.9.1 to 5.9.2 cause a crash in plasmashell, i don't save backtrace but

[Differential] [Updated] D4667: [applet] Let specify a version for applets private plugins

anthonyfieroni added a reviewer: dfaure. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4667 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma, sitter, davidedmundson, dfaure Cc: plasma-devel,

[Differential] [Commented On] D4455: [System Tray Containment] Ungrab mouse before opening context menu

anthonyfieroni added a comment. I'm not happy with this patch, Kai. I think ungrabbing should be done in one place, plasma-framework, and on menu destruction. 1. Maximize window 2. Right click on item in systray 3. Select item from menu list 4. Exclusive click is needed i.e. grab

[Differential] [Commented On] D4711: Ungrab mouse on menu close

anthonyfieroni added a comment. I'm not pretty sure, but https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#374 on click at other window we have enter && mouseGrabber REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

[Differential] [Updated, 3 lines] D4491: Let make taskmanager tooltip readable again

anthonyfieroni updated this revision to Diff 11719. anthonyfieroni added a comment. Fix too long tooltip text REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4491?vs=11096=11719 REVISION DETAIL https://phabricator.kde.org/D4491 AFFECTED FILES

[Differential] [Commented On] D4667: [applet] Let specify a version for applets private plugins

anthonyfieroni added a comment. OK, upgrading just override existing library, no? So lets make 2 test: 1. Change in taskmanagerplugin that isn't abi -> force replace the lib when plasmashell works -> nothing happened 2. Make an abi change -> force replace it when plasmashell works ->

[Differential] [Request, 14 lines] D4711: Ungrab mouse on menu close

anthonyfieroni created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Qt 5.8 has a bit changed and ungrabbing at show does not work. REPOSITORY R242 Plasma Framework (Library)

[Differential] [Request, 8 lines] D4712: Ungrab mouse on menu close

anthonyfieroni created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Same as plasma-framework, on audio volume is weird as hell. Right click -> settings -> click in config window :) REPOSITORY R120

[Differential] [Abandoned] D4587: [ContainmentInterface] Ungrab mouse on context menu close

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. https://phabricator.kde.org/D4455 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4587 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 8 lines] D4587: [ContainmentInterface] Ungrab mouse on context menu close

anthonyfieroni created this revision. anthonyfieroni added a reviewer: Plasma. anthonyfieroni added subscribers: mart, davidedmundson. anthonyfieroni set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted

[Differential] [Updated, 2 lines] D4518: Ungrab mouse in taskmanager context menu

anthonyfieroni removed R119 Plasma Desktop as the repository for this revision. anthonyfieroni updated this revision to Diff 11100. anthonyfieroni added a comment. Remove call to ungrabMouse in show() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4518?vs=11097=11100 REVISION

[Differential] [Updated, 2 lines] D4518: Ungrab mouse in taskmanager context menu

anthonyfieroni set the repository for this revision to R119 Plasma Desktop. anthonyfieroni updated this revision to Diff 11102. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4518?vs=11100=11102 REVISION DETAIL https://phabricator.kde.org/D4518

[Differential] [Accepted] D4521: Activate minimise all plasmoid on mouse enter if the user is dragging mimedata

anthonyfieroni accepted this revision. anthonyfieroni added a reviewer: anthonyfieroni. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4521 EMAIL PREFERENCES

[Differential] [Requested Changes To] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni requested changes to this revision. anthonyfieroni added a comment. This revision now requires changes to proceed. One more change, wait for me :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL PREFERENCES

[Differential] [Commented On] D4518: Ungrab mouse in taskmanager context menu

anthonyfieroni added a comment. Qt 5.8 has annoying bug, dismiss context menu by left clicking excatly over other window (not desktop or taskmanager) grabbing stays in taskmanager. I will investigate for workaround, if someone has a purpose i'll be happy :) REPOSITORY R119 Plasma Desktop

[Differential] [Accepted] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma,

[Differential] [Commented On] D4171: [Task Manager] Remove arbitrary sizes from tooltip

anthonyfieroni added a comment. It should be :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, hein, subdiff Cc: anthonyfieroni,

[Differential] [Commented On] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni added a comment. Task.qml line 145 add backend.cancelHighlightWindows(); So when it's pressed button (left, middle, right) on task it show always stop highlight effect :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL

[Differential] [Commented On] D4587: [ContainmentInterface] Ungrab mouse on context menu close

anthonyfieroni added a comment. > Also: how do you know whether your change will still work in Qt 5.7? I noticed same downside there, if someone still has Qt 5.7 can test it. Tested Qt 5.6 on Kubuntu backport -> works. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

[Differential] [Commented On] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni added a comment. For LTS 5.8 some guard or backporting it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, anthonyfieroni Cc:

[Differential] [Commented On] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni added a comment. Originally, i push it for 5.8 :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, anthonyfieroni Cc: plasma-devel,

[Differential] [Accepted] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma,

[Differential] [Commented On] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni added a comment. You can try in Task.qml onHighlightedChanged: { if (highlighted) { backend.cancelHighlightWindows(); } } If it can help :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL

[Differential] [Updated] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni added a comment. This is needed 1. Enable highlight windows 2. Hover group item 3. Left click on effect is stopped 4. Move mouse over window list 5. Ugly highlight window effect So add a guard if (m_taskManagerItem) {

[Differential] [Closed] D4518: Ungrab mouse in taskmanager context menu

anthonyfieroni closed this revision. anthonyfieroni added a comment. https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9=5eb79cf68eb7883da4a4b8d132b70f032157d802 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4518 EMAIL PREFERENCES

Re: Review Request 129875: [kcm] Fix reset logic

marked as submitted. Review request for Plasma and Marco Martin. Changes --- Submitted with commit be4cff0ed1dea4515751210b7db9fe3f29ddd037 by Anthony Fieroni to branch Plasma/5.8. Repository: plasma-desktop Description --- Load is called right after reset button is clicked

Review Request 129872: [lookandfeel] Support changing window decoration

://git.reviewboard.kde.org/r/129872/diff/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129868: [lookandfeel] Complete breeze look and feel

/ Testing --- Thanks, Anthony Fieroni

Re: Review Request 129869: Complete breeze-dark look and feel

Pereira Da Costa and Marco Martin. Repository: breeze Description --- Apply breeze window decoration Diffs (updated) - lookandfeel.dark/contents/defaults b491d470 Diff: https://git.reviewboard.kde.org/r/129869/diff/ Testing --- Thanks, Anthony Fieroni

[Differential] [Closed] D4491: Let make taskmanager tooltip readable again

anthonyfieroni closed this revision. anthonyfieroni added a comment. https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.9=4c7022b936da587aa081cddbd419e32597718954 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4491 EMAIL PREFERENCES

Re: Review Request 129835: [IconDialog] Set proper icons group

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129835/#review102090 --- Ping - Anthony Fieroni On Ян. 15, 2017, 12:27 след обяд

Review Request 129835: [IconDialog] Set proper icons group

f: https://git.reviewboard.kde.org/r/129835/diff/ Testing --- Change group to Desktop, explicit size will override it. Thanks, Anthony Fieroni

Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect when close window in group item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128038/#review98407 --- For 5.7.4 - Anthony Fieroni On Авг. 9, 2016, 8:25 след

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128647/#review98406 --- Ping. For 5.7.4 - Anthony Fieroni On Авг. 13, 2016, 8:17

Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect when close window in group item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128038/#review98511 --- Ping, whats wrong to push it? - Anthony Fieroni On Авг. 9

[Differential] [Commented On] D4711: Ungrab mouse on menu close

anthonyfieroni added a comment. Yep, same faulty beharior present in all Qt apps, Qupzilla, QtCreator, etc. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

anthonyfieroni added inline comments. INLINE COMMENTS > jsalatas wrote in ToolTipInstance.qml:108 > Is it possible to have it always fixed to 2 lines and not just max to 2? > Otherwise having either 1 or 2 line we would end up in unaligned/bad-looking > tooltips (see screenshot), although I

[Differential] [Updated, 5 lines] D4491: Let make taskmanager tooltip readable again

anthonyfieroni updated this revision to Diff 11837. anthonyfieroni added a comment. ElideMiddle on basic regex match REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4491?vs=11719=11837 REVISION DETAIL https://phabricator.kde.org/D4491 AFFECTED

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

anthonyfieroni added a comment. > ! In https://phabricator.kde.org/D4491#90001, @jsalatas wrote: > I like the idea but ElideMiddle doesn't seem to work for me: Seems that it just keeps the left part of the text that it can fit and ignores anything else :\ Yeah, looks like only

[Differential] [Closed] D4491: Let make taskmanager tooltip readable again

anthonyfieroni closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4491 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: anthonyfieroni, #plasma:_design, #plasma, hein, subdiff Cc: jsalatas, markg, broulik,

[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

anthonyfieroni added a comment. At least i plan to commit it from tomorrow release, so title 1 line or 2 lines ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4491 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated, 8 lines] D4712: Ungrab mouse on menu close

anthonyfieroni updated this revision to Diff 11880. anthonyfieroni added a comment. To commit it later today ? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4712?vs=11601=11880 REVISION DETAIL https://phabricator.kde.org/D4712 AFFECTED FILES

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

tps://git.reviewboard.kde.org/r/128754/#comment66446> I think always emitting is error prone. You can emitting twice even 3 times. Same below. - Anthony Fieroni On Авг. 25, 2016, 2:48 след обяд, David Edmundson

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

> On Септ. 11, 2016, 9:32 след обяд, Anthony Fieroni wrote: > > src/engine/database.cpp, line 128 > > <https://git.reviewboard.kde.org/r/128890/diff/1/?file=476743#file476743line128> > > > > It's needed *m_env = 0;* > > Or you can add method clos

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

tps://git.reviewboard.kde.org/r/128890/#comment66720> It's needed *m_env = 0;* Or you can add method close to call it in all way. src/engine/database.cpp (line 128) <https://git.reviewboard.kde.org/r/128890/#comment66721> - Anthony Fieroni On Септ. 11, 2016, 9:27 след обяд, Christoph Cu

Review Request 129009: [busy indicator] Limit animation loops

Diff: https://git.reviewboard.kde.org/r/129009/diff/ Testing --- Pass. Thanks, Anthony Fieroni

Re: Review Request 129058: [corona] Sync config immidiately when it's dirty

> On Септ. 28, 2016, 1:12 след обяд, Marco Martin wrote: > > all thisdoes is causing more disk access, making things slower > > Anthony Fieroni wrote: > More disk access, maybe, but slower, how can be? > > Aleix Pol Gonzalez wrote: > Why more disk access

Re: Review Request 128997: Fix most obvious clazy and clang warnings

> On Септ. 22, 2016, 2:42 преди обяд, David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? > > Aleix Pol Gonzalez wrote: > The warning was saying that it's a delete of

Re: Review Request 128956: Make KF5Baloo optional

> On Sept. 20, 2016, 3:10 p.m., David Edmundson wrote: > > >Usage of krunner without any segfaults. > > > > You can just disable it with the provided checkbox, you don't gain anything > > from disabling it at compile time. > > Andreas Sturmlechner wrote: > That's not quite true; even with

Re: Review Request 128754: When marking a containment as deleted, also mark all sub-applets as deleted - fixes system tray container configs not being deleted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128754/#review98646 --- Looks good to me. +1 - Anthony Fieroni On Авг. 25, 2016

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

> On Авг. 26, 2016, 7:22 преди обяд, Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > <https://git.reviewboard.kde.org/r/128760/diff/1/?file=475410#file475410line44> > > > > This must be not (!inited). > > However this is

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

> On Авг. 26, 2016, 7:22 преди обяд, Anthony Fieroni wrote: > > kstyle/breezestyleplugin.cpp, line 44 > > <https://git.reviewboard.kde.org/r/128760/diff/1/?file=475410#file475410line44> > > > > This must be not (!inited). > > However this is

Re: Review Request 128761: Fix crash when using QProxyStyle and exit()

tps://git.reviewboard.kde.org/r/128761/#comment66462> This must be not (!inited). However this is not proper fix. Correct and test patch in this way QPointer style = new Style; Below unchanged, so when QPointer got delete it hold nullptr by itself and delete will be safe. - A

Re: Review Request 128760: Fix crash when using QProxyStyle and exit()

tps://git.reviewboard.kde.org/r/128760/#comment66461> This must be not (!inited). However this is not proper fix. Correct and test patch in this way QPointer style = new Style; Below unchanged, so when QPointer got delete it hold nullptr by itself and delete will be safe. - A

Re: Review Request 128647: [DesktopView] Stop raising desktop over dialog windows

/desktopview.cpp 83866dc Diff: https://git.reviewboard.kde.org/r/128647/diff/ Testing --- 1. open 1 or more non maximized windows 2. make left clicks periodically between window and the desktop 3. desktop is raised over opened windows *sometimes* Thanks, Anthony Fieroni

Re: Review Request 129058: [corona] Sync config immidiately when it's dirty

To reply, visit: https://git.reviewboard.kde.org/r/129058/#review99612 --- On Sept. 28, 2016, 10:42 a.m., Anthony Fieroni wrote: > > --- > This is an automatically generate

Re: Review Request 129058: [corona] Sync config immidiately when it's dirty

> On Sept. 28, 2016, 1:12 p.m., Marco Martin wrote: > > all thisdoes is causing more disk access, making things slower > > Anthony Fieroni wrote: > More disk access, maybe, but slower, how can be? > > Aleix Pol Gonzalez wrote: > Why more disk access

Re: Review Request 129058: [corona] Sync config immidiately when it's dirty

07ad284 src/plasma/corona.cpp 7ff64cd src/plasma/private/corona_p.h d556baf Diff: https://git.reviewboard.kde.org/r/129058/diff/ Testing --- Seems good but it may have downsides? Thanks, Anthony Fieroni

Review Request 129058: [corona] Sync config immidiately when it's dirty

downsides? Thanks, Anthony Fieroni

Re: Review Request 129187: Fix dangling pointer in KPackageJob

tps://git.reviewboard.kde.org/r/129187/#comment67174> emit? - Anthony Fieroni On Окт. 15, 2016, 12:43 преди обяд, David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 129203: Fixes for building plasma-framework

org/r/129203/#comment67209> You can't increase minimum deps only for this framework. It's done automatically for all and when it's needed. Just try this patch https://git.reviewboard.kde.org/r/129065/ give 'ship it' if works correctly - Anthony Fieroni On Окт. 17, 2016, 4:37 пред

Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect in group item

marked as submitted. Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Eike Hein. Changes --- Submitted with commit aeec4ae8869b487fe516a920b49a1fde4ea48c06 by Anthony Fieroni to branch Plasma/5.8. Repository: plasma-desktop Description --- 1. Enable highlighted

Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect in group item

> On Дек. 7, 2016, 3:59 след обяд, Anthony Fieroni wrote: > > You not against i plan to ship this patch next week. Ping, Eike, it works fine. - Anthony --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect in group item

. - Anthony Fieroni On Dec. 4, 2016, 1:07 p.m., Anthony Fieroni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

<    1   2   3   4   5   6   7   >