D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 updated this revision to Diff 54032. GB_2 added a comment. Improve and clean UI REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=54026=54032 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 updated this revision to Diff 54033. GB_2 added a comment. Fix groupbox widths REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=54032=54033 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED FILES

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-17 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R99:36dd29f8b65a: Improve the look of the GTK Application Style KCM UI (authored by GB_2). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D19788: [service runner] throw out kde3 "compat" code

2019-03-15 Thread Björn Feber
GB_2 added a comment. This is bug 383287 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19788 To: sitter, broulik Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-15 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, move the KCM below the Application Style KCM, drop the word GNOME, update strings

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Björn Feber
GB_2 added a comment. In D19651#428453 , @ndavis wrote: > Is that "Application style" combobox long enough to accommodate longer strings like "MS Windows 9x"? Yes, it adjusts itself to the width of the longest item automatically.

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Björn Feber
GB_2 added a comment. In D19651#428458 , @ndavis wrote: > Can it have the same default width as the toolbar text location comboboxes? Yeah, I can do that. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19651: Improve the look of the Application Style KCM UI

2019-03-11 Thread Björn Feber
GB_2 updated this revision to Diff 53635. GB_2 added a comment. Check if configure button should be enabled after clicking "Defaults" and rename "cbStyle" to "comboStyle" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53592=53635 BRANCH

D19651: Improve the look of the Application Style KCM UI

2019-03-11 Thread Björn Feber
GB_2 added a comment. In D19651#428459 , @GB_2 wrote: > In D19651#428458 , @ndavis wrote: > > > Can it have the same default width as the toolbar text location comboboxes? > > > Yeah, I can

D19651: Improve the look of the Application Style KCM UI

2019-03-13 Thread Björn Feber
GB_2 updated this revision to Diff 53792. GB_2 added a comment. Implement Rooty's suggestions and update preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53747=53792 BRANCH master REVISION DETAIL

D19651: Improve the look of the Application Style KCM UI

2019-03-13 Thread Björn Feber
GB_2 updated this revision to Diff 53798. GB_2 added a comment. Update preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53792=53798 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES

D19651: Improve the look of the Application Style KCM UI

2019-03-13 Thread Björn Feber
GB_2 updated this revision to Diff 53803. GB_2 added a comment. Update Quick Help text REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53798=53803 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES

D19651: Improve the look of the Application Style KCM UI

2019-03-13 Thread Björn Feber
GB_2 added a comment. In D19651#430117 , @rooty wrote: > Please consider abbreviating the labels: > > - dropping text in the last two dropdown menu items (No Text, Text Only, Beside Icons, Below Icons) > - dropping the word location (it's

D19651: Improve the look of the Application Style KCM UI

2019-03-13 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a946944edb20: Improve the look of the Application Style KCM UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53803=53806

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

2019-03-09 Thread Björn Feber
GB_2 added a comment. In D19472#427613 , @ngraham wrote: > In D19472#427046 , @broulik wrote: > > > This suffers from the same bug as the action in the D17410 .

D19788: [service runner] throw out kde3 "compat" code

2019-03-18 Thread Björn Feber
GB_2 added a comment. GTK+ was recently renamed to GTK (https://mail.gnome.org/archives/gtk-devel-list/2019-February/msg0.html). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19788 To: sitter, broulik Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel,

D19469: [sddm-theme] Update login screen preview image

2019-03-20 Thread Björn Feber
GB_2 added a comment. In D19469#435183 , @rooty wrote: > In D19469#435175 , @GB_2 wrote: > > > The file size is quite big (you can change the compression in Spectacle) and I think the resolution

D19469: [sddm-theme] Update login screen preview image

2019-03-20 Thread Björn Feber
GB_2 added a comment. BTW, it's still not 1920x1080. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19469: [sddm-theme] Update login screen preview image

2019-03-20 Thread Björn Feber
GB_2 added a comment. The file size is quite big (you can change the compression in Spectacle) and I think the resolution should be 1920x1080. Please also change the user images to the colorful Konqi and Katie ones. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19469: [sddm-theme] Update login screen preview image

2019-03-20 Thread Björn Feber
GB_2 added a comment. In D19469#435216 , @rooty wrote: > In D19469#435215 , @GB_2 wrote: > > > BTW, it's still not 1920x1080. > > > Noted. (Why is that relevant though?) Much more

D19469: [sddm-theme] Update login screen preview image

2019-03-20 Thread Björn Feber
GB_2 added a comment. In D19469#435220 , @rooty wrote: > F6703853: image.png > > This is the Konqi avatar I have available in SySe. It renders as fairly blurry / lower quality than the one I opted for

D19651: Improve the look of the Application Style KCM UI

2019-03-12 Thread Björn Feber
GB_2 updated this revision to Diff 53747. GB_2 added a comment. Improve preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53635=53747 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-16 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > apol wrote in kde-gtk-config.desktop:1 > All this not saying they're right or wrong but unrelated to the change at > stake. I'll remove the things that weren't here before, but this is just sorting the desktop entry to make it consistent with

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, merge the two tabs into one page and make the KCM look better. F6680804:

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Björn Feber
GB_2 updated this revision to Diff 53591. GB_2 added a comment. Clean up style preview UI file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53589=53591 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES

D19651: Improve the look of the Application Style KCM UI

2019-03-10 Thread Björn Feber
GB_2 updated this revision to Diff 53592. GB_2 added a comment. Rename style preview checkbox from "Check box" to "Checkbox" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53591=53592 BRANCH master REVISION DETAIL

D18785: Use different Font Management KCM "All Fonts" icon

2019-02-07 Thread Björn Feber
GB_2 updated this revision to Diff 51115. GB_2 added a comment. Use new icon "font" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18785?vs=51032=51115 BRANCH use-different-font-management-all-fonts-icon (branched from master) REVISION DETAIL

D18785: Use different Font Management KCM "All Fonts" icon

2019-02-06 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Needed for D18702 . F6591513: New Font Management All Fonts

D18785: Use different Font Management KCM "All Fonts" icon

2019-02-08 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:e5ef9c97e75e: Use different Font Management KCM All Fonts icon (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18785?vs=51115=51162

D18861: Improve the Fonts KCM UI

2019-02-08 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Makes some improvements to the Fonts KCM UI, like applying the KDE HIG, adding icons and tooltips to

D18861: Improve the Fonts KCM UI

2019-02-08 Thread Björn Feber
GB_2 updated this revision to Diff 51213. GB_2 added a comment. Change "Force fonts DPI" checkbox text to "Force font DPI" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18861?vs=51211=51213 BRANCH master REVISION DETAIL

D18861: Improve the Fonts KCM UI

2019-02-08 Thread Björn Feber
GB_2 added a comment. What about `Noto Sans 10pt`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19079: Make look of Font Management KCM UI more consistent

2019-02-16 Thread Björn Feber
GB_2 updated this revision to Diff 51877. GB_2 added a comment. Use /Cancel style message box buttons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51866=51877 BRANCH make-look-of-font-management-kcm-ui-more-consistent (branched from

D19079: Make look of Font Management KCM UI more consistent

2019-02-17 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:8596ae908533: Make look of Font Management KCM UI more consistent (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51877=51893

D19079: Make look of Font Management KCM UI more consistent

2019-02-16 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in KCmFontInst.cpp:236 > This one doesn't need an ellipsis. If the window/dialog that pops up when you > click on it is nothing more than a confirmation box, we don't use ellipsis. > > However the confirmation dialog that results from

D19079: Make look of Font Management KCM UI more consistent

2019-02-16 Thread Björn Feber
GB_2 updated this revision to Diff 51866. GB_2 added a comment. Remove unneeded ellipses REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51855=51866 BRANCH arcpatch-D19079 REVISION DETAIL https://phabricator.kde.org/D19079 AFFECTED

D19079: Make look of Font Management KCM UI more consistent

2019-02-16 Thread Björn Feber
GB_2 added a comment. In D19079#413663 , @ngraham wrote: > While we're at it, can we turn those Yes/No messageboxes into /Cancel style instead? Sure REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19079

D19079: Make look of Font Management KCM UI more consistent

2019-02-16 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in KCmFontInst.cpp:236 > Heh I think that may be a typo and the word was supposed to be "excluding". I > specifically remember having a conversation about this and we concluded that > confirmation prompts didn't count because then you

D19093: Improve the look of the Emoticons KCM UI

2019-02-17 Thread Björn Feber
GB_2 updated this revision to Diff 51905. GB_2 added a comment. Fix resizing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19093?vs=51903=51905 BRANCH improve-look-of-emoticons-kcm-ui (branched from master) REVISION DETAIL

D19093: Improve the look of the Emoticons KCM UI

2019-02-17 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, make buttons consistent and make the KCM look better. F6619998: Improved

D19093: Improve the look of the Emoticons KCM UI

2019-02-18 Thread Björn Feber
GB_2 updated this revision to Diff 51978. GB_2 added a comment. Address comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19093?vs=51905=51978 BRANCH improve-look-of-emoticons-kcm-ui (branched from master) REVISION DETAIL

D19093: Improve the look of the Emoticons KCM UI

2019-02-18 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:8b413729da44: Improve the look of the Emoticons KCM UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19093?vs=51978=51979 REVISION

D18903: Make Appearance KCMs' labels consistent

2019-02-12 Thread Björn Feber
GB_2 added a comment. We currently use the KAboutData name in headers, we can easily change them to real titles and leave the desktop files how they are currently (explanation sentences). Should we just use the KCM name in the header or something more explaining like "Look and Feel Theme

D18861: Improve the look of the Fonts KCM UI

2019-02-09 Thread Björn Feber
GB_2 updated this revision to Diff 51274. GB_2 added a comment. Show pt after font size and remove seperator in the font preview. Also apply the KDE HIG even more. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18861?vs=51213=51274 BRANCH master

D18892: Move Look and Feel KCM to top level

2019-02-09 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Moves the LnF KCM from the Workspace Theme category to the top level (to the Appearance section),

D18892: Move Look and Feel KCM to top level

2019-02-13 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:0af980f5cab8: Move Look and Feel KCM to top level (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18892?vs=51301=51642 REVISION DETAIL

D18892: Move Look and Feel KCM to top level

2019-02-13 Thread Björn Feber
GB_2 added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18892 To: GB_2, #plasma, #vdg, rooty, ngraham, davidedmundson, abetts Cc: ngraham, davidedmundson, abetts, rooty, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel,

D19006: Use KCM name in KCM header

2019-02-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the KCM name in Qt Widgets KCM headers, to make them consistent with others. F6614892: KCM Name

D19009: Use better KDE GTK Config KCM desktop file comment

2019-02-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use a better KDE GTK Config KCM desktop file comment that is correct and consistent with others.

D19009: Use better KDE GTK Config KCM desktop file comment

2019-02-14 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R99:bceb50cb8ec3: Use better KDE GTK Config KCM desktop file comment (authored by GB_2). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D19006: Use KCM name in KCM header

2019-02-14 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R124:b6ad57fc5fa2: Use KCM name in KCM header (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19006?vs=51688=51695 REVISION DETAIL

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. In D18903#411538 , @ngraham wrote: > In D18903#411529 , @filipf wrote: > > > For this patch (and moving forward) we still have 2 dilemmas left then:

D18903: Make Appearance KCMs' labels consistent

2019-02-13 Thread Björn Feber
GB_2 added a comment. Oops REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

2019-02-10 Thread Björn Feber
GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. Perfect! REPOSITORY R119 Plasma Desktop BRANCH 516-appearance-header-labels (branched from master) REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham,

D19038: Make Appearance KCM tooltip texts consistent

2019-02-15 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Improve wording and add an ellipsis where needed in tooltips in Appearance KCMs. TEST PLAN Open

D19038: Make Appearance KCM tooltip texts consistent

2019-02-15 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:6eb834d7: Make Appearance KCM tooltip texts consistent (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19038?vs=51761=51778 REVISION

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

2019-02-15 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R31:1befbfed8bbe: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to… (authored by GB_2). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

2019-02-15 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Improve wording and make texts consistent with others. TEST PLAN Open the Curors KCM and hover over

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

2019-02-15 Thread Björn Feber
GB_2 updated this revision to Diff 51781. GB_2 added a comment. Fix comment REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19046?vs=51780=51781 BRANCH make-breeze-theme-tooltip-texts--consistent-and-rename-breeze-snow-cursors-to-breeze-light (branched

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

2019-02-15 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in index.theme:46 > `Comment=Comment=Breeze`? :) Oops, haha REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19046 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2,

D17410: Add alternatives button to applet configuration in panel edit mode

2019-02-16 Thread Björn Feber
GB_2 added a subscriber: broulik. GB_2 added a comment. It seems like this is quite difficult, me and @broulik couldn't figure it out. If someone wants to take over this revision then please do it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To:

D19079: Make look of Fonts KCM UI more consistent

2019-02-16 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG and make tooltips, buttons and others more consistent and better looking.

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

2019-02-07 Thread Björn Feber
GB_2 added a comment. In D18797#407129 , @ngraham wrote: > So if this isn't an acceptable solution, then what we need to do is remove all the 22px monochrome versions of icons that have colorful 32px-and-larger versions. What I proposed

D18861: Improve the Fonts KCM UI

2019-02-09 Thread Björn Feber
GB_2 added a comment. In D18861#408459 , @davidedmundson wrote: > Please use more descriptive messages than "Improve the blahblah". > Practically every single commit aims to improve the product. I added the word UI, what do you

D18419: Adjust some KCMs to implement new Appearance section layout

2019-01-25 Thread Björn Feber
GB_2 added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D18528: [Desktop Toolbox] Use a clearer name when the label is shown

2019-01-25 Thread Björn Feber
GB_2 added a comment. Looks good! INLINE COMMENTS > ToolBoxButton.qml:30 > > -property string text: main.Plasmoid.activityName > +property string text: main.Plasmoid.activityName == i18n("Default") ? > i18n("Desktop Toolbox") : i18n("Desktop Toolbox - %1 Activity", >

D18561: Use same intro page system settings icon as in the desktop file

2019-02-01 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R124:d5740e73d070: Use same intro page system settings icon as in the desktop file (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D18559: Use correct sidebar back button press color

2019-02-01 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R124:cad722aa0fa0: Use correct sidebar back button press color (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18559?vs=50363=50651 REVISION

D18677: Change workspace theme category icon

2019-02-02 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R124:4ef5a0b01421: Change workspace theme category icon (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18677?vs=50726=50728 REVISION DETAIL

D18682: Update Breeze Dark Look and Feel theme previews

2019-02-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Update and improve some old Breeze Dark Look and Feel theme previews (similar to D18681

D18677: Change workspace theme category icon

2019-02-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use a proper workspace theme icon for the workspace theme category. F6583141: Workspace Theme

D18682: Update Breeze Dark Look and Feel theme previews

2019-02-03 Thread Björn Feber
GB_2 updated this revision to Diff 50762. GB_2 added a comment. Improve Look and Feel theme previews REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18682?vs=50738=50762 BRANCH update-breezedark-lookandfeel-theme-previews (branched from master) REVISION

D18681: Update Breeze Look and Feel theme previews

2019-02-03 Thread Björn Feber
GB_2 updated this revision to Diff 50761. GB_2 added a comment. Improve Look and Feel theme previews REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18681?vs=50737=50761 BRANCH update-breeze-lookandfeel-theme-previews (branched from master)

D18681: Update Breeze Look and Feel theme previews

2019-02-02 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Update and improve some old Breeze Look and Feel theme previews (the Breeze Dark previews will be

D18419: Adjust some KCMs to implement new Appearance section layout

2019-02-02 Thread Björn Feber
GB_2 added a comment. I think we should really move the LnF KCM to the top level now since it affects everything. Doing that is safe IMO. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts,

D18681: Update Breeze Look and Feel theme previews

2019-02-02 Thread Björn Feber
GB_2 added a comment. In D18681#404092 , @abetts wrote: > Maybe I am asking for a lot... but could these be animated and show what the splash screen does? Maybe a gif animation on hover? There's already the preview button that shows the

D18681: Update Breeze Look and Feel theme previews

2019-02-03 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ba642873f40f: Update Breeze Look and Feel theme previews (authored by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18681?vs=50761=50765 REVISION

D18682: Update Breeze Dark Look and Feel theme previews

2019-02-03 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R31:2750e07e4e00: Update Breeze Dark Look and Feel theme previews (authored by GB_2). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18682?vs=50762=50766 REVISION DETAIL

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

2019-01-24 Thread Björn Feber
GB_2 added a comment. Next time please upload images directly to Phabricator. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

2019-01-24 Thread Björn Feber
GB_2 added a comment. Thanks! Looks good! REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 commandeered this revision. GB_2 edited reviewers, added: davidedmundson; removed: GB_2. GB_2 added a comment. Sure! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson,

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 added a comment. BTW, @davidedmundson or someone else: How do I get the icon name/source here: `iconSource: plasmoid.action("alternatives").icon`? It currently returns a QIcon, but I want the name/source of it from QML. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55959. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55958=55959 REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES containments/panel/contents/ui/ConfigOverlay.qml To: GB_2, #plasma,

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55960. GB_2 added a comment. Try to fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55959=55960 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-10 Thread Björn Feber
GB_2 updated this revision to Diff 55958. GB_2 edited the summary of this revision. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55856=55958 REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES containments/panel/contents/ui/ConfigOverlay.qml To: GB_2,

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-09 Thread Björn Feber
GB_2 added a comment. In D17410#446874 , @Codezela wrote: > This icon have a lot of details for this small size we need more clear one I guess The icon was added here: D20367 I think it's still ok,

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-09 Thread Björn Feber
GB_2 added a comment. Nice, thank you so much! INLINE COMMENTS > ConfigOverlay.qml:392 > +iconSource: "preferences-desktop-default-applications" > +text: i18n("Alternatives...") > +enabled: >

D18419: Adjust some KCMs to implement new Appearance section layout

2019-04-08 Thread Björn Feber
GB_2 added a comment. In D18419#400163 , @davidedmundson wrote: > > Improve text on existing QWidgets KCMs to conform to the HIG > > After this. > > > Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG > >

D19209: [sddm-kcm] Adjust Background label and button

2019-04-08 Thread Björn Feber
GB_2 closed this revision. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: GB_2, #vdg, #plasma, filipf, ngraham Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,

D20093: Show a context menu on pressAndHold

2019-04-08 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20093 To: apol, #plasma, mart Cc: GB_2, davidedmundson, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20043: digitalclock: have it display a context menu onPressAndHold

2019-04-08 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R120 Plasma Workspace BRANCH digiclock REVISION DETAIL https://phabricator.kde.org/D20043 To: apol, #plasma, ngraham Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17410: Add alternatives button to applet configuration in panel edit mode

2019-04-13 Thread Björn Feber
GB_2 added a comment. Or we could just leave it how it is now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack,

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Needed for D20536 TEST PLAN Open the avatar gallery.

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 added a comment. Ok, the problem is that now the default user icon doesn't work with a dark theme. I think we should just provide it in `breeze-icons`, so it is the default user icon that also gets selected when you click `Clear Avatar`. REPOSITORY R128 User Manager REVISION DETAIL

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56265. GB_2 added a comment. Remove monochrome icon REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20564?vs=56264=56265 BRANCH change-default-user-avatar (branched from master) REVISION DETAIL

D19077: Redesign the theme preview window

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56266. GB_2 added a comment. Prevent deprecation warning REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=52351=56266 BRANCH arcpatch-D19077 REVISION DETAIL

D19077: Redesign the theme preview window

2019-04-14 Thread Björn Feber
GB_2 added a comment. In D19077#442323 , @mart wrote: > In D19077#422017 , @filipf wrote: > > > @mart could you help us out a bit please? I used code with "Kirigami.Theme.viewBackgroundColor.r",

D19077: Redesign the theme preview window

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56268. GB_2 added a comment. Try to fix diff REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=56266=56268 BRANCH arcpatch-D19077 REVISION DETAIL https://phabricator.kde.org/D19077

D19011: Thunderbolt KCM and KDED module

2019-04-15 Thread Björn Feber
GB_2 added a comment. Looks ok to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner,

D15423: System settings: make date/time format preview consistent

2019-04-15 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15423 To: McPain, hein, #vdg Cc: GB_2, davidedmundson, abetts, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

<    1   2   3   4   5   6   7   >