Re: Review Request 126460: Honor SkipGrouping hint from KNotification

, so I'll +1 this. But as for the actual bug that brought you here: Why are we getting two notifications for everything from Plasma in the first place? - David Edmundson On Dec. 21, 2015, 8:24 p.m., Martin Klapetek wrote: > > --

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

> On Dec. 21, 2015, 8:38 p.m., David Edmundson wrote: > > This does seem like a much better way to handle the grouping, so I'll +1 > > this. > > > > But as for the actual bug that brought you here: > > Why are we getting two notifications for everythi

Re: Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126461/#review89861 --- Ship it! Ship It! - David Edmundson On Dec. 21, 2015, 8

Re: Review Request 126463: Allow applets to set full ToolTip item

) <https://git.reviewboard.kde.org/r/126463/#comment61607> what would happen if the tooltipItem object gets deleted by the plasmoid after having set the object in the applet interface? - David Edmundson On Dec. 21, 2015, 10:12 p.m., Martin Klapetek

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

.width(), boundingRect().size().height())); to be a member var outside loadPixmap and only call loadPixmap if that acutally changes? - David Edmundson On Dec. 22, 2015, 3:17 a.m., Eike Hein wrote: > > --- > This is an automati

Re: Review Request 126468: AppletQuickItem: Drop timer to create full representation

desktop? Definitely this is a change we want to be making, but it looks like a workaround for something else being terribly broken, we need to be sure that's fixed. I'll apply this too and also check. - David Edmundson On Dec. 22, 2015, 10:01 a.m., David R

Re: Review Request 126468: AppletQuickItem: Drop timer to create full representation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126468/#review89904 --- Ship it! Ship It! - David Edmundson On Dec. 22, 2015, 10

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

> On Dec. 22, 2015, 11:59 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 406 > > <https://git.reviewboard.kde.org/r/126466/diff/1/?file=425194#file425194line406> > > > > One of the (albeit extremely flimsy) arguments to a time

Review Request 126471: Don't emit statusChanged if it hasn't changed

rc/plasma/applet.cpp 0b7ef5632c1accb3373aa8f2f57a7880e5f3640d Diff: https://git.reviewboard.kde.org/r/126471/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126472: Don't always load the timetracker

Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

line 332) <https://git.reviewboard.kde.org/r/126466/#comment61650> does this not need an update() too? - David Edmundson On Dec. 22, 2015, 4:58 p.m., Eike Hein wrote: > > --- > This is an automatically generated e

Re: Review Request 126471: Don't emit statusChanged if it hasn't changed

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 01cd374c8e6396a8f9135338c34dde7570c79e03 by David Edmundson to branch master. Repository: plasma-framework Description --- For some applets the status is bound to a complex

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89946 --- Ship it! Ship It! - David Edmundson On Dec. 22, 2015, 5

Re: Review Request 126475: Make sure PlasmaCore.WindowThumbnail doesn't redirect windows while disabled or invisible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126475/#review89947 --- Ship it! Ship It! - David Edmundson On Dec. 22, 2015, 6

Re: Review Request 122859: WIP: Don't animate from previous pixmap when IconItem has been invisible

> On Dec. 22, 2015, 9:58 p.m., Kai Uwe Broulik wrote: > > I suppose this is obsolete now. I don't think it is. The other patch was about removing a silly timer before loading a pixmap, however it still always has the fade when changing source. - David ---

Re: Review Request 124047: Improve clock's tooltip layout

the size of the grid applets/digital-clock/package/contents/ui/Tooltip.qml (line 131) <https://git.reviewboard.kde.org/r/124047/#comment61661> this won't do anything. - David Edmundson On Dec. 22, 2015, 7:38 p.m., Martin Klapetek wrote: > > --

Re: Review Request 126477: [breeze-gtk] Relax cmake version requirement to rest of plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126477/#review89986 --- Ship it! Ship It! - David Edmundson On Dec. 22, 2015, 9

Review Request 126491: Set root context properties on the right context

5389b3d55bfbdbf76b shell/panelconfigview.cpp 29a50bc03d8750e2370c5c2b5cfe761a031c43e9 shell/panelview.cpp 893def0ced7297271d03dd27f40f8f6599a2354f shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd Diff: https://git.reviewboard.kde.org/r/126491/diff/ Testing --- Thanks

Re: Review Request 126491: Set root context properties on the right context

a031c43e9 shell/panelview.cpp 893def0ced7297271d03dd27f40f8f6599a2354f shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd Diff: https://git.reviewboard.kde.org/r/126491/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel m

Review Request 126497: Guard against applet failing to load in systemtray task

84d2baf4da0ef6d0381dfc79fa374b5c54cf2189 Diff: https://git.reviewboard.kde.org/r/126497/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126498: Use the right graphics for min and max sliders

--- We never noticed on Breeze because they look the same. BUG:356790 Diffs - desktoppackage/contents/configuration/panelconfiguration/Ruler.qml 16b0c7137070d237778e705396b6e271859a947e Diff: https://git.reviewboard.kde.org/r/126498/diff/ Testing --- Thanks, David Edmundson

Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

--- BUG: 356874 Diffs - desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml 9d04d0aa8b53f219e937228f91abee5ff439d02a Diff: https://git.reviewboard.kde.org/r/126499/diff/ Testing --- Thanks, David Edmundson

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

e it. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126499/#review90041 --- On Dec. 24, 2015, 1:43 a.m., David

Re: Review Request 126517: [ShellManager] Make use of StatusNotifier DrKonqi

round this somehow - there's a timer in KCrash internals where we can know if something is a crash within the first 20 seconds of loading. - David Edmundson On Dec. 25, 2015, 4:24 p.m., Kai Uwe Broulik wrote: > > --- > This is

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

as historically we have a have a habbit of them not getting done Also your StatusNotifierItem leaks - but it proably wants to be the lifespan of the application anyway. - David Edmundson On Dec. 25, 2015, 4:24 p.m., Kai Uwe Broulik wrote

Re: Review Request 126517: [ShellManager] Make use of StatusNotifier DrKonqi

> On Dec. 25, 2015, 5:22 p.m., David Edmundson wrote: > > On first thought this is awesome. I like the video. It looks good. > > > > but now I'm going to point something out that's going to ruin your Christmas > > > > If Plasma crashes, you

Re: Review Request 126512: Use proper deleters for libxcb structs in xembed-sni-proxy.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126512/#review90106 --- Ship it! Ship It! - David Edmundson On Dec. 25, 2015, 4

Re: Review Request 126498: Use the right graphics for min and max sliders

/r/126498/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126498: Use the right graphics for min and max sliders

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 426a24c051d187875abc0e373cdc252f151b1d21 by David Edmundson to branch Plasma/5.5. Repository: plasma-desktop Description --- We never noticed on Breeze because they look the same. BUG:356790 REVIEW

Re: Review Request 126497: Guard against applet failing to load in systemtray task

marked as submitted. Review request for Plasma. Changes --- Submitted with commit e8c6426ac12c14be68a68b9492274140c28f3285 by David Edmundson to branch Plasma/5.5. Bugs: 356470 https://bugs.kde.org/show_bug.cgi?id=356470 Repository: plasma-workspace Description --- If an

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

https://git.reviewboard.kde.org/r/126524/#comment61731> the file could have changed regardless of whether the name has, like if I edit it in krita or something. Unless you want to compare mtimes, you may as well just copy it everytime. - David Edmundson On D

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

> On Dec. 24, 2015, 3:22 a.m., Martin Klapetek wrote: > > Screenshot? Also looks like a good candidate for QML-KMessageWidget (do we > > have a component for that already?) > > David Edmundson wrote: > You wrote one in the clock applet, you have not made it a compo

Re: Review Request 126517: [ShellManager] Make use of StatusNotifier DrKonqi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126517/#review90165 --- Ship it! Ship It! - David Edmundson On Dec. 25, 2015, 4

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

tps://git.reviewboard.kde.org/r/126515/#comment61743> and -> or surely? both in code and comments. - David Edmundson On Dec. 27, 2015, 4:11 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159> > > > > and -> or surely? > > > > both in code and comments. >

Re: Review Request 126472: Don't always load the timetracker

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit ab135f4e8ed451f4f310732e6f5bc084aff69519 by David Edmundson to branch master. Repository: plasma-framework Description --- Don't always load the timetracker It has a timer

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159> > > > > and -> or surely? > > > > both in code and comments. >

Review Request 126538: Don't duplicate a tonne of KCrash code

54f4bd655efb9364aed66d27b9b10708d1e324c3 shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 Diff: https://git.reviewboard.kde.org/r/126538/diff/ Testing --- None. Thanks, David Edmundson ___ Plasma

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

538/#comment61751> oh, I probably want to keep this and set the flag as appropriate. - David Edmundson On Dec. 27, 2015, 9:10 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126491: Set root context properties on the right context

marked as submitted. Review request for Plasma. Changes --- Submitted with commit c692bc53a8c5cf5802084085b9aed11203998d38 by David Edmundson to branch Plasma/5.5. Bugs: 355885, 356545 and 356916 https://bugs.kde.org/show_bug.cgi?id=355885 https://bugs.kde.org/show_bug.cgi?id

Re: Review Request 126539: Check sockaddr_un buffer size before strcpy()ing into it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126539/#review90188 --- Ship it! Ship It! - David Edmundson On Dec. 28, 2015, 12

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

tps://git.reviewboard.kde.org/r/122859/#comment61752> huh? that just reloads the current image whenever visibility gets toggled. 1) that's wrong since eike's patch. loadPixmap is deffered till a polish event before 2) how does that fix anything? - David Edmund

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/#review90193 --- On Dec. 27, 2015, 9:10 p.m., David Edmundson wrote: > > --- >

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

) - shell/main.cpp 54f4bd655efb9364aed66d27b9b10708d1e324c3 shell/shellmanager.h 3e1fc0a4b05eec0d2f7a1bc3e8c5cfc8cc7934e2 shell/shellmanager.cpp 0a6ac5e4ec2de7616be3af7a8715bd4450e562f0 Diff: https://git.reviewboard.kde.org/r/126538/diff/ Testing --- None. Thanks, David Edmundson

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

version restarted Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 1ff63c257ec57dcc5c13507981ea8ec1fc79544e by David Edmundson to branch master. Repository: plasma-desktop Description --- BUG: 356874 Diffs - desktoppackage/contents/configuration

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 3ff5cdd3cf75c7d9d7edd72d88dd1c440fb1995d by David Edmundson to branch master. Repository: plasma-workspace Description --- KCrash already has auto restart which copies the args and only respawns n

Re: Review Request 126544: [Kickoff] Hide history tab if empty

en. and given it won't work this is just wasted code. - David Edmundson On Dec. 28, 2015, 2:01 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 126544: [Kickoff] Hide history tab if empty

> On Dec. 28, 2015, 2:04 p.m., David Edmundson wrote: > > applets/kickoff/package/contents/ui/FullRepresentation.qml, line 65 > > <https://git.reviewboard.kde.org/r/126544/diff/1/?file=426357#file426357line65> > > > > why? > > > > if we

Re: Review Request 125921: Don't rely graphic objects in panel script engine

t.js to set min, max sizes as well as alignment and offset which were previously broken. Once loaded opened the interactive editor and run stuff like: panel = panelById(1); panel.alignment = "center" panel.height = 40 Seems to work as bef

Re: Review Request 125921: Don't rely graphic objects in panel script engine

et min, max sizes as well as alignment and offset which were previously broken. Once loaded opened the interactive editor and run stuff like: panel = panelById(1); panel.alignment = "center" panel.height = 40 Seems to work as before Thanks, David Edmundson

Re: Review Request 125921: Don't rely graphic objects in panel script engine

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 0dc7f6c3e5d62f6d8211e5d024ee3080b2baae37 by David Edmundson to branch master. Bugs: 355918 https://bugs.kde.org/show_bug.cgi?id=355918 Repository: plasma-workspace Description --- The basic

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote: > > sddmauthhelper.cpp, line 74 > > <https://git.reviewboard.kde.org/r/126524/diff/1/?file=426085#file426085line74> > > > > Ideally we should check the *calling* user can read this file, as you &g

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote: > > sddmauthhelper.cpp, line 74 > > <https://git.reviewboard.kde.org/r/126524/diff/1/?file=426085#file426085line74> > > > > Ideally we should check the *calling* user can read this file, as you &g

Re: Review Request 126559: dark colorscheme option for cuttlefish

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126559/#review90279 --- Ship it! Ship It! - David Edmundson On Dec. 29, 2015, 1

Re: Review Request 124204: Use proper relative paths to import js code

> On Dec. 29, 2015, 1:36 p.m., Marco Martin wrote: > > this still seems to cause issues for some people. > > May this series of patches be worth to push anyways? >this still seems to cause issues for some people. Where have you seen that? I don't recall seeing any bug reports. - David

Re: Review Request 126559: dark colorscheme option for cuttlefish

tps://git.reviewboard.kde.org/r/126559/#comment61788> may be better to make the text be more like: ComplementaryColorGroup otherwise if you're editing a dark theme it's confusing. - David Edmundson On Dec. 29, 2015, 1:35 p.m., Ma

Re: Review Request 126559: dark colorscheme option for cuttlefish

> On Dec. 29, 2015, 2:32 p.m., David Edmundson wrote: > > cuttlefish/package/contents/ui/Tools.qml, line 130 > > <https://git.reviewboard.kde.org/r/126559/diff/1/?file=427731#file427731line130> > > > > may be better to make the text be m

Re: Review Request 126557: use the new KDEPackageAppTemplates ECM module

tps://git.reviewboard.kde.org/r/126557/#comment61791> is this still right? - David Edmundson On Dec. 29, 2015, 9:53 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 126562: Deal properly with symlinks in path to packages

/packageurlinterceptor.cpp (line 93) <https://git.reviewboard.kde.org/r/126562/#comment61794> why the +1? is it that canonicalFilePath not leave a trailing slash which we had before? - David Edmundson On Dec. 29, 2015, 3:08 p.m., Kevin Ottens

Re: Review Request 126566: Add "applicationcrash" notification event

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126566/#review90309 --- Ship it! Ship It! - David Edmundson On Dec. 29, 2015, 9

Review Request 126573: Don't duplicate checking content length is within user set bounds

a85a79ec9fda41c6ac8efd76a9fc7094d3a46537 Diff: https://git.reviewboard.kde.org/r/126573/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126570/#review90333 --- Ship it! Ship It! - David Edmundson On Dec. 29, 2015, 10

Review Request 126575: Add missing emit

--- Add missing emit Diffs - shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 Diff: https://git.reviewboard.kde.org/r/126575/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org

Review Request 126574: Don't adjust thickness twice

--- No point doing a setMinimumWidth/Height directly in positionPanel (which we always call) does a setMinimumSize anyway Diffs - shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 Diff: https://git.reviewboard.kde.org/r/126574/diff/ Testing --- Thanks, David

Review Request 126576: Don't emit signals in another object from panel.

/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd Diff: https://git.reviewboard.kde.org/r/126576/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126577: Update battery.svgz

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126577/#review90340 --- Ship it! Ship It! - David Edmundson On Dec. 30, 2015, 1

Re: Review Request 126576: Don't emit signals in another object from panel.

On Dec. 30, 2015, 12:52 p.m., David Edmundson wrote: > > The rest LGTM. Thanks. You're right it's unrelated. Removed for now. - David --- This is an automatically generated e-mail. To reply, visit: https://git.revie

Re: Review Request 126574: Don't adjust thickness twice

marked as submitted. Review request for Plasma. Changes --- Submitted with commit ce58e59e471b6a0d5a29d1653fde6b8cd0499300 by David Edmundson to branch master. Repository: plasma-workspace Description --- No point doing a setMinimumWidth/Height directly in positionPanel (which we

Re: Review Request 126576: Don't emit signals in another object from panel.

marked as submitted. Review request for Plasma. Changes --- Submitted with commit c62452c467e96756a4e5bcaddcee98caa7d27d49 by David Edmundson to branch master. Repository: plasma-workspace Description --- Emitting objects in another object is generally bad practice. ShellCorona

Re: Review Request 126575: Add missing emit

marked as submitted. Review request for Plasma. Changes --- Submitted with commit e23a1814b0a11624c4970a890578ddfaf3beea51 by David Edmundson to branch master. Repository: plasma-workspace Description --- Add missing emit Diffs - shell/panelview.cpp

Re: Review Request 126573: Don't duplicate checking content length is within user set bounds

marked as submitted. Review request for Plasma. Changes --- Submitted with commit ba733d16fb2849b2b2cc390ed89b5200dffb5c3f by David Edmundson to branch master. Repository: plasma-desktop Description --- This is done by PanelView, we should not be doing the same thing twice. Longer

Re: Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126579/#review90359 --- +1 - David Edmundson On Dec. 30, 2015, 7:09 p.m., Kai Uwe

Re: Review Request 126590: [WebBrowser plasmoid] Remember last visited url and restore it on startup.

> On Jan. 1, 2016, 4:48 p.m., Kai Uwe Broulik wrote: > > applets/webbrowser/contents/ui/main.qml, line 58 > > > > > > Note plasmoid.configuration.url is a String whereas url is a QUrl. > > Working with URLs, espe

Re: Review Request 126590: [WebBrowser plasmoid] Remember last visited url and restore it on startup.

) <https://git.reviewboard.kde.org/r/126590/#comment61841> this doesn't seem needed. urlField.text is already bound to webview.url on line 43 Do you have commit access? - David Edmundson On Jan. 1, 2016, 5:15 p.m., Mihail Ivc

Re: Review Request 126594: [SNI DataEngine] ProtocolVersion is an int

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126594/#review90427 --- Ship it! Ship It! - David Edmundson On Jan. 1, 2016, 10

Re: Review Request 126597: Notificatioins rework

oks pretty much like it's just a revert of 4a6f7db0018a2a7366ac7f2ad61fc33f31566c03 Plus a change from setX/setY to setPosition to skip the the "Behavior on y {" animation. Is that right? - David Edmundson On Jan. 2, 201

Re: Review Request 126597: Notificatioins rework

> On Jan. 2, 2016, 9:27 a.m., David Edmundson wrote: > > Snarky comments don't really help acheive anything. > > > > What version of Qt are you running. This was all added to work round a > > change in a late Qt XCB 5.5? > > > > Also could you exp

Re: Review Request 126597: Notificatioins rework

ng(function() {configurationChanged(); return screenPositionSelector.selectedPosition; }); calling configurationChanged - David Edmundson On Jan. 2, 2016, 6:55 a.m., Anthony Fieroni wrote: > > --- > This is an automatically genera

Re: Review Request 126472: Don't always load the timetracker

wboard.kde.org/r/126472/#review89924 --- On Dec. 27, 2015, 7:38 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

sk.qml (line 278) <https://git.reviewboard.kde.org/r/126621/#comment61890> Do we need a paintedWidth/paintedHeight in IconItem? - David Edmundson On Jan. 4, 2016, 1:50 p.m., Kai Uwe Broulik wrote: > > --- > This is an aut

Re: Review Request 126625: paintedWidth/paintedheight for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126625/#review90579 --- Ship it! - David Edmundson On Jan. 4, 2016, 4:33 p.m

Re: Review Request 126356: change minimum size of clipboard

> On Dec. 15, 2015, 2:29 p.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/clipboard.qml, line 69 > > > > > > this is not the actual size of the systray, but a hardcoded value which > > might match (o

Re: Review Request 126629: update the sddm kcm first step

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126629/#review90645 --- Ship it! Ship It! - David Edmundson On Jan. 5, 2016, 2:34

Re: Review Request 126635: TaskManager: Fix tooltip overflowing screen size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126635/#review90646 --- Ship it! - David Edmundson On Jan. 5, 2016, 12:52 p.m

Re: Review Request 126637: IconItem: Add animated property

too? - David Edmundson On Jan. 5, 2016, 12:52 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126636: TaskManager: Enable vertical scroll in tooltip

l events to the scroll area. - David Edmundson On Jan. 5, 2016, 12:52 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revie

Re: Review Request 126641: [Units] scale desktop icon sizes

tps://git.reviewboard.kde.org/r/126641/#comment61970> this comment appears to be a great big lie? - David Edmundson On Jan. 5, 2016, 5:41 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

This wont' solve the problem of downstreams doing their own themes and failing to update their version numbers properly unless they always release at the same time as plasma-framework. - David Edmundson On Jan. 5, 2016, 6:11 p.m., Kai Uwe Bro

Re: Review Request 126652: [Units] Return at least 1ms for durations

> On Jan. 7, 2016, 4:32 p.m., Kai Uwe Broulik wrote: > > I guess we should rather get https://codereview.qt-project.org/#/c/145237/ > > in :) nah, that'll be Qt 5.6 at the earliest. +1 from me on the patch. It's fine to have workarounds if we know they'll only be temporary workarounds. - Dav

Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

hat's true, they'll want to know about it. - David Edmundson On Jan. 10, 2016, 1:59 a.m., Dāvis Mosāns wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

i,f member variables. but this is the same as hte original code, so it's fine. - David Edmundson On Dec. 25, 2015, 7:02 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 126689: Change minimum Size of Calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126689/#review90844 --- Ship it! Ship It! - David Edmundson On Jan. 10, 2016, 12

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

tps://git.reviewboard.kde.org/r/126687/#comment62074> what if m_items.value(sourceName).count() is 0 ? - David Edmundson On Jan. 10, 2016, 5:10 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

tps://git.reviewboard.kde.org/r/126687/#comment62076> we want this part unconditionally. - David Edmundson On Jan. 10, 2016, 8:59 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

t all - David Edmundson On Jan. 10, 2016, 10:03 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126713: fix font preview colors

plasma-workspace/xembedsniproxy/sniproxy.cpp (which in itself is copied from KWindowSystem, which I think was copied from Qt) - David Edmundson On Jan. 10, 2016, 10:12 p.m., Thomas Lübking wrote: > > --- > This is an auto

Re: Review Request 126713: fix font preview colors

> On Jan. 10, 2016, 10:31 p.m., David Edmundson wrote: > > Can I suggest you copy SNIProxy::convertFromNative from > > plasma-workspace/xembedsniproxy/sniproxy.cpp > > > > (which in itself is copied from KWindowSystem, which I think was copied > > from Qt)

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

ode for instance and how does this help solve that? There's no method to get a palette from a ColorSet - David Edmundson On Jan. 5, 2016, 11:16 a.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 126721: Don't consider Unknown output an external monitor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126721/#review90945 --- Ship it! Ship It! - David Edmundson On Jan. 11, 2016, 7

<    4   5   6   7   8   9   10   11   12   13   >