> On Aug. 16, 2016, 7:05 a.m., David Faure wrote:
> > doc/kcontrol/khtml-general/index.docbook, line 7
> > <https://git.reviewboard.kde.org/r/128684/diff/1/?file=474210#file474210line7>
> >
> > Yeah I don't understand what this docbook is doing
----
On Aug. 26, 2016, 7:05 a.m., David Faure wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128767/
> -
(0x14af560), current thread is QThread(0x14e4240)
Could not find any platform plugin
Thanks,
David Faure
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit a940089a8f2af58b14b4bfa76db23a199b65a04e by David Faure
to branch master.
Repository: plasma-framework
Description
---
This happens when QtCreator launches qmlplugindump.
Testcase
> On Nov. 3, 2016, 12:53 p.m., Marco Martin wrote:
> > I'm in favor of this, let's wait to 5.29 tough
5.28 RC is tagged, you can now push commits for 5.29.
- David
---
This is an automatically generated e-mail. To reply, visit:
?
Not sure who maintains either one, the names I see in there are all from 2004
or before. So I suppose this is nowadays "plasma team collective
maintainance", which is why I'm asking on plasma-devel before adding a few
more files to plasma-desktop ;-)
Please CC me, I'm not subscribed.
--
D
a terminal in the current folder ^^
> >
> > > dolphin shouldn't allow this.. right?
> >
> > Konsole's desktop file has a key X-KDE-AuthorizeAction=shell_access that
> > tells klauncher to refuse to start it when such restriction is in effect.
> >
> > I'll cc
/kfiledialog_unittest.cpp (line 109)
<https://git.reviewboard.kde.org/r/129732/#comment68103>
Will be uninitialized if the lambda isn't called. Better initialize it.
- David Faure
On Dec. 31, 2016, 9:42 a.m., Albert Astals Cid
A better approach would be
QTRY_VERIFY(findFileWidget());
This will repeatedly call findFileWidget() until it works or until 5
seconds have passed.
Then you don't need timers nor separate methods nor a new member variable.
The rest of the test can just follow that line.
-
dfaure added a comment.
Yeah KF5Konq is a bug, it shouldn't be named that way.
I don't really care about casing, the cmake code will refer to the imported
target (which shouldn't have a KF5:: prefix either), not to the library name
anyway.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> broulik wrote in baloofilepropertiesplugin.desktop:8
> I went through all extractors in KFileMetaData and looked at what they
> support.
>
> Unfortunately
dfaure added a comment.
The idea sounds OK to me.
INLINE COMMENTS
> CMakeLists.txt:32
> +FILE KF5KioArchiveTargets.cmake
> +NAMESPACE KF5::
> +)
The KF5 prefix is wrong, this isn't part of KF5.
> CMakeLists.txt:44
> +
> +add_library(KF5KioArchive kio_archivebase.cpp
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kio_desktop.cpp:171
> +// Set a descriptive display name for the root item
> +if (entry.stringValue(KIO::UDSEntry::UDS_NAME) == QLatin1String(".")) {
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Looks OK. It would be good to port this away from kdelibs4support though, to
avoid propagating that dependency on users of the lib -- making it impossible
to remove later.
At least it
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5221
To: broulik, #plasma, hein, elvisangelaccio, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfiledialog_unittest.cpp:84
> +
> +QMimeType headerMime =
> QMimeDatabase().mimeTypeForName(QStringLiteral("text/x-chdr"));
> +QMimeType
dfaure added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in kfiledialog_unittest.cpp:116
> No, selectedMimeTypeFilter() is only in 5.9 so that wouldn't compile
Oh I see. The QCOMPARE is just so that a failure happens. Pretty pointless,
it's not testing anything from Qt. I would
https://bugs.kde.org/show_bug.cgi?id=376128
David Faure <fa...@kde.org> changed:
What|Removed |Added
Component|general |default
P
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Extra credit for factorizing this into a file-static function and handling
data: URLs separately (no point in seeing 100 chars of data crap, we could do
data:[...] or something like that).
dfaure added a comment.
Yes; looks much nicer, doesn't it?
INLINE COMMENTS
> job_p.h:76
> Job *q_ptr;
> +static const int DescriptionUrlMaxLength = 100;
>
This can now be moved to the helper function.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5013
dfaure added a comment.
Ship it ;)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5013
To: yuenlim, #plasma, dfaure
Cc: dfaure, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
dfaure added a comment.
Can you use KStringHandler::csqueeze ? This way filenames are still visible.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D5013
To: yuenlim, #plasma
Cc: dfaure, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
dfaure added a comment.
"I didn't find signals to notify changes" --> you mean how to tell apps that
something changed in a given protocol? That's what KDirNotify is for, but you
can't do the monitoring from a short-lived slave, you need something that stays
alive for the whole session, and
dfaure added a comment.
KFileItem::localPath() should not ever ever be a URL like desktop:/. That
would be very wrong.
It just returns what you set in UDS_LOCAL_PATH, so it's kio_desktop you
should debug, not kio ;)
Well except for KIO::ForwardingSlaveBase, called by kio_desktop -- note
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
If you say it works... ;)
REPOSITORY
R320 KIO Extras
BRANCH
Applications/16.12
REVISION DETAIL
https://phabricator.kde.org/D4839
To: elvisangelaccio, #plasma, dfaure
Cc:
dfaure added a comment.
QDir::cleanPath or QUrl::NormalizePathSegments can help making this fix more
generic.
But I'm curious, where does the "/." come from in the first place?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4923
To: broulik, #plasma,
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:c732c8087cfe: Make unittest independent from the location
of the executable. (authored by dfaure).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
davidedmundson/xdgv6
REVISION DETAIL
https://phabricator.kde.org/D7304
To: davidedmundson, #plasma, dfaure
Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai,
dfaure added a comment.
Looks good, just some details.
INLINE COMMENTS
> plugin_babelfish.cpp:225
> + part->url().scheme().compare(QLatin1String("https"),
> Qt::CaseInsensitive) == 0 ) &&
> +(part->inherits("KHTMLPart") || part->inherits("KWebKitPart"))) {
>
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R226 Konqueror
REVISION DETAIL
https://phabricator.kde.org/D6573
To: marten, #konqueror, #plasma, dfaure
Cc: plasma-devel, #dolphin, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
dfaure added a comment.
Isn't a mutex needed to protect this data structure that is apparently
modified by different threads?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6569
To: graesslin, #frameworks, #plasma, #kwin
Cc: dfaure, plasma-devel, ZrenBot,
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I suppose updating the handler for text/html would make sense too, so that
clicking on a local HTML file opens the same webbrowser.
Some people editing HTML files might prefer that
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> componentchooserbrowser.cpp:132
> +}
> +profile->sync();
> +
Don't you mean mimeAppsList->sync()?
REPOSITORY
R119 Plasma Desktop
REVISION
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Excellent idea.
INLINE COMMENTS
> broulik wrote in componentchooserbrowser.cpp:85
> One could also instead use
>
> KServiceTypeTrader::self()->query(QStringLiteral("Application"),
>
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5446
To: elvisangelaccio, #plasma, dfaure
Cc: anthonyfieroni, plasma-devel, spstarr,
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Thanks!
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D5561
To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D5560
To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, lukas
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Nice work.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D5562
To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D5566
To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, lukas
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D5567
To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, lukas
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kio_sftp.cpp:836
> // Handle user canceled or dialog failed to open...
> -if (!openPasswordDialog(info, errMsg)) {
> +if
dfaure added a comment.
In https://phabricator.kde.org/D6933#129446, @broulik wrote:
> > I suppose updating the handler for text/html would make sense too, so
that clicking on a local HTML file opens the same webbrowser.
>
> Well, KRun has a special case for text/html to always open
dfaure added a comment.
"Show" is a bit of a historical name here, this isn't about showing apps in a
menu...
X-KDE-OnlyLoadOnQtPlatforms would be closer to the truth, no?
Looks good otherwise.
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D6899
To: mart,
dfaure created this revision.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REVISION SUMMARY
This fixes the check in the unittest when doing
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY
dfaure added a comment.
Ah, this key is already used, for applications? I wasn't aware, if that's the
case.
Hmm, then maybe better keep the same key indeed.
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D6899
To: mart, #frameworks, #plasma
Cc: dfaure,
dfaure added inline comments.
INLINE COMMENTS
> kio_man.cpp:247
> +QString lang = QLocale::languageToString((*it_loc).language());
> +if ( !lang.isEmpty() && lang!=QString("C") ) {
> +QString dir = (*it_dir) + '/' + lang;
keep the spaces around !=
>
dfaure created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The QFileDialog documentation says these are equivalent:
dialog.setNameFilter("All C++ files (*.cpp *.cc *.C *.cxx *.c++)");
dfaure created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This fixes support for ":" in filenames.
BUG: 376365
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
setSelectedUrl
dfaure closed this revision.
dfaure added a comment.
Pushed in b785b9c (stupid `arc land` merged two commits)
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D6350
To: dfaure, #plasma, fvogt, apol
Cc: plasma-devel, ZrenBot,
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:4736950ec2e7: KDE QFileDialog helper: support name
filters without parenthesis. (authored by dfaure).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6351?vs=15765=15769#toc
REPOSITORY
R135
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Ths hack isn't horrible (window() makes sense too), however
1. you might want to move the call to window() inside KRun itself so it
applies to all apps
2. please add a link
https://bugs.kde.org/show_bug.cgi?id=366795
--- Comment #29 from David Faure <fa...@kde.org> ---
... with which protocol exactly?
--
You are receiving this mail because:
You are the assignee for the bug.
dfaure added a comment.
Excellent finding, it helped me reduce further the most annoying Qt bug I'm
experiencing right now (in kmail)
--> https://bugreports.qt.io/browse/QTBUG-59017
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D6046
To: broulik, #plasma,
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
initiallySelectedMime (branched from Plasma/5.10)
REVISION DETAIL
https://phabricator.kde.org/D5957
To: elvisangelaccio, #plasma, dfaure
Cc:
dfaure added a comment.
Yeah the favicon for kde.org is bigger than the size limit from the kio code
-- ironic, isn't it. I never took the time to find out if it could be reduced,
or if the size limit should be increased, and whatever other websites and other
webbrowsers do.
As for
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Easy one ;-)
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D5569
To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D5568
To: marten, #plasma, dfaure
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, lukas
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
defaultFilterSaveMode (branched from Plasma/5.10)
REVISION DETAIL
https://phabricator.kde.org/D5956
To: elvisangelaccio, #plasma, dfaure
Cc:
dfaure created this revision.
dfaure added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
QMutex isn't the right tool for this:
- If tryLock succeeds, the code didn't unlock the mutex again,
dfaure created this revision.
dfaure added reviewers: Plasma, davidedmundson, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
[this happens in the zanshin runner, due to libKF5AkonadiCalendar.so.5 linking
to
dfaure abandoned this revision.
dfaure added a comment.
Ah OK. I'm using Plasma/5.11 so I didn't have that fix.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8318
To: dfaure, #plasma, davidedmundson, broulik
Cc: apol, plasma-devel, mlaurent, ZrenBot,
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:df6658eee5c6: Fix QFile::copy warning when the colors
file doesnt exist (authored by dfaure).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
dfaure created this revision.
dfaure added reviewers: mart, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
There is no need to even look for a "Default.colors" file when
using the default color scheme,
This might be of interest to some of you.
-- Forwarded Message --
Subject: Change in qt/qtbase[dev]: Make QPlatformServices as a separated
plugin
Date: mardi 29 août 2017, 10:59:02 CEST
From: Jan Grulich (Code Review) <gerrit-nore...@qt-project.org>
To: David Faure <
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7681
To: adridg, dfaure, mart
Cc: plasma-devel, apol, mart, hein
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6163
To: broulik, #plasma, dfaure
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas,
dfaure added a comment.
In https://phabricator.kde.org/D8419#158645, @broulik wrote:
> Don't you also need a `Messages.sh` and `TRANSLATION_DOMAIN` define?
Well spotted. The Messages.sh file was there, but not the define. Fixed and
pushed.
REPOSITORY
R120 Plasma Workspace
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c2cf81f26bfe: Dict Engine: improve error handling.
(authored by dfaure).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8419?vs=21116=21215#toc
REPOSITORY
R120 Plasma Workspace
CHANGES
dfaure added a comment.
In https://phabricator.kde.org/D8421#158352, @davidedmundson wrote:
> Have you added it to the panel?
What should happen when I do? Surely a webview won't fit there...
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D8421
dfaure added a dependent revision: D9003: Dict applet: implement config dialog
for choosing a dictionary.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D8421
To: dfaure, #plasma
Cc: anthonyfieroni, broulik, davidedmundson, plasma-devel, #plasma, ZrenBot,
dfaure edited the test plan for this revision.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D8421
To: dfaure, #plasma
Cc: broulik, davidedmundson, plasma-devel, #plasma, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
dfaure updated this revision to Diff 22852.
dfaure edited the test plan for this revision.
dfaure added a comment.
clean up TODO
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8421?vs=21473=22852
BRANCH
master
REVISION DETAIL
dfaure updated this revision to Diff 22855.
dfaure added a comment.
Remove old code, not used anymore.
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8421?vs=22852=22855
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8421
AFFECTED
dfaure added a comment.
In https://phabricator.kde.org/D8421#171420, @davidedmundson wrote:
> > What should happen when I do? Surely a webview won't fit there...
>
> We should show an icon (like a dictionary or something)
> which will show the popup with the relevant plasmoid.
>
dfaure updated this revision to Diff 22860.
dfaure added a comment.
Use a signal instead of invokeMethod
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8421?vs=22855=22860
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8421
dfaure edited the test plan for this revision.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D8421
To: dfaure, #plasma
Cc: ngraham, anthonyfieroni, broulik, davidedmundson, plasma-devel, #plasma,
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:bf39f91db8de: Dict applet: implement config dialog for
choosing a dictionary (authored by dfaure).
Restricted Application added a project: Plasma.
Restricted Application added a subscriber:
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:2e0fd299caba: Port the dict applet to KF5 and QtQuick 2
(authored by dfaure).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8421?vs=22860=23273
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:208ad519efa8: DictEngine: set a scheme for the URLs,
otherwise webengine wont handle them (authored by dfaure).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
dfaure created this revision.
dfaure added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Instead of returning "\n\n"
when the word doesn't exist, return a proper readable string so users
know
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:02d8fbfb1928: Dictionary Engine: fix synchronization
issues. (authored by dfaure).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8320?vs=20832=21125
dfaure created this revision.
dfaure added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
My wife was missing this applet, after migrating to Plasma 5.
Therefore I had to learn how to write
dfaure updated this revision to Diff 21496.
dfaure added a comment.
Remove now unnecessary C++11 literal syntax
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8534?vs=21474=21496
BRANCH
Plasma/5.11
REVISION DETAIL
dfaure added a comment.
Oops, thanks for the fix.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D12774
To: hein, #plasma, mart
Cc: dfaure, rikmills, ngraham, fvogt, plasma-devel, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts,
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Makes sense, binding needs to be updated when the value changes.
Thanks for the fix!
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D13760
To: broulik,
dfaure added inline comments.
INLINE COMMENTS
> davidedmundson wrote in mediaframe.cpp:336
> This could have just been an else of the branch above
And then one day someone adds a check for contains() before prepend(), for
instance, and you would need to come back to this structure of the code.
dfaure marked an inline comment as done.
dfaure added inline comments.
INLINE COMMENTS
> broulik wrote in main.qml:4
> Unused?
Ah, yes. That was for "formFactor" as in
https://techbase.kde.org/Development/Tutorials/Plasma5/QML2/GettingStarted#Minimum_size
(which I had to fix so the syntax
dfaure added inline comments.
INLINE COMMENTS
> dfaure wrote in main.qml:33
> `Layout.fillHeight: true` led to a 1-pixel-high webview, not good.
>
> `Layout.fillWidth: true` is good, it means I don't duplicate the width
> anymore.
>
> OK, and doing that in the TextField makes the applet
dfaure updated this revision to Diff 21473.
dfaure added a comment.
Add support for clicking on links; improve layout a bit
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8421?vs=21127=21473
BRANCH
master
REVISION DETAIL
dfaure added inline comments.
INLINE COMMENTS
> CMakeLists.txt:59
> find_package(LibTaskManager CONFIG REQUIRED)
> +find_package(LibColorCorrect CONFIG REQUIRED)
> find_package(KWinDBusInterface CONFIG REQUIRED)
Why is it required? Can't this KCM be skipped if the lib isn't available?
Also,
dfaure added inline comments.
INLINE COMMENTS
> kcm_nightcolor.desktop:18
> +Name[de]=Nachtfarbe
> +Comment=Adjust color temperatur at night to reduce eye strain
> +Comment[de]=Passe Farbtemperatur nachts an um Augen zu entlasten
Typo: temperatur -> temperature.
REPOSITORY
R119 Plasma
dfaure added a comment.
In https://phabricator.kde.org/D9070#197332, @rjvbb wrote:
> What happens when you remove the `,Regular`
That fixes the problem indeed.
>> Workaround: enabling the line that calls
QApplication::setDesktopSettingsAware(false).
>> Proof that this
dfaure added a comment.
I've been hitting a very similar bug where a Qt app was trying to use a bold
font, and this had no effect when running in a plasma workspace, because of
this code in kfontsettingsdata.cpp.
Testcase (couldn't be simpler...)
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Indeed.
Fixed in shared-mime-info 1.10 (commit 009f22a,
https://bugs.freedesktop.org/show_bug.cgi?id=101667)
Fix proposed for Qt: https://codereview.qt-project.org/218155
dfaure added a comment.
Ah, the un-namespaced name made me think it was an external dependency.
OK, sorry for the noise, I must have updated plasma-desktop without updating
plasma-workspace, it works now after a run of kdesrc-build.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
dfaure added inline comments.
INLINE COMMENTS
> colorscope.h:131
> +QObject *const m_parent;
> +Plasma::Theme::ColorGroup m_actualGroup;
>
valgrind says this member isn't initialized, please fix.
http://www.davidfaure.fr/2018/colorscope_valgrind_log.txt
REPOSITORY
R242 Plasma
dfaure created this revision.
dfaure added reviewers: anthonyfieroni, elvisangelaccio, plasma-devel, broulik,
arichardson.
Restricted Application added a project: Plasma.
dfaure requested review of this revision.
REVISION SUMMARY
This regression (compared to kdelibs4's direct KFileDialog
dfaure created this revision.
dfaure added reviewers: arichardson, anthonyfieroni, elvisangelaccio,
plasma-devel, broulik.
dfaure requested review of this revision.
REVISION SUMMARY
This was fixed initially in commit 7bbbd93
dfaure updated this revision to Diff 38681.
dfaure added a comment.
Add a workaround for the current Qt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14440?vs=38653=38681
BRANCH
Plasma/5.13
REVISION DETAIL
https://phabricator.kde.org/D14440
AFFECTED FILES
dfaure updated this revision to Diff 38682.
dfaure added a comment.
Add unittest (which fails without this fix)
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14437?vs=38648=38682
BRANCH
directoryEntered
REVISION
201 - 300 of 481 matches
Mail list logo
