Re: feature freeze exception

2024-03-22 Thread David Redondo
Am Donnerstag, 21. März 2024, 16:51:00 CET schrieb Mike Noe: > Hello fellow developers! > > I'd like to request a feature freeze exception for > https://invent.kde.org/plasma/print-manager/-/merge_requests/116. I feel > that this is important to get into the next release because we've had a >

Re: Wayland Nvidia situation for initial Plasma 6 release

2024-02-07 Thread David Redondo
Am Mittwoch, 7. Februar 2024, 10:37:13 CET schrieb Kai Uwe Broulik: > Hi, > > plasma-integration already (which I am NOT happy about!) creates a GL > context to check whether to use software rendering, there we could also > check the GL_VENDOR and set basic render loop. > Yes we did that in 5

Wayland Nvidia situation for initial Plasma 6 release

2024-02-07 Thread David Redondo
Hi, when using Wayland on Nvidia there is a significant problem that QtQuick windows freeze when resized, this can also manifest in plasma popups sometimes not showing up. ref. https://bugreports.qt.io/browse/QTBUG-95817 This can be worked around with using the basic render loop instead of the

Re: QML: a packagers nightmare. Assistance please.

2023-11-08 Thread David Redondo
Am Mittwoch, 8. November 2023, 12:22:33 CET schrieb Scarlett Moore: > Hi everyone, > As we progress through the Qt6 transition I have been trying to keep > up on our QML dependencies and I keep tripping over circular > dependency nightmare. We switched to a mega package format which > includes qml

Re: Plasma 6 alpha modules list

2023-10-30 Thread David Redondo
Am Freitag, 27. Oktober 2023, 17:39:22 CET schrieb Jonathan Riddell: > kwayland-integration - drop No, it is needed for Qt5 apps. David

Re: Plasma-integration and branches

2023-06-20 Thread David Redondo
Am Freitag, 16. Juni 2023, 13:37:20 CEST schrieb David Edmundson: > We've discussed a few times an issue with plasma-integration and > supporting Qt5 and Qt6 clients. > > When we release Plasma 6, we need to ensure that a Qt5 and Qt6 builds > are released. We need users to have both as they are

Re: kio-extras and the KF5/KF6 period

2023-06-07 Thread David Redondo
Am Mittwoch, 7. Juni 2023, 13:00:13 CEST schrieb Luigi Toscano: > I think this is a different case: plasma-integration is part of plasma, and > afaik the maser branch of all repositories which are part of plasma are > Qt6-only already. Note that plasma-integration is our Qt Platform Theme and is

Re: kio-extras and the KF5/KF6 period

2023-06-07 Thread David Redondo
Am Donnerstag, 25. Mai 2023, 12:51:32 CEST schrieb Nicolas Fella: > Hi, > > Am 17.05.23 um 00:02 schrieb Albert Astals Cid: > > kio-extras provides plugins for kio. > > > > So KF5 applications want a KF5 kio-extras and KF6 applications want a KF6 > > kio- extras. > > This is also the case in

Re: Adjusting Kickoff favorites for Plasma 5.27 not working anymore

2023-05-23 Thread David Redondo
I think this issue has been reported as https://bugs.kde.org/show_bug.cgi?id=448660 Seems distros resort to patching files, as these are installed maybe you can do so as well. On my system that is /usr/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/config/main.xml David Am Freitag,

Re: Splitting KGlobalAccel interface and runtime

2023-02-14 Thread David Redondo
Am Montag, 13. Februar 2023, 21:05:33 CET schrieb Nicolas Fella: > It wouldn't automatically solve the coinstallability problem of KF5 and > KF6, because a kglobalacceld provided by KF5-KGlobalAccel would still > conflict with a Plasma-provided kglobalacceld, but it's at least > conceptually less

Re: make IDEs aware of the headers

2023-01-18 Thread David Redondo
Am Samstag, 7. Januar 2023, 16:40:27 CET schrieb Andrey Butirsky: > > Other IDEs should benefit too. KDevelop (and I think Kate too) displays headers in "Project" view without this. I am not convinced of this amount of work (and cluttering of our CMake files) to workaround IDE/editor

Re: Latte Dock 0.10.9

2022-11-25 Thread David Redondo
Am Mittwoch, 16. November 2022, 17:38:12 CET schrieb Jonathan Riddell: > Hi Michael, I've been asking to make a new latte-dock bugfix release to > include this Wayland fix > https://invent.kde.org/plasma/latte-dock/-/commit/1d468a94e931d684f1ec180584 > eaa1d25765f100 > > I've made a tar from that

Re: Cherry-picking policy

2022-11-21 Thread David Redondo
Am Samstag, 19. November 2022, 05:06:11 CET schrieb Ben Cooksley: > Not sure how much of this is on our radar at the moment, but I do know that > we were playing with a bot to do tagging of MRs at one point in time. > > In terms of how this bot operates, how are people thinking it should work? I

Re: Using layershell-qt

2022-09-23 Thread David Redondo
Am Freitag, 23. September 2022, 13:19:05 CEST schrieb Ralf Van Bogaert: > Hi, > Cool project, that you are trying to use layershell-qt with Qt6! > *qt.qpa.wayland: No shell integration named "layer-shell" > foundqt.qpa.wayland: Loading shell integration failed.qt.qpa.wayland: > Attempted to

Re: semicolons and the policy that was none

2022-08-10 Thread David Redondo
Am 2022-08-10 15:57, schrieb Harald Sitter: Aloha, Someone recently dug up this page from 2012 https://community.kde.org/Plasma/QMLStyle#JS_Code_Blocks First I'd like to point out that this page isn't a policy page, if it was meant to be then it needs to be linked on the policies page and

Re: [GSoC Draft proposal] Redesign system settings modules by porting them to QtQuick

2022-04-04 Thread David Redondo
Am Freitag, 1. April 2022, 19:09:07 CEST schrieb Nate Graham: > I would be willing to co-mentor alongside someone else with more dev > experience. I am happy to be co-mentor. As I was never a mentor before you can also mentor my mentoring ;) - >I'm looking for potentials

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

2021-11-24 Thread David Redondo
davidre added a comment. This has been done elsewhere REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D27036 To: davidedmundson, #plasma Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D26675: [sddm-theme] Don't have a broken reveal password button

2021-10-04 Thread David Redondo
davidre added a comment. we could install an icon into hicolor as fallback REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26675 To: davidedmundson, #plasma Cc: davidre, ahmadsamir, bharadwaj-raju, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

Re: [sysadmin/repo-metadata] projects-invent/plasma/ksysguard: There's no ksysguard 5.23

2021-09-21 Thread David Redondo
Am Dienstag, 21. September 2021, 10:23:57 CEST schrieb Ben Cooksley: > [...] > [2021-09-20T19:24:50.371Z] * KSysGuard Afaik that's libksysguard and not ksysguard as in the repo, that's fine > Currently the CI Dependency Build jobs for Plasma on the stable side are a > sea of red. > Can someone

Re: [sysadmin/repo-metadata] projects-invent/plasma/ksysguard: There's no ksysguard 5.23

2021-09-21 Thread David Redondo
Am Sonntag, 19. September 2021, 23:09:04 CEST schrieb Albert Astals Cid: > Plasma devs if there will be no new ksysguard 5.22.x release please tell > us and we'll clean it up from stable i18n Hi Albert, yes that's correct. From Plasma side there will be no further ksysguard releases. Of course

Re: KDE CI: Plasma » libksysguard » kf5-qt5 FreeBSDQt5.15 - Build # 295 - Failure!

2021-09-01 Thread David Redondo
Am Mittwoch, 1. September 2021, 00:01:49 CEST schrieb David Edmundson: > CC'ing BSD people as only BSD is affected. > > https://build.kde.org/job/Plasma/job/libksysguard/job/kf5-qt5%20FreeBSDQt5.1 > 5/295/ > > I'm stumped on this, the code looks fine. > The build started failing from an

Re: ECM 5.85: introducing KDE_COMPILERSETTINGS_LEVEL concept

2021-08-19 Thread David Redondo
This (being the thing described in Friedrich's email, that was sent to kde-devel and that I've attached below) is going to affect us. We migrated to KDECompilerSettings because we were using KDEFrameworksCompilerSettings when we should not have been and the find version bump hit us. At the moment

Re: The unfortunate state of Plasma's stable branch CI coverage

2021-06-29 Thread David Redondo
I executed the steps that David described and the dependency builds did succeed and the build queue is still filled at this moment. But the stable jobs should now be on 5.22 I hope. Regards, David

Microsoft taking inspiration from Plasma slogan

2021-06-29 Thread David Redondo
Hi, after many people saying that Windows 11 looks a bit similar to Plasma (which is not the focus of this message, please don't start discussing it in detail). They are now using a very familiar slogan to promote Windows 11. Go to https://insider.windows.com/en-us/insidewindows11 and scroll

Re: Monday meeting notes for 14/06/2021

2021-06-14 Thread David Redondo
Am Montag, 14. Juni 2021, 15:43:52 CEST schrieb Nate Graham: > KGlobaAccel seems somewhat fragile; I feel like every time anyone > touches anything about it, stuff breaks. Is it possible to improve unit > test coverage for it? I don't think more testing of KGlobalAccel would solve the problem.

Fwd: Krunner plugins - basic questions from the new plasma dev

2021-04-20 Thread David Redondo
Forwarding to plasma-devel -- Weitergeleitete Nachricht -- Betreff: Krunner plugins - basic questions from the new plasma dev Datum: Sonntag, 18. April 2021, 21:07:37 CEST Von: Slawek Kaplonski An: kde-de...@kde.org Hi, I'm user of the KDE since some time and now I want to

Re: Plasma 5.22 Kickoff Notes

2021-03-10 Thread David Redondo
Thank you for your opinion Marco. Am Mittwoch, 10. März 2021, 09:30:35 CET schrieb Marco Martin: > wasn't present at the kickoff meeting so commenting just here, just now. > I'm quite against qqc2-breeze-style and i think it was a mistake. > It was that the style used in plasma-mobile had bugs,

qqc2-breeze-style should use bugs.kde.org for bug tracking

2021-03-03 Thread David Redondo
Hi, I think when the gitlab migration happened, it was agreed that bug tracking still happens on bugs.kde.org and gitlab issues will eventually replace phabricator tasks. The readme of qqc2-breeze-style includes: > # Bug Reports/Feature Requests/Issues: > >File your reports/requests here:

D23257: Allow for easier syncing of Plasma font

2021-02-18 Thread David Redondo
davidre closed this revision. REVISION DETAIL https://phabricator.kde.org/D23257 To: filipf, ngraham, #plasma, davidedmundson Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed,

D23257: Allow for easier syncing of Plasma font

2021-02-18 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > filipf wrote in sddmkcm.cpp:243 > Unfortunately not yet because we still need the `kdeglobals` file for color > schemes. From my previous testing it's not enough to just copy some line > `colorScheme=Adwaita`, we actually need to copy all of the

D23257: Allow for easier syncing of Plasma font

2021-02-18 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > sddmkcm.cpp:243 > > if (!kdeglobalsPath.isEmpty()) { > args[QStringLiteral("kdeglobals")] = kdeglobalsPath; Should I remove this then? BRANCH arcpatch-D23257 REVISION DETAIL https://phabricator.kde.org/D23257 To: filipf,

D23257: Allow for easier syncing of Plasma font

2021-02-18 Thread David Redondo
davidre added a comment. I rebased it because of the rewrite that happened, can you check if everything is still ok @filipf BRANCH arcpatch-D23257 REVISION DETAIL https://phabricator.kde.org/D23257 To: filipf, ngraham, #plasma, davidedmundson Cc: davidre, plasma-devel, Orage,

D23257: Allow for easier syncing of Plasma font

2021-02-18 Thread David Redondo
davidre updated this revision to Diff 83430. davidre added a comment. Rebase CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23257?vs=64999=83430 BRANCH arcpatch-D23257 REVISION DETAIL https://phabricator.kde.org/D23257 AFFECTED FILES src/sddmkcm.cpp To: filipf, ngraham,

D23257: Allow for easier syncing of Plasma font

2021-02-16 Thread David Redondo
davidre added a comment. Everybody ok if I push this, before it is forgotten again? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH easier-font-syncing (branched from master) REVISION DETAIL https://phabricator.kde.org/D23257 To: filipf, ngraham, #plasma, davidedmundson Cc:

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

2020-11-17 Thread David Redondo
davidre added a comment. Ping? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D27036 To: davidedmundson, #plasma Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

Re: Monday meeting notes for 9/11/2020

2020-11-09 Thread David Redondo
Am Montag, 9. November 2020, 15:22:51 CET schrieb Nate Graham: > On 11/9/20 5:18 AM, Marco Martin wrote: > > Missing form David Redondo: > > * I made a simple patch so QMenus are polished before creating the > > platform window > > * https://codereview.qt-proje

Re: Plasma and a bachelor thesis

2020-10-23 Thread David Redondo
Hi Ilya, > That's fair. Even though the format would declare it an engineering thesis > and shift the focus more to the code, I would still need to show research > skills, explain the novelty of this work (maybe by using a more general > topic name) and write plenty of text. Do you think the

Plasma Beta Review Day

2020-09-20 Thread David Redondo
Hi, during the last kickoff meeting we decided to hold a public Plasma Beta Review day on BBB to get more feedback on the beta release. The date in the wiki is Thursday next week (exactly one week after the beta). If we want to go through with this idea, we need to decide on a time frame and

Relicensing a file in Dr. Konqi

2020-09-11 Thread David Redondo
Hello Hans, we are currently converting copyright headers to SPDX expressions to be in line with the REUSE specification, see https://phabricator.kde.org/T12528 and https://invent.kde.org/teams/licensing During this I found this file https://invent.kde.org/plasma/drkonqi/-/blob/

Monday Meeting Notes for 10/08/2020

2020-08-10 Thread David Redondo
Nico: - Update Flatpak runtime to KF5 5.73 https://invent.kde.org/packaging/flatpak-kde-runtime/-/merge_requests/17 - Tweak some margins in the dialer: https://invent.kde.org/plasma-mobile/ plasma-dialer/-/merge_requests/20 - Some code cleanup in Kongress - Fix passive notification padding when

Re: Plasma related BoFs at Akademy 2020

2020-08-04 Thread David Redondo
Hi Aleix, Am Montag, 3. August 2020, 16:40:21 CEST schrieb Aleix Pol: > We do have several Plasma BoF. I see at least Plasma Discover and > Plasma Mobile. ;) Seems like I should have used ctrl+f instead of scrolling over the page and looking manually. ;) > Hardware collaborations should also be

Plasma related BoFs at Akademy 2020

2020-08-03 Thread David Redondo
Hi, currently I see no Plasma related BoFs at https://community.kde.org/Akademy/ 2020/AllBoF . Do you think we should have some specific BoFs and/or a general Plasma one? Or maybe you already have a subject that you feel warrants a BoF? Then feel free to tell us and add it to the wiki.

Re: Breakage in Breeze Icons

2020-07-21 Thread David Redondo
I fixed the build now. There was a symlink to a removed file which cmake -E copy_directory didn't like. Regards, David

Re: dipping a toe in waywater? :)

2020-07-03 Thread David Redondo
Hello René, maybe this blog post from Aleix can help you. It explains how to started a nested session or wayland session. https://www.proli.net/2020/04/03/developing-kwin-wayland/ Regard, David

D29154: Use QWindow overload of QIcon::pixmap

2020-06-13 Thread David Redondo
davidre added a comment. In my testing dragging a window to a screen with a different scalefactor has no issue and @apol said for him it's better than the status quo. So I would like to land this REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29154 To: davidre,

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-06-08 Thread David Redondo
davidre added a comment. Ping REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29462 To: Zren, #kirigami, mart Cc: davidre, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D29140: Show POTD in lock screen

2020-05-16 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > kded_potd.cpp:25 > +delete engine; > +delete watcher; > +} Don't need to delete watcher because you constructed it with `this` as parent. https://doc.qt.io/qt-5/objecttrees.html For the engine don't delete it because you don't have the

D29140: Show POTD in lock screen

2020-05-16 Thread David Redondo
davidre added a comment. Flickr works here F8325269: Screenshot_20200516_095930.png > For the leaks, I really have no idea. (also asked some friends but no help) C++ isn't my primary programming language. If you can share some

D29140: Show POTD in lock screen

2020-05-14 Thread David Redondo
davidre added a comment. I don't get how saving as a png fails if we have the image as QImage. INLINE COMMENTS > kded_potd.cpp:9 > +{ > +consumer = new Plasma::DataEngineConsumer(); > +engine = consumer->dataEngine(QStringLiteral("potd")); still leaks > kded_potd.cpp:28 > + */ >

D29140: Show POTD in lock screen

2020-05-14 Thread David Redondo
davidre added a comment. I fail to see what the kded module actually does. Or is it the case that simply requesting the data from the engine causes it to cache the image on disk? Maybe that should be documented. INLINE COMMENTS > CMakeLists.txt:44 > CoreAddons > +DBusAddons >

D29703: Disable horizontal scrollbar in systemtray settings

2020-05-13 Thread David Redondo
davidre updated this revision to Diff 82728. davidre added a comment. do it for all REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29703?vs=82721=82728 BRANCH scroll (branched from Plasma/5.18) REVISION DETAIL

D29704: [kcms/baloo] Disable horizonal scrollbar

2020-05-13 Thread David Redondo
davidre updated this revision to Diff 82727. davidre added a comment. Do it for every scrollview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29704?vs=82722=82727 BRANCH scroll (branched from Plasma/5.18) REVISION DETAIL

D29704: [kcms/baloo] Disable horizonal scrollbar

2020-05-13 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY We need to hardcode it now because of QTBUG-83890. CCBUG: 419514 REPOSITORY R119 Plasma Desktop BRANCH scroll (branched

D29703: Disable horizontal scrollbar in systemtray settings

2020-05-13 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY We need to hardcode it now because of QTBUG-83890. CCBUG: 419514 REPOSITORY R120 Plasma Workspace BRANCH scroll

D29701: Disable horizontal scrollbar in kcm

2020-05-13 Thread David Redondo
davidre added a comment. Should this go to master, too? Or should we hope that we need the workaround only for 5.18 and 5.19 and the qtbug will be fixed eventually? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D29701 To: davidre, broulik,

D29701: Disable horizontal scrollbar in kcm

2020-05-13 Thread David Redondo
davidre updated this revision to Diff 82719. davidre added a comment. . REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29701?vs=82718=82719 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29701 AFFECTED FILES

D29701: Disable horizontal scrollbar in kcm

2020-05-13 Thread David Redondo
davidre created this revision. davidre added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. davidre requested review of this revision. REVISION SUMMARY We need to hardcode it now because of QTBUG-83890. CCBUG:

D29632: [kcms/keys] Use better collator settings

2020-05-12 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R119:847d9216e0c1: [kcms/keys] Use better collator settings (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29632?vs=82625=82626 REVISION

D29632: [kcms/keys] Use better collator settings

2020-05-12 Thread David Redondo
davidre updated this revision to Diff 82625. davidre added a comment. numeric REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29632?vs=82529=82625 BRANCH collator (branched from master) REVISION DETAIL https://phabricator.kde.org/D29632

D29644: Select application after it is added

2020-05-12 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R119:bc5c1d882ed8: Select application after it is added (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29644?vs=82621=82624 REVISION

D29579: [kcms/keys] Really ignore unknown action

2020-05-12 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R119:12a14a789da4: [kcms/keys] Really ignore unknown action (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29579?vs=82407=82623 REVISION

D29635: [kcms/keys] Make saving sync

2020-05-12 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R119:fcb04768142f: [kcms/keys] Make saving sync (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29635?vs=82535=82622 REVISION DETAIL

D29644: Select application after it is added

2020-05-12 Thread David Redondo
davidre updated this revision to Diff 82621. davidre added a comment. Use PropertyAction REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29644?vs=82545=82621 BRANCH addIndex (branched from master) REVISION DETAIL

D29644: Select application after it is added

2020-05-11 Thread David Redondo
davidre created this revision. davidre added reviewers: broulik, ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY After adding an application, an user will probably want to edit shortcuts for

D29632: [kcms/keys] Use better collator settings

2020-05-11 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > shortcutsmodel.cpp:89 > QCollator collator; > +collator.setCaseSensitivity(Qt::CaseInsensitive); > std::sort(m_components.begin(), m_components.end(), > [&](const Component , const

D29635: [kcms/keys] Make saving sync

2020-05-11 Thread David Redondo
davidre created this revision. davidre added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY If it's async it will not save when changing modules, or quitting kcmshell, see T13140

D29632: Use better collator settings

2020-05-11 Thread David Redondo
davidre created this revision. davidre added reviewers: ognarb, broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH collator (branched from master) REVISION DETAIL

D29619: Improve StatusNotifierTest

2020-05-11 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R120:5459a533974e: Improve StatusNotifierTest (authored by davidre). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29619?vs=82491=82521 REVISION DETAIL

D28208: Move sni icon handling logic from data engine to applet

2020-05-11 Thread David Redondo
davidre updated this revision to Diff 82519. davidre added a comment. - fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=82492=82519 BRANCH sni (branched from master) REVISION DETAIL https://phabricator.kde.org/D28208 AFFECTED

D29625: Add global shortcut

2020-05-11 Thread David Redondo
davidre added a comment. In D29625#668203 , @davidre wrote: > -1 for khotkeys. Add `X-KDE-Shortcuts` to the desktop file instead and instal it to share/kglobalaccel REPOSITORY R124 System Settings REVISION DETAIL

D29625: Add global shortcut

2020-05-11 Thread David Redondo
davidre added a comment. -1 for khotkeys. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D29625 To: guoyunhe, #plasma Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D28208: Move sni icon handling logic from data engine to applet

2020-05-11 Thread David Redondo
davidre updated this revision to Diff 82492. davidre added a comment. - Rebase without test REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78982=82492 BRANCH sni (branched from master) REVISION DETAIL

D29619: Improve StatusNotifierTest

2020-05-11 Thread David Redondo
davidre added a comment. F8308915: Screenshot_20200511_093148.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29619 To: davidre, kmaterka Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D29619: Improve StatusNotifierTest

2020-05-11 Thread David Redondo
davidre created this revision. davidre added a reviewer: kmaterka. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Allows to set Icon, AttentionIcon and OverlayIcon either by name or pixmap. Makes it easier

D29580: [kcms/keys] Also consider portable text when filtering

2020-05-10 Thread David Redondo
davidre created this revision. davidre added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Enables searching for "ctrl" or "shift" in non english locale REPOSITORY R119 Plasma

D29579: [kcms/keys] Really ignore unknown action

2020-05-10 Thread David Redondo
davidre created this revision. davidre added reviewers: ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise the end() iterator is dereferenced resulting in a crash BUG: 421016 TEST

D28744: Rewrite of the global shortcuts kcm

2020-04-30 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R119:1ee6660ceb62: Rewrite of the global shortcuts kcm (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=81441=81607 REVISION

D25144: [RFC][Global Shortcuts KCM] Categorize into Applications and System Services

2020-04-29 Thread David Redondo
davidre abandoned this revision. davidre added a comment. Superseeded by total rewrite of the kcm REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25144 To: davidre, #plasma, mlaurent, ngraham Cc: mlaurent, ngraham, plasma-devel, Orage, LeGast00n,

D28744: Rewrite of the global shortcuts kcm

2020-04-29 Thread David Redondo
davidre added a comment. In D28744#659447 , @ngraham wrote: > I find that I'm not able to set shortcuts involving the space key. The key sequence get repeated twice in the button and the Apply button ever becomes enabled. Can you reproduce?

D28744: Rewrite of the global shortcuts kcm

2020-04-28 Thread David Redondo
davidre updated this revision to Diff 81441. davidre added a comment. - Reinstate the pointingHand mouseAreas - Make delegate automatically expand if it's the only one REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=81435=81441 BRANCH

D28744: Rewrite of the global shortcuts kcm

2020-04-28 Thread David Redondo
davidre updated this revision to Diff 81435. davidre added a comment. - Make the delegate use states REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=81305=81435 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D29154: Use QWindow overload of QIcon::pixmap

2020-04-28 Thread David Redondo
davidre added a comment. I did some digging and think that things should be repainted when they change screen https://code.woboq.org/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp.html#_ZN13QWidgetWindow18handleScreenChangeEv REPOSITORY R31 Breeze REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

2020-04-27 Thread David Redondo
davidre updated this revision to Diff 81305. davidre added a comment. rebasae REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=81304=81305 BRANCH kcmkeys2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28744

D28744: Rewrite of the global shortcuts kcm

2020-04-27 Thread David Redondo
davidre updated this revision to Diff 81304. davidre added a comment. - Use model.* properties - Use placeholder message - Still don't know why model properties are undefined when switching components REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29140: Fix POTD in lock screen (partly)

2020-04-25 Thread David Redondo
davidre added a comment. In D29140#656817 , @guoyunhe wrote: > To totally solve the issue, there are several solutions I can find: > > 1. POTD need to have a daemon process that can always access network. The lock screen send request to the

D29154: Use QWindow overload of QIcon::pixmap

2020-04-25 Thread David Redondo
davidre added a comment. Actually everything in the sidebad is very blurry at 2x REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29154 To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29154: Use QWindow overload of QIcon::pixmap

2020-04-25 Thread David Redondo
davidre added a comment. In D29154#656690 , @apol wrote: > This is what it looks like for me with the patch applied. > > scale 1x: F8258193: Screenshot_20200424_203628.png > scale 2x: F8258201:

D29157: force systemsettings for kcms

2020-04-24 Thread David Redondo
davidre added a comment. Maybe todo remove? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29157 To: mart, #plasma Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29154: Use QWindow overload of QIcon::pixmap

2020-04-24 Thread David Redondo
davidre added a comment. In D29154#656585 , @apol wrote: > +1 > > I did the same thing for kirigami @ D29100 and plasma-framework @ D29102 yesterday after looking at

D29154: Use QWindow overload of QIcon::pixmap

2020-04-24 Thread David Redondo
davidre updated this revision to Diff 81107. davidre added a comment. Correct code style when I'm touching these lines either way REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29154?vs=81106=81107 BRANCH window REVISION DETAIL

D29154: Use QWindow overload of icon.pixmap

2020-04-24 Thread David Redondo
davidre created this revision. davidre added reviewers: apol, broulik, ndavis, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Previously only the combobox used this overload but that dropped in

D28908: Use the same icon mode calculation for comboboxes as for buttons

2020-04-24 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R31:5a62232415bc: Use the same icon mode calculation for comboboxes as for buttons (authored by davidre). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D29012: Fix variable mixup

2020-04-24 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R31:49cff2127371: Fix variable mixup (authored by davidre). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29012?vs=80657=81104 REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

2020-04-23 Thread David Redondo
davidre updated this revision to Diff 81016. davidre added a comment. - Don't drop installing scheme files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80767=81016 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D29058: Set a component display name for the action collection of ksmserver

2020-04-23 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R120:9056449edc89: Set a component display name for the action collection of ksmserver (authored by davidre). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29052: Set component display name for touchboard and keyboard kcm action collections

2020-04-23 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R119:e64a3cb2af23: Set component display name for touchboard and keyboard kcm action collections (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29058: Set a component display name for the action collection of ksmserver

2020-04-21 Thread David Redondo
davidre created this revision. davidre added reviewers: ngraham, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY "ksmserver" is not a good user visible string. TEST PLAN check in global

D29052: Set component display name for touchboard and keyboard kcm action collections

2020-04-21 Thread David Redondo
davidre created this revision. davidre added reviewers: ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise they get assigned a generic "KDE Daemon" name because of kded TEST PLAN

D28744: Rewrite of the global shortcuts kcm

2020-04-21 Thread David Redondo
davidre updated this revision to Diff 80767. davidre added a comment. - Fix defaults - Add pending deletion thing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80675=80767 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

2020-04-21 Thread David Redondo
davidre added a comment. In D28744#652925 , @ngraham wrote: > Here's how it looks with the old KCM: F8249724: Screenshot_20200420_125405.png > > So my KDE Daemon category has one entry in French for

  1   2   3   4   5   >