Re: KDE/kdelibs/plasma
On lundi 16 août 2010 21:02:04 Brian David Pritchett wrote: SVN commit 1164453 by pritchett: Added akonadi storage plugin loading. M +31 -21datacontainer.cpp M +2 -2 private/datacontainer_p.h Hi, could you verify these commit please ? plasma-desktop doesn't start here (I have 100% cpu here) I reverted datacontainer.cpp and it works fine. Regards - #0 QChar::cell (this=0x233db60) at ../../include/QtCore/../../src/corelib/tools/qchar.h:283 #1 0x7f6fcc126744 in operator (out=..., str=...) at tools/qstring.cpp:7249 #2 0x7f6fcc200185 in operator QString (s=..., l=...) at ../../include/QtCore/../../src/corelib/io/qdatastream.h:261 #3 0x7f6fcc1fff4d in operator (out=..., list=...) at ../../include/QtCore/../../src/corelib/tools/qstringlist.h:251 #4 0x7f6fcc1fe628 in QMetaType::save (stream=..., type=11, data=0x21fb7d8) at kernel/qmetatype.cpp:607 #5 0x7f6fcc2205ff in QVariant::save (this=0x21fb7d8, s=...) at kernel/qvariant.cpp:1998 #6 0x7f6fcc220699 in operator (s=..., p=...) at kernel/qvariant.cpp:2026 #7 0x7f6fcfd48cf5 in Plasma::DataContainer::store (this=0x2334e90) at /home/laurent/kde/kde4/kdelibs/plasma/datacontainer.cpp:220 #8 0x7f6fcfd4c40c in Plasma::DataEngine::removeSource (this=0x233bcd0, source=...) at /home/laurent/kde/kde4/kdelibs/plasma/dataengine.cpp:324 #9 0x7f6fcfd4e4b4 in Plasma::DataEngine::qt_metacall (this=0x233bcd0, _c=QMetaObject::InvokeMetaMethod, _id=value optimized out, _a=0x7fff3cf7deb0) at /home/laurent/kde/kde4/kdelibs/build/plasma/dataengine.moc:128 #10 0x7f6faea98965 in ComicEngine::qt_metacall (this=0x233db60, _c=35485056, _id=0, _a=0x21d7578) at /home/laurent/kde/kde4/kdeplasma- addons/build/dataengines/comic/comic.moc:75 #11 0x7f6fcc1f8103 in QMetaObject::metacall (object=0x233bcd0, cl=QMetaObject::InvokeMetaMethod, idx=7, argv=0x7fff3cf7deb0) at kernel/qmetaobject.cpp:237 #12 0x7f6fcc20e50c in QMetaObject::activate (sender=0x2334e90, m=0x7f6fd013dba0, local_signal_index=1, argv=0x7fff3cf7deb0) at kernel/qobject.cpp:3295 #13 0x7f6fcfd47fd5 in Plasma::DataContainer::becameUnused (this=0x233db60, _t1=value optimized out) at /home/laurent/kde/kde4/kdelibs/build/plasma/datacontainer.moc:119 #14 0x7f6fcfd488b6 in Plasma::DataContainer::checkUsage (this=0x2334e90) at /home/laurent/kde/kde4/kdelibs/plasma/datacontainer.cpp:366 #15 0x7f6fcfd4cb43 in Plasma::DataEngine::query (this=0x233bcd0, source=...) at /home/laurent/kde/kde4/kdelibs/plasma/dataengine.cpp:148 #16 0x7f6fb19b210a in ComicApplet::init (this=0x1eb4030) at /home/laurent/kde/kde4/kdeplasma-addons/applets/comic/comic.cpp:146 #17 0x7f6fcfd308a0 in Plasma::ContainmentPrivate::initApplets (this=0x1ec4ab0) at /home/laurent/kde/kde4/kdelibs/plasma/containment.cpp:451 #18 0x7f6fcfd447ac in Plasma::CoronaPrivate::importLayout (this=0x1883a90, conf=value optimized out, mergeConfig=value optimized out) at /home/laurent/kde/kde4/kdelibs/plasma/corona.cpp:514 #19 0x7f6fcfd45413 in Plasma::Corona::loadLayout (this=0x18cacd0, configName=...) at /home/laurent/kde/kde4/kdelibs/plasma/corona.cpp:451 #20 0x7f6fcfd46272 in Plasma::Corona::initializeLayout (this=0x18cacd0, configName=...) at /home/laurent/kde/kde4/kdelibs/plasma/corona.cpp:354 #21 0x7f6fd1044060 in PlasmaApp::corona (this=0x17747f0) at /home/laurent/kde/kde4/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp:800 #22 0x7f6fd10444e3 in PlasmaApp::setupDesktop (this=0x17747f0) at /home/laurent/kde/kde4/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp:286 #23 0x7f6fd1045f8e in PlasmaApp::qt_metacall (this=0x17747f0, _c=QMetaObject::InvokeMetaMethod, _id=value optimized out, _a=0x7fff3cf7eb10) at /home/laurent/kde/kde4/kdebase/build/workspace/plasma/desktop/shell/plasmaapp.moc:148 #24 0x7f6fcc1f8103 in QMetaObject::metacall (object=0x17747f0, cl=QMetaObject::InvokeMetaMethod, idx=42, argv=0x7fff3cf7eb10) at kernel/qmetaobject.cpp:237 #25 0x7f6fcc20e50c in QMetaObject::activate (sender=0x18b63b0, m=0x7f6fcc56b400, local_signal_index=0, argv=0x0) at kernel/qobject.cpp:3295 #26 0x7f6fcc2180bb in QSingleShotTimer::timeout (this=0x18b63b0) at .moc/debug-shared/qtimer.moc:82 #27 0x7f6fcc217f8b in QSingleShotTimer::timerEvent (this=0x18b63b0) at kernel/qtimer.cpp:308 #28 0x7f6fcc209cd9 in QObject::event (this=0x18b63b0, e=0x7fff3cf7f3a0) at kernel/qobject.cpp:1212 #29 0x7f6fcb0204fc in QApplicationPrivate::notify_helper (this=0x178a4c0, receiver=0x18b63b0, e=0x7fff3cf7f3a0) at kernel/qapplication.cpp:4306 #30 0x7f6fcb01da01 in QApplication::notify (this=0x17747f0, receiver=0x18b63b0, e=0x7fff3cf7f3a0) at kernel/qapplication.cpp:3710 #31 0x7f6fccf47336 in KApplication::notify (this=0x17747f0, receiver=0x18b63b0, event=0x7fff3cf7f3a0) at /home/laurent/kde/kde4/kdelibs/kdeui/kernel/kapplication.cpp:310 #32
Re: Plasmate: some files miss licenses
On lundi 14 mars 2011 14:25:10 Sebastian Kügler wrote: Hi all, Ok for me. Regards ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: libplasma GPL files
On Sunday 07 September 2008 12:42:28 Alex Merry wrote: On Sunday 07 September 2008 09:01:10 Marco Martin wrote: On 9/7/08, Davide Bettio [EMAIL PROTECTED] wrote: Hi, I think that we should change the license of the list below of files from GPL to LGPL: yeah, mixing licenses of sources that gets in the same binary don't make like illegal to distribute the binary or something like that? Not in this case. It just makes libplasma GPL-licensed. Which is definitely not what we want. We need permission to relicense these from: Alexis Ménard Sebastian Kuegler Aaron Seigo Rob Scheepmaker Dan Meltzer Laurent Montel I can't see there being an issue with any of them, but legally we need their written permission. If you're on this list, please can you reply saying that to agree to relicense any GPL code in libplasma of yours to LGPL (v2+)? Alex For me it's ok -- Laurent Montel, KDE/KOffice developer, Qt consultancy projects Klarälvdalens Datakonsult AB, Platform-independent software solutions ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [Kde-pim] KHolidays 5 branch
Le Sunday 28 December 2014 17:19:48 John Layt a écrit : Hi, I've just pushed a new branch called kf5-port to the kholidays repository for people to look at. This contains the set of api changes I wanted to make and attempts to remove the kdelibs4support dependency. We can't for the moment see last commit. Could someone who understands CMake better than me have a look at the last commit, as it refuses to link to QWidget once I remove the kdelibs4support linkage. Fixed now. Once that's fixed, what's the next step, do people want to see each individual change go on review board? Or do I just push and get it tagged for the next frameworks release? Kdepim/kdepimlibs/pim* module compiles against this branch ? The api changes are pretty self-explanatory, but there's a couple of interim measures needed to plug gaps in Qt to allow removing kdelibs4support usage: 1) I've replaced KCalendarSystem with a private copy of QCalendarSystem until it is merged into Qt 2) I've had to import some private Qt code for converting ISO codes to QLocale language and country enums until Qt adds the required public api or I finish OpenCodes. I've kept the astronomical and astrological classes, but haven't looked at them in detail. I was wondering if we want to add private d-pointers to them just to be safe? Some other possible changes remain, but are not really necessary for the first release: 1) Change from ki18n to tr 2) Make the widget and designer plugin build fully optional (any CMake wizard care to do it?) 3) Add the Holiday Category public api Cheers! John. ___ KDE PIM mailing list kde-...@kde.org https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksystraycmd] [Bug 344168] there is no ksystray for plasma5
https://bugs.kde.org/show_bug.cgi?id=344168 Laurent Montel mon...@kde.org changed: What|Removed |Added CC||mon...@kde.org --- Comment #3 from Laurent Montel mon...@kde.org --- Just a question about systray What I need to have it ? I use Plasma5 master + qt5.4.1 and I can't see konversation systray. How it works in plasma 5 ? I need a specific module ? -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksystraycmd] [Bug 344168] there is no ksystray for plasma5
https://bugs.kde.org/show_bug.cgi?id=344168 --- Comment #5 from Laurent Montel mon...@kde.org --- I activated it in konversation but same problem. But each time that I start plasma5 there is a dialogbox which asked to search an engine for systray. It tries to search but didn't find. So what is missing ? I need to build sni for qt5 ? -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksystraycmd] [Bug 344168] there is no ksystray for plasma5
https://bugs.kde.org/show_bug.cgi?id=344168 --- Comment #7 from Laurent Montel mon...@kde.org --- Created attachment 91093 -- https://bugs.kde.org/attachment.cgi?id=91093action=edit dialog box which asks statusnotieritem engine Sorry it's in french but it asks an engine for statusnotifieritem. -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[ksystraycmd] [Bug 344168] there is no ksystray for plasma5
https://bugs.kde.org/show_bug.cgi?id=344168 --- Comment #9 from Laurent Montel mon...@kde.org --- Indeed it was dbusmenu-qt5 which was missing. It works fine now. Thanks. Too bad that kdesrc-build doesn't install it by default. Thanks Regards -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125618: Fixes to KameraConfigDialog
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125618/#review87485
---
kcontrol/kameraconfigdialog.cpp (line 285)
<https://git.reviewboard.kde.org/r/125618/#comment60058>
you use dynamic_cast so you need to test pointer otherwise it can return
null
- Laurent Montel
On oct. 13, 2015, 2:20 matin, Christian Butcher wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125618/
> ---
>
> (Updated oct. 13, 2015, 2:20 matin)
>
>
> Review request for KDE Graphics, Plasma and Marcus Meissner.
>
>
> Repository: kamera
>
>
> Description
> ---
>
> Fixes to the KameraConfigDialog dialogue problems, as seen in the screenshots
> attached to [this previous
> review](https://git.reviewboard.kde.org/r/125433/).
>
> Adds a QScrollArea (with no frame) to allow resizing more easily.
>
> Labels are on the left side of the GridLayouts now, with their controls to
> the right (LineEdit, CheckBox, Slider).
> The labels are almost the same in each of the three cases, but unsure that
> making just one Label, then changing based on an if() is an improvement.
>
>
> Diffs
> -
>
> kcontrol/kameraconfigdialog.cpp f8cdd43b9623ab26b868399ecf3e184c03b41d57
>
> Diff: https://git.reviewboard.kde.org/r/125618/diff/
>
>
> Testing
> ---
>
> Tested with Nikon 1 V2, which seems to have a significant number of available
> fields, and of varied types. Expect that not all `GP_WIDGET_{x,y,z}` are
> covered.
> Tried to test with phone but uses MTP - Plasma and Dolphin allow me to open
> it nicely, and Kamera KCM shows the phone, but won't allow any actions on it.
> Unsure if this means that the KCM should discard MTP phones with which it
> can't interface.
>
>
> Thanks,
>
> Christian Butcher
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125817: Add plugin system for Calendar events
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review87500 --- src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h (line 53) <https://git.reviewboard.kde.org/r/125817/#comment60077> Use Q_NULLPTR is better too src/declarativeimports/calendar/plasmacalendarintegration/plasmacalendarintegration_export.h (line 1) <https://git.reviewboard.kde.org/r/125817/#comment60078> Can we autogenerate it in kf5 ? - Laurent Montel On oct. 26, 2015, 8:22 après-midi, Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125817/ > --- > > (Updated oct. 26, 2015, 8:22 après-midi) > > > Review request for Plasma and Daniel Vrátil. > > > Repository: plasma-framework > > > Description > --- > > This adds a simple plugin interface that can be subclassed > and provide events integration with Plasma Calendar applet. > > It's asynchronous and I've kept it deliberately simple. > For now the Calendar tells the plugins which date range > is being displayed, the plugins load the data and then > emit the dataReady() signal containing the events. > > The events are stored in a multihash for quick access > by the Calendar's agenda part but also for overall > easy-to-use (eg. in teh model data()). > > The event data is stored in EventData class, which has > a pretty self-explanatory members, except perhaps the > "isMinor" one. The intention with this is to support > namedays, where in some countries the calendars have > different name every day. This is just a minor holiday > and as such should not mark the calendar grid, otherwise > the whole grid would be in a different color. > > Putting the interface here might raise the question of > depending on plasma-framework, but plugins provided by > KDE can go to plasma-workspace and other 3rd party ones > would just have to live with it. I don't think it will > be a problem but if it turns out it is, we can rethink > the placement. > > > Diffs > - > > src/declarativeimports/calendar/CMakeLists.txt 40ead91 > src/declarativeimports/calendar/calendarplugin.cpp bafe80c > src/declarativeimports/calendar/daysmodel.h a5bdac9 > src/declarativeimports/calendar/daysmodel.cpp 2d059a8 > src/declarativeimports/calendar/eventdatadecorator.h PRE-CREATION > src/declarativeimports/calendar/eventdatadecorator.cpp PRE-CREATION > src/declarativeimports/calendar/plasmacalendarintegration/CMakeLists.txt > PRE-CREATION > > src/declarativeimports/calendar/plasmacalendarintegration/PlasmaCalendarIntegrationConfig.cmake.in > PRE-CREATION > > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h > PRE-CREATION > > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.cpp > PRE-CREATION > > src/declarativeimports/calendar/plasmacalendarintegration/plasmacalendarintegration_export.h > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125817/diff/ > > > Testing > --- > > I have a simple KHolidays based plugin written (patch should be up later > today) > and patches in the Calendar applet. > > Everything works as expected: > * the days are marked as containing an event > * the agenda part displays details of that event (name) > > > Thanks, > > Martin Klapetek > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124991: Fix autostart desktop file save location
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124991/#review84570 --- Sorry I didn't see this request. I fixed it without it. Again sorry about it. - Laurent Montel On août 30, 2015, 6:07 matin, Andrew Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124991/ --- (Updated août 30, 2015, 6:07 matin) Review request for Plasma and David Edmundson. Bugs: 352005 https://bugs.kde.org/show_bug.cgi?id=352005 Repository: plasma-desktop Description --- Commit 2bbda1e23fd8cff7350260e9003e489f9b838f39 left the traling slash in m_desktopPath out, causing desktop files to be saved to autostartprogram.desktop instead of autostart/program.desktop Diffs - kcms/autostart/autostart.cpp a45d524459ede920b45c5b1587049f77388c330a Diff: https://git.reviewboard.kde.org/r/124991/diff/ Testing --- Tested adding executables and applications. Tested disabling and enabling. Thanks, Andrew Chen ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Info about data from store.kde.org + kdepim
Hi, Before store.kde.org, kdepim ues knewstuff to get data from server. We had for example kmail header theme on old server. But now in new server I can't see them. Do you have an idea why we don't get them now ? Thanks for info. Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
Re: Review Request 129736: KHoliday update - reworked holidays for Poland
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129736/#review101714
---
Ship it!
Seems ok.
Ship it.
Regards
- Laurent Montel
On Jan. 1, 2017, 8:38 a.m., Roman Standzikowski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129736/
> ---
>
> (Updated Jan. 1, 2017, 8:38 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kholidays
>
>
> Description
> ---
>
> The patch contains updated holidays for Poland. This would fix bug
> https://bugs.kde.org/show_bug.cgi?id=365153.
>
>
> For general information about polish holidays (especially the ones we do not
> work in Poland), see:
>
> - see https://en.wikipedia.org/wiki/Public_holidays_in_Poland
> - polish law act: http://isap.sejm.gov.pl/DetailsServlet?id=WDU2015090
>
> Changes:
> - [most important, this HAS TO BE MAINLINED!!!] 6th of January is now a
> public holiday, since 2011 (see
> https://en.wikipedia.org/wiki/Epiphany_(holiday)#Poland)
> - '?ledzik' is not really a religious holiday, this is just the last day of
> carnival (see https://en.wikipedia.org/wiki/Carnival#Poland), there are no
> special religious celebrations at this day in Poland
> - moved Valentine's Day ('Walentynki') to civil holidays; I'm not really sure
> what is the different between 'civil' and 'cultural' holidays, but it seems
> no sense to have just the Valentine's Day in cultural and nothing else there
> - 'Zaduszki' (full name: 'Dzie? Zaduszny') is definitely a religious holiday
> (see https://en.wikipedia.org/wiki/All_Souls%27_Day,
> https://pl.wikipedia.org/wiki/Zaduszki)
> - 'Wigilia' is also a religious holiday (see
> https://en.wikipedia.org/wiki/Christmas_Eve,
> https://pl.wikipedia.org/wiki/Wigilia_Bo%C5%BCego_Narodzenia)
> - 'Wniebowzi?cie NMP' ('Assumption of the Blessed Virgin Mary') is a bit
> complicated; this is both Army Day and Assumption of the Blessed Virgin Mary
> (see https://en.wikipedia.org/wiki/Public_holidays_in_Poland). Since in the
> polish law act the Assumption is mentioned, it is now a 'public religious',
> and the Army Day ('Dzie? Wojska Polskiego') was added as a civil one
> - 'Lany Poniedzia?ek' ('Wet Monday') is a (still live) slavic-pagan
> tradition; since it is not mentioned in the polish law act, I have moved it
> to civil (this day is a holiday, because it is also a second day of Easter).
> I am not 100% sure about this change, any help would be welcome
> - 'Dzie? Programisty' ('Programmers Day') added as a civil holiday; I
> couldn't resist :)
> - added 'T?usty Czwartek' ('Fat Thursday' -
> https://en.wikipedia.org/wiki/Fat_Thursday#Poland); since there are no
> special religious celebrations this day, I have marked it as civil
> - added 'Dzie? Górnika' ('Miners Day' -
> https://pl.wikipedia.org/wiki/Barb%C3%B3rka) - there are traditional
> celebration held in mining areas of Poland
> - added 'Dzie? Edukacji Narodowej' ('Teacher's Day' -
> https://en.wikipedia.org/wiki/Teachers%27_Day), it is celebrated in every
> school
> - renamed '?w' Miko?aj' to 'Miko?ajki', as this is more common name - see
> https://pl.wikipedia.org/wiki/Miko%C5%82ajki_(zwyczaj)
> - polish 'Andrzejki' is a night 29/30 November (again, slavic-pagan tradition
> - https://pl.wikipedia.org/wiki/Andrzejki), not really the same as 'St.
> Andrew's Day'; moved to 29th November, as 30th November is already after the
> feast
> - daylight saving time added (same time is in the whole European Union) -
> 'Czas letni', 'Czas zimowy'
> - added 'Prima Aprilis' ('April Fools' Day')
> - added 'Dzie? Solidarno?ci i Wolno?ci' ('Solidarity and Freedom Day' - see
> https://pl.wikipedia.org/wiki/Dzie%C5%84_Solidarno%C5%9Bci_i_Wolno%C5%9Bci)
> - added 'Dzie? Zwyci?stwa' ('Victory Day' - see
> https://pl.wikipedia.org/wiki/Dzie%C5%84_Zwyci%C4%99stwa)
> - added equinoxes and solstices
> - added comment about polish school holidays
>
>
> Diffs
> -
>
> holidays/plan2/holiday_pl_pl 54d56ac
>
> Diff: https://git.reviewboard.kde.org/r/129736/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Roman Standzikowski
>
>
Re: Review Request 129736: KHoliday update - reworked holidays for Poland
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129736/#review101691
---
holidays/plan2/holiday_pl_pl (line 171)
<https://git.reviewboard.kde.org/r/129736/#comment68106>
2015?
- Laurent Montel
On Dec. 31, 2016, 5:04 p.m., Roman Standzikowski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129736/
> ---
>
> (Updated Dec. 31, 2016, 5:04 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kholidays
>
>
> Description
> ---
>
> The patch contains updated holidays for Poland. This would fix bug
> https://bugs.kde.org/show_bug.cgi?id=365153.
>
>
> For general information about polish holidays (especially the ones we do not
> work in Poland), see:
>
> - see https://en.wikipedia.org/wiki/Public_holidays_in_Poland
> - polish law act: http://isap.sejm.gov.pl/DetailsServlet?id=WDU2015090
>
> Changes:
> - [most important, this HAS TO BE MAINLINED!!!] 6th of January is now a
> public holiday, since 2011 (see
> https://en.wikipedia.org/wiki/Epiphany_(holiday)#Poland)
> - '?ledzik' is not really a religious holiday, this is just the last day of
> carnival (see https://en.wikipedia.org/wiki/Carnival#Poland), there are no
> special religious celebrations at this day in Poland
> - moved Valentine's Day ('Walentynki') to civil holidays; I'm not really sure
> what is the different between 'civil' and 'cultural' holidays, but it seems
> no sense to have just the Valentine's Day in cultural and nothing else there
> - 'Zaduszki' (full name: 'Dzie? Zaduszny') is definitely a religious holiday
> (see https://en.wikipedia.org/wiki/All_Souls%27_Day,
> https://pl.wikipedia.org/wiki/Zaduszki)
> - 'Wigilia' is also a religious holiday (see
> https://en.wikipedia.org/wiki/Christmas_Eve,
> https://pl.wikipedia.org/wiki/Wigilia_Bo%C5%BCego_Narodzenia)
> - 'Wniebowzi?cie NMP' ('Assumption of the Blessed Virgin Mary') is a bit
> complicated; this is both Army Day and Assumption of the Blessed Virgin Mary
> (see https://en.wikipedia.org/wiki/Public_holidays_in_Poland). Since in the
> polish law act the Assumption is mentioned, it is now a 'public religious',
> and the Army Day ('Dzie? Wojska Polskiego') was added as a civil one
> - 'Lany Poniedzia?ek' ('Wet Monday') is a (still live) slavic-pagan
> tradition; since it is not mentioned in the polish law act, I have moved it
> to civil (this day is a holiday, because it is also a second day of Easter).
> I am not 100% sure about this change, any help would be welcome
> - 'Dzie? Programisty' ('Programmers Day') added as a civil holiday; I
> couldn't resist :)
> - added 'T?usty Czwartek' ('Fat Thursday' -
> https://en.wikipedia.org/wiki/Fat_Thursday#Poland); since there are no
> special religious celebrations this day, I have marked it as civil
> - added 'Dzie? Górnika' ('Miners Day' -
> https://pl.wikipedia.org/wiki/Barb%C3%B3rka) - there are traditional
> celebration held in mining areas of Poland
> - added 'Dzie? Edukacji Narodowej' ('Teacher's Day' -
> https://en.wikipedia.org/wiki/Teachers%27_Day), it is celebrated in every
> school
> - renamed '?w' Miko?aj' to 'Miko?ajki', as this is more common name - see
> https://pl.wikipedia.org/wiki/Miko%C5%82ajki_(zwyczaj)
> - polish 'Andrzejki' is a night 29/30 November (again, slavic-pagan tradition
> - https://pl.wikipedia.org/wiki/Andrzejki), not really the same as 'St.
> Andrew's Day'; moved to 29th November, as 30th November is already after the
> feast
> - daylight saving time added (same time is in the whole European Union) -
> 'Czas letni', 'Czas zimowy'
> - added 'Prima Aprilis' ('April Fools' Day')
> - added 'Dzie? Solidarno?ci i Wolno?ci' ('Solidarity and Freedom Day' - see
> https://pl.wikipedia.org/wiki/Dzie%C5%84_Solidarno%C5%9Bci_i_Wolno%C5%9Bci)
> - added 'Dzie? Zwyci?stwa' ('Victory Day' - see
> https://pl.wikipedia.org/wiki/Dzie%C5%84_Zwyci%C4%99stwa)
> - added equinoxes and solstices
> - added comment about polish school holidays
>
>
> Diffs
> -
>
> holidays/plan2/holiday_pl_pl 54d56ac
>
> Diff: https://git.reviewboard.kde.org/r/129736/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Roman Standzikowski
>
>
D8431: Port to autogenerate logging category
mlaurent added reviewers: afiestas, sebas, davidedmundson. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8431 To: mlaurent, afiestas, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8432: Use nullptr. Initialize pointer
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R110 KScreen Library BRANCH use_nullptr REVISION DETAIL https://phabricator.kde.org/D8432 AFFECTED FILES backends/xcbwrapper.cpp backends/xrandr/xrandrconfig.cpp backends/xrandr/xrandroutput.cpp src/backendlauncher/backenddbuswrapper.h src/backendlauncher/backendloader.cpp src/backendlauncher/backendloader.h src/backendmanager.cpp src/config.cpp src/configmonitor.cpp src/doctor/doctor.h src/doctor/dpmsclient.h src/edid.h src/getconfigoperation.h src/mode.cpp src/setconfigoperation.h To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8432: Use nullptr. Initialize pointer
mlaurent added a reviewer: davidedmundson. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D8432 To: mlaurent, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8442: WIP: Define default Action when we plug unknown monitor
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Default action when we plug unknown monitor REPOSITORY R104 KScreen BRANCH customize_connect_unknown_monitor REVISION DETAIL https://phabricator.kde.org/D8442 AFFECTED FILES kcm/src/kcm_kscreen.cpp kcm/src/widget.cpp kcm/src/widget.h kded/generator.cpp kded/generator.h tests/kded/CMakeLists.txt To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: WIP: Define default Action when we plug unknown monitor
mlaurent created this revision. mlaurent added a project: Plasma. REVISION SUMMARY Default action when we plug unknown monitor REPOSITORY R104 KScreen BRANCH customize_connect_unknown_monitor REVISION DETAIL https://phabricator.kde.org/D8444 AFFECTED FILES kcm/src/kcm_kscreen.cpp kcm/src/widget.cpp kcm/src/widget.h kded/generator.cpp kded/generator.h tests/kded/CMakeLists.txt To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: Define default Action when we plug unknown monitor
mlaurent added a comment. @sebas: What do you want as widget design ? Is it ok to add plasma dependancy in kscreen ? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D8444: Define default Action when we plug unknown monitor
mlaurent added a comment. (I was in vacation.) Ok so I need to create an osd plasma for it. I can trash this current patch. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D8444: Define default Action when we plug unknown monitor
mlaurent added a comment. Ping ? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D9300: Store screenMapping info only once
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. seems good for me REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9300 To: amantia, #plasma, mwolff, hein, broulik, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9300: Store screenMapping info only once
mlaurent added inline comments.
INLINE COMMENTS
> screenmapper.cpp:202
> +KConfigGroup group(config, QLatin1String("ScreenMapping"));
> +QStringList mapping =
> group.readEntry(QLatin1String("screenMapping"), QStringList{});
> +setScreenMapping(mapping);
const QStringList
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9300
To: amantia, #plasma, mwolff, hein, broulik
Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
D9325: Use QUrl in the ScreenMapper API
mlaurent added inline comments.
INLINE COMMENTS
> screenmapper.cpp:101
> const auto screenPathWithScheme = screenUrl.url();
> -const bool isEmpty = (path.isEmpty() || screenUrl.path() == "/");
> +const bool isEmpty = (screenUrl.isEmpty() || screenUrl.path() == "/");
> // restore the stored locations
"== QLatin1Char('/') ?"
REVISION DETAIL
https://phabricator.kde.org/D9325
To: amantia, #plasma, mwolff, dakon, broulik
Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
D9323: Use ScreenMapper everywhere as a singleton
mlaurent added a comment. Seems ok for me. REVISION DETAIL https://phabricator.kde.org/D9323 To: amantia, #plasma, mwolff, hein Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D9325: Use QUrl in the ScreenMapper API
mlaurent added inline comments.
INLINE COMMENTS
> foldermodeltest.cpp:34
>
> +static QUrl stringToUrl(const QString ) {
> +return QUrl::fromUserInput(path, {}, QUrl::AssumeLocalFile);
new line after ')'
> positionertest.cpp:38
>
> +static QUrl stringToUrl(const QString ) {
> +return QUrl::fromUserInput(path, {}, QUrl::AssumeLocalFile);
I don't think that it used in this file.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9325
To: amantia, #plasma, mwolff, dakon, broulik
Cc: mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
D8553: It's autotests not tests
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH rename_as_autotest REVISION DETAIL https://phabricator.kde.org/D8553 AFFECTED FILES containments/desktop/plugins/folder/CMakeLists.txt containments/desktop/plugins/folder/autotests/CMakeLists.txt containments/desktop/plugins/folder/autotests/foldermodeltest.cpp containments/desktop/plugins/folder/autotests/foldermodeltest.h containments/desktop/plugins/folder/autotests/positionertest.cpp containments/desktop/plugins/folder/autotests/positionertest.h containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.cpp containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.h containments/desktop/plugins/folder/tests/CMakeLists.txt containments/desktop/plugins/folder/tests/foldermodeltest.cpp containments/desktop/plugins/folder/tests/foldermodeltest.h containments/desktop/plugins/folder/tests/positionertest.cpp containments/desktop/plugins/folder/tests/positionertest.h containments/desktop/plugins/folder/tests/viewpropertiesmenutest.cpp containments/desktop/plugins/folder/tests/viewpropertiesmenutest.h To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8553: It's autotests not tests
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8553 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8432: Use nullptr. Initialize pointer
This revision was automatically updated to reflect the committed changes. Closed by commit R110:7c602a831f5d: Use nullptr. Initialize pointer (authored by mlaurent). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8432?vs=21172=21566 REVISION DETAIL https://phabricator.kde.org/D8432 AFFECTED FILES backends/xcbwrapper.cpp backends/xrandr/xrandrconfig.cpp backends/xrandr/xrandroutput.cpp src/backendlauncher/backenddbuswrapper.h src/backendlauncher/backendloader.cpp src/backendlauncher/backendloader.h src/backendmanager.cpp src/config.cpp src/configmonitor.cpp src/doctor/doctor.h src/doctor/dpmsclient.h src/edid.h src/getconfigoperation.h src/mode.cpp src/setconfigoperation.h To: mlaurent, davidedmundson, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8553: It's autotests not tests
This revision was automatically updated to reflect the committed changes. Closed by commit R119:357bb3ab75c9: Its autotests not tests (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8553?vs=21558=21565#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8553?vs=21558=21565 REVISION DETAIL https://phabricator.kde.org/D8553 AFFECTED FILES containments/desktop/plugins/folder/CMakeLists.txt containments/desktop/plugins/folder/autotests/CMakeLists.txt containments/desktop/plugins/folder/autotests/foldermodeltest.cpp containments/desktop/plugins/folder/autotests/foldermodeltest.h containments/desktop/plugins/folder/autotests/positionertest.cpp containments/desktop/plugins/folder/autotests/positionertest.h containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.cpp containments/desktop/plugins/folder/autotests/viewpropertiesmenutest.h containments/desktop/plugins/folder/tests/CMakeLists.txt containments/desktop/plugins/folder/tests/foldermodeltest.cpp containments/desktop/plugins/folder/tests/foldermodeltest.h containments/desktop/plugins/folder/tests/positionertest.cpp containments/desktop/plugins/folder/tests/positionertest.h containments/desktop/plugins/folder/tests/viewpropertiesmenutest.cpp containments/desktop/plugins/folder/tests/viewpropertiesmenutest.h To: mlaurent, hein, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8515: Don't loop twice here
mlaurent added a comment. This one too ?:) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8515 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8516: Emit signal when we change PerStripe
This revision was automatically updated to reflect the committed changes. Closed by commit R119:bf0a2b81426e: Emit signal when we change PerStripe (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8516?vs=21421=21550#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8516?vs=21421=21550 REVISION DETAIL https://phabricator.kde.org/D8516 AFFECTED FILES containments/desktop/plugins/folder/positioner.cpp To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8549: We use Q_DECL_OVERRIDE or override.
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY > use unique keyword override = TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH use_override REVISION DETAIL https://phabricator.kde.org/D8549 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.h containments/desktop/plugins/folder/folderplugin.h containments/desktop/plugins/folder/itemviewadapter.h containments/desktop/plugins/folder/positioner.h containments/desktop/plugins/folder/wheelinterceptor.h To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8515: Don't loop twice here
This revision was automatically updated to reflect the committed changes. Closed by commit R119:9a5e9be03fe6: Dont loop twice here (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8515?vs=21422=21552 REVISION DETAIL https://phabricator.kde.org/D8515 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/positioner.cpp To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8516: Emit signal when we change PerStripe
mlaurent added a comment. Ping ?:) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8516 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8517: Test enable status change and perStripe change
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8517 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8549: We use Q_DECL_OVERRIDE or override.
This revision was automatically updated to reflect the committed changes. Closed by commit R119:0adccf18e3d0: We use Q_DECL_OVERRIDE or override. (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8549?vs=21551=21553 REVISION DETAIL https://phabricator.kde.org/D8549 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.h containments/desktop/plugins/folder/folderplugin.h containments/desktop/plugins/folder/itemviewadapter.h containments/desktop/plugins/folder/positioner.h containments/desktop/plugins/folder/wheelinterceptor.h To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8517: Test enable status change and perStripe change
This revision was automatically updated to reflect the committed changes. Closed by commit R119:27fb7629ce1d: Test enable status change and perStripe change (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8517?vs=21426=21549 REVISION DETAIL https://phabricator.kde.org/D8517 AFFECTED FILES containments/desktop/plugins/folder/tests/CMakeLists.txt containments/desktop/plugins/folder/tests/foldermodeltest.cpp containments/desktop/plugins/folder/tests/positionertest.cpp containments/desktop/plugins/folder/tests/positionertest.h containments/desktop/plugins/folder/tests/viewpropertiesmenutest.cpp containments/desktop/plugins/folder/tests/viewpropertiesmenutest.h containments/desktop/plugins/folder/viewpropertiesmenu.h To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8474: Reserve size in container
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8474 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8474: Reserve size in container
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile/test REPOSITORY R119 Plasma Desktop BRANCH reserve_info REVISION DETAIL https://phabricator.kde.org/D8474 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8474: Reserve size in container
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a4205b4ef4e0: Reserve size in container (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8474?vs=21310=21311 REVISION DETAIL https://phabricator.kde.org/D8474 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp To: mlaurent, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8475: Avoid to make loop twice. Return -1 if we don't find it
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8475 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8473: Modernize code. Use nullptr where it's possible
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Remove extra ';' Use override everywhere as we already use it in some part of code Fix potential crash when we delete a pointer TEST PLAN build/using :) REPOSITORY R119 Plasma Desktop BRANCH modernize_folderplugin REVISION DETAIL https://phabricator.kde.org/D8473 AFFECTED FILES containments/desktop/plugins/folder/directorypicker.cpp containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h containments/desktop/plugins/folder/labelgenerator.cpp containments/desktop/plugins/folder/mimetypesmodel.cpp containments/desktop/plugins/folder/mimetypesmodel.h containments/desktop/plugins/folder/placesmodel.h containments/desktop/plugins/folder/positioner.cpp containments/desktop/plugins/folder/positioner.h containments/desktop/plugins/folder/previewpluginsmodel.cpp containments/desktop/plugins/folder/previewpluginsmodel.h containments/desktop/plugins/folder/rubberband.h containments/desktop/plugins/folder/shortcut.h containments/desktop/plugins/folder/viewpropertiesmenu.cpp containments/desktop/plugins/folder/viewpropertiesmenu.h To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8473: Modernize code. Use nullptr where it's possible
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8473 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8475: Avoid to make loop twice. Return -1 if we don't find it
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH optimize_search_indexforurl REVISION DETAIL https://phabricator.kde.org/D8475 AFFECTED FILES containments/desktop/plugins/folder/positioner.cpp To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8478: We already depend against 5.34
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH remove_check REVISION DETAIL https://phabricator.kde.org/D8478 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8477: Use directly hasLinkType()
This revision was automatically updated to reflect the committed changes. Closed by commit R119:3b3c83c14971: Use directly hasLinkType() (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8477?vs=21317=21320 REVISION DETAIL https://phabricator.kde.org/D8477 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp To: mlaurent, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8476: qPort to new connect api + use const'ref
mlaurent added inline comments. INLINE COMMENTS > broulik wrote in foldermodel.h:256 > Did you check whether QML can cope with `const &`? The `urls` is used in an > `onMove` QML handler (I recall it not handling `const *` well) I didn't see an error here, but perhaps I didn't test action which use this signal. To be safe I will exclude this part of patch until I am sure that it's ok. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8476 To: mlaurent, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8477: Use directly hasLinkType()
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH use_hasLinkType REVISION DETAIL https://phabricator.kde.org/D8477 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8477: Use directly hasLinkType()
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8477 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8478: We already depend against 5.34
This revision was automatically updated to reflect the committed changes. Closed by commit R119:9f99b4a3c7e8: We already depend against 5.34 (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8478?vs=21319=21321 REVISION DETAIL https://phabricator.kde.org/D8478 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp To: mlaurent, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8476: qPort to new connect api + use const'ref
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8476 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8476: qPort to new connect api + use const'ref
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH port_to_new_connect_api REVISION DETAIL https://phabricator.kde.org/D8476 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8478: We already depend against 5.34
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8478 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8476: qPort to new connect api + use const'ref
mlaurent updated this revision to Diff 21324. mlaurent added a comment. - Perhaps that qml doesn't support const QUrl & REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8476?vs=21315=21324 BRANCH port_to_new_connect_api REVISION DETAIL https://phabricator.kde.org/D8476 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h To: mlaurent, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8475: Avoid to make loop twice. Return -1 if we don't find it
This revision was automatically updated to reflect the committed changes. Closed by commit R119:aac3db7a4d3c: Avoid to make loop twice. Return -1 if we dont find it (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8475?vs=21312=21314 REVISION DETAIL https://phabricator.kde.org/D8475 AFFECTED FILES containments/desktop/plugins/folder/positioner.cpp To: mlaurent, hein, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8473: Modernize code. Use nullptr where it's possible
mlaurent updated this revision to Diff 21348. mlaurent added a comment. - Perhaps gcc/clang can optimize it. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8473?vs=21309=21348 BRANCH modernize_folderplugin REVISION DETAIL https://phabricator.kde.org/D8473 AFFECTED FILES containments/desktop/plugins/folder/directorypicker.cpp containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h containments/desktop/plugins/folder/labelgenerator.cpp containments/desktop/plugins/folder/mimetypesmodel.h containments/desktop/plugins/folder/placesmodel.h containments/desktop/plugins/folder/positioner.cpp containments/desktop/plugins/folder/positioner.h containments/desktop/plugins/folder/previewpluginsmodel.cpp containments/desktop/plugins/folder/previewpluginsmodel.h containments/desktop/plugins/folder/rubberband.h containments/desktop/plugins/folder/shortcut.h containments/desktop/plugins/folder/viewpropertiesmenu.cpp containments/desktop/plugins/folder/viewpropertiesmenu.h To: mlaurent, hein Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8488: Clean forward declaration
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8488 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8488: Clean forward declaration
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH clean_forward_declaration REVISION DETAIL https://phabricator.kde.org/D8488 AFFECTED FILES containments/desktop/plugins/folder/menuhelper.h containments/desktop/plugins/folder/subdialog.h To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8489: Clean includes
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH clean_includes REVISION DETAIL https://phabricator.kde.org/D8489 AFFECTED FILES containments/desktop/plugins/folder/folderplugin.cpp containments/desktop/plugins/folder/folderplugin.h containments/desktop/plugins/folder/labelgenerator.cpp containments/desktop/plugins/folder/mimetypesmodel.h To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8489: Clean includes
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8489 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8473: Modernize code. Use nullptr where it's possible
mlaurent added inline comments. INLINE COMMENTS > broulik wrote in mimetypesmodel.cpp:109 > Isn't the compiler smart ehough? Really I don't know if compiler is able to resolve it when it's not a const variable. If you told me that gcc/clang is able to do it ok :) I can trust you if you told me it's not a problem REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8473 To: mlaurent, hein Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8489: Clean includes
This revision was automatically updated to reflect the committed changes. Closed by commit R119:12a1360101cf: Clean includes (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8489?vs=21350=21354 REVISION DETAIL https://phabricator.kde.org/D8489 AFFECTED FILES containments/desktop/plugins/folder/folderplugin.cpp containments/desktop/plugins/folder/folderplugin.h containments/desktop/plugins/folder/labelgenerator.cpp containments/desktop/plugins/folder/mimetypesmodel.h To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8473: Modernize code. Use nullptr where it's possible
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b95bdf216b8f: Modernize code. Use nullptr where its possible (authored by mlaurent). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8473?vs=21348=21356#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8473?vs=21348=21356 REVISION DETAIL https://phabricator.kde.org/D8473 AFFECTED FILES containments/desktop/plugins/folder/directorypicker.cpp containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h containments/desktop/plugins/folder/labelgenerator.cpp containments/desktop/plugins/folder/mimetypesmodel.h containments/desktop/plugins/folder/placesmodel.h containments/desktop/plugins/folder/positioner.cpp containments/desktop/plugins/folder/positioner.h containments/desktop/plugins/folder/previewpluginsmodel.cpp containments/desktop/plugins/folder/previewpluginsmodel.h containments/desktop/plugins/folder/rubberband.h containments/desktop/plugins/folder/shortcut.h containments/desktop/plugins/folder/viewpropertiesmenu.cpp containments/desktop/plugins/folder/viewpropertiesmenu.h To: mlaurent, hein Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8476: qPort to new connect api + use const'ref
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b706bc73fa63: qPort to new connect api + use constref (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8476?vs=21324=21357 REVISION DETAIL https://phabricator.kde.org/D8476 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h To: mlaurent, hein Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8488: Clean forward declaration
This revision was automatically updated to reflect the committed changes. Closed by commit R119:9d0b117f6fed: Clean forward declaration (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8488?vs=21349=21355 REVISION DETAIL https://phabricator.kde.org/D8488 AFFECTED FILES containments/desktop/plugins/folder/menuhelper.h containments/desktop/plugins/folder/subdialog.h To: mlaurent, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8447: Add unit tests for Folder View
mlaurent requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8447: Add unit tests for Folder View
mlaurent added a comment. missing copyright in new file too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: WIP: Define default Action when we plug unknown monitor
mlaurent added a comment. Wierd why it created a new review ??? This one is more recent. I will close 8442 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8442: WIP: Define default Action when we plug unknown monitor
mlaurent abandoned this revision. mlaurent added a comment. https://phabricator.kde.org/D8444 was opened. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8442 To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8447: Add unit tests for Folder View
mlaurent added a comment. Add in toplevel: if(BUILD_TESTING) add_definitions(-DBUILD_TESTING) endif(BUILD_TESTING) + create a folderplugin_private_export.h as #ifndef KSIEVEUIPRIVATE_EXPORT_H #define KSIEVEUIPRIVATE_EXPORT_H #include "ksieveui_export.h" /* Classes which are exported only for unit tests */ #ifdef BUILD_TESTING 1. ifndef FOLDERPLUGIN_TESTS_EXPORT 2. define FOLDERPLUGIN_TESTS_EXPORT FOLDERPLUGIN_EXPORT 3. endif #else /* not compiling tests */ define FOLDERPLUGIN_TESTS_EXPORT #endif #endif > we avoid to export symbol when we don't build test => distro doesn't generate lib with unnecessary exported symbol. = INLINE COMMENTS > CMakeLists.txt:39 > +generate_export_header(folderplugin BASE_NAME folderplugin) > +add_subdirectory(tests) Use if(BUILD_TESTING) add_subdirectory(tests) endif() it's avoid to build tests when distro builds it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: WIP: Define default Action when we plug unknown monitor
mlaurent added a subscriber: dvratil. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent Cc: dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: WIP: Define default Action when we plug unknown monitor
mlaurent updated this revision to Diff 21283. mlaurent added a comment. - Update extend to left REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8444?vs=21231=21283 BRANCH customize_connect_unknown_monitor REVISION DETAIL https://phabricator.kde.org/D8444 AFFECTED FILES kcm/src/kcm_kscreen.cpp kcm/src/widget.cpp kcm/src/widget.h kded/generator.cpp kded/generator.h tests/kded/CMakeLists.txt To: mlaurent Cc: dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8447: Add unit tests for Folder View
mlaurent added inline comments.
INLINE COMMENTS
> folderplugin_private_export.h:1
> +#ifndef FOLDERPLUGIN_PRIVATE_EXPORT_H
> +#define FOLDERPLUGIN_PRIVATE_EXPORT_H
Missing copyright
> foldermodeltest.cpp:1
> +#include "foldermodeltest.h"
> +#include "foldermodel.h"
Missing copyright
> foldermodeltest.cpp:87
> +QCOMPARE(index.data(FolderModel::FileNameRole).toString(),
> + QString("file%1.txt").arg(i + 1));
> +}
QStringLiteral(...).arg
> foldermodeltest.cpp:102
> +QCOMPARE(index.data(FolderModel::FileNameRole).toString(),
> + QString("file%1.txt").arg(i + 1));
> +}
QStringLiteral(...).arg(...)
> foldermodeltest.cpp:132
> +QTest::addColumn("name");
> +QTest::newRow("Folder rename") << 0 << "firstDirRenamed";
> +QTest::newRow("File rename") << 1 << "file1.pdf";
QStringLiteral("...) same for other line
> foldermodeltest.h:1
> +#ifndef FOLDERMODELTEST_H
> +#define FOLDERMODELTEST_H
missing copyright
> positionertest.cpp:1
> +#include "positionertest.h"
> +
copyright
> positionertest.cpp:53
> +delete m_folderModel;
> +m_folderModel = 0;
> +delete m_positioner;
nullptr;
> positionertest.cpp:55
> +delete m_positioner;
> +m_positioner = 0;
> +}
nullptr;
> positionertest.h:1
> +#ifndef POSITIONERTEST_H
> +#define POSITIONERTEST_H
missing copyright
REVISION DETAIL
https://phabricator.kde.org/D8447
To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot,
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
D8447: Add unit tests for Folder View
mlaurent accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D8447 To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: WIP: Define default Action when we plug unknown monitor
mlaurent marked an inline comment as done. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: WIP: Define default Action when we plug unknown monitor
mlaurent updated this revision to Diff 21288. mlaurent added a comment. - Don't use Q_FOREACH as it will be deprecated in the future REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8444?vs=21283=21288 BRANCH customize_connect_unknown_monitor REVISION DETAIL https://phabricator.kde.org/D8444 AFFECTED FILES kcm/src/kcm_kscreen.cpp kcm/src/widget.cpp kcm/src/widget.h kded/generator.cpp kded/generator.h tests/kded/CMakeLists.txt To: mlaurent Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: Define default Action when we plug unknown monitor
mlaurent retitled this revision from "WIP: Define default Action when we plug unknown monitor" to "Define default Action when we plug unknown monitor". REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: Define default Action when we plug unknown monitor
mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: Define default Action when we plug unknown monitor
mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: Define default Action when we plug unknown monitor
mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8444: Define default Action when we plug unknown monitor
mlaurent edited the test plan for this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8493: Make Folder View screen aware
mlaurent added inline comments. INLINE COMMENTS > foldermodel.h:192 > +ScreenMapper* screenMapper() const; > +void setScreenMapper(ScreenMapper* screenMapper); > + Coding style "space before *" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8493 To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid Cc: broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D8515: Don't loop twice here
mlaurent updated this revision to Diff 21422. mlaurent added a comment. - Avoid twice loop here too REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8515?vs=21418=21422 BRANCH dont_loop_twice REVISION DETAIL https://phabricator.kde.org/D8515 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/positioner.cpp To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8514: Const'ify method
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8514 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8514: Const'ify method
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile REPOSITORY R119 Plasma Desktop BRANCH use_const_method REVISION DETAIL https://phabricator.kde.org/D8514 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8514: Const'ify method
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d5456864596f: Constify method (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8514?vs=21417=21420 REVISION DETAIL https://phabricator.kde.org/D8514 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h To: mlaurent, hein, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8517: Test enable status change and perStripe change
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN compile + launch autotest REPOSITORY R119 Plasma Desktop BRANCH add_more_autotest REVISION DETAIL https://phabricator.kde.org/D8517 AFFECTED FILES containments/desktop/plugins/folder/tests/positionertest.cpp containments/desktop/plugins/folder/tests/positionertest.h To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8517: Test enable status change and perStripe change
mlaurent updated this revision to Diff 21424. mlaurent added a comment. - Start to create autotest for viewpropertiesmenu REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8517?vs=21423=21424 BRANCH add_more_autotest REVISION DETAIL https://phabricator.kde.org/D8517 AFFECTED FILES containments/desktop/plugins/folder/tests/CMakeLists.txt containments/desktop/plugins/folder/tests/positionertest.cpp containments/desktop/plugins/folder/tests/positionertest.h containments/desktop/plugins/folder/tests/viewpropertiesmenutest.cpp containments/desktop/plugins/folder/tests/viewpropertiesmenutest.h containments/desktop/plugins/folder/viewpropertiesmenu.h To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8513: Use emit as all other code use emit and not Q_EMIT
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH use_emit_keyword REVISION DETAIL https://phabricator.kde.org/D8513 AFFECTED FILES containments/desktop/plugins/folder/shortcut.cpp To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8516: Emit signal when we change PerStripe
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH fix_missing_emit_signal REVISION DETAIL https://phabricator.kde.org/D8516 AFFECTED FILES containments/desktop/plugins/folder/positioner.cpp To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8516: Emit signal when we change PerStripe
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8516 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8513: Use emit as all other code use emit and not Q_EMIT
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8513 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8515: Don't loop twice here
mlaurent added a reviewer: hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8515 To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8513: Use emit as all other code use emit and not Q_EMIT
This revision was automatically updated to reflect the committed changes. Closed by commit R119:25d2652a7bd2: Use emit as all other code use emit and not Q_EMIT (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8513?vs=21416=21419 REVISION DETAIL https://phabricator.kde.org/D8513 AFFECTED FILES containments/desktop/plugins/folder/shortcut.cpp To: mlaurent, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8447: Add unit tests for Folder View
This revision was automatically updated to reflect the committed changes. Closed by commit R119:c681a2f6ef63: Add unit tests for Folder View (authored by mlaurent). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8447?vs=21377=21415 REVISION DETAIL https://phabricator.kde.org/D8447 AFFECTED FILES containments/desktop/plugins/folder/CMakeLists.txt containments/desktop/plugins/folder/foldermodel.h containments/desktop/plugins/folder/folderplugin_private_export.h containments/desktop/plugins/folder/positioner.h containments/desktop/plugins/folder/tests/CMakeLists.txt containments/desktop/plugins/folder/tests/foldermodeltest.cpp containments/desktop/plugins/folder/tests/foldermodeltest.h containments/desktop/plugins/folder/tests/positionertest.cpp containments/desktop/plugins/folder/tests/positionertest.h To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot, renatoo, olivierjg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8517: Test enable status change and perStripe change
mlaurent updated this revision to Diff 21426. mlaurent added a comment. - Add more autotest REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8517?vs=21424=21426 BRANCH add_more_autotest REVISION DETAIL https://phabricator.kde.org/D8517 AFFECTED FILES containments/desktop/plugins/folder/tests/CMakeLists.txt containments/desktop/plugins/folder/tests/foldermodeltest.cpp containments/desktop/plugins/folder/tests/positionertest.cpp containments/desktop/plugins/folder/tests/positionertest.h containments/desktop/plugins/folder/tests/viewpropertiesmenutest.cpp containments/desktop/plugins/folder/tests/viewpropertiesmenutest.h containments/desktop/plugins/folder/viewpropertiesmenu.h To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8380: Modernize: use nullptr
mlaurent created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R104 KScreen BRANCH use_nullptr (branched from master) REVISION DETAIL https://phabricator.kde.org/D8380 AFFECTED FILES kcm/src/collapsablebutton.h kcm/src/controlpanel.cpp kcm/src/kcm_kscreen.cpp kcm/src/outputconfig.cpp kcm/src/previewwidget.cpp kcm/src/resolutionslider.cpp kcm/src/widget.cpp kded/daemon.cpp kded/device.cpp kded/generator.cpp To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8380: Modernize: use nullptr
mlaurent updated this revision to Diff 21009. mlaurent added a comment. - Remove unused variable REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8380?vs=21007=21009 BRANCH remove_unsed_variable REVISION DETAIL https://phabricator.kde.org/D8380 AFFECTED FILES kcm/src/collapsablebutton.h kcm/src/controlpanel.cpp kcm/src/kcm_kscreen.cpp kcm/src/outputconfig.cpp kcm/src/previewwidget.cpp kcm/src/resolutionslider.cpp kcm/src/widget.cpp kded/daemon.cpp kded/device.cpp kded/generator.cpp To: mlaurent Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
