D29726: BookmarksRunner: Change caching databases

meven added inline comments. INLINE COMMENTS > chrome.cpp:55 > for(const Profile &profile : profiles) { > +updateCacheFile(profile.faviconSource(), profile.faviconCache()); > m_profileBookmarks << new ProfileBookmarks(profile); Might as well check the returned value for err

D29726: BookmarksRunner: Change caching databases

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me REPOSITORY R120 Plasma Workspace BRANCH avid_unnecessary_copying (branched from master) REVISION DETAIL https://phabricator.kde.org/D29726 To: alex, #plasma, ngraham,

D10197: Fix krunner's alt+f2 on wayland

meven added inline comments. INLINE COMMENTS > view.cpp:247 > -m_plasmaShellSurface->setPanelTakesFocus(true); > -m_plasmaShellSurface->setRole(PlasmaShellSurface::Role::Panel); > -//this should be on showEvent, but it was too soon so none of > those had any e

D29819: Using background rectangle in icon text when in software rendering

meven added a comment. This can be closed : https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29819 To: brunogoncalves, #plasma, ngraham Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D28154: Add users KCM

meven added a comment. So next step would be to shadow user_manager ? A naive ripgrep gave : $ rg user_manager .. ../kxmlgui/src/kbugreport.cpp 352:m_process->start(QStringLiteral("kcmshell5"), QStringList() << QStringLiteral("user_manager")); ../systemsettings

D29807: Change Chrome API design

meven added a comment. Seems good, two small clean ups INLINE COMMENTS > chromeprofile.cpp:8 > +ProfileBookmarks::ProfileBookmarks(const QString &path, const QString &name) > +: m_path(path), m_name(name), m_favicon(nullptr) { > +// Remove "Bookmarks" from end of path `{` on new line

D29827: Give users the ability to disable the microphone indicator

meven added a comment. In D29827#673569 , @kurmikon wrote: > In D29827#673551 , @ngraham wrote: > > > The name needs to be your full name ("Firstname Lastname"). This was a pre-existing requirement,

D29827: Give users the ability to disable the microphone indicator

meven added a comment. In D29827#673611 , @davidedmundson wrote: > It's an SNI, I thought the systemtray could already filter SNIs in the enties tab of the system tray? Currently it appears in the systray config only when the microphone

D29807: Change Chrome API design

meven accepted this revision as: meven. meven added a comment. This revision is now accepted and ready to land. Two smalls things. Seems good to me otherwise. Give some times to other to have a final say before merging. INLINE COMMENTS > chromeprofile.cpp:33 > +const QStringList

D26111: Runner: make recentdocument use KActivityStats data

meven abandoned this revision. meven marked an inline comment as done. meven added a comment. Moved to https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 INLINE COMMENTS > meven wrote in recentdocuments.cpp:78 > It is needed for QString coming from KActivitiesStats, they can b

D28544: RecentDocuments Runner: Cleanup and formatting

meven added a comment. To rebase after https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 lands REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28544 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n,

D3835: [Calendar] Populate overview models on-demand

meven accepted this revision as: meven. meven added a comment. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. @broulik is it still on the table ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D3835 To: broulik

D28544: RecentDocuments Runner: Cleanup and formatting

meven added a comment. Well @alex https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 was merged, so if you are still up to do it, now is a good time to rebase your changes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28544 To: alex, dav

D29807: Change Chrome API design

meven accepted this revision. meven added a comment. @broulik perhaps a review ? REPOSITORY R120 Plasma Workspace BRANCH api_inconsistencies (branched from master) REVISION DETAIL https://phabricator.kde.org/D29807 To: alex, broulik, #plasma, ngraham, meven Cc: anthonyfieroni, plasma-

D27129: [Notifications] Allow expiring an entire group

meven accepted this revision as: meven. meven added a comment. This revision is now accepted and ready to land. Seems fine to me REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27129 To: broulik, #plasma, meven Cc: meven, plasma-devel, Orage, LeGast00n, The-

D29847: Fixes compile problem for freebsd because of missing crypt.h

meven added a comment. In D29847#674811 , @usta wrote: > In D29847#674807 , @adridg wrote: > > > https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes > > > > There's already a CM

D29395: Refactor MediaController

meven added a comment. ping @cblack and reviewers The commit message could mention the UI changes as well. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: meven, kmaterka, iasensio, broulik, trmdi, ngraham, plasma-devel, Or

D29807: Change Chrome API design

meven added a comment. In D29807#675032 , @alex wrote: > Friendly Ping :-) > > Or should I just move this to gitlab? This is close to be approved, no need to move this. I think this can land @broulik @ngraham ? INLINE COMMENTS

[plasmashell] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Méven Car changed: What|Removed |Added CC||meven@enioka.com --- Comment #53 from Méven

D28651: Load and use global animation settings

meven added inline comments. INLINE COMMENTS > breezestyle.cpp:189 > +QStringLiteral( "org.kde.KGlobalSettings" ), > +QStringLiteral( "notifyChange" ), this, > SLOT(configurationChanged()) ); > #if QT_VERSION < 0x050D00 // Check if Qt version < 5.13 Shouldn't it

D26718: aggregate text for KRunner in DesktopView

meven closed this revision. meven added a comment. At moved to https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/148 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham, br

D29466: [applets/appmenu] Add search to global application menu

meven added subscribers: ngraham, meven. meven added a comment. In D29466#674210 , @trmdi wrote: > Can this be moved to krunner? In that case it can be used even when the user doesn't use global menu? I don't think think so, this search w

D23392: [energy KCM] Add battery Technology

meven requested review of this revision. meven added a comment. This is now ready to review since KF 5.62 was released. I have tested it. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23392 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS

D23392: [energy KCM] Add battery Technology

This revision was automatically updated to reflect the committed changes. Closed by commit R102:42fe072ad0fe: [energy KCM] Add battery Technology (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23392?vs=65189&id=67209 REVISION DETAIL

D23392: [energy KCM] Add battery Technology

meven added a comment. In D23392#541021 , @ltoscano wrote: > What is the difference between "LeadAcid" and "Lead Acid"? There is a mistake here, will fix. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23392

D24379: [energy kcm] Fix Technology values

meven created this revision. meven added reviewers: ngraham, ltoscano. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Fix incorrect value of Technology enum. Thanks @ltoscano for the catch. Relates to D23392

D24379: [energy kcm] Fix Technology values

meven updated this revision to Diff 67240. meven added a comment. Lower case technology REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24379?vs=67239&id=67240 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24379 AFFECTED FILES Modul

D24379: [energy kcm] Fix Technology values

meven updated this revision to Diff 67258. meven added a comment. Fix enum values REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24379?vs=67240&id=67258 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24379 AFFECTED FILES Modules/ene

D24379: [energy kcm] Fix Technology values

meven updated this revision to Diff 67261. meven added a comment. Use enum values for chargeState and technology REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24379?vs=67258&id=67261 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2437

D24379: [energy kcm] Fix Technology values

meven added a comment. In D24379#541409 , @davidedmundson wrote: > This is already available and translated in solid. > > solid/src/solid/devices/backends/upower/upowerdevice.cpp > 142:return tr("Lithium Ion", "battery technology")

D24379: [energy kcm] Fix Technology values

meven added inline comments. INLINE COMMENTS > batterymodel.cpp:31 > { > -qmlRegisterType(); > + > qmlRegisterUncreatableType("org.kde.kinfocenter.energy.private", > 1, 0, "Battery", > +QStringLiteral("Use Solid::Battery")); Used this nice documentation to choose the right

D24379: [energy kcm] Fix Technology values

This revision was automatically updated to reflect the committed changes. Closed by commit R102:b5a061ee9a14: [energy kcm] Fix Technology values (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24379?vs=67261&id=67312 REVISION DETAIL

D23578: Before requesting a scan, check the time threshold

meven updated this revision to Diff 67595. meven marked 5 inline comments as done. meven added a comment. Rebase, clean wirelessScanTimerEnabled, better use delete m_wirelessScanRetryTimer.take to clean m_wirelessScanRetryTimer hashmap, add some comments REPOSITORY R116 Plasma Network Mana

D23578: Before requesting a scan, check the time threshold

meven added inline comments. INLINE COMMENTS > jgrulich wrote in main.qml:77 > What about this? I removed this because 1: Request scan failure should never happen anymore because the handler makes sure never to call requestScan too often. The timer can just constantly ask for request scans it

D24543: Set an icon theme for gtk applications in the icons kcm

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Apart from the small nitpick seems good to me. INLINE COMMENTS > configeditor.cpp:51 > using qsp = QStandardPaths; > + > QString > configLocation(qsp::writableLocation(qsp::Generic

D24683: [KWindowSystem] in icon() return realistic icon size

meven created this revision. meven added reviewers: KWin, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The icon function did not take into account the fact that icons have limited size options

D24683: [KWindowSystem] in icon() return realistic icon size

meven updated this revision to Diff 68012. meven added a comment. Clean up REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24683?vs=68011&id=68012 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24683 AF

D24683: [KWindowSystem] in icon() return realistic icon size

meven added a subscriber: ngraham. meven added a comment. @ngraham In Wayland this allows the Tooltips from the taskmanager to display centered icon for wayland windows. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D24683 To: m

D24683: [KWindowSystem] in icon() return realistic icon size

meven updated this revision to Diff 68022. meven marked an inline comment as done. meven added a comment. Actually use the scaled pixmap REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24683?vs=68012&id=68022 BRANCH ar

D24683: [KWindowSystem] in icon() return realistic icon size

meven added inline comments. INLINE COMMENTS > mart wrote in windowsystem.cpp:173 > what's the logic behind the numbers 40, 56, 96 ans 192? > should at least be in a comment It was copied from kwindowsystem/src/platforms/xcb/kwindowsytem.cpp So I don't know precisely but at least it is coherent

D24683: [KWindowSystem] in icon() return realistic icon size

meven added inline comments. INLINE COMMENTS > meven wrote in windowsystem.cpp:173 > It was copied from kwindowsystem/src/platforms/xcb/kwindowsytem.cpp > So I don't know precisely but at least it is coherent with X. > Unfortunately the commit history does not tell much. I can't explain the curr

D23578: Before requesting a scan, check the time threshold

meven added inline comments. INLINE COMMENTS > meven wrote in main.qml:77 > I removed this because > > 1: > Request scan failure should never happen anymore because the handler makes > sure never to call requestScan too often. > The timer can just constantly ask for request scans it does not im

D24208: [Notifications] Dodge Plasma dialogs

meven added a comment. I have some personal feedback regarding this : 1. I open my bluetooth popup 2. Click on a device to connect to 3. Nothing happens 4. I close the bluetooth popup 5. I discover a notification telling me the bluetooth connection failed Because of this chang

D24208: [Notifications] Dodge Plasma dialogs

meven added a comment. In D24208#548272 , @ngraham wrote: > In D24208#548153 , @broulik wrote: > > > Bluetooth could provide some better feedback inside the plasmoid. > > > Agreed, notification

D24683: [KWindowSystem] in icon() return realistic icon size

meven added a subscriber: anthonyfieroni. meven added a comment. ping @zzag @mart Any feedback INLINE COMMENTS > meven wrote in windowsystem.cpp:173 > I can't explain the current logic. > > @mart Do you think I should change the logic to give it more sense ? > > Perhaps make the 24, 40.. v

D24691: Add support for WPA3

meven added inline comments. INLINE COMMENTS > wifisecurity.cpp:403 > { > -if (index == 0) { > +if (index == 0) { // None > m_ui->stackedWidget->setCurrentIndex(0); It would be nice to convert use SecurityTypeIndex enum instead of hardcoded values. It seems to me those values

D23578: Before requesting a scan, check the time threshold

meven updated this revision to Diff 68120. meven added a comment. Rebasing REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23578?vs=67595&id=68120 BRANCH arcpatch-D23578 REVISION DETAIL https://phabricator.kde.org/D23578 AFFEC

D23578: Before requesting a scan, check the time threshold

This revision was automatically updated to reflect the committed changes. Closed by commit R116:96203335b408: Before requesting a scan, check the time threshold (authored by meven). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23578?

D22005: Accept local paths

meven updated this revision to Diff 68127. meven added a comment. Use QDir::isAbsolutePath and rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22005?vs=60372&id=68127 BRANCH arcpatch-D22005 REVISION DETAIL https://phabricator.kde.org/D220

D24728: Ensure url from KActivity resources are properly built

meven created this revision. meven added reviewers: broulik, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Relates to D22005 BUG: 401579 FIXED-IN: 5.18 TEST PLA

D22005: Ensure url from KActivity resources are properly built

meven updated this revision to Diff 68132. meven added a comment. amend commit message REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22005?vs=68127&id=68132 BRANCH arcpatch-D22005 REVISION DETAIL https://phabricator.kde.org/D22005 AFFECTED FI

D24683: [KWindowSystem] in icon() return realistic icon size

meven marked 5 inline comments as done. meven added inline comments. INLINE COMMENTS > anthonyfieroni wrote in windowsystem.cpp:173 > That's adjustment, 16, 32, 48, 64, 128, 256 are standard icon sizes, when you > got a value between 2 sizes you adjust it by lower bound. Say (256 - 128) / 2 > =

D24683: [KWindowSystem] in icon() return realistic icon size

meven marked 2 inline comments as done. meven added a comment. Anyone to care to review and accept this small code change ? REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D24683 To: meven, #kwin, davidedmundson Cc: anthonyfieroni,

D24683: [KWindowSystem] in icon() return realistic icon size

This revision was automatically updated to reflect the committed changes. Closed by commit R130:8339cba19e9a: [KWindowSystem] in icon() return realistic icon size (authored by meven). REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.k

D22005: Ensure url from KActivity resources are properly built

meven updated this revision to Diff 68193. meven added a comment. Avoid an unnecessary dereference REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22005?vs=68132&id=68193 BRANCH arcpatch-D22005 REVISION DETAIL https://phabricator.kde.org/D22005

D24758: Add a desktop for utility keditfiletype

meven created this revision. meven added reviewers: broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Allow to display its Icon in Wayland BUG: 383615 REPOSITORY R126 KDE CLI Utilities BRANCH

D24758: Add a desktop for utility keditfiletype

meven updated this revision to Diff 68239. meven added a comment. Add missing .desktop file REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24758?vs=68238&id=68239 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24758 AFFECTED FIL

D24758: [KEditFileType] Add a desktop file

meven updated this revision to Diff 68243. meven added a comment. Replace OnlyShowIn= by NoDisplay=true USe KDE_INSTALL_APPDIR instead of deprecated XDG_APPS_INSTALL_DIR REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24758?vs=68239&id=68243 BRAN

D24758: [KEditFileType] Add a desktop file

meven marked an inline comment as done. meven added a comment. Thanks @kossebau @broulik REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D24758 To: meven, broulik, ngraham Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2

D24758: [KEditFileType] Add a desktop file

meven added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:57 > KDE_INSTALL_APPDIR, please. XDG_APPS_INSTALL_DIR is deprecated, cmp. > https://api.kde.org/ecm/kde-module/KDEInstallDirs.html We have a bunch of apps to update, I used this because I found it in krusader code

D24758: [KEditFileType] Add a desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit R126:9b2c7dec61de: [KEditFileType] Add a desktop file (authored by meven). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24758?vs=68243&id=68245 REVISION DET

D24804: Fix regression in mobile wifi kcm

meven accepted this revision. meven added a comment. I wish I had caught this, thanks @nicolasfella REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24804 To: nicolasfella, meven, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleig

D24804: Fix regression in mobile wifi kcm

meven added inline comments. INLINE COMMENTS > main.qml:30 > > -PlasmaNM.Handler { > -id: handler PlasmNM.Handler must be kept, (used line 56) REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24804 To: nicolasfella, meven, jgrulic

D24856: Add a .desktop file to ksplashqml

meven created this revision. meven added reviewers: apol, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY To prevent warnings in kwin such as : kwin_core: Did not grant the interface "org_kde_plasma_wind

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven created this revision. meven added reviewers: apol, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY To avoid kwin warnings in ~/.local/share/sddm/wayland-session.log such as : kwin_core: Could not

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven updated this revision to Diff 68522. meven added a comment. Fix unrelated change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24857?vs=68521&id=68522 BRANCH arcpatch-D24857 REVISION DETAIL https://phabricator.kde.org/D24857 AFFECTED

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven updated this revision to Diff 68523. meven added a comment. Fix unrelated change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24857?vs=68522&id=68523 BRANCH arcpatch-D24857 REVISION DETAIL https://phabricator.kde.org/D24857 AFFECTED

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven updated this revision to Diff 68550. meven added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24857?vs=68523&id=68550 BRANCH arcpatch-D24857 REVISION DETAIL https://phabricator.kde.org/D24857 AFFECTED FILES krunne

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b3065f7db0d6: Install krunner desktop file to ${KDE_INSTALL_APPDIR} (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24857?vs=68550&id=6

D24913: Converts a couple foreach

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24913 AFFECTED FILES

D24913: Converts a couple foreach

meven added inline comments. INLINE COMMENTS > view.cpp:224 > > -Q_FOREACH (QScreen* screen, QGuiApplication::screens()) { > +const auto screens = QGuiApplication::screens(); > +for (QScreen* screen : screens) { screens currently returns QList and QList should get deprecated in Qt

D24913: Converts a couple foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1f95ea34ac40: Converts a couple foreach (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24913?vs=68668&id=68675 REVISION DETAIL http

D24856: Add a .desktop file to ksplashqml

meven updated this revision to Diff 68737. meven added a comment. Add GenericName REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24856?vs=68520&id=68737 BRANCH arcpatch-D24856_1 REVISION DETAIL https://phabricator.kde.org/D24856 AFFECTED FIL

D24856: Add a .desktop file to ksplashqml

meven updated this revision to Diff 68738. meven added a comment. Rebase on master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24856?vs=68737&id=68738 BRANCH arcpatch-D24856_1 REVISION DETAIL https://phabricator.kde.org/D24856 AFFECTED FI

D24856: Add a .desktop file to ksplashqml

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ksplashqml.desktop.cmake:8 > +X-DBUS-StartupType=Unique > +X-DBUS-ServiceName=org.kde.ksplashqml > +X-KDE-StartupNotify=false I think X-DBUS-* may not be necessary here. > ngraham wrote in ksplashqml.desktop.

D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven created this revision. meven added reviewers: fvogt, apol, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Redo of D24857 afetr a53e8065fbce3de526781e236014404a7

D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven added a comment. In D24947#554001 , @fvogt wrote: > IMO it's a good thing to have KRunner as application in the menu anyway It was not in the application menu before With this change (and without NoDisplay) it will be displayed.

D25042: Rename cmake project to KActivityManagerd, remove unused option

meven created this revision. meven added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY KACTIVITIES_LIBRARY_ONLY is used only in kactiviy library. REPOSITORY R161 KActivity Manager Service B

D24856: Add a .desktop file to ksplashqml

meven updated this revision to Diff 68987. meven marked an inline comment as done. meven added a comment. ksplashqml is not a dbus service REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24856?vs=68738&id=68987 BRANCH arcpatch-D24856_2 REVISION

D25089: Use X-KDE-NoGlobalShortcut to read that an app has shorcuts disable

meven created this revision. meven added reviewers: Plasma, apol, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY A Drawback with the current patch is that it will loose previous set preferences. Se

D25089: Use X-KDE-NoGlobalShortcut to read that an app has shorcuts disable

meven added a comment. In D25089#557130 , @davidedmundson wrote: > Can you tell me which .desktops files are going to be using this flag, I don't think I follow so far. The ones installed in `${DATA_INSTALL_DIR}/kglobalaccel` for the nee

D25042: Rename cmake project to KActivityManagerd, remove unused option

This revision was automatically updated to reflect the committed changes. Closed by commit R161:fbcd08aacb5f: Rename cmake project to KActivityManagerd, remove unused option (authored by meven). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D24720: [applets/systemtray] Rewrite popups with layouts

meven added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:21 > +import QtQuick 2.13 > +import QtQuick.Layouts 1.13 > + You effectively bumped the runtime dependency of plasma-framework to Qt 5.13. Did we need to ? Would 5.12 suffice ? Or was it just time to start using Qt 5.13.

D25395: Make avatar icon dpr aware aka HiDPI rendered

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D25395 AFFECTED FILES src

D25398: Check values have changed before setting the model

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Only save data that needs to be saved and use sanitized data rather than raw text field input. TEST PL

D25398: Check values have changed before setting the model

meven added a comment. In D25398#564639 , @apol wrote: > The commit message looks wrong, maybe you meant PolicyKit? PackageKit should be irrelevant. Thank you for pointing it out. > Other than that +1 Do you mean to accept it th

D25395: Make avatar icon dpr aware aka HiDPI rendered

meven updated this revision to Diff 70008. meven added a comment. Code style REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25395?vs=69982&id=70008 BRANCH arcpatch-D25395 REVISION DETAIL https://phabricator.kde.org/D25395 AFFECTED FILES src/ac

D25398: Check values have changed before setting the model

meven added a comment. In D25398#564706 , @ngraham wrote: > Nice. Does this fix any of these? > > - https://bugs.kde.org/show_bug.cgi?id=384894 This diff fix this one I had a look at the others : > - https://bugs.kde.org/show

D25398: Check values have changed before setting the model

meven added a comment. In D25398#564887 , @ngraham wrote: > In D25398#564843 , @meven wrote: > > > I had a look at the others : > > > > > - https://bugs.kde.org/show_bug.cgi?id=392943 > > > - ht

D25395: Make avatar icon dpr aware aka HiDPI rendered

This revision was automatically updated to reflect the committed changes. Closed by commit R128:a6f37349cd40: Make avatar icon dpr aware aka HiDPI rendered (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25395?vs=70008&id=70063 REVISI

D25398: Check values have changed before setting the model

This revision was automatically updated to reflect the committed changes. Closed by commit R128:b279882ad9e4: Check values have changed before setting the model (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25398?vs=69988&id=70106 R

D25439: Don't CacheUser/UnCacheUser when editing Realname

meven created this revision. meven added reviewers: ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY 1d10226d and 83549

D25398: Check values have changed before setting the model

meven added a comment. In D25398#565210 , @ngraham wrote: > Agreed. Works for me and looks safe, but maybe let's do master only for safety. > > Can you file a bug upstream on the odd behavior in AccountsService? No need in the end. I

D25439: Don't CacheUser/UnCacheUser when editing Realname

This revision was automatically updated to reflect the committed changes. Closed by commit R128:a2f7d308f9b5: Don't CacheUser/UnCacheUser when editing Realname (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25439?vs=70108&id=70153 RE

D25486: [Greeter] Add a onSuspend() signal to Authenticator

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY CCBUG: 414399 REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.k

D25487: [lockscreen] Clear password field when system suspends

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 414399 FIXED-IN: 5.18 TEST PLAN Depends on D25486 1.

D25486: [Greeter] Add a onSuspend() signal to Authenticator

meven updated this revision to Diff 70205. meven added a comment. Undo blank line changes REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25486?vs=70203&id=70205 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25486 AFFECTED FILES g

D25486: [Greeter] Add a onSuspend() signal to Authenticator

meven added a comment. If this solution is the one expected, I will probably offer a patch to sddm's greeter following the same pattern. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D25486 To: meven, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jra

D25486: [Greeter] Add a onSuspend() signal to Authenticator

meven abandoned this revision. meven added a comment. In D25486#566549 , @broulik wrote: > Have you had a look at the libkworkspace2 stuff? It should have that signal in it and is ready to be made a qml import iirc I tried to find code th

D25487: [lockscreen] Clear password field when system suspends

meven updated this revision to Diff 70215. meven added a comment. Reuse SessionManagement component from libkworkspace org.kde.plasma.private.sessions REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25487?vs=70204&id=70215 BRANCH master REVISIO

<    1   2   3   4   5   6   7   8   >