D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. Gentle ping dear reviewers. INLINE COMMENTS > recentdocuments.cpp:69 > +| Agent::any() > +| Url("/*/" + term + "*") > +| Limit(30); Request for now is limited, it will need some work in KActivityStats to be more clever REPOSITORY

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. ping :) @hein REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. In D26582#600469 , @hein wrote: > So does this fall through to the dialog when the type hasn't been determined Any file has always one mime type : "application/octet-stream", but KRun generally resolves mimetype thr

D22005: Ensure url from KActivity resources are properly built

meven abandoned this revision. meven added a comment. After further check, my patch does not do much, just allowed me to discover bug about dolphin's recent folder list missing. if (QDir::isAbsolutePath(resource)) { resource = QUrl::fromLocalFile(resource).toString(); }

D24728: Ensure url from KActivity resources are properly built

meven abandoned this revision. meven added a comment. See comment in D22005 https://phabricator.kde.org/D22005#600706 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24728 To: meven, broulik, hein Cc: plasma-devel, Orage

D26915: Allow to display in the task context menu the recently accessed directories

meven created this revision. meven added reviewers: hein, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Useful for filemanagers, i.e Dolphin Depends on D26407 R

D26916: Allow to display in the kicker appliation context menu the recently accessed directories

meven created this revision. meven added reviewers: Plasma, hein, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Similar to D26915 Depends on D26407

D26891: Apply Breeze GTK theme on startup, if the config is empty

meven added inline comments. INLINE COMMENTS > gtkconfig.cpp:215 > +if (currentGtk2Theme.isEmpty()) { > +setGtk2Theme(QStringLiteral("Breeze")); > +} What if users have a different default / theme set on first launch ? I would suggest to read the current theme instead of hardcodi

D26934: KCM/Autostart Add a model to separate logic from UI

meven created this revision. meven added reviewers: mlaurent, ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Adds the complete fileName of the autastart entries as tooltips. TEST PLAN - Add a de

D26895: Introduce an Info Center mode

meven added inline comments. INLINE COMMENTS > BaseMode.cpp:32 > #include "ModuleView.h" > - > +#include > class BaseMode::Private { Not needed > mart wrote in ModuleView.cpp:349 > that's a good point. > Tough, at the moment we don't do anything with the statistics in kinfocenter > mode, so

D26895: Introduce an Info Center mode

meven added inline comments. INLINE COMMENTS > main.cpp:81 > > -SettingsBase *mainWindow = new SettingsBase(); > +if (binaryName == QStringLiteral("kinfocenter")) { > +aboutData.setDesktopFileName(QStringLiteral("org.kde.kinfocenter")); You can use mode here REPOSITORY R124

D26893: Fix a building issue

This revision was automatically updated to reflect the committed changes. Closed by commit R128:e1569e3341e7: Fix a building issue (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26893?vs=74303&id=74507 REVISION DETAIL https://phabri

D26893: Fix a building issue

meven added a comment. In D26893#601874 , @jriddell wrote: > Add this patch fixes compile on the KDE neon CI https://build.neon.kde.org/job/bionic_unstable_kde_user-manager/107/ > > Curiously I can't recreate the failure on my local computer

D26970: Remove use of deprecated KDialog, fix two warnings

meven created this revision. meven added reviewers: Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN No UI changes REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.k

D26970: Remove use of deprecated KDialog, fix two warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fb71ced98460: Remove use of deprecated KDialog, fix two warnings (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26970?vs=74516&id=74525

D26797: KCM/Component Refactor UI to a single list of combobox

meven updated this revision to Diff 74541. meven marked 7 inline comments as done. meven added a comment. Code formatting, add qAsConst, only search for one directory kcm_componentchooser to find its components REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.

D26842: Fix fonts KCM button state

meven added inline comments. INLINE COMMENTS > meven wrote in fonts.cpp:473 > You can make this static. Just a nitpick, I guess you plan to change it soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26842 To: bport, #plasma, ervin, crossi, meven Cc: brouli

D26998: Fix new user creation

meven created this revision. meven added reviewers: ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY UserAdded was called only when other parameters were provided for a new user beside nam

D26998: Fix new user creation

meven added a comment. In D26998#602676 , @davidedmundson wrote: > I reached that same conclusion late last night (so in a sense ), and abandoned the other patch thinking I had everything understood. > > But then I tried it and it didn't

D26998: Fix new user creation

This revision was automatically updated to reflect the committed changes. Closed by commit R128:184a544cdef0: Fix new user creation (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26998?vs=74602&id=74604 REVISION DETAIL https://phabr

D26912: Use Qt5 signal syntax, format files, optimizations

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. This kcms is going through some refactoring in D26934 , not the greatest time for a mostly formatting PR. This will introduce a lot of conflic

D26797: KCM/Component Refactor UI to a single list of combobox

meven added a comment. > I may want to reconsider and simply add whatever service is in Default Application and display it, ignoring entries in "Added Associations", as I do elsewhere. I am thinking about doing this, as it makes the code more similar with other cfgplugin, and the curren

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven created this revision. meven added reviewers: Plasma, broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 396537 FIXED-IN: 5.18 REPOSITORY R119 Plasma Desktop BRANCH master REVISI

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven updated this revision to Diff 74649. meven added a comment. Separate foreach conversions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74647&id=74649 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27019 AFFECTED FIL

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven updated this revision to Diff 74654. meven marked an inline comment as done. meven added a comment. Only display device that are not ignored Solid::StorageVolume and Solid::StorageAccess REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven updated this revision to Diff 74656. meven added a comment. Checking if this is a not-ignored or not mounted StorageAccess is what we need REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74654&id=74656 BRANCH master REVISION DETAIL

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven created this revision. meven added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY A user might find odd that when a known device in the UI is unmounted, it disappears. Despite

D26478: KCM/baloo Display full mount point in list of excluded mount points

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3d5719e76a57: KCM/baloo Display full mount point in list of excluded mount points (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26478?v

D26912: Use Qt5 signal syntax, format files, optimizations

meven added a comment. In D26912#603041 , @alex wrote: > Hello, > > I already wondered how this will be handled. > > Should I abandon this revision now and maybe create a new one with the relevant changes once your request has been merged

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven added inline comments. INLINE COMMENTS > broulik wrote in DeviceModel.cpp:119 > Do we want to add items that are *not* a `StorageAccess`? > Shouldn't this be more like > > if (access && !access->isIgnored())` I needed to add the not mounted storage access as storage access ignores not

D27052: Solid-device-automounter/kcm: Convert some foreach

meven created this revision. meven added reviewers: broulik, ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN builds REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator

D27053: Solid-device-automounter/kcm: Improve width of columns

meven created this revision. meven added reviewers: ngraham, ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Make the "automatic login on..." columns thinner to give more room to the Peripheral col

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

meven created this revision. meven added reviewers: Plasma, ervin, ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY To make clear to the user what automount options imply. REPOSITORY R119 Plasm

D27058: Clean outdated QT_VERSION_CHECK

meven created this revision. meven added reviewers: Plasma, ervin, mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Plasma desktop depends on KF 5.66 REPOSITORY R119 Plasma Desktop BRANCH clean-chec

D27052: Solid-device-automounter/kcm: Convert some foreach

meven added a comment. In D27052#603798 , @alex wrote: > Hello, > I have a question regarding your changed. > > you sometimes declare the variables you want to loop over before the loop, but sometimes in the loop. > For instance in Devi

D27058: Clean outdated QT_VERSION_CHECK

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5ee3b4145c26: Clean outdated QT_VERSION_CHECK (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27058?vs=74752&id=74765 REVISION DETAIL

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven updated this revision to Diff 74767. meven added a comment. Don't list ignored devices as intended REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74656&id=74767 BRANCH arcpatch-D27019 REVISION DETAIL https://phabricator.kde.org/D

D27053: Solid-device-automounter/kcm: Improve width of columns

meven added a comment. Makes more sense with D27057 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27053 To: meven, ngraham, ervin, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampalou

D27053: Solid-device-automounter/kcm: Improve width of columns

meven updated this revision to Diff 74770. meven added a comment. Add translation context REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27053?vs=74743&id=74770 BRANCH arcpatch-D27053 REVISION DETAIL https://phabricator.kde.org/D27053 AFFECTED

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

meven updated this revision to Diff 74773. meven marked 3 inline comments as done. meven added a comment. Simplify DeviceModel::flags, carriage returns REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27057?vs=74750&id=74773 BRANCH onattabch REVISI

D27053: Solid-device-automounter/kcm: Improve width of columns

meven updated this revision to Diff 74776. meven added a comment. Case issue REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27053?vs=74770&id=74776 BRANCH arcpatch-D27053 REVISION DETAIL https://phabricator.kde.org/D27053 AFFECTED FILES soli

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

meven updated this revision to Diff 74782. meven added a comment. Use a switch case REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27057?vs=74773&id=74782 BRANCH onattabch REVISION DETAIL https://phabricator.kde.org/D27057 AFFECTED FILES sol

D27052: Solid-device-automounter/kcm: Convert some foreach

meven updated this revision to Diff 74803. meven added a comment. Add intermediate const variable for function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27052?vs=74742&id=74803 BRANCH arcpatch-D27052 REVISION DETAIL https://phabricator.kde

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5eb5c9ab7d7e: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74

D27053: Solid-device-automounter/kcm: Improve width of columns

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8eb9e9b72a47: Solid-device-automounter/kcm: Improve width of columns (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27053?vs=74776&id=74

D26797: KCM/Component Refactor UI to a single list of combobox

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f55252fbf5d6: KCM/Component Refactor UI to a single list of combobox (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26797?vs=74541&id=74

D27116: KCM/Component email: simplify code, add a const

meven created this revision. meven added reviewers: Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Clean up adding entries for Added Associations section of mimeapplist Just find the application

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

meven updated this revision to Diff 74920. meven added a comment. Improved flag function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27057?vs=74782&id=74920 BRANCH onattabch REVISION DETAIL https://phabricator.kde.org/D27057 AFFECTED FILES

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven created this revision. meven added reviewers: ervin, ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY - Make default button work - Move connection from cpp to .ui - Slight label change T

D27154: KCM/solid-actions convert foreach

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27154 AFFECTED FIL

D27154: KCM/solid-actions convert foreach

meven updated this revision to Diff 74995. meven added a comment. Add a missing space REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27154?vs=74993&id=74995 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27154 AFFECTED FILES kcms

D27154: KCM/solid-actions convert foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5bb3ebc94d82: KCM/solid-actions convert foreach (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27154?vs=74995&id=74996 REVISION DETAIL

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

meven added a comment. In D27057#605279 , @ngraham wrote: > It's not related to this patch, but looking at the table, it would be nice to move from a tree view into a list view with section headers, like how the GLobal Shortcuts KCM does.

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. 5.18 or not ? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26582 REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouka

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9ae855e0dcbc: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26582?vs=73

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

meven added a comment. Let's be safe and targe 5.19 REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26582 REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachu

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

This revision was automatically updated to reflect the committed changes. Closed by commit R119:37e9bd06774b: Solid-device-automounter/kcm: Enable/Disable columns automount… (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27057?vs=74

D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. ping @broulik REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenB

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

meven accepted this revision. meven added a comment. I can confirm the patch fix the issue. Tested with [General] font=Noto Sans,10,-1,5,50,0,0,0,0,0 in `.config/kdeglobals` With and without the patch, and the apply button now is highlighted when it the font setting w

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven created this revision. meven added reviewers: bport, ervin, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 417276 TEST PLAN Have no email client installed. In kcm componentchooser - s

D27397: Align name displayed for wayland session with sddm

meven created this revision. meven added reviewers: ervin, crossi, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 417499 Since commit https://github.com/sddm/sddm/commit/62cd789ff62d7d9c6ef189314f0

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven updated this revision to Diff 75679. meven marked an inline comment as done. meven added a comment. Add a space REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27395?vs=75671&id=75679 BRANCH arcpatch-D27384 REVISION DETAIL https://phabrica

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven added inline comments. INLINE COMMENTS > bport wrote in componentchooserbrowser.cpp:107 > add a space between - and 1 > > By the way this check seems strange to me, can you confirm it still allow to > save custom browser ? Once the user has added browsers to the list, they appear as bef

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven updated this revision to Diff 75691. meven added a comment. standardize how we check if the combobox has a value to save, allow to mark the value as changed when there was no value selected at the beginning REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricato

D27397: Align name displayed for wayland session with sddm

meven abandoned this revision. meven added a comment. Was fixed by D27358 REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27397 To: meven, ervin, crossi, bport Cc: ngraham, plasma-devel, Orage, LeGast00n, Th

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven updated this revision to Diff 75695. meven marked an inline comment as done. meven added a comment. Clean a redundant check, ensure that if the user cancels selecting a custom app, the right entry is selected and hasChanged reflects the state correctly REPOSITORY R119 Plasma Desktop

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven added inline comments. INLINE COMMENTS > crossi wrote in componentchooseremail.cpp:154 > While you are here, can you had a check on this pointer. I don't understand > why there is one below but not here. I would rather do the opposite the check below is for historical reasons from before

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven added inline comments. INLINE COMMENTS > meven wrote in componentchooseremail.cpp:154 > I would rather do the opposite the check below is for historical reasons from > before my refactoring. I meant to remove the check below (which I did). REPOSITORY R119 Plasma Desktop REVISION DETAI

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven added a comment. How about you @bport ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27395 To: meven, bport, ervin, crossi, davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ra

D26111: Runner: make recentdocument use KActivityStats data

meven marked an inline comment as done. meven added a comment. Please if someone could review/test, it makes the recent document krunner so much more useful, with longer history and gtk apps history. It seems to me like a worthwhile feature. REPOSITORY R120 Plasma Workspace REVISION DETA

D27052: Solid-device-automounter/kcm: Convert some foreach

meven added inline comments. INLINE COMMENTS > ervin wrote in DeviceAutomounter.cpp:73 > nitpick, feel free to ignore: would make sense to switch to a const ref here > since we're touching the line anyway. in the same vein, "const auto" on the > line before wouldn't be a bad idea either (if we

D27052: Solid-device-automounter/kcm: Convert some foreach

meven updated this revision to Diff 75840. meven marked an inline comment as done. meven added a comment. Add a space REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27052?vs=74803&id=75840 BRANCH arcpatch-D27052_1 REVISION DETAIL https://phabri

D27052: Solid-device-automounter/kcm: Convert some foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R119:efdf88ec48b4: Solid-device-automounter/kcm: Convert some foreach (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27052?vs=75840&id=75841#toc REPOSITORY R119 Plasma Deskto

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven updated this revision to Diff 75845. meven marked 2 inline comments as done. meven added a comment. Add a delete for m_settings, move m_devices to ctor intialization REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=74925&id=75845 BRANCH

D27116: KCM/Component email: simplify code

meven updated this revision to Diff 75846. meven marked an inline comment as done. meven added a comment. Fix a couple missing spaces REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27116?vs=74897&id=75846 BRANCH arcpatch-D27116 REVISION DETAIL

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven updated this revision to Diff 75847. meven marked 2 inline comments as done. meven added a comment. Add a missing space, improve comment as suggested REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27024?vs=74667&id=75847 BRANCH arcpatch-D270

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven updated this revision to Diff 75891. meven marked an inline comment as done. meven added a comment. Remove m_settings AutomounterSettings member from DeviceAutomounterKCM REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=75845&id=75891 B

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven added inline comments. INLINE COMMENTS > bport wrote in DeviceAutomounterKCM.cpp:84 > We can also change kcfgc to add parent in constructor It would imply make AutomounterSettings not-static. I would need to change the DeviceModel that uses AutomounterSettings static functions as well. >

D27470: Set good default value for cursor theme and size in KRDB

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. This looks like a good kcms to convert to KConfigXT... INLINE COMMENTS > krdb.cpp:756 > + QString theme = mousecfg.readEntry("cursorTheme", > QString("breeze_cursors")); > + QString size

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven added inline comments. INLINE COMMENTS > ervin wrote in DeviceAutomounterKCM.cpp:57 > I tend to consider this as a step back to be honest. Singletons tend to be > more trouble down the line when something goes wrong. Please beware this will make my patch quite a lot more intrusive, Device

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven updated this revision to Diff 75920. meven marked 2 inline comments as done. meven added a comment. Add a validLastCurrentIndex function, check emailClientService is not null before using it REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27395

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven marked 4 inline comments as done. meven added inline comments. INLINE COMMENTS > ervin wrote in DeviceAutomounterKCM.cpp:57 > Sure, moving away from a singleton is always intrusive (just like moving away > from a global variable which it is really). Let's aim for it in a different > speci

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

meven created this revision. meven added reviewers: ervin, crossi, bport, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Depends on D27127 REPOSITORY R119 Plasma De

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > meven wrote in DeviceAutomounterKCM.cpp:57 > Just waiting for this review then, I am preparing the next patch D27480 REPOSITORY R119 Plasma Desktop REVISION DETAIL ht

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven updated this revision to Diff 75926. meven added a comment. Make validLastCurrentIndex const, newline before { REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27395?vs=75920&id=75926 BRANCH arcpatch-D27395 REVISION DETAIL https://phabricat

D27482: Update kdeglobals config file for Breeze widgetStyle

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Works : replace widgetStyle in group KDE and selects the application style in systemsettings; Does not edit widgetStyle in group General +1 on fixing whatever lowercased the value in the

D27407: Breeze widgetStyle value is Breeze

meven added inline comments. INLINE COMMENTS > defaults:8 > [kdeglobals][Icons] > Theme=breeze > ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham Cc: ngraham, plasma-devel, Orage, LeGas

D27495: Remove unnecessary code and function calls

meven added inline comments. INLINE COMMENTS > shellrunner.cpp:68 > { > Q_UNUSED(match); > you can remove this line REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27495 To: alex, davidedmundson, ngraham, broulik Cc: meven, plasma-devel, Orage, LeGast

D27495: Remove unnecessary code and function calls

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me, please give time to other reviewers. REPOSITORY R120 Plasma Workspace BRANCH shellrunner_cleanup REVISION DETAIL https://phabricator.kde.org/D27495 To: alex, davided

D27517: Better handle authentication error

meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 417882 Not tested yet ! REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D27517

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven added a comment. Is it fine for other reviewers ? REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D27395 REVISION DETAIL https://phabricator.kde.org/D27395 To: meven, bport, ervin, crossi, davidedmundson, #plasma Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-De

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

meven accepted this revision. meven added a comment. Nice ! REPOSITORY R110 KScreen Library BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27536 To: dvratil, #plasma, davidedmundson, meven Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me, wait for @broulik review REPOSITORY R120 Plasma Workspace BRANCH webshortcuts_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27566 To: a

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven updated this revision to Diff 76286. meven marked 3 inline comments as done. meven added a comment. Fix indentation and add intermediate variable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=75891&id=76286 BRANCH arcpatch-D27127_1

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

This revision was automatically updated to reflect the committed changes. Closed by commit R119:07b4f3fb6c3c: Solid-device-automounter/kcm: Use KConfigXT in ui (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=76286&id=76289

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

meven updated this revision to Diff 76294. meven marked 7 inline comments as done. meven added a comment. Rebase, review fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27480?vs=75923&id=76294 BRANCH arcpatch-D27480 REVISION DETAIL https://p

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

meven added inline comments. INLINE COMMENTS > ervin wrote in DeviceAutomounter.cpp:111 > This is rather odd. A too eager search and replace? ;-) Thanks indeed > ervin wrote in AutomounterSettings.cpp:23 > I guess you could have used `using > AutomounterSettingsBase::AutomounterSettingsBase;`

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven marked an inline comment as done. meven added a comment. Is it fine for other reviewers ? REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D27395 REVISION DETAIL https://phabricator.kde.org/D27395 To: meven, bport, ervin, crossi, davidedmundson, #plasma Cc: anthonyfieroni, plasma-

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8f1043c641a2: KCM/ComponentChooser Treat cases when there is no app for a usage (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27395?vs=

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ca02af6584c6: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

<    1   2   3   4   5   6   7   8   >