D24223: [RFC] Add global themes that mimic other platforms' workflows

2021-11-15 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. I no longer think this is a good idea. :( User feedback suggests that our default UX is too similar to another platform (Windows) already, which puts it in an "uncanny valley" where it is like 80% the same as that platform, but diverg

T13927: Pop!_os style window tiling

2021-09-09 Thread Nathaniel Graham
ngraham closed this task as "Invalid". ngraham added a comment. No need for two places to discuss the same thing; Let's close this in favor of https://invent.kde.org/plasma/kwin/-/issues/10, and take the discussion there. TASK DETAIL https://phabricator.kde.org/T13927 To: ngraham Cc: zamu

D25280: [Baloo KCM] Purge index when disabling indexing

2021-04-14 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Moved over to https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/427. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25280 To: ngraham, tcanabrava, #plasma, #vdg, #baloo Cc: justinzobel, br

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2021-04-14 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Moved over to https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/427. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: just

D23257: Allow for easier syncing of Plasma font

2021-02-17 Thread Nathaniel Graham
ngraham added a comment. Let's do it. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH easier-font-syncing (branched from master) REVISION DETAIL https://phabricator.kde.org/D23257 To: filipf, ngraham, #plasma, davidedmundson Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren

T13927: Pop!_os style window tiling

2020-12-08 Thread Nathaniel Graham
ngraham renamed this task from "Pop shell in KDE Plasma" to "Pop!_os style window tiling". ngraham removed plasma-devel as the assignee of this task. ngraham added a subscriber: plasma-devel. ngraham edited projects, added KWin; removed Plasma. TASK DETAIL https://phabricator.kde.org/T13927 To

T13927: Pop shell in KDE Plasma

2020-12-08 Thread Nathaniel Graham
ngraham added a comment. Ah ok, so you're asking for better tiling support to be built in. TASK DETAIL https://phabricator.kde.org/T13927 To: plasma-devel, ngraham Cc: cblack, niccolove, ngraham, rafasantos, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenB

T13927: Pop shell in KDE Plasma

2020-12-08 Thread Nathaniel Graham
ngraham added a comment. What is "pop shell"? TASK DETAIL https://phabricator.kde.org/T13927 To: plasma-devel, ngraham Cc: ngraham, rafasantos, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,

D13988: Use subseq matching for service runner

2020-12-03 Thread Nathaniel Graham
ngraham closed this revision. ngraham added a comment. Manually merged because `arc land` doesn't seem to want to work anymore. You can see it at //invent.kde.org/plasma/plasma-workspace/commit/9f2abd0a54d51d9234a5a9489d1342b261429fa3. Thanks Michael! REPOSITORY R120 Plasma Workspace

D13988: Use subseq matching for service runner

2020-12-03 Thread Nathaniel Graham
ngraham added a comment. Still applies cleanly and seems to fix the bug. Landing. REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik, ngraham Cc: meven, justinzo

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

2020-11-24 Thread Nathaniel Graham
ngraham added a comment. And please mention the URL for this change, for reference purposes. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9040 To: davidedmundson, broulik Cc: boldewyn, kigwana, graesslin, ngraham, broulik, plasma-devel, Orage, LeGast0

D9040: Revert "[Lock Screen / Login] Add "reveal password button""

2020-11-24 Thread Nathaniel Graham
ngraham added a comment. Yes, my own children make use of the "Show password" button on our family Windows 10 machine (Which I plan to put KDE Neon on soon) and I can confirm your exact use case and how this regresses it. Could you please file a bug report on `plasmashell | Theme - Breez

D25428: Improved support for desktop "Folder View"

2020-10-01 Thread Nathaniel Graham
ngraham added a comment. Awesome! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: The-Feren-OS-Dev, edevito, cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fba

D27271: [kcms/colors] RFC: Accent Colours

2020-09-29 Thread Nathaniel Graham
ngraham added a comment. Could you move this and the dependent patches to Gitlab? It would be good to get this in for 5.21. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27271 To: cblack, #plasma, #vdg Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Or

D17533: Make the button's purpose more clear

2020-09-28 Thread Nathaniel Graham
ngraham added a comment. @amantia, if you would like to continue with this, could you move it to invent.kde.org? as a merge request for plasma-desktop? Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17533 To: amantia, #plasma_accessibility, davidedmu

D29466: [applets/appmenu] Add search to global application menu

2020-09-08 Thread Nathaniel Graham
ngraham added a comment. Putting it in KRunner could make at least a little bit of sense if it worked everywhere--i.e. with in-window menubars as well. However since it does not, I think the current location makes sense. Could you move this to GitLab maybe? REPOSITORY R120 Plasma Work

D28651: Load and use global animation settings

2020-08-04 Thread Nathaniel Graham
ngraham added a comment. Agreed. @sandsmark, would you be interested in following up with that? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze, ngraham Cc: meven, cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, plasma-devel, #br

D28651: Load and use global animation settings

2020-08-03 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze, ngraham Cc: meven, cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampalou

D28686: [Battery Monitor] Choose better wording

2020-07-16 Thread Nathaniel Graham
ngraham removed a reviewer: broulik. ngraham added a comment. This revision is now accepted and ready to land. Go ahead and land this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, #vdg, ngraham, ognarb, broulik Cc: ognarb, plasma-devel,

D28321: [applets/devicenotifier] Port to ExpandableListItem

2020-07-10 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Cleaned this up a bit and moved it to https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/151 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28321 To: ngraham, #vdg, #plasma, broulik Cc:

D28321: [applets/devicenotifier] Port to ExpandableListItem

2020-07-09 Thread Nathaniel Graham
ngraham added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28321 To: ngraham, #vdg, #plasma, broulik Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesj

D24223: [RFC] Add global themes that mimic other platforms' workflows

2020-07-06 Thread Nathaniel Graham
ngraham added a comment. In D24223#675737 , @Boxie wrote: > In D24223#675715 , @ngraham wrote: > > > Do folks have any ideas for alternative layouts that don't explicitly mimic other platforms? >

D24223: [RFC] Add global themes that mimic other platforms' workflows

2020-07-01 Thread Nathaniel Graham
ngraham added a comment. Do folks have any ideas for alternative layouts that don't explicitly mimic other platforms? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24223 To: ngraham, #vdg, #plasma Cc: felixernst, Boxie, wstephenson, davidre, LeGast00n, enriq

D24223: [RFC] Add global themes that mimic other platforms' workflows

2020-06-27 Thread Nathaniel Graham
ngraham added a comment. I'm open to re-doing this to expose alternative layouts that don't explicitly mimic other platforms. The problem is, I'm not very creative in my use of this functionality. All I really do is put my panel on the left screen edge. I would need ideas for alternative lay

D16897: Allow windows to be closed from the window switchers

2020-06-24 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Continued at https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/5 and https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/115 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D168

D29741: [Logout] Port to QQC2 and PC3

2020-06-24 Thread Nathaniel Graham
ngraham added a comment. Was there a reason why this never landed? REPOSITORY R120 Plasma Workspace BRANCH port-logout-screen (branched from master) REVISION DETAIL https://phabricator.kde.org/D29741 To: filipf, #plasma, davidedmundson, ngraham Cc: plasma-devel, Orage, LeGast00n, The-

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2020-06-23 Thread Nathaniel Graham
ngraham added a comment. Plasma now depends on Qt 5.14. Is there anything in there that would allow this to move forward? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: luxus, snugghash, gladhorn, mart, hein, ngraham, graesslin, davided

D29140: Show POTD in lock screen

2020-06-19 Thread Nathaniel Graham
ngraham added a comment. Done and landed! You can close this now. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, davidre, broulik Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fb

D19444: Make long menus optionally scrollable instead of always expanding horizontally

2020-06-13 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Doesn't seem like there's interest in this. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19444 To: ngraham, #breeze, broulik Cc: guidosanchez, ndavis, davidedmundson, mvourlakos, cfeck, plasma-devel, Orage,

D28321: [applets/devicenotifier] Port to ExpandableListItem

2020-06-13 Thread Nathaniel Graham
ngraham added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28321 To: ngraham, #vdg, #plasma, broulik Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesj

D28321: [applets/devicenotifier] Port to ExpandableListItem

2020-06-13 Thread Nathaniel Graham
ngraham added a comment. I'd like to land this early in the 5.20 cycle so we have lots of time for testing, if possible. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28321 To: ngraham, #vdg, #plasma, broulik Cc: dfaure, plasma-devel, Orage, LeGast00n, Th

D24223: [RFC] Add global themes that mimic other platforms' workflows

2020-06-12 Thread Nathaniel Graham
ngraham added a comment. We discussed this at the sprint and concluded broadly that we could move forward with it (once the TODOs are addressed of course). We also decided for T11746 that we would go with the approach of a sheet that lets you enable and d

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-06-12 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma, niccolove, cblack Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cbl

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-06-12 Thread Nathaniel Graham
ngraham added a comment. I'm going to stand firm on 2.5x gridUnit for now. That works out to 46px, which is not too tall (IMO) and increases touch friendliness by a lot. Let's all keep in mind that this is super easily configurable. REPOSITORY R119 Plasma Desktop REVISION DETAIL https:/

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-06-12 Thread Nathaniel Graham
ngraham added a comment. We discussed this and D29501 at the virtual plasma sprint today and concludes that we should probably do the horizontal version here. Nobody overtly hated the vertical version, but issues displaying the clock +date and system tray

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-06-12 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. We discussed this and D27845 at the virtual plasma sprint today and concludes that we should probably do the horizontal version. Nobody overtly hated this proposal, but issues displaying the clock+

D29535: Add a SpinBox (with draggability) to panel thickness adjustment UI

2020-06-12 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #plasma, mart Cc: mart, ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-06-09 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29462 To: Zren, #kirigami, mart Cc: davidre, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D29603: Adds custom spacing between task manager icons

2020-06-08 Thread Nathaniel Graham
ngraham commandeered this revision. ngraham edited reviewers, added: martellini; removed: ngraham. ngraham added a comment. Cool, thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29603 To: ngraham, #vdg, martellini Cc: ngraham, niccolove, plasma-devel,

D29820: Correction when displaying "badger counter" icons using software rendering

2020-06-08 Thread Nathaniel Graham
ngraham commandeered this revision. ngraham edited reviewers, added: brunogoncalves; removed: ngraham. ngraham added a comment. This was done on GitLab, and was gated on hardware rendering being used. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29820 To: n

D29847: Fixes compile problem for freebsd because of missing crypt.h

2020-06-06 Thread Nathaniel Graham
ngraham added a reviewer: adridg. ngraham added a subscriber: adridg. ngraham added a comment. Adding @adridg as a reviewer. Note that we have moved to Gitlab, so future contributions should be submitted at invent.kde.org. Thanks! You can find the documentation at https://community.kde.o

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-06-04 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma, ngraham Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, les

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-06-04 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I'll fix that for you and land this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma, ngraham Cc: ndavis, ngraham, plasm

D29845: Added option to change grid thickness

2020-06-03 Thread Nathaniel Graham
ngraham added a comment. Would it make sense to have it scale smoothly according to panel size by default? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29845 To: piotrkakol Cc: gladhorn, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS

D29603: Adds custom spacing between task manager icons

2020-05-31 Thread Nathaniel Graham
ngraham added a comment. Thanks! Do you think you could maybe re-open this at https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/? We're transitioning patch review over to GitLab. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29603 To: martellin

D29831: Update availableScreenRect when a panel moves to another screen

2020-05-29 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29831 To: akandaurov, #plasma, davidedmundson Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesj

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-28 Thread Nathaniel Graham
ngraham added a comment. Overall it works very well given the current plumbing here! I'll accept it after one little change: INLINE COMMENTS > touchpad.qml:294 > + > +Controls.SpinBox { > +id: accelSpeedSpinbox Can you set `Layouts.Layout.minimumWidth: Kirigami.U

D29140: Show POTD in lock screen

2020-05-26 Thread Nathaniel Graham
ngraham added a comment. @davidre is this better now? Also @broulik and other #plasma people may want to review. Finally, you might consider moving this to GitLab for greater visibility. REPOSITORY R114 Plasma Addons REVISION DETAIL htt

D29603: Adds custom spacing between task manager icons

2020-05-26 Thread Nathaniel Graham
ngraham added a comment. Thanks! And sorry for the long delay before reviewing. However this doesn't seem to be working for me; no matter what value I enter, my vertical icons-only-task manager's icon spacing does not change. Also, instead of allowing the user to specify a pixel value, w

D27078: Drag-and-drop files at the right coordinates

2020-05-26 Thread Nathaniel Graham
ngraham closed this revision. REVISION DETAIL https://phabricator.kde.org/D27078 To: painlessroaster, hein, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterbe

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-05-26 Thread Nathaniel Graham
ngraham added a comment. In D29501#669458 , @ndavis wrote: > That's a good point. Is there a way to choose a different default layout based on info about the user's setup? I think choosing layouts based on the user's hardware may be necessary to

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

2020-05-25 Thread Nathaniel Graham
ngraham added a comment. Sorry for the delay in reviewing this. It's on my to-do list. I'll try to make some time today (it is a national holiday in my country). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngr

D29827: Give users the ability to disable the microphone indicator

2020-05-24 Thread Nathaniel Graham
ngraham added a comment. In D29827#673734 , @kmaterka wrote: the system tray icon (some applications have such option). > If you don't want the icon, do not start an app in the first place Yeah that's not gonna be an option here. > o

D29827: Give users the ability to disable the microphone indicator

2020-05-24 Thread Nathaniel Graham
ngraham added a comment. In D29827#673615 , @meven wrote: > In D29827#673611 , @davidedmundson wrote: > > > It's an SNI, I thought the systemtray could already filter SNIs in the enties tab of the

D29827: Give users the ability to disable the microphone indicator

2020-05-22 Thread Nathaniel Graham
ngraham added a comment. The name needs to be your full name ("Firstname Lastname"). This was a pre-existing requirement, it's just not enforced before patch submission, rather than afterwards. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29827

D28539: [Emoji panel] search when the user begins typing

2020-05-22 Thread Nathaniel Graham
ngraham closed this revision. ngraham added a comment. This landed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28539 To: ngraham, apol, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, Z

D29827: Give users the ability to disable the microphone indicator

2020-05-22 Thread Nathaniel Graham
ngraham added a comment. You need to push to your fork of the `plasma-pa` repo, not the main location. `git push fork` should do it if you've set up your fork with the name `fork` as described in https://community.kde.org/Infrastructure/GitLab#Add_the_fork_to_your_source_checkout REPOSITORY

D29827: Give users the ability to disable the microphone indicator

2020-05-22 Thread Nathaniel Graham
ngraham added a comment. In D29827#673535 , @kurmikon wrote: > In D29827#673534 , @ngraham wrote: > > > What email? Huh? > > > The page you linked say I have to send an email. > > Anyway, I

D29827: Give users the ability to disable the microphone indicator

2020-05-22 Thread Nathaniel Graham
ngraham added a comment. What email? Huh? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29827 To: kurmikon, ngraham, #vdg, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, Zr

D29827: Give users the ability to disable the microphone indicator

2020-05-22 Thread Nathaniel Graham
ngraham added a comment. Thanks for the patch! KDE has since moved to GitLab at invent.kde.org/ and we would prefer not to use Phabricator for new patches. Could you re-submit this as a merge request at https://invent.kde.org/plasma/plasma-pa/-/merge_requests, and then Abandon this? Tha

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-20 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. All right, I'll abandon this revision and turn it into a Phab task: T13180: Make it easier to apply the wallpaper to the desktop(s), lock screen, and login screen all at once REPOSITORY R120 Plas

D27669: [kstyle] Tools area

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. Now disabled toolbar items don't use the disabled text color when disabled. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham Cc: mart, maartens, abstractdevelop, IlyaBiz

D28154: Add users KCM

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. Great, that works! BTW I think you can change the KCM name to `kcm_users` as you originally wanted. Sorry for saying otherwise. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D28154_1 REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma

D28154: Add users KCM

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. The avatar sheet still does not close with Esc. :/ REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D28154_1 REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-

D28317: Adjust default color scheme and titlebar appearance for Tools Area

2020-05-19 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Moved to Invent: https://invent.kde.org/plasma/breeze/-/merge_requests/3 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: cblack, ndavis, niccolove, The-Feren-OS-Dev, manueljl

D27669: [kstyle] Tools area

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. I think this should land early in the 5.20 cycle so we have a lot of time for testing. However I think we need to land it alongside the new colorscheme so people don't get a bad first impression, or else re-work it to pull the color from a new "toolsarea" color set t

D20569: Use more compact OSD

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: ngraham, #plasma, #vdg, broulik, niccolove, ndavis Cc: ndavis, kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, Codezela, filipf, zzag, plasma-devel

D29333: Don't show an empty error dialog when canceling the sync password prompt

2020-05-19 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Looked into it and concluded that PolKit/Kauth are... special. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D29333 To: ngraham, filipf, davidedmundson, #plasma Cc: broulik, mthw, plasm

D20569: Use more compact OSD

2020-05-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 83067. ngraham edited the test plan for this revision. ngraham added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20569?vs=56281&id=83067 BRANCH arcpatch-D20569_2 REVISION DETAIL https

D20569: Use more compact OSD

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. I would like to formally re-submit this for consideration. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: ngraham, #plasma, #vdg, broulik Cc: kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, Codez

D20569: RFC: Use more compact OSD

2020-05-19 Thread Nathaniel Graham
ngraham commandeered this revision. ngraham added a reviewer: broulik. ngraham added a comment. Yoink. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: ngraham, #plasma, #vdg, broulik Cc: kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmu

D26881: [Applets/Folder View] Allow using a folder that ends with a space

2020-05-19 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. What a silly little patch this was. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26881 To: ngraham, hein, #plasma Cc: anthonyfieroni, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblac

D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, Zren

D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 83066. ngraham added a comment. Compute background color in a more colorscheme-friendly way REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29081?vs=83065&id=83066 BRANCH menu-title-looks-less-like-a-menu-item (branched

D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 83065. ngraham added a comment. Fix non-rounded corners REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29081?vs=83064&id=83065 BRANCH menu-title-looks-less-like-a-menu-item (branched from master) REVISION DETAIL htt

D29081: [QStyle] Make menu titles look less like menu items

2020-05-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 83064. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29081?vs=80924&id=83064 BRANCH menu-title-looks-less-like-a-menu-item (branched from master) REVISION DETAIL https://phabricator.

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. Ah, it doesn't cherry-pick cleanly. You'll have to wait for 5.20, sorry. This is a good incentive to start living on git master. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel, Or

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. Oh you mean both of them. Yeah, seems reasonable. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D29438: Use font: instead of font.pointSize: where possible

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29438 To: ngraham, cblack, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-moh

D29437: Use font: instead of font.pointSize: where possible

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29437 To: ngraham, cblack, #plasma Cc: ahiemstra, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. In D29818#672947 , @epopov wrote: > In D29818#672942 , @ngraham wrote: > > > was landed on master, not 5.19 > > > Can it be moved to Plasma 5.19? Rut the regres

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29818 To: epopov, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-moha

D29818: Check if the clipboard is empty when initializing the status of the Clipboard applet

2020-05-19 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Oops, sorry for not catching that. D29652 was landed on master, not 5.19, so it's not urgent. Thanks. Note that we have migrated to GitLab; would you mind submitting future patches as Merge Req

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. In D29798#672886 , @mart wrote: > the length of that button text is quite daunting, i fear imagining how would be in geman :p Indeed, and Brazilian Portuguese, and probably many others too. What are your tho

D24721: Show backend name and version in app delegates

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. Ping! This is an important thing to have overall; could you please submit it as a Merge Request at https://invent.kde.org/plasma/discover/-/merge_requests? Thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24721 To

D29819: Using background rectangle in icon text when in software rendering

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. We have moved to GitLab now; could you submit this as a Merge Request at https://invent.kde.org/plasma/plasma-desktop/-/merge_requests? Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29819 To: brunogoncalves, #plasma, ng

D29820: Correction when displaying "badger counter" icons using software rendering

2020-05-19 Thread Nathaniel Graham
ngraham added a comment. We have moved to GitLab now; could you submit this as a Merge Request at https://invent.kde.org/plasma/plasma-desktop/-/merge_requests? Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29820 To: brunogoncalves, ngraham Cc:

D29712: [applets] Show KCMs in System Settings or Info Center, as appropriate

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29712 To: ngraham, mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-moh

D29713: [applets] Show KCMs in System Settings

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29713 To: ngraham, mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-moham

D29714: [applets] Show KCMs in System Settings

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29714 To: ngraham, mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohame

D29716: [applet] Show KCM in System Settings

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D29716 To: ngraham, jgrulich, mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, him

D29799: [kcms/notifications] Port "no search result" message to PlaceholderMessage

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29799 To: ngraham, #vdg, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D29766: [applets/taskmanager] Match default tooltip spacing in custom tooltip

2020-05-18 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29766 To: ngraham, #vdg, #plasma, cblack Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, a

D29771: [Notifications] Don't take updated time into account for sorting

2020-05-18 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29771 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-

D29785: Always use Window colorset for AbstractApplicationHeader

2020-05-18 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R169:5a716f3947dd: Always use Window colorset for AbstractApplicationHeader (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29785?vs=82968&id=8304

D29785: Always use Window colorset for AbstractApplicationHeader

2020-05-18 Thread Nathaniel Graham
ngraham added a comment. Not all of the headers use toolbars, but I thought the idea was for them all to use a consistent base appearance? @mart? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29785 To: ngraham, #kirigami, mart Cc: apol, plasma-devel, fbampaloukas

D28154: Add users KCM

2020-05-17 Thread Nathaniel Graham
ngraham added a comment. Now that D29394 has landed, you can add those images here! REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: ltoscano, mart, yur

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-16 Thread Nathaniel Graham
ngraham added a comment. You're probably right. This was a pretty lazy patch. The inherent challenge here is that desktop wallpapers are per-containment ("Containment" means a screen or activity), while the lock and login screens are per-session. A further complication is that the login

D29799: [kcms/notifications] Port "no search result" message to PlaceholderMessage

2020-05-16 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Now the appearance is consistent with other similar messages, as well as the one to

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

2020-05-16 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This should make it a bit easier for people to change the wallpapers in all three places. In

  1   2   3   4   5   6   7   8   9   10   >