D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Thanks for your work. Will re-review soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas

D28873: Add SwipeNavigator component

ngraham added a comment. Looking fine. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiems

D29784: Hardcode less colorSets

ngraham added a comment. Fixed the Kirigami half of this in D29785 . Just address the inline comment and then this is good to go! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D29784 To: apol, #plasma, ngraham Cc

D29785: Always use Window colorset for AbstractApplicationHeader

ngraham created this revision. ngraham added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY ...Otherwise when an `AbstractApplicationHeader` is used on a page that overrides the c

D29784: Hardcode less colorSets

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Now the tiny toolbar above the sidebar is a different color from the one beside it: F8323489: Screenshot_20200515_105617.png It's app

D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. So much better REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29770 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n

D29765: Add a blurless SDDM theme

ngraham added a comment. I agree, I think we need to come up with some infrastructure to allow SDDM themes to display user-visible settings. Even though this new theme is mostly symlinks, duplicating `main.qml` is uglier and less nice maintenance-wise then putting conditions in it. Also ship

D29437: Use font: instead of font.pointSize: where possible

ngraham added a comment. So is this good to go? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29437 To: ngraham, cblack, #plasma Cc: ahiemstra, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBo

D29766: [applets/taskmanager] Match default tooltip spacing in custom tooltip

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Task Manager app's custom tooltips use level 5 Headings for the subtitles, which is poi

D28873: Add SwipeNavigator component

ngraham added a comment. When there isn't room to show all labels, eliding the labels or collapsing the inactive tabs to square-ish icons-only things that are still clickable/touchable would seem to make more sense to me. The above screenshot kind of looks like a visual glitch IMO. REPOSITO

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Typically would would bind both to the same backend value and everything would just magically work. However the code in this KCM is terrible, and is quite imperative, without using bindings properly. So you'll have to manually set both anywhere the slider's value is

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Actually sorry, I won't get to that refactor soon so I don't want to block your work. Is this reviewable in its current state? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngraham,

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

ngraham added a comment. In D29749#671052 , @gikari wrote: > Yes. That's why i only hide the UI. The backend still sets the GTK2 theme too alongside with GTK3. This only removes the possibility to select different themes for different versions o

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7a4ea26a6561: Automatically close Clipboard applet after clearing history or deleting the… (authored by epopov, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE ht

D28873: Add SwipeNavigator component

ngraham added a comment. In D28873#671042 , @mart wrote: > If i make the window narrow enough, that's what happens > F8319940: Screenshot_20200514_164118.png > > perhaps it tabbar should scroll instea

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

ngraham added a comment. 1. There's still GIMP (and IIRC Audacity) when it comes to major GTK2 apps. I'm not saying don't do this, but maybe it's a bit premature? 2. Now that the GTK theme page only has one small row of items in it, it seems a bit silly to have on a separate page. It feels

D29727: Add mobile-friendly versions

This revision was automatically updated to reflect the committed changes. Closed by commit R31:9873c57ea383: Add mobile-friendly versions (authored by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29727?vs=82774&id=82797 REVISION DETAIL https://pha

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

ngraham added inline comments. INLINE COMMENTS > clipboard.qml:33 > Plasmoid.switchHeight: units.gridUnit * 5 > -Plasmoid.status: clipboardSource.data["clipboard"]["empty"] ? > PlasmaCore.Types.PassiveStatus : PlasmaCore.Types.ActiveStatus > Plasmoid.toolTipMainText: i18n("Clipboar

D28627: Adaptive panel opacity

ngraham added a comment. I still don't notice what you're trying to point out, so I'll take your word for it. :p REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: cblack, #plasma, davidedmundson, niccolove, #vdg Cc: apol, ngraham, davidedmundson, plas

D29140: Fix POTD in lock screen (complete)

ngraham resigned from this revision. ngraham added reviewers: davidre, broulik. ngraham added a comment. It works! Great job. I'd like #plasma people to review this as well, and I think we should wait until after 5.19 branches before landing it,

D29694: Introduce Avatar component

ngraham added a comment. +1 overall. I notice that this algorithm will return "KB" for Kai Uwe Broulik and HC for Hugo Pereira da Costa. Is that right? Names are hard. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29694 To: cblack, #kirigami, #vdg Cc: ngraha

D29694: Introduce Avatar component

ngraham added a comment. In D29694#669873 , @filipf wrote: > Cool stuff. The commit message needs to be expanded to explain where and how this will be used, and also needs to list key implentation feats (initials, colors). > > I believe we u

D29727: Add mobile-friendly versions

ngraham created this revision. ngraham added reviewers: VDG, bshah. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Unfortunately this wallpaper is very landscape-centric in design, so it is not very mobile-fr

D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. For the stable branch, we will need a patch that conditionally disables all of this stuff if you happen to have Frameworks 5.69 or newer. We don't want the stable branch to be broken for

D29394: Add photographic user avatars

ngraham accepted this revision. ngraham added a comment. Shipit! REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, The-

D29716: [applet] Show KCM in System Settings

ngraham created this revision. ngraham added reviewers: jgrulich, mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. ngraham requested review of this revision. REVISION SUMMARY CCBUG: 417836 Depends on D29711

D29714: [applets] Show KCMs in System Settings

ngraham created this revision. ngraham added reviewers: mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 417836 FIXED-IN: 5.20 Depends on D29711

D29713: [applets] Show KCMs in System Settings

ngraham created this revision. ngraham added reviewers: mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY CCBUG: 417836 Depends on D29711 As this will d

D29712: [applets] Show KCMs in System Settings or Info Center, as appropriate

ngraham created this revision. ngraham added reviewers: mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY CCBUG: 417836 Depends on D29711 As this will d

D28154: Add users KCM

ngraham added inline comments. INLINE COMMENTS > broulik wrote in UserDetailsPage.qml:217 > Can you add some way to make Escape close the sheet but not the entire KCM, > when run standalone through kcmshell? Hopefully the following is sufficient, > otherwise you'd have to mess with `FocusScope`

D29709: Give all OverlaySheets consistent headers

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in UpdatesPage.qml:39 > "Update Issue" Oops, thanks. Fixed in 11cf0dc694f92551f75617b664cd3e7e49e98df8 . REPOSITORY

D29394: Add photographic user avatars

ngraham added a comment. The .license files could live in another folder. Maybe `src/pics_sources`? REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb, p

D29709: Give all OverlaySheets consistent headers

This revision was automatically updated to reflect the committed changes. Closed by commit R134:fb1880d436a8: Give all OverlaySheets consistent headers (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29709?vs=82735&id=8273

D29709: Give all OverlaySheets consistent headers

ngraham updated this revision to Diff 82735. ngraham marked an inline comment as done. ngraham added a comment. Remove testing thingy that snuck in REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29709?vs=82734&id=82735 BRANCH master REVI

D29709: Give all OverlaySheets consistent headers

ngraham marked an inline comment as done. ngraham added a comment. String freeze is tomorrow. INLINE COMMENTS > apol wrote in ApplicationPage.qml:282 > I guess this was for testing? Yes, to work around ODRS flakiness. :( REPOSITORY R134 Discover Software Store REVISION DETAIL https://p

D29709: Give all OverlaySheets consistent headers

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY OverlaySheet has a `header:` property typically used to give the sheet

D29394: Add photographic user avatars

ngraham added a comment. @jriddell, does this licensing situation look sane? REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeG

D29394: Add photographic user avatars

ngraham accepted this revision. ngraham added a comment. Perfecto. REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, Th

D29692: Recommend better width calculation for PlaceholderMessage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:f1a2c678f9bd: Recommend better width calculation for PlaceholderMessage (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29692?vs=82689&id=826

D29692: Recommend better width calculation for PlaceholderMessage

ngraham created this revision. ngraham added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Left and right anchors + margins + vertical centering don't work well work together, and th

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

This revision was automatically updated to reflect the committed changes. Closed by commit R134:eb5ccec97a12: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

ngraham updated this revision to Diff 82687. ngraham marked 2 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29689?vs=82683&id=82687 BRANCH port-to-placeholdermessa

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN F8313851: Screenshot_20200512_121457.png

D29679: Dedicated drop areas for assigning tasks to activities

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! Very nice work. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D29679 To: ivan, #plasma, ngraham, mart Cc: plasma-devel, Orage, LeG

D29394: Add photographic user avatars

ngraham accepted this revision. ngraham added a comment. Awesome. Love the pancakes, the gecko, and the new gaming controller. Much nicer. I really like Doggo, AirBalloon, Pencils, and Sushi, and think those might be worth including as well. I also kind of like Fish too! Chip seems

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ngraham added a comment. (JFYI I just noticed that kde-cli-tools is broken and needs porting too) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29687 To: ahmadsamir, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, j

D28154: Add users KCM

ngraham added a comment. In D28154#668362 , @ltoscano wrote: > Technically kcm should be called kcm_. So far the Plasma_version part has been ignored, but at least kcm_ should be there. > > I'm not sure about the lack of the button. I

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

This revision was automatically updated to reflect the committed changes. Closed by commit R119:854a62e57772: Remove stepsize 24 from DPI spinbox inside kcm fontconfig (authored by kurmikon, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.k

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

ngraham added a comment. Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29431 To: kurmikon, #plasma, #vdg, ngraham Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot

D29603: Adds custom spacing between task manager icons

ngraham added a comment. In D29603#669015 , @martellini wrote: > Sounds cool. I'll be working on it. > I must that the iconSize setting is only visibile if the panel is vertical, why do you think it is so? Not sure I fully understahd,

D29595: Add gocryptfs support

ngraham added a comment. @ivan are you gonna land this, or should I? REPOSITORY R845 Plasma Vault BRANCH add-gocryptfs-support (branched from master) REVISION DETAIL https://phabricator.kde.org/D29595 To: mpilia, ivan, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

ngraham added a comment. In D29501#667413 , @ndavis wrote: > I agree with the size chosen if we are doing a vertical panel since that size allows app icons to be 48px and makes the systray more compact by using 2 columns. However, I can't think

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

ngraham added a comment. Got confirmation from @davidedmundson that this is okay. Can you provide an email address so I can land your patch with correct git authorship information? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29431 To: kurmikon, #plasma, #

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. That's not how it works. Patches need to be properly reviewed. I can do so on behalf of VDG, bud I'd like @davidedmundson's sign-off too, because IIRC he was the one who proposed or imple

D28321: [applets/devicenotifier] Port to ExpandableListItem

ngraham updated this revision to Diff 82653. ngraham added a comment. Remove a FIXME (it's already a problem in the existing version so it's not an artifact of this port REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28321?vs=82264&id=82653 BRANC

D29595: Add gocryptfs support

ngraham added inline comments. INLINE COMMENTS > ivan wrote in vaultwizardbase.h:65 > Heh, it was my first impression when the priority patch was contributed to > Vaults. Now I'm extra careful :) Perhaps the unintuitive nature of the numbering could be clarified with a comment in a follow-up p

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29651 To: epopov, ngraham, plasma-devel, broulik Cc: broulik, Orage, LeGast00n, The-Feren-OS-Dev

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e6ed4a888314: [applets/notifications] Remain visible after removing all notifications while… (authored by epopov, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

ngraham added a comment. > (similar to how the Notification applet closes after the last notification is removed). But you're changing that in D29651 ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29652 To: epopov

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Don't remove the curly braces for simple if statements REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29651 To: epopov, ngraham, plasma-devel

D29024: feat(wayland): support multiple protocol extensions through plugin system

ngraham added a comment. In D29024#668383 , @romangg wrote: > Note that I need to have this plugin system or something similar in for 5.19 or I will be forced to fork libkscreen permanently for KWinFT. I would like to avoid this and instead cont

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

ngraham abandoned this revision. ngraham added a comment. Oh I forgot that it was only in 5.19. We can continue in D29633 , it's better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29636 To: ngraham, broulik, #pla

D29570: Fix some alignments

ngraham added inline comments. INLINE COMMENTS > niccolove wrote in PowerManagementItem.qml:34 > It does look a bit too close on the right border in LTS. I guess I should add > a rightMargin here? Noah's point was that this doesn't automatically reverse itself due to a known Qt bug. However Da

D29595: Add gocryptfs support

ngraham added reviewers: ivan, Plasma. ngraham added a comment. Very cool! REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29595 To: mpilia, ivan, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, rag

D29603: Adds custom spacing between task manager icons

ngraham added a comment. In D29603#668422 , @martellini wrote: > > Also, it doesn't make sense IMO to expose separate horizontal and vertical controls; there should be just one control visible, and it should affect the task manager no matter it

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

ngraham created this revision. ngraham added reviewers: broulik, Plasma, Localization. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Current code only updates the text on the "not charging" condition, causing

D27203: Don't try to open files we can't figure out where they are

ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=408174? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27203 To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir Cc: ngraham, plasma-devel, Orage, LeG

D29548: Drag and drop assigning windows to activities in the default switcher

ngraham added a comment. So cool! Can you make the activity that the window is being dragged into highlight or otherwise somehow provide a visual indication that it's going to accept the drop? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29548 To: ivan, #

D29603: Adds custom spacing between task manager icons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I think it would make more sense to fix the default sizing behavior rather than adding these. We already have an "icon size" setting which roughly adjusts this already, just not

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. The latter, if you don't mind. I appreciate your patience! I hope to have the rewrite submitted tomorrow. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis, ngraham, plasma-devel, Orage, LeGa

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Indeed, the code here is a catastrophe. I'm actually in the middle of a rewrite to make everything more declarative which should make UI changes much easier. If you'd like to wait a few days until that's done, it might make your patch a lot simpler. REPOSITORY R11

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham added a comment. Managed to re-introduce https://bugs.kde.org/show_bug.cgi?id=414045, so it looks like that's not related to this. Will fix it in another patch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #plasma C

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham updated this revision to Diff 82324. ngraham added a comment. Move the config bar as the panel changes thickness REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29535?vs=82280&id=82324 BRANCH panel-adjustment-adjustment (branched from maste

D29518: Remove remaining icons from applets with custom tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R119:eeab79954d7d: Remove remaining icons from applets with custom tooltips (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29518?vs=82234&i

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham planned changes to this revision. ngraham added a comment. Need to re-implement the panel thickness change handling REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #plasma Cc: ahiemstra, cblack, plasma-devel, Orage, LeG

D29517: Remove remaining icons from applets with custom tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R114:1d64bd119235: Remove remaining icons from applets with custom tooltips (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29517?vs=82233&id

D29516: Remove remaining icon from applet with custom tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fe20601bddd5: Remove remaining icon from applet with custom tooltip (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29516?vs=82232&id

D28487: Redesign of system monitor plasmoids

ngraham added a comment. When I create a new System Monitor Sensor widget, it's totally blank: F8300732: Screenshot_20200508_103957.png Needs to have a Configure... button on it in this case. REPOSITORY R120 Plasma Workspace REVISION DETAIL htt

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham added a subscriber: ahiemstra. ngraham added a comment. An idea brought up by @ahiemstra would be to add dragability into the SpinBox control itself, which was suggested in T9460 and would automatically re-implement/preserve draggability. I can loo

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

ngraham added a comment. Very cool stuff! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28623 To: gikari, #breeze, #plasma, cblack Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, Zre

D29157: force systemsettings for kcms

ngraham accepted this revision. ngraham added a comment. I say ship it! REPOSITORY R120 Plasma Workspace BRANCH phab/systemsettings REVISION DETAIL https://phabricator.kde.org/D29157 To: mart, #plasma, ngraham Cc: broulik, ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-O

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham added a comment. In D29535#666303 , @abetts wrote: > I love this idea. I would request to keep the drag behavior and follow up with a second ticket to propose a change in the drag behavior for the panel. I considered that, but whi

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham updated this revision to Diff 82280. ngraham marked an inline comment as done. ngraham added a comment. Use less arbitrary min and max values REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29535?vs=82277&id=82280 BRANCH panel-adjustment-ad

D29535: Change panel thickness adjustment UI to use a SpinBox

ngraham created this revision. ngraham added reviewers: abetts, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We receive many complaints and bug reports about the current UI for adjusting panel

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

ngraham updated this revision to Diff 82264. ngraham added a comment. Remove more FIXMEs (the first one was already broken with the current implementation), and for the second one, there's no better way to implement this, though I may remove the logic entirely REPOSITORY R120 Plasma Worksp

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

ngraham updated this revision to Diff 82262. ngraham added a comment. Fix a FIXME REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28321?vs=82111&id=82262 BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL https://phabrica

D29264: New tabs for Breeze

ngraham added a comment. The tab widget's active tab background color is something that can be played with in code--and already is, in fact. With the default Breeze color scheme, observe how it has a subtly lightened background color compared to the rest of the view background. Since ev

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

ngraham added a comment. Never mind, @zzag discovered that I didn't have the `xorg-x11-server-sdk` package installed, so nothing to see here, and sorry for the noise! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29514 To: asturmlechner, #plasma, zzag Cc: c

D28922: Port Sensor Face loading from plasmoid

ngraham added a comment. Hmm, this doesn't seem to apply cleanly on top of current master. REPOSITORY R111 KSysguard Library BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-F

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

ngraham added a comment. In D29514#665916 , @cblack wrote: > That's the source package location, not where you'd expect to find the headers for usage by other packages. You'd probably be looking for `/usr/include/xorg/xserver-properties.h`.

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

ngraham added a comment. In D29514#665911 , @asturmlechner wrote: > In D29514#665869 , @ngraham wrote: > > > Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h

D29516: Remove remaining icon from applet with custom tooltip

ngraham created this revision. ngraham added reviewers: bugseforuns, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Last bits needed for T12778 . CCBUG: 420

D29518: Remove remaining icons from applets with custom tooltips

ngraham created this revision. ngraham added reviewers: bugseforuns, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Last bits needed for T12778 . BUG: 42093

D29517: Remove remaining icons from applets with custom tooltips

ngraham created this revision. ngraham added reviewers: bugseforuns, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Last bits needed for T12778 . CCBUG: 420

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

ngraham added a comment. Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: -- The following features have been disabled: * XorgServer, XServer header needed for touchpad KCM (X11 backend) -- T

D28154: Add users KCM

ngraham added a comment. I would like to get this into 5.19, which would mean moving the code back into the user-manager repo, or removing it as a dependency for Plasma 5.19 by requesting an exception to the repo freeze. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D28154 REVISION DE

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. There's still disagreement over whether we should do this or the other one, and how to implement them, so I don't think we know what release one of them will land in (if any). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To:

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

ngraham added a comment. In D29501#665639 , @filipf wrote: > If user data would show low vertical panel usage, what are we really fixing and for who? Extrapolating from that and presuming that a fair share of them are content with the current de

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

ngraham added a comment. #plasma ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Every change upsets somebody; that's not a reason to avoid change. We change things when the proposed change is a universal or net improvement, and we leave things the same when it would be worse or no better. So you should evaluate that (and any) patch on its merits

<    1   2   3   4   5   6   7   8   9   10   >