D28034: [Applet] Port to ExpandableListItem

ngraham added a comment. Yeah, the PC3 busy indicator component itself seems to be to blame for items 1 and 3. I'll look into it. I hadn't really considered #2 as a valid use case while working on the component, but I can look into it. REPOSITORY R116 Plasma Network Management Applet

D27271: [kcms/colors] RFC: Accent Colours

ngraham added a comment. This doesn't compile for me: /home/nate/kde/src/plasma-desktop/kcms/colors/editor/scmeditorcolors.cpp: In member function ‘void SchemeEditorColors::updateColorSchemes()’: /home/nate/kde/src/plasma-desktop/kcms/colors/editor/scmeditorcolors.cpp:378:16: erro

D28034: [Applet] Port to ExpandableListItem

ngraham updated this revision to Diff 79522. ngraham added a comment. - Don't switch to the details tab when showing the expanded view - Re-enable the Connect button when hiding the password field REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabric

D28632: use the decoded url for launcherPosition

ngraham added a comment. Not `Plasma/5.18`? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28632 To: mart, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himce

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. The blocking bug was just fixed with D28632 , therefore... ping! :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: mart, filipf, kmaterka, gvgeo, davidedmu

D28632: use the decoded url for launcherPosition

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This completely fixes the issue for me. Stable branch, probably. REPOSITORY R120 Plasma Workspace BRANCH phab/launchers REVISION DETAIL https://phabricator.kde.org/D28632 To:

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham updated this revision to Diff 79514. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27845?vs=77053&id=79514 BRANCH iotm-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D27845

D28631: Remove Icons from system tray item tooltips

ngraham updated this revision to Diff 79511. ngraham marked an inline comment as done. ngraham added a comment. Revert change to remove code from the Data Engine REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28631?vs=79510&id=79511 BRANCH remov

D28631: Remove Icons from system tray item tooltips

ngraham created this revision. ngraham added reviewers: Plasma, davidre, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY It was decided in T12778 to remove icons fr

D28625: [WIP] Use ShadowedRectangle for Card backgrounds

ngraham added a comment. Dang this looks so good. +1 for the visuals at least. REPOSITORY R169 Kirigami BRANCH card_shadowrect REVISION DETAIL https://phabricator.kde.org/D28625 To: ahiemstra, #kirigami, #vdg, cblack Cc: ngraham, nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2,

D28627: WIP: Made panel opaque on maximized window

ngraham added a comment. In D28627#643038 , @davidedmundson wrote: > Why? See the discussion in D28353 . Essentially, we ran into a design issue whereby increasing the transparency of the panel lo

D28614: Add better player tab crash handling

ngraham accepted this revision. ngraham added a comment. I have the same issue with Firefox and can confirm that this fixes it! REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28614 To: broulik, #plasma, fvogt, cblack, ngraham Cc: ngraham, plasma-d

D28034: [Applet] Port to ExpandableListItem

ngraham planned changes to this revision. ngraham added a comment. Thanks for the review. Will fix. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28034 To: ngraham, #vdg, #plasma, jgrulich Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Fere

D28035: [Applet] Port to ExpandableListItem

ngraham updated this revision to Diff 79437. ngraham added a comment. Update required Frameworks version REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28035?vs=77966&id=79437 BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL

D28575: Make headings of systray and applet merge

ngraham added a comment. Hmm, here's what I get when I apply this and then D28467 : F8216515: Screenshot_20200404_213411.png Other applets also seem to be affected: F8216520: Screenshot_20200404_213522.png

D27849: [applets/digital-clock] Remove the tooltip icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d1a0835bee52: [applets/digital-clock] Remove the tooltip icon (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27849?vs=79370&id=79371

D27849: [applets/digital-clock] Remove the tooltip icon

ngraham updated this revision to Diff 79370. ngraham added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27849?vs=76972&id=79370 BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/

D27847: [applet/taskmanager] Remove the launcher items' tooltip icons

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f14afa945cea: [applet/taskmanager] Remove the launcher items' tooltip icons (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27847?vs=76

D28037: [Applet] Port to ExpandableListItem

ngraham updated this revision to Diff 79364. ngraham added a comment. Rebase REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28037?vs=77938&id=79364 BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D28239: Stop multiplying duration values

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:f3bbc0ba0e34: Stop multiplying duration values (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE

D28238: Stop multiplying duration values

This revision was automatically updated to reflect the committed changes. Closed by commit R120:295870252434: Stop multiplying duration values (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28238?vs=78358&id=79362 REVISION DETA

D27669: [kstyle] Tools area

ngraham added a comment. If we're going to consider the titlebar a part of the tools area, then it needs a separator line underneath it whether it's drawn on a Blender window or a Plasma config window The idea was always to draw a separator line under the bottom-most element of the Tools Are

D28154: Add users KCM

ngraham added a comment. In D28154#640943 , @cblack wrote: > Add parent category Now it shows up on the base level of navigation, rather than within the Account Details group where it currently lives. REPOSITORY R119 Plasma Desktop RE

D28154: Add users KCM

ngraham added inline comments. INLINE COMMENTS > cblack wrote in ChangePassword.qml:65 > that's basically what this does Well, it doesn't work for me. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: crossi, The-Fe

D28154: Add users KCM

ngraham added inline comments. INLINE COMMENTS > UserDetailsPage.qml:101 > +layer.enabled: user.faceValid > +layer.effect: OpacityMask { > +maskSource: Rectangle { Nice! How about an outline around the circle like we do in Kickoff?

D28539: [Emoji panel] search when the user begins typing

ngraham added a comment. Yes, but hitting Ctrl+f and typing results in an instant search, while applying this patch and just typing results in a 3-second lag for me before the view switches and the search begons. It feels like I did something wrong rather than running into some kind of inher

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Haven't tried yet, sorry. I'll give it another shot today. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Fere

D28154: Add users KCM

ngraham added a comment. Now it's this: "file:///home/nate/kde/usr/share/kpackage/kcms/user_manager/contents/ui/UserDetailsPage.qml" "Error loading QML file.\n257: Type ChangePassword unavailable\n31: Cannot assign to non-existent property \"anchors\"\n" REPOSITORY R119 Plasm

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. So here's what I see in the system tray popup: F8213414: Screenshot_20200403_102113.png The toolbar doesn't touch the edges of its sur

D28281: Add options for OSD feedback

This revision was automatically updated to reflect the committed changes. Closed by commit R115:1df3476ced19: Add options for OSD feedback (authored by sgoth, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28281?vs=784

D28154: Add users KCM

ngraham added a comment. I think that broke the details page. Console spew says: QQmlComponent: Component is not ready "file:///home/nate/kde/usr/share/kpackage/kcms/user_manager/contents/ui/UserDetailsPage.qml" "Error loading QML file.\n257: Type ChangePassword unavailable\n

D28539: [Emoji panel] search search when the user begins typing

ngraham created this revision. ngraham added reviewers: apol, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now you need to hit Ctrl + F to start searching. This patch additionally makes th

D28154: Add users KCM

ngraham added inline comments. INLINE COMMENTS > ChangePassword.qml:65 > + > +onAccepted: !passwordWarning.visible && verifyField.text && > passwordField.text && passButton.apply() > + hitting the return key on this field should effectively click the Create button > UserDetails

D27669: [kstyle] Tools area

ngraham added a comment. In D27669#640473 , @cblack wrote: > In D27669#639569 , @ngraham wrote: > > > Anyway I worked around that in D27669 , and I guess it's not

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

ngraham added a comment. With D27669 , it's probably time to revisit drawing this separator at all. We should probably be relying on the widget and/or decoration style to do it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.or

D28236: [applet/taskmanager] Remove unnecessary icon size values set on PC3 toolbuttons

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:122a7ded1291: [applet/taskmanager] Remove unnecessary icon size values set on PC3 toolbuttons (authored by ngraham). R

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5a5e0bc0880b: [kcms/baloo] Refine UI and prepare for more indexing options in the future (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. Currently there are only two choices, yes. However as mentioned before, one of the goals of this patch is to future-proof the UI for the addition of more options, which is coming soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2

D28517: Send notification when screencasting fails

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fair enough. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH cblack/screencast-notify-error (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D28517: Send notification when screencasting fails

ngraham added inline comments. INLINE COMMENTS > screencaststream.cpp:374 > +notification->setTitle(i18n("Failed to start screencasting")); > +notification->setText(i18n("Error: %1").arg(body)); > +notification->setIconName(QStringLiteral("data-error")); `.arg` is unneces

D27979: Add top area to notifications

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. The padding looks much better with default font settings: F8211692: Screenshot_20200402_090740.png I'm using 11pt Ubuntu though, not 10pt Noto S

D28154: Add users KCM

ngraham added a comment. So it does. My bad, sorry. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGas

D28154: Add users KCM

ngraham added a comment. Wait, why are you adding the Konqis to this diff? You should use whatever framework provides the gallery instead of re-implementing all of that and duplicating the assets. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cb

D28154: Add users KCM

ngraham added a comment. You should set `smooth: true` on those avatars in the new gallery so they aren't so jaggy. Also the button to add your own avatar from a file should probably have a label in it so people can figure out what it does. And the sheet that the new gallery is on should be

D27669: [kstyle] Tools area

ngraham added a comment. Lightening the stuff on the Tools Area is a nice effect though, IMO. Implementation-wise, we could also use the Fade inactive window effect in the color scheme itself for this. However it's a bit buggy as various apps have widgets that don't respect it (I've filed bu

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. It's not a terrible idea, I just need to think about it a bit. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, LeGast0

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. But would we still have Breeze, Breeze Light, and Breeze Dark Plasma themes? If we're going to get rid of the Breeze color scheme and just have light and dark, it might be a bit odd to still have a Breeze Plasma theme. Also maybe we should discuss that after thi

D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet

ngraham added a comment. While it has focus, yes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28483 To: epopov, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himces

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. If you tell it to proceed after that, does it succeed or fail? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, LeGast0

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. You don't need to already be on the other branch, just apply this on top of master. If all goes well, `arc` should first apply D27669 , then this one. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 T

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. In D28317#639589 , @ndavis wrote: > yes Done. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, david

D27979: Add top area to notifications

ngraham added a comment. This looks amazing! I love it. I think the content area below the header needs an additional `units.smallSpacing` margin though. The text in that area comes really close to touching the header: F8209858: Screenshot_20200401_115821.png

D27669: [kstyle] Tools area

ngraham added a comment. Anyway I worked around that in D27669 , and I guess it's not really a huge deal for toolbar icons. One thing I notice is that the bottom separator line for the titlebar isn't drawn for 3rd-party apps where there is no Tools Are

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79070. ngraham added a comment. Make the Tools Area patch the base commit, again REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79069&id=79070 BRANCH tools-area-color-changes (branched from master) REVISION D

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79069. ngraham added a comment. Lighten the button when the window is inactive REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79066&id=79069 BRANCH tools-area-color-changes (branched from master) REVISION DET

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79066. ngraham added a comment. Make 86851917557ea7deeaaac05b3d62e021d93041e9 the base commit REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79063&id=79066 BRANCH tools-area-color-changes (branched from master

D27669: [kstyle] Tools area

ngraham added a comment. While working on D28317 , I noticed something: when a window becomes inactive, the icons change their colors, but only for the parts of the icon using the text color. Red icons, or parts of icons that are red, don't change at all w

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79063. ngraham added a comment. Make the close button red REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79062&id=79063 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabric

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Damn, that didn't work. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampalou

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79062. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78686&id=79062 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabricator.kde.org/D28317

D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet

This revision was automatically updated to reflect the committed changes. Closed by commit R120:247ff0bdb646: [applets/clipboard] Don't close when clicking history item if pop-up was pinned… (authored by epopov, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28483: Updated patch that fixes the issue of closing a pinned the Clipboard applet

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, I see what you mean now. This is indeed a better solution. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28483 To: epopov, ngraham Cc: plasma-

D28485: Move QMimeData registration back to where it belongs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yikes! Stable branch, probably REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D28485 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n

D28461: In sidebar mode show if a module is in default state or not

ngraham added a comment. So every single KCM will need to be patched to add a settings proper in support of this? Oof. Is there no easier way? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg Cc: ng

D28483: Updated patch that fixes the issue of closing a pinned the Clipboard applet

ngraham added a comment. This needs to be rebased on master, because, it needs to apply //on top of// your previous patch, not //instead// of it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28483 To: epopov, ngraham Cc: plasma-devel, Orage, LeGast00n, T

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. What was the problem with the previous one? It works great for me. Can you submit your changes as a new patch rather than updating this one? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc:

D27669: [kstyle] Tools area

ngraham added a comment. Thanks, that helps a lot. It still feels a little bit slower than before, but it's at least much improved. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre Cc: maartens, abstrac

D28461: In sidebar mode show if a module is in default state or not

ngraham added a comment. Is D28460 the only other patch that's needed? I applied that and then this patch compiled fine, but I don't see any difference in the sidebar, despite having changed some settings from their default values. REPOSITORY R124 Syst

D28057: Fix/Allow folderview popup mode icon and list icon size

ngraham added a comment. Sorry for the delay, I will resume reviewing this soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28057 To: pereira.alex, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, za

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Make sure you test how this looks in the System Tray too, and not just as a standalone applet. ;) INLINE COMMENTS > FullRepresentation.qml:31 > > -PlasmaBt.DevicesProxyMo

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham added a comment. Screenshots in the Test Plan section are always appreciated :) REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D28467 To: niccolove, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouka

D28461: In sidebar mode show if a module is in default state or not

ngraham added a comment. I get a compile error: /home/nate/kde/src/systemsettings/core/MenuItem.cpp: In member function ‘void MenuItem::updateDefault()’: /home/nate/kde/src/systemsettings/core/MenuItem.cpp:154:36: error: ‘isDefaults’ is not a member of ‘KCModuleLoader’ 154 |

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham added a comment. In D28467#638980 , @niccolove wrote: > I'm a bit confused by > > import org.kde.plasma.components 2.0 as PlasmaComponents > import org.kde.plasma.components 3.0 as PlasmaComponents3 > > > is it correct?

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

This revision was automatically updated to reflect the committed changes. Closed by commit R120:175424169d18: [applets/clipboard]: Fix applet closing itself when clicking on a history item… (authored by epopov, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. Works perfectly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc: davidedmundson, plasma-devel, Orage, LeG

D28458: [runners/converter] Skip empty parts when splitting units

ngraham added a comment. No problem. :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28458 To: alex, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai,

D28458: [runners/converter] Skip empty parts when splitting units

This revision was automatically updated to reflect the committed changes. Closed by commit R114:6e6c5707d406: [runners/converter] Skip empty parts when splitting units (authored by alex, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D28465: [Categories Page] Use BasicListItem

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! Tablet mode spacing should just be added into BasicListItem itself, if it doesn't already have it. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. You'll need to compile Plasma from git master, and then run your master-branch plasma session. There are instructions here: https://community.kde.org/Get_Involved/development#Plasma Feel free to ping me or anyone else in #plasma

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. Hmm, this isn't working for me. When I pin open the system tray popup and click on a Klipper history item, the popup stays open as expected, but the Klipper applet itself closes, so the pop-up is replaced with the applets list. Is this working for you? REPOSITOR

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Same error about not being able to find the module. Sorry for not being clear. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham, davidre, plasma-devel, Orage,

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. The path would be `/home/nate/kde/usr/lib64/gtk-3.0/` on my system, but nonetheless there is no effect. :( REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngraham,

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. You can add it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. @ndavis like this? F8206344: Screenshot_20200330_123644.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, david

D27669: [kstyle] Tools area

ngraham added a comment. Found an issue in Virtualbox: the menubar isn't considered a part of the Tools Area: F8206280: Screenshot_20200330_113752.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasm

D28133: [applets/digital-clock] Switch timezones by clicking on them in the popup

ngraham added a comment. Hmm, that's a good point. I hadn't realized that. Would it make sense for changing the timezone in the applet to actually change the whole system timezone too, rather than just the display in the applet? Is that something we can do? REPOSITORY R120 Plasma Workspac

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. It can, you just need to fix the merge conflicts manually. If it doesn't apply cleanly to master, that means it can't be landed on master. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc: dav

D28435: [System Tray] Update effective status on model insertion

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This fixes the same issue affecting Vaults too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28435 To: broulik, #plasma, kmaterka, davidre, ahmadsami

D27701: [ComboBox] Use transparent dimmer

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah, this fixes those issues for me too. Seems to make sense. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D27701 To: broulik, #pla

D28427: [libnotificationmanager] forward notifications to lockscreen

ngraham added a comment. In D28427#637913 , @nicolasfella wrote: > So notifications are only forwarded if x-kde-show-on-lockscreen is set? I wonder if opt-out (x-kde-dont-show-on-lockscreen) would be better with regard to third-party apps. From

D27669: [kstyle] Tools area

ngraham added a comment. Nice, that seems to have fixed the issue again. However I still see a significant performance regression though. Switching tabs in Kate is now quite slow, especially when there are many open and you use a keyboard shortcut to do so. I see the spinning busy cursor

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Well this is kind of a problem then since we need to support development builds to a nonstandard install prefix. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ngr

D28072: [GTK Config] Apply color scheme to GTK3 applications

ngraham added a comment. Hmm, when following those instructions, I get the following console error: Gtk-Message: 08:50:13.086: Failed to load module "colorreload-gtk-module" And the color scheme doesn't change. The `colorreload-gtk3-module` target did get built, and it installed a

D28354: [applets/digital-clock] Fix calendar events not being shown at first

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a05dc73cf7fb: [applets/digital-clock] Fix calendar events not being shown at first (authored by epopov, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://ph

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. This needs a rebase on master, as it currently does not apply. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D28354: [applets/digital-clock] Fix calendar events not being shown at first

ngraham added a comment. Can you rebase this patch on current master? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28354 To: epopov, ngraham, #plasma, vkrause Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, G

D27669: [kstyle] Tools area

ngraham added a comment. I just found an interesting bug. KDE apps with menubars show a mis-colored area to the right of the menubar when maximized: F8203808: vokoscreenNG-2020-03-28_22-03-54.webm REPOSITORY R31 Breeze REVISION DETAIL https://phabr

D28366: [krunner] Don't set the position three times in a row

ngraham added a comment. Yeah, it's not like the KRunner KCM is currently overflowing with options and it would get lost. :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28366 To: davidedmundson, #plasma, apol Cc: pereira.alex, ngraham,

D28366: [krunner] Don't set the position three times in a row

ngraham added a comment. In D28366#636969 , @broulik wrote: > Can we just nuke this option? I know people on the internetz™ are quite vocal about it but effectively it's just broken and unmaintained ...That, or make it configurable with a

D28354: [applets/digital-clock] Fix calendar events not being shown at first

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28354 To: epopov, ngraham, #plasma, vkrause Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

<    2   3   4   5   6   7   8   9   10   11   >