D24223: [WIP] Add global themes that mimic other platforms' workflows

[Niccolò Venerandi]

niccolove added a comment.


  In Cupertino, I think that the apps launcher should be limited in width and 
should auto-hide. 
  Regarding a side panel, I think it's really easy and nice to make the system 
tray somehow full height, that would easily mimick macOS and W10 
:
  F7432840: image.png  
  I'd also consider to make the global theme also change plasma theme, color 
scheme or even application style so that it switches to a even more similiar 
interface. If Cupertino global theme switched to a light version of 
https://store.kde.org/p/1252328/, that would be, well, //extraordinary//. In 
such case, I'd also consider the addition of a Fluent theme. Still, I can see 
why this would be much harder.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: niccolove, rikmills, cblack, broulik, mvourlakos, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24223: [RFC] Add global themes that mimic other platforms' workflows

[Niccolò Venerandi]

niccolove added a comment.


  In D24223#537927 , @fabianr wrote:
  
  > > It doesn't auto-hide by default in macOS. I decided to make it span the 
full width of the screen because not doing this is IMO one of the dumbest parts 
of that macOS dock, because it pointlessly  wastes the bottom-left-most and 
bottom-right-most pixels, which are two of the four easiest to click pixels in 
the whole screen.
  >
  > Even if you don't agree with the dock being limited in width, I think you 
still should make it limited. It is one of the most distinct visual aspects of 
the original desktop.
  
  
  I agree that being limited in width is a very import aspect of macOS. Whether 
it looks better or worse is debatable (personally, I prefer it limited), but 
it's a distinc visual aspect of the desktop, and it would confuse users to do 
that otherwise. Users who do not like it will be able to expand the panel.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24223

To: ngraham, #vdg, #plasma
Cc: davidre, LeGast00n, enriqueme, mart, fabianr, Zren, mmustac, niccolove, 
rikmills, cblack, broulik, mvourlakos, plasma-devel, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27669: WIP: [kstyle] Tools area

[Niccolò Venerandi]

niccolove added a comment.


  It should not be the window decoration theme to draw the line, as the user 
might want to change the decoration whilst preserving the tools area 
appearance. I'm not sure how Kvantum does it, but it's able to draw 1px lines 
on apps:
  F8132802: Screenshot_20200226_095018.png 

  Except for kirigami, which have their own:
  F8132807: Screenshot_20200226_095239.png 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze
Cc: ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Niccolò Venerandi]

niccolove added a comment.


  +1

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27737: Fixed margin of digital clock

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  margin_digital_clock (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27737

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove updated this revision to Diff 76672.
niccolove added a comment.


  Fixed layouts

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27697?vs=76571=76672

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27737: Fixed margin of digital clock

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fed83f884acd: Fixed margin of digital clock (authored by 
niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27737?vs=76678=76692

REVISION DETAIL
  https://phabricator.kde.org/D27737

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: niccolove, #vdg, #plasma, davidedmundson, ngraham
Cc: gvgeo, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27737: Fixed margin of digital clock

[Niccolò Venerandi]

niccolove added a comment.


  Is this correct, or is there anything special I have to do to land it to 
stable?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27737

To: niccolove, #vdg, #plasma, davidedmundson, ngraham
Cc: gvgeo, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove updated this revision to Diff 76674.
niccolove added a comment.


  Fix close button right margin

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27697?vs=76672=76674

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Niccolò Venerandi]

niccolove added a comment.


  E.g.: dedoimedo complained about this in both the .18 and .17 review.

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

To: The-Feren-OS-Dev, #vdg, niccolove, ngraham
Cc: IlyaBizyaev, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27832: Fix spacing change

[Niccolò Venerandi]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:eb4235eae1e8: Fix spacing change (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27832?vs=76929=76930

REVISION DETAIL
  https://phabricator.kde.org/D27832

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27832: Fix spacing change

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  A accidentally changed spacing with my previous commit

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fixspacing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27832

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Niccolò Venerandi]

niccolove added a comment.


  +1 to 38
  Weirdly enough, the plasma icon only looks that big from >40, while the IOTM 
does not use big icons in 40 yet. I'd like small icons to be used consistently.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: niccolove, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77001.
niccolove added a comment.


  Remove old highlight

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=76911=77001

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  Ah, this one.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77002.
niccolove added a comment.


  Remove previous highlight

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27824?vs=76912=77002

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27824

AFFECTED FILES
  src/applet/package/contents/ui/DeviceItem.qml
  src/applet/package/contents/ui/FullRepresentation.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  Seems correct to me - rather, the nm button is way too on the right. I could 
make that one consistent instead.

REPOSITORY
  R97 Bluedevil

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27824

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77004.
niccolove added a comment.


  Nope

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77003=77004

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  In D27823#621958 , @ngraham wrote:
  
  > This needs a rebase. Also you probably need to delete the existing 
mouseover highlight effect.
  
  
  Git is telling me this is up to date. Also, what existing mouseover effect?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77003.
niccolove added a comment.


  Right margin of button

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77001=77003

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Niccolò Venerandi]

niccolove added a comment.


  The plasma logo is also quite big. For reference, here's my 38px panel:
  F8152196: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: KonqiDragon, niccolove, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26945: fix(plasmoid): add smallSpacing to leftMargin

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:b0f3fa30d427: fix(plasmoid): add smallSpacing to 
leftMargin (authored by niccolove).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26945?vs=76025=76920

REVISION DETAIL
  https://phabricator.kde.org/D26945

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml

To: niccolove, #vdg, romangg
Cc: romangg, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:149075077b82: Changed leftMargins to smallSpacing to be 
consistent (authored by niccolove).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26946?vs=76913=76923#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26946?vs=76913=76923

REVISION DETAIL
  https://phabricator.kde.org/D26946

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove added a comment.


  Uff, I screwed up landing this patch: 
https://cgit.kde.org/plasma-workspace.git/commit/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma, ngraham
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27807: Changed style of pressed list item to be consistent

[Niccolò Venerandi]

niccolove abandoned this revision.
niccolove added a comment.


  Actually, there is a proper way to do this. Gimme a sec.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27807

To: niccolove, #vdg, #plasma
Cc: ngraham, plasma-devel, ndavis, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27824: Use consistent highlight

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This uses the PlasmaComponents.Highlight feature to be consistent with other 
lists

REPOSITORY
  R97 Bluedevil

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27824

AFFECTED FILES
  src/applet/package/contents/ui/DeviceItem.qml
  src/applet/package/contents/ui/FullRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove updated this revision to Diff 76913.
niccolove added a comment.


  Remove spacing changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26946?vs=76024=76913

BRANCH
  smallspacingmargin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26946

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
niccolove requested review of this revision.

REVISION SUMMARY
  Use the PlasmaComponents.Highlight feature to be consistent with other lists.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26945: fix(plasmoid): Added smallSpacing to leftMargin

[Niccolò Venerandi]

niccolove added a comment.


  Is the commit given by the patch title that I just changed, or do I have to 
change the commit name somewhere else?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26945

To: niccolove, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76529.
niccolove added a comment.


  - Merge branch 'master' into topbar

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76374=76529

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76530.
niccolove added a comment.


  Using new TopArea element from PlasmaComponents

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76529=76530

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  Ok - I think I got it. I will try to create a generic PlasmaCore.TopArea 
element and use it here.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> mart wrote in ExpandedRepresentation.qml:48
> not in all places you will have access to a dialog. the magic correct values 
> should come from the toparea margins itself done to go well with the 
> correspoding background svg.
> 
> in the end, i would like to have this in a control... i kinda hope a standard 
> toolBar control (will need some special casing when that style is running in 
> plasma or an app in plasma mobile

Okay, I tried to create a new component for this on 
https://phabricator.kde.org/D27695. I did not use toolBar because it was 
already using a different svg, but if you think that's the best idea, I can 
investigate that

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This is supposed to add a top area to floating notifications:
  (just a sec)
  The result is not correct:
  (just a sec)
  Also, this is also applied to notifications in the notification list, which 
should instead remain unchanged:
  (just a sec)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove added a comment.


  Wait, are notifications ignoring dialog/background theme margins!?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27697

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove updated this revision to Diff 76543.
niccolove added a comment.


  Fix margins

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27697?vs=76533=76543

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove updated this revision to Diff 76571.
niccolove added a comment.


  Fixed margin

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27697?vs=76543=76571

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76374.
niccolove added a comment.


  Used toparea margins rather than systray dialog.margins

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=75095=76374

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> mart wrote in ExpandedRepresentation.qml:48
> not in all places you will have access to a dialog. the magic correct values 
> should come from the toparea margins itself done to go well with the 
> correspoding background svg.
> 
> in the end, i would like to have this in a control... i kinda hope a standard 
> toolBar control (will need some special casing when that style is running in 
> plasma or an app in plasma mobile

I've done the first part (the magic correct values should come from the toparea 
margins).

Regarding the control, I'm not sure how it could be done, since the usage of 
the toparea element changes a lot:

- On the systemtray, it includes a big header and buttons on the right
- On the notifications, it includes a small header / text and buttons on the 
right
- On kickoff, it should include the entire area with the profile picture, name 
and password.

How could that be done?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove added a comment.


  F8146611: Screenshot_20200303_103831.png 

  Seems aligned to me, the problem is that the new small checkbox has a margin 
to the left by default.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 76823.
niccolove added a comment.


  Make anchors fill parent

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76530=76823

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove updated this revision to Diff 76825.
niccolove added a comment.


  Components and rounding

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27697?vs=76674=76825

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27697

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26773: Added option to blur background on active window

[Niccolò Venerandi]

niccolove updated this revision to Diff 74439.
niccolove added a comment.


  Set all proper leftMargins to smallSpacing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26773?vs=73894=74439

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26773

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  wallpapers/image/imagepackage/contents/config/main.xml
  wallpapers/image/imagepackage/contents/ui/WindowModel.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml

To: niccolove, #plasma
Cc: mart, Zren, ngraham, anthonyfieroni, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D26945: Added smallSpacing to leftMargin

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  With the other two patches, this aims to make leftMargin consistent in 
plasmoids.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26945

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  With other two patches, this aims to make leftMargin consistent in widgets

REPOSITORY
  R120 Plasma Workspace

BRANCH
  smallspacingmargin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26946

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27159: Moved the header to the bottom

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Moved the header to the bottom, according to T10470 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  move_header_to_bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27159

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27143: moved do not disturb to the bottom

[Niccolò Venerandi]

niccolove updated this revision to Diff 75012.
niccolove added a comment.


  Renamed header to footer

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27143?vs=74956=75012

BRANCH
  bottom_notification_options (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27143

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove, ngraham, broulik, #plasma
Cc: gvgeo, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, ngraham, alexeymin, skadinna, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, ahiemstra, mbohlender, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  In D27189#606788 , @ndavis wrote:
  
  > .+1 to this idea. I noticed that the separator on the left is less dark. 
I'm not necessarily opposed to that, but is it intentional? Also, where is 
toparea.svg? I don't see it in `breeze/widgets/`
  
  
  The line color is accidental, I should fix that. The svg should be created 
(in a different patch, I thought?)
  The one I'm currently using is:
  F8088084: test.svg 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27194: Remove human avatars

[Niccolò Venerandi]

niccolove added a comment.


  +1

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27194

To: ndavis, #vdg
Cc: niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  In D27189#606914 , @ngraham wrote:
  
  > Yeah, so you'll want to submit a plasma-frameworks patch which includes the 
new SVG and mark this as depending on it.
  
  
  Okay
  
  > The reason why the text is now pushed over is because you added the new 
`PlasmaCore.FrameSvgItem` *inside* the `RowLayout` that contains the `Heading`. 
If anything the reverse should be true; the `RowLayout` should be inside the 
new header SVG.
  
  That can't be done as far as I know - elements are not displayed correctly 
when inside. Or maybe it's because I should use Layouts better?
  
  > Also you can't set anchors on an item inside a Layout; it causes binding 
loops. Anchors are only for positioning items that are outside of Layouts. 
Items inside Layouts get positioned using properties like `Layout.fillWidth, 
`Layout.Alignment`, `Layout.maximumWidth`, and so on.
  
  I'd do that, but as far as I know Layout does not support the negative margin 
I need to expand the area to the borders :-/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27143: moved do not disturb to the bottom

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  As per T10470 , I moved the notification 
do not disturb buttons to the bottom

TEST PLAN
  *just a sec*

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bottom_notification_options (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27143

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27144: Moved toggles to the bottom according to T10470

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REPOSITORY
  R97 Bluedevil

BRANCH
  move_toggle_to_bottom (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27144

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml
  src/applet/package/contents/ui/Toolbar.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove added a comment.


  I thought about this; so, I should remove margins from everywhere, and we add 
them to the desktop theme? I can make that patch

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26773: Added option to blur background on active window

[Niccolò Venerandi]

niccolove added a comment.


  Sorry, forgot I was on a arc feature already! Forget the last commit

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26773

To: niccolove, #plasma
Cc: mart, Zren, ngraham, anthonyfieroni, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove updated this revision to Diff 74443.
niccolove added a comment.


  Revert accidental line changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26946?vs=74441=74443

BRANCH
  smallspacingmargin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26946

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove updated this revision to Diff 76024.
niccolove added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26946?vs=74443=76024

BRANCH
  smallspacingmargin (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26946

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26945: Added smallSpacing to leftMargin

[Niccolò Venerandi]

niccolove updated this revision to Diff 76025.
niccolove added a comment.


  - Merge branch 'master' of https://anongit.kde.org/kscreen

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26945?vs=74438=76025

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26945

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml

To: niccolove, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26946: Changed leftMargins to smallSpacing to be consistent

[Niccolò Venerandi]

niccolove added a comment.


  In D26946#602022 , @ngraham wrote:
  
  > What I care about is that the margins are consistent and things are 
properly left-aligned by default. That is to say, nothing should have to 
override the default margins to have everything perfectly aligned.
  
  
  After trying a different solution, I'd suggest to go with these patches as a 
short term solution. I generally want to revise margins for desktop theme - so 
panels as well - but I'd like to see this fixed before that. Keep in mind that 
this is not overriding the margins, but just adding up to them, something that 
most of our applet do.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26946

To: niccolove, #vdg, #plasma
Cc: gvgeo, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Niccolò Venerandi]

niccolove added a comment.


  In D27436#612343 , 
@The-Feren-OS-Dev wrote:
  
  > To make it stretch to the borders, simply just remove padding from 
panel.svgz and from the Plasmoid highlight SVG.
  
  
  But themes should be able to set their padding, I can't just remove it. 
Rather, I was trying to give the effect a negative margin equal to the panel 
margin size.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Niccolò Venerandi]

niccolove added a comment.


  ...but that does not seem simple and would be inconsistent with the task 
view, so we might want to leave that for another patch

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Switch from tabs for pressed applets to tasks.
  
  - Tabs should be avoided because it's quite semantically incorrect and I need 
to change tab style in another patch to make them look prettier but that would 
break clicked plasmoids
  - Tasks appearance is consistent with the system tray that's next to it; 
plus, I think that it looks prettier than just a line. It should extend to 
borders, which I could add on next commit here

REPOSITORY
  R119 Plasma Desktop

BRANCH
  avoid_tabs_for_applets (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27436

AFFECTED FILES
  desktoppackage/contents/applet/CompactApplet.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  See D27444 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  I'm afraid I need help here, I can't figure out the layout.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26773: Added option to blur background on active window

[Niccolò Venerandi]

niccolove added a comment.


  I've tried to ask some users, and I received generally positive feedback on 
the idea, as many considered it pretty. There's a plugin that does this (with 
many positive reviews on the store), but I think it's not a good idea to fork 
very similar codebases, and this patch would make it much more discoverable by 
default. I just think it would be a pretty feature that users might like. I 
love it myself. It make the eye focus on the active window rather than the 
background.
  Example:
  F7892727: Screenshot_20200119_201932.png 

  F7892729: Screenshot_20200119_201957.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26773

To: niccolove, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26773: Added option to blur background on active window

[Niccolò Venerandi]

niccolove added a comment.


  Mh, but this is specifically to blur just the wallpaper, as you might want to 
get information from other windows. At that point, it would be weird for it to 
be a kwin effect, as it's much more related to just the wallpaper, and the user 
would expect it to be in the wallpaper settings.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26773

To: niccolove, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26773: Added option to blur background on active window

[Niccolò Venerandi]

niccolove added a comment.


  Yes, I *DID* take some code from Zren plugin and wrote some other. My 
intention was absolutely not to steal his code, I want to be clear about that: 
I had opened an issue on his repo asking him to upstream the code, but then I 
thought that it was probably simple enough that I could figure out how it could 
be implemented in master based on his code, and get back to him with the patch 
directly to make the whole process easier for him. I did not do that yet 
because this patch is missing some stuff, my intention was not to already 
submit the patch for landing, I tried to make that clear in the summary because 
I couldn't find the phab button to flag it as 'not done'. I opened the diff 
because I had already worked on it for 4/5 hours and did not want to keep 
changes on local, and keeping the open diff helps me remember what I'm working 
on, plus I wanted to know if there were objections to implementing the feature 
before spending more time on it.
  
  I now realize that submitting an half-finished task based on the zren code 
without much explanation gave the wrong impression, I'm sorry about this, and I 
hope that the explanation above clarifies it. My bad: I was really tired, in a 
hurry when submitting, and I had spent the whole afternoon on this (even 
reusing parts of zren's code, yes) so I just wanted to stop and study. Next 
time I'll be more careful.
  
  This said (IF ZREN WILL GIVE PERMISSION TO USE HIS CODE, of course!) I don't 
like the idea of doing a kwin effect instead because:
  
  - Since this directly affects just the wallpaper /desktop, I think that an 
user would expect this to be in the wallpaper/desktop configuration page. It is 
just a tickbox that can go inline with the 'Get new wallpapers...' but to the 
left, so it uses no space and does not clutter the UI
  - Having it in the kwin effects section, along many many other effects, would 
bring down drastically the discoverability of the option, which is a bit of a 
pity since it's the kind of thing that you don't usually look for, but might 
enjoy once you've seen it.
  
  Also, less important but I'm not sure at all I can manage to write a desktop 
effect about this, especially since (afaik) it uses  js plugins instead of QML, 
and I'm not sure how the blur could be implemented there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26773

To: niccolove, #plasma
Cc: ngraham, anthonyfieroni, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26773: Added option to blur background on active window

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Create an option, off by default, that blurs the wallpaper when it detecs an 
open window.
  Currently it broke the transition from one wallpaper to another.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26773

AFFECTED FILES
  wallpapers/image/imagepackage/contents/config/main.xml
  wallpapers/image/imagepackage/contents/ui/WindowModel.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27979: Added top area to notifications

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  Added the new PlasmoidHeading component to notifications, see:
  (...)
  This also adds it to the notifications in the history, which is not wanted.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_toparea

REVISION DETAIL
  https://phabricator.kde.org/D27979

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27697: WIP: Added top area to notification header

[Niccolò Venerandi]

niccolove added a comment.


  Opened another one due to i-messed-up-arc-again: 
https://phabricator.kde.org/D27979

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27697

To: niccolove, broulik, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77410.
niccolove added a comment.


  Trying to get rid of unrelated changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77409=77410

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77411.
niccolove added a comment.


  Second try of getting rid of unrelated changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77410=77411

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77412.
niccolove added a comment.


  Third one's a charm

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77411=77412

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77416.
niccolove added a comment.


  Trailing spaces

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77412=77416

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77409.
niccolove added a comment.


  - Merge branch 'master' into topbar

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=76823=77409

BRANCH
  topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77512.
niccolove added a comment.


  Removed head

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77510=77512

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77514.
niccolove added a comment.


  - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into 
systray_toparea
  

  
  remove unrelated change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77512=77514

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77510.
niccolove added a comment.


  - Merge branch 'master' of https://anongit.kde.org/plasma-workspace into 
systray_toparea

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77416=77510

BRANCH
  systray_toparea (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77203.
niccolove added a comment.


  Fixed double declaration

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77004=77203

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77212.
niccolove added a comment.


  rebase

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77203=77212

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77219.
niccolove added a comment.


  remove old highlight

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77218=77219

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  Should now work?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:24f2bd58bb5a: Use consistent highlight (authored by 
niccolove).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27824?vs=77002=77205

REVISION DETAIL
  https://phabricator.kde.org/D27824

AFFECTED FILES
  src/applet/package/contents/ui/DeviceItem.qml
  src/applet/package/contents/ui/FullRepresentation.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77217.
niccolove added a comment.


  remove old highlight

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77215=77217

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  CMakeLists.txt
  applet/contents/config/config.qml
  applet/contents/config/main.xml
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/configGeneral.qml
  applet/contents/ui/main.qml
  applet/metadata.desktop
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/kcm_networkmanagement.desktop
  kcm/qml/AddConnectionDialog.qml
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/ConnectionItem.qml
  kcm/qml/Dialog.qml
  kcm/qml/main.qml
  kded/modemmonitor.cpp
  kded/networkmanagement.desktop
  kded/networkmanagement.notifyrc
  kded/notification.cpp
  kded/portalmonitor.cpp
  kded/portalmonitor.h
  kded/service.cpp
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/declarative/enums.h
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/bondwidget.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv6widget.cpp
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/wifisecurity.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui
  libs/editor/settings/vlanwidget.cpp
  libs/editor/settings/wificonnectionwidget.cpp
  libs/editor/settings/wifisecurity.cpp
  libs/editor/settings/wifisecurity.h
  libs/editor/settings/wiredconnectionwidget.cpp
  libs/editor/settings/wiredconnectionwidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/widgets/passwordfield.cpp
  libs/editor/widgets/settingwidget.cpp
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  mobile/broadband/mobilebroadbandsettings.desktop
  mobile/broadband/package/metadata.desktop
  mobile/wifi/package/contents/ui/PasswordField.qml
  mobile/wifi/package/metadata.desktop
  mobile/wifi/wifisettings.desktop
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpadvanced.ui
  vpn/l2tp/l2tpadvancedwidget.cpp
  vpn/l2tp/l2tpadvancedwidget.h
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectauthworkerthread.cpp
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotectui.desktop
  vpn/openvpn/openvpnadvancedwidget.cpp
  vpn/ssh/plasmanetworkmanagement_sshui.desktop
  vpn/ssh/sshwidget.cpp

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77218.
niccolove added a comment.


  ops

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77217=77218

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27824: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  Wait, I think I understood the reason

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D27824

To: niccolove, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77214.
niccolove added a comment.


  rebase x2

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77212=77214

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  CMakeLists.txt
  applet/contents/config/config.qml
  applet/contents/config/main.xml
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/configGeneral.qml
  applet/contents/ui/main.qml
  applet/metadata.desktop
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/kcm_networkmanagement.desktop
  kcm/qml/AddConnectionDialog.qml
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/ConnectionItem.qml
  kcm/qml/Dialog.qml
  kcm/qml/main.qml
  kded/modemmonitor.cpp
  kded/networkmanagement.desktop
  kded/networkmanagement.notifyrc
  kded/notification.cpp
  kded/portalmonitor.cpp
  kded/portalmonitor.h
  kded/service.cpp
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/declarative/enums.h
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/bondwidget.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv6widget.cpp
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/wifisecurity.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui
  libs/editor/settings/vlanwidget.cpp
  libs/editor/settings/wificonnectionwidget.cpp
  libs/editor/settings/wifisecurity.cpp
  libs/editor/settings/wifisecurity.h
  libs/editor/settings/wiredconnectionwidget.cpp
  libs/editor/settings/wiredconnectionwidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/widgets/passwordfield.cpp
  libs/editor/widgets/settingwidget.cpp
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  mobile/broadband/mobilebroadbandsettings.desktop
  mobile/broadband/package/metadata.desktop
  mobile/wifi/package/contents/ui/PasswordField.qml
  mobile/wifi/package/metadata.desktop
  mobile/wifi/wifisettings.desktop
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpadvanced.ui
  vpn/l2tp/l2tpadvancedwidget.cpp
  vpn/l2tp/l2tpadvancedwidget.h
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectauthworkerthread.cpp
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotectui.desktop
  vpn/openvpn/openvpnadvancedwidget.cpp
  vpn/ssh/plasmanetworkmanagement_sshui.desktop
  vpn/ssh/sshwidget.cpp

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  well fuck.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77215.
niccolove added a comment.


  rebase x3

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77214=77215

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77254.
niccolove added a comment.


  ops

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77253=77254

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove updated this revision to Diff 77253.
niccolove added a comment.


  fixed name of list

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77219=77253

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  CMakeLists.txt
  applet/contents/config/config.qml
  applet/contents/config/main.xml
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/configGeneral.qml
  applet/contents/ui/main.qml
  applet/metadata.desktop
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/kcm_networkmanagement.desktop
  kcm/qml/AddConnectionDialog.qml
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/ConnectionItem.qml
  kcm/qml/Dialog.qml
  kcm/qml/main.qml
  kded/modemmonitor.cpp
  kded/networkmanagement.desktop
  kded/networkmanagement.notifyrc
  kded/notification.cpp
  kded/portalmonitor.cpp
  kded/portalmonitor.h
  kded/service.cpp
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/declarative/enums.h
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/bondwidget.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv6widget.cpp
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/wifisecurity.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui
  libs/editor/settings/vlanwidget.cpp
  libs/editor/settings/wificonnectionwidget.cpp
  libs/editor/settings/wifisecurity.cpp
  libs/editor/settings/wifisecurity.h
  libs/editor/settings/wiredconnectionwidget.cpp
  libs/editor/settings/wiredconnectionwidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/widgets/passwordfield.cpp
  libs/editor/widgets/settingwidget.cpp
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  mobile/broadband/mobilebroadbandsettings.desktop
  mobile/broadband/package/metadata.desktop
  mobile/wifi/package/contents/ui/PasswordField.qml
  mobile/wifi/package/metadata.desktop
  mobile/wifi/wifisettings.desktop
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpadvanced.ui
  vpn/l2tp/l2tpadvancedwidget.cpp
  vpn/l2tp/l2tpadvancedwidget.h
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectauthworkerthread.cpp
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotectui.desktop
  vpn/openvpn/openvpnadvancedwidget.cpp
  vpn/ssh/plasmanetworkmanagement_sshui.desktop
  vpn/ssh/sshwidget.cpp

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

[Niccolò Venerandi]

niccolove added a comment.


  Sorry, I had different files with different versions. Now it shows correctly 
for me, with all files up to date. That said, is it normal that:
  F8167163: image.png 
  
  - the top elements has a top separator
  - icon size of the second element is smaller
  
  ? seems wrong to me, but not because of this patch

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27436: Use task rather than tabs

[Niccolò Venerandi]

niccolove added a comment.


  Actually, after some use, I don't think this is the best effect to use. I 
will investigate more.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  avoid_tabs_for_applets (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27436

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f4195688e68e: Created a top area based on 
widgets/toparea.svg (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27189?vs=77514=77628

REVISION DETAIL
  https://phabricator.kde.org/D27189

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  Weird. I can't reproduce, neither in my compiled nor stable install:
  F8176254: Screenshot_20200314_233208.png 

  But then again, apparently it's not master-y master, so maybe something 
changed?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27189: Created a top area based on widgets/toparea.svg

[Niccolò Venerandi]

niccolove added a comment.


  I think I have the old network manager. I will submit patches.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27979: [WIP] Add top area to notifications

[Niccolò Venerandi]

niccolove added a comment.


  In D27979#625809 , @broulik wrote:
  
  > Please also test with icons and configure button, I use 
https://tests.peter.sh/notification-generator/ which can generate a multitude 
of test notifications
  
  
  Yepp, I did test it with various notifications.
  
  In D27979#625865 , @ngraham wrote:
  
  > Please test to make sure that your patches work :)
  
  
  I do! But since I was unable to add that class to my local framework, I 
tested it by putting the PlasmoidHeading in the same folder and using 
"PlasmoidHeading" instead of "PlasmaExtras.PlasmoidHeading". Then I replaced it 
to make the diff, but got the name wrong.
  
  Anyway - the main thing missing in this task is how to avoid broke history - 
do you have any tip on how I could address it?
  F8170937: Screenshot_20200311_173516.png 


INLINE COMMENTS

> ngraham wrote in NotificationItem.qml:119
> there are spaces on this line

I set up Kate to show trailing spaces now, so I should stop putting them 
accidentally.

> broulik wrote in NotificationPopup.qml:168
> You know I'm not a fan of randomly dividing sizes

What should I use? 0 is too small, while the entire margin is too big.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27979

To: niccolove, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28627: Adaptive panel opacity

[Niccolò Venerandi]

niccolove added a comment.


  I feel like it makes sense for the user to want to use a opaque panel rather 
than a transparent one. Also, that relies on themes actually turning on the 
effect, while users could already benefit from it even on current themes if the 
setting was exposed. Also, that allows for making only some panels adaptive, 
unity-stile.  However, as far as I know, there's no [easy] way to detect 
transparency from the theme. I might be wrong here.
  
  - During the transition from transparent to opaque, the panel becomes 
immediately gray and then trasitions. I guess that's because you turn off blur 
at the beginning of the animation?
  - This should also be implemented for plasmoids popups as well, in order for 
them to integrate correctly:
  
  F8234048: Screenshot_20200413_171827.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28627

To: cblack, #plasma, davidedmundson, niccolove, #vdg
Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28873: Add SwipeNavigator component

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> mart wrote in SwipeNavigator.qml:55
> different tabbars should really depend only on whether it's a mobile device 
> or not (and be at bottom if mobile): a very small window on desktop is not a 
> mobile app

I think the tabbar should not be at the bottom on mobile. It's not necessary to 
touch the control as swiping from any point of the page should change the page, 
it is more visible when put at top, it is more consistent with kde and not-kde 
applications and introduces a position inconsistency between devices 
(touchscreen laptops should also be taken into consideration).

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28873

To: cblack, #kirigami, #vdg
Cc: niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D28575: Make headings of systray and applet merge

[Niccolò Venerandi]

niccolove updated this revision to Diff 80313.
niccolove added a comment.


  Only merge if header is actually visible

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=79483=80313

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra