D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

Pitel added a comment. @martinkostolny I will try to give it some testing this week. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11071 To: Pitel, #plasma, martinkostolny Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D7537: KDE logout screen - change black icons & texts to white/greyish

Pitel added a comment. I finally found what was wrong here: the background should not be black when button background color is light but the calculation introduced by D5036 is wrong. My attempt to fix it is D11262 .

D7537: KDE logout screen - change black icons & texts to white/greyish

Pitel added a comment. @mvourlakos I did some more testing and I am really confused. The important color seems to be button text color in Plasma theme setting. Results: With `colorGroup: PlasmaCore.Theme.ComplementaryColorGroup` (which is currently hardcoded): - with white button

D7537: KDE logout screen - change black icons & texts to white/greyish

Pitel added a comment. I guess I am not that confused anymore -- with normal color group the color of text (outside of buttons) is determined by text color theme setting but with complementary group by button text color. I think correct solution would be to construct `ColorScope` with

D11262: KDE logout screen background color fix

Pitel added a comment. With dark button background as it used to F5750710: Screenshot_20180312_151959.png but if you choose some crazy combination (like black text on green background) it will also work (without this patch the background here would be

D11262: KDE logout screen background color fix

Pitel added a comment. In D11262#224113 , @ngraham wrote: > Would you be interested in producing similar patches for the Lock and Login screens, which suffer from the same issue? > > - Login screen:

D11262: KDE logout screen background color fix

Pitel created this revision. Pitel added reviewers: mart, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY The patch D5036 did calculate

D10944: [taskmanager applet] Do not fill width

Pitel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY Make task mananger applet use only space it needs and not eat more - it looks better with global

D11292: [RFC] Ordered system tray v2

Pitel added a comment. I am aware of `getFixedItemId`, only forgot to mention it in summary. Right now it is not included mostly because it is another hack (but fixing stupid behavior of someone else so unavoidable) and I do not use DropBox, but if this gets any closer to landing, we should

D11262: KDE logout screen background color fix

Pitel added a comment. I see that relative luminance formula is more correct but I would like to point out that we do not need here to calculate precise luminance. The point of the `?:` statement is to collapse colors close to back to real black because gray overlay with 50 % opacity does

D10944: [taskmanager applet] Do not fill width

Pitel added a comment. Ping. The current version adds a configuration option `fillWidth` (enabled by default) which allows the applet to grow beyond its preferred size. I tested it in usual setup and with `fillWidth` enabled the behavior is unchanged. REPOSITORY R119 Plasma Desktop

D11292: [RFC] Ordered system tray v2

Pitel added a comment. In D11292#225006 , @davidedmundson wrote: > FWIW, the crash you're referring to is also fixed with an up-to-date (not released yet) Qt. If you are referring to https://codereview.qt-project.org/#/c/50/ I tried

D11292: [RFC] Ordered system tray v2

Pitel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY My try at ordered system try heavily inspired by D11233 .

D11233: Ordered system tray

Pitel added a comment. I really like the idea of being able to reorder the systray as I wish. I could not resist and took my stab on the issue (with drag) D11292 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11233

D11292: [RFC] Ordered system tray v2

Pitel updated this revision to Diff 29457. Pitel added a comment. - modified `onConfigurationChanged` so it triggers updates of properties depending on `cfg_shownItems` and `cfg_hiddenItems` - make trash bin not draggable - removed `ComboBox` hack (which was not working anyway) and added

D10944: [taskmanager applet] Do not fill width

Pitel added a comment. Ahh sorry I misunderstood you. Moving this option to containment level seems reasonable although I'm not sure for how many other applets it might be useful -- except taskbar and Active Windows Control (the global menu applet in my screen shot and it already has this

D10944: [taskmanager applet] Do not fill width

Pitel added a comment. I understand you do not like adding options that you do not like adding options adjust think which should be configured on another level. But to be able to configure filling empty space at level of panel applets must not claim they need more space than they really do

D11352: [RFC] Auto ordered systray

Pitel added a comment. In D11352#227065 , @wsdfhjxc wrote: > Doesn't seem to work for me. Only Notifications item is visible by default while there are multiple items set to be shown in the configuration. Also, changing the visibility state

D7537: KDE logout screen - change black icons & texts to white/greyish

Pitel added a comment. I have the same problem in 5.12.2 release. I think the root of it is assuming that foreground in `PlasmaCore.Theme.ComplementaryColorGroup` is white(ish) and background is dark (this is true only if normal color scheme uses dark text on light background, which is

D11308: Use the default Plasma wallpaper on the lock screen

Pitel added a comment. +1 for picture instead of blue. With the current UI I would really appreciate option to choose text color independently on plasma color scheme (and such option would solve any static picture). Other possibility I was thinking about was 50 % opaque (default black)

D10837: bad textarea width for rename file if filename too short

Pitel added a comment. @painlessroaster is not me. What gave you impression he is? REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma, hein Cc: Pitel, cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed,

D11072: [Active Window Control] Show window title when app name is missing

Pitel added a comment. I do not have write access. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11072 To: Pitel, #plasma, martinkostolny Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11352: [RFC] Auto ordered systray

Pitel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY @mart dislikes idea of manually ordering the systray (D11233 ,

D11292: [RFC] Ordered system tray v2

Pitel added a comment. To compare with auto ordering (as @mart would like) see D11352 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11292 To: Pitel, #plasma, #vdg Cc: mart, zzag, davidedmundson, anthonyfieroni,

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

Pitel added a comment. The patch definitely can wait until you finish the rework. A few thoughts that crossed my mind when reading proposed changes: - I really like the standalone basic items placed by drag and drop. - Is floating really floating or just another layer of occupying?

D11065: [Active Window Control] Slightly fix vertical alignment of window name

Pitel updated this revision to Diff 28886. Pitel added a comment. Moving appmenu instead of window title. REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11065?vs=28738=28886 BRANCH realign REVISION DETAIL

D11072: [Active Window Control] Show window title when app name is missing

Pitel added a comment. Do I need to do anything to make it land? REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11072 To: Pitel, #plasma, martinkostolny Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 30728. Pitel added a comment. - Remove QtQuick.Controls import (was needed only by Checkbox) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11410?vs=30555=30728 BRANCH fixedSizeOverride REVISION DETAIL

D11262: KDE logout screen background color fix

Pitel added a comment. I finally got to do some testing and it is not looking good for luminance formula `0.2126*r + 0.7152*g + 0.0722*b`. Screenshot with background color `#5500FF` (blueish, button background on picture), you can see that black text is readable on it, but it has

D11262: KDE logout screen background color fix

This revision was automatically updated to reflect the committed changes. Closed by commit R120:af2a74341d5f: KDE logout screen background color fix (authored by Pitel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11262?vs=29324=30937 REVISION

D11262: KDE logout screen background color fix

Pitel added a comment. It is meant as one. I am still kinda new here, so I am not exactly sure how to that (without confusing Phabricator). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: fvogt, cfeck, fredrik, ngraham,

D11262: KDE logout screen background color fix

Pitel added a comment. I guess I should have renamed it from `isLightColor` to something like `isNotAlmostBlack`... The point was to replace almost black colors with real black because it looks better with opacity. IMHO `(0,0,128)`, which is deep blue, is far enough from black to not mess

D11262: KDE logout screen background color fix

Pitel added a comment. It also should be in `Plasma/5.12` now. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11262 To: Pitel, mart, #plasma Cc: ragreen, fvogt, cfeck, fredrik, ngraham, abetts, broulik, mvourlakos, plasma-devel, ZrenBot, lesliezhai,

D11262: KDE logout screen background color fix

Pitel added a comment. In D11262#237099 , @ragreen wrote: > > I am not sure what artifacts is he referring to (but I am usually blind to this kind of issues)... > > I'm not. I did not mean that I want to ignore them, I just need them

D11262: KDE logout screen background color fix

Pitel added a comment. @ragreen I am sorry to disappoint but this patch does not remove the (usually black) half-opaque overlay the G+ post refers to. It only changes its color to button background color in the case that button background color is too far from black to make sure the text is

D11021: [Media controller] Add simple volume control

Pitel updated this revision to Diff 30963. Pitel added a comment. Convert `changeVolume` helper into a Job... Right now it does not check wheter the DBus call is successful - I tried to wire it in but ended with segfault. I will investigate it further. Except that I hope it is ok.

D11065: [Active Window Control] Slightly fix vertical alignment of window name

This revision was automatically updated to reflect the committed changes. Closed by commit R884:1119c47f1756: [Active Window Control] Slightly fix vertical alignment of window name (authored by Pitel). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE

D11072: [Active Window Control] Show window title when app name is missing

This revision was automatically updated to reflect the committed changes. Closed by commit R884:f48d5afac734: Show window title when app name is missing (authored by Pitel). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE

D11352: [RFC] Auto ordered systray

Pitel added inline comments. INLINE COMMENTS > Pitel wrote in AbstractItem.qml:80 > Probably not, I have not observed any problems even without this rule, I just > wanted to be safe. I see that I can use `applet.id` or even > `applet.pluginName` as there should be at most one instace of given

D11352: [RFC] Auto ordered systray

Pitel updated this revision to Diff 30859. Pitel added a comment. - Remove debug print REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11352?vs=30111=30859 BRANCH stableSystray2 REVISION DETAIL https://phabricator.kde.org/D11352 AFFECTED

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

Pitel added a comment. >> show on: mouse out | mouse in | always (and possibly never show unless it is covered by other options, show on mouse out not available for buttons and appmenu) > > This one I don't fully understand. Why show on: mouse_out|mouse_in for all items is not enough

D11746: Assign notification area category

Pitel added a comment. @wsdfhjxc can you land it yourself or should I do it? I would like to land this, D11748 , D11749 , D11750 , and D11751 , so

D11021: [Media controller] Add simple volume control

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bd5619e0155a: [Media controller] Add simple volume control (authored by Pitel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11021?vs=30963=31231

D11410: [RFC] Add option to make applet fixed width

Pitel added inline comments. INLINE COMMENTS > mart wrote in ConfigOverlay.qml:385 > this will probably need as well > currentApplet.applet.pluginName == "org.kde.plasma.panelspacer" > > or it gets lost when the spacer is configured as not expanding and i guess > the spacer is special and we

D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 31036. Pitel added a comment. Fix tooltip text. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11410?vs=30728=31036 BRANCH fixedSizeOverride REVISION DETAIL https://phabricator.kde.org/D11410 AFFECTED FILES

D11352: [RFC] Auto ordered systray

Pitel added a comment. > i would prefer the final version to be quiet Sure. INLINE COMMENTS > mart wrote in AbstractItem.qml:80 > This is probably not necessary: both plasmoids and statusnotifieritems have > ids that you can access (numeric for plasmoids, alphanumeric for >

D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 30555. Pitel added a comment. - Replace checkbox with a checkable button - Add support for panel spacer -- currently we just check whether the applet is panel spacer and if it is we use `applet.configuration.expanding` instead of our `fixedSizeOverride`.

D11352: [RFC] Auto ordered systray

Pitel planned changes to this revision. Pitel added a comment. Ok, that looks that I did screw something. Time to investigate... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11352 To: Pitel Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai,

D11352: [RFC] Auto ordered systray

Pitel updated this revision to Diff 29690. Pitel added a comment. @mart you were very right to point out the `callLater` because that is exactly what was broken. The code assumed that all calls of `callLater` with different arguments are executed but in fact only those eith different

D11352: [RFC] Auto ordered systray

Pitel updated this revision to Diff 29973. Pitel added a comment. - put UnknownCategory first - treat applets with category not in the list as UnknownCategory - split reorderItem function into two - add temporary hack whcih allows overriding applet's category (applets with wrong

D11021: [Media controller] Add simple volume control

Pitel added inline comments. INLINE COMMENTS > broulik wrote in multiplexedservice.h:38 > Shouldn't this be a job? So you use the `startOperationCall` stuff used > elsewhere (for e.g. Play and so on) I guess it would look more consistent if it was a job but somehow I fail to see why any of

D11352: [RFC] Auto ordered systray

Pitel updated this revision to Diff 29977. Pitel added a comment. ty, updated REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11352?vs=29973=29977 BRANCH stableSystray2 REVISION DETAIL https://phabricator.kde.org/D11352 AFFECTED FILES

D11021: [Media controller] Add simple volume control

Pitel added a comment. ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma, broulik Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 29940. Pitel added a comment. In D11410#229277 , @mart wrote: > it's moving on the right track.. i would like the checkbox to appear like the one in the panel spacer, in the context menu could be tricky as

D11352: [RFC] Auto ordered systray

Pitel updated this revision to Diff 30111. Pitel added a comment. Great, but I found one more bug (and it affected order of items). This fixes it. - Add tie breaking (for the unlikely case of the same category & text) - Add debug print - Fix sorting algorithm (the order was wrong if

D11292: [RFC] Ordered system tray v2

Pitel abandoned this revision. Pitel added a comment. Replaced by D11352 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11292 To: Pitel, #plasma, #vdg Cc: mart, zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham,

D11352: [RFC] Auto ordered systray

Pitel added a comment. I am using Czech translation and I am satisfied with item order (but I keep only a few items in my systray). I like the current rule because it is simple and have some internal logic (even though it might not be obvious what the `text` of an applet is) and it is not

D11410: [RFC] Add option to make applet fixed width

Pitel added a comment. Also do we want this or two options instead: - no expanding: `maximumWidth = preferredWidth`, and - no shrinking: `minimumWidth = preferredWidth`? Because when attempting to use `fillWidth = false` with full version of task manager it will probably overflow

D11410: [RFC] Add option to make applet fixed width

Pitel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY @hein refused D10944 with wish to move the config option to

D10944: [taskmanager applet] Do not fill width

Pitel abandoned this revision. Pitel added a comment. Replaced by D11410 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10944 To: Pitel, ngraham, mart Cc: hein, mart, ngraham, plasma-devel, #plasma, ZrenBot, lesliezhai,

D11352: [RFC] Auto ordered systray

Pitel added a comment. I guess Phabricator does not let me only respond to inline comments. INLINE COMMENTS > mart wrote in main.qml:65 > as convention we usually don't have getFoo as names (and this is not getting > a property anyways) > i would like a more descriptive name like

D11352: [RFC] Auto ordered systray

Pitel added a comment. Phabricator:Pitel 2:0 INLINE COMMENTS > mart wrote in AbstractItem.qml:81 > what's the reson for using callLater? The main reason is to avoid calling `updateItemVisibility` from itself which might happen if `stackAfter` fires the `onParentChanged` event at wrong

D11021: [Media contoller] Add simple volume control

Pitel created this revision. Pitel added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY Add simple volume control to Media Controller applet. Volume can by

D11021: [Media contoller] Add simple volume control

Pitel added a comment. The idea crossed my mind but I rarely use expanded version of the applet and there are two problems to deal with: - Where exactly to place the slider (I am bad at designing UI). - What should upper bound of slider be -- usually 1 is good option but mpris does

D11021: [Media controller] Add simple volume control

Pitel retitled this revision from "[Media contoller] Add simple volume control" to "[Media controller] Add simple volume control". REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai,

D11021: [Media controller] Add simple volume control

Pitel edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11021: [Media controller] Add simple volume control

Pitel added a reviewer: broulik. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma, broulik Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11021: [Media controller] Add simple volume control

Pitel edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma, broulik Cc: broulik, nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11021: [Media controller] Add simple volume control

Pitel updated this revision to Diff 28701. Pitel added a comment. - Added OSD support. - Refactored osd & volume bounding logic into helper `MultiplexedService::changeVolume`. Is there any way to get player name & icon without adding `PlayerControl::container`? REPOSITORY R120

D11021: [Media controller] Add simple volume control

Pitel updated this revision to Diff 28729. Pitel added a comment. The `changeVolume` helper must be in `PlayerControl` class and `MultiplexedService` must only forward calls to it in order to volume change by mouse wheel also work for other sources than only mutliplex one. REPOSITORY R120

D11065: [Active Window Control] Slightly fix vertical alignment of window name

Pitel created this revision. Pitel added reviewers: Plasma, martinkostolny. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY On my setup the window label was 1px lower than global

D11065: [Active Window Control] Slightly fix vertical alignment of window name

Pitel added a comment. Would it be better to move global menu 1px down instead? PlasmaComponents.Label { id: appmenuButtonTitle -anchors.centerIn: appmenuButtonBackground +anchors.top:

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

Pitel created this revision. Pitel added reviewers: Plasma, martinkostolny. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY Currently global menu is always aligned on the other

D11072: [Active Window Control] Show window title when app name is missing

Pitel created this revision. Pitel added reviewers: Plasma, martinkostolny. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY Some apps do not have application name (e.g. Android

D11073: [RFC] [Active Window Control] Elide appmenu when it is too long

Pitel created this revision. Pitel added reviewers: Plasma, martinkostolny. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY When appmenu is too large to fit in and "»" button

D10944: [taskmanager applet] Do not fill width

Pitel added a comment. Not really -- if I understand correctly allocating space works following way: All widgets get space they claim they need and the surplus is split among widgets with fillWidth == true in ratio which seems proportinal to width of given widgets. So even if global menu

D10944: [taskmanager applet] Do not fill width

Pitel added a comment. Screenshots with Global Menu applet (panel contains Global menu, growing Spacer and icon taskmanager). Old: F5736170: Screenshot_20180302_112934.png New: F5736172: Screenshot_20180302_112956.png

D10944: [taskmanager applet] Do not fill width

Pitel updated this revision to Diff 28345. Pitel added a comment. Choice whether to fill or not fill width was turned into config option and i possible to set (and used) only for iconsOnly version of taskmanager. Screenshot with original behavior: F5735025:

D10944: [taskmanager applet] Do not fill width

Pitel updated this revision to Diff 28405. Pitel added a comment. In previous revisions I used fillWidth = false but it is wrong because it not only prevents expanding but also it prevents applet from shrinking. So use Layout.maximumWidth = Layout.preferredWidth instead. Also after further

D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 66260. Pitel added a comment. Reabse & polish UI REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11410?vs=31036=66260 BRANCH fixedSizeOverride2 REVISION DETAIL https://phabricator.kde.org/D11410 AFFECTED

D11352: [RFC] Auto ordered systray

Pitel updated this revision to Diff 66209. Pitel added a comment. Rebase on current master and squash REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11352?vs=30859=66209 BRANCH stableSystray2 REVISION DETAIL