D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

bruns added a comment. In D13291#314195 , @smithjd wrote: > kioclient5 ls settings:/ > system-administration > > dolphin settings:/ > System Administration In dolphin, you can click on "System Administration". With kioclient5, I c

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

bruns added a comment. In D13291#314195 , @smithjd wrote: > kioclient5 ls settings:/ > system-administration > > dolphin settings:/ > System Administration That belongs into the test plan, of course with the needed context. REPOS

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

bruns added a comment. Can you please give an example? 1. Exact command 2. Current output 3. Expected output REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D13291 To: smithjd, #plasma Cc: bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, ngra

D14806: [AppStream Runner] Reduce verbosity of log output

bruns requested review of this revision. bruns added a comment. Why should I squash the commits? Each one: - compiles **and** works on its own - addresses a slightly different issue Citing from https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets > OTOH,

D14807: [AppStream Runner] Also search when there were errors during Pool::load

bruns updated this revision to Diff 40160. bruns edited the test plan for this revision. bruns added a comment. Remove from patch stack, apply first REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14807?vs=39637&id=40160 REVISION DETAIL https://p

D14807: [AppStream Runner] Also search when there were errors during Pool::load

bruns added a comment. Citing from https://community.kde.org/Policies/Commit_Policy#Commit_complete_changesets > OTOH, commits should be preferably "atomic" - not splittable. That means that every bugfix, feature, refactoring or reformatting should go into an own commit. This, too, impr

D14807: [AppStream Runner] Also search when there were errors during Pool::load

bruns added a comment. In D14807#309460 , @apol wrote: > This is outright weird, please send just one patch with the feature and the logging and without the wrong lines. Which wrong lines? Why should I squash the commits? Each one:

D14807: [AppStream Runner] Also search when there were errors during Pool::load

bruns created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The return code of the Pool::load() method is somewhat misleading, as it returns true only if there we

D14806: [AppStream Runner] Reduce verbosity of log output

bruns created this revision. bruns added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Its rather pointless to spew an error message each time a query is done.

D14805: [AppStream Runner] Use categorized logging

bruns created this revision. bruns added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Add category org.kde.plasma.runner.appstream, like done for the Services

D14804: [AppStream Runner] Pass on error message from the library

bruns created this revision. bruns added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY AppStreamQt since 0.10.6 allows to pass on error messages in case some

D12498: Fully remove `Application Name` from Details panel

bruns added a comment. In D12498#296546 , @ngraham wrote: > Darn, that's a shame. "Not Provided" it is, then. @bruns, are you okay with this? Either > 'Description' not provided, please file a bug report or > 'Description'

D12498: Fully remove `Application Name` from Details panel

bruns added a comment. In D12498#296414 , @ngraham wrote: > ... but I'd still prefer something a little bit more descriptive like "Not provided by " The problem is you can not really know the application. While often the Action-ID is de

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

bruns added a comment. New revision with remaining tasks: D12498 REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12479 To: sharvey, davidedmundson, ngraham, #plasma Cc: bruns, abetts, plasma-devel, #plasma, ra

D12498: Fully remove `Application Name` from Details panel

bruns added a comment. In D12498#278422 , @ngraham wrote: > Looks good to me, though the string needs to make clear that the bug report should go to the 3rd-party app developer, not to us! Otherwise we'll get a bunch of un-actionable bugs.

D12498: Fully remove `Application Name` from Details panel

bruns added a comment. In D12498#278380 , @ngraham wrote: > Ah yeah, that makes sense. Instead of "Missing", how about "Not available; please file a bug with the developer of this software" ...Or something like that. Somewhat to verbose

D12498: Fully remove `Application Name` from Details panel

bruns added a comment. In D12498#278285 , @ngraham wrote: > This concept (and the proposed label) is suitable for a developer audience, not a regular user audience. > > We have the same issue in Discover when upstreams don't ship enough ApSt

D12498: Fully remove `Application Name` from Details panel

bruns added a comment. In D12498#272379 , @ngraham wrote: > I feel like if we go with "missing", users will blame us and we'll get bug reports ("If it's missing, why can't you provide it? Duh!"). Its simple "We can not provide it because

D12498: Fully remove `Application Name` from Details panel

bruns added a comment. @sharvey can you address the remaining nitpicks? INLINE COMMENTS > sharvey wrote in AuthDialog.cpp:349 > I was checking to see if this was still open, and would like to discuss > "Missing". I considered "Missing" while I was originally coding this, but > thought it so

D12641: Workaround Device Notifier showing an error despite volume being mounted correctly

bruns added a comment. -1 Coding style - you could use a lambda here Lacking comment, as its not obvious why the code is needed parent revision is missing ... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12641 To: mlibera, #plasma, broulik, #fram

D12498: Fully remove `Application Name` from Details panel

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > authdetails.ui:26 > > - Action: > + Action ID: > Can you also change it for the placeholder label (row 2, col 1) - convention is to set

D12498: Fully remove `Application Name` from Details panel

bruns added inline comments. INLINE COMMENTS > AuthDialog.cpp:345 > // neither isEmpty() or isNull() worked (?) > if (actionDescription.description() == "") { > QFont descrFont(action_label->font()); ` == ""` should be identical to .isEmpty(), please recheck > AuthDialog.cpp:

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. In D12311#252212 , @stikonas wrote: > In D12311#252165 , @bruns wrote: > > > Resizing: http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#g

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. In D12311#250731 , @stikonas wrote: > In D12311#250688 , @bruns wrote: > > > Gnome-disks does, and so do other programs. > > > Gnome-disks uses UDisks to do everything and

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. Gnome-disks does, and so do other programs. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, brun

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. Its not available otherwise ... REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D12311 To: sharvey, davidedmundson, ngraham, abetts, #frameworks Cc: stikonas, bruns, ltoscano,

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. No, thats completely off, as thats the action you are authorizing. > Authorization is required to format disk WDC WD10EZEX-08M2NA0 I want it to show what it is asking permission for, and to be specific - does it want to format the USB stick I just inserted, or

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. Btw, an easy way to trigger the dialog is e.g. $> pkcheck -u -p $$ -a org.freedesktop.udisks2.eject-media-system $$ is the PID of the shell. REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH align-lock-icon (branched from master) REVISION DETAIL htt

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. The "Authentication is required to ..." header line is directly sourced from the action definition below `/usr/share/polkit-1/actions/*` "Administrator password" is insufficient/wrong, as you can also (dependent on system configuration) authorize the actions as ano

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. If you really want to save some space (and probably make it easier for users to understand the dialog without getting lost), I think the whole > An application is attempting to perform an action that requires privileges. > Authentication is required to perform th

D12050: Make automounting work even if StorageAccess is ignored

bruns added a comment. Well, I really do not like what arc is doing behind my back ... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12050 To: bruns, ngraham, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D12050: Make automounting work even if StorageAccess is ignored

bruns added a comment. damn, that did not work as expected ... landed on master should I just "arc land --onto Plasma/5.12" ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12050 To: bruns, ngraham, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot

D12050: Make automounting work even if StorageAccess is ignored

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8dedbcdf4197: Make automounting work even if StorageAccess is ignored (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12050?vs=31695&id=3

D12050: Make automounting work even if StorageAccess is ignored

bruns added a comment. In D12050#242755 , @ngraham wrote: > Did you mean BUG: 391706? No, this commit *fixes* 389479, but it is a prerequisite for fixing 391706 (which is essentially a revert, thus would regress 389479). REPOSITORY R11

D12050: Make automounting work even if StorageAccess is ignored

bruns created this revision. bruns added a reviewer: ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY There is no reason to make mounting dependent on the StorageAccess.igno

D7770: [lookandfeel] Fix GLES incompatibilities in UserDelegate shader code

This revision was automatically updated to reflect the committed changes. Closed by commit R120:129884c7b02f: [lookandfeel] Fix GLES incompatibilities in UserDelegate shader code (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7770

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

This revision was automatically updated to reflect the committed changes. Closed by commit R245:f299edfeb8fd: [solid/fstab] Swap vendor and product properties, allow i18n of description (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7773?vs=

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

This revision was automatically updated to reflect the committed changes. Closed by commit R245:9929fc8fbdcb: [solid/fstab] Add support for x-gvfs style options in fstab (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7774?vs=19458&id=19949

D7770: [lookandfeel] Fix GLES incompatibilities in UserDelegate shader code

bruns added a task: T7071: Fragment shader in UserDelegate.qml is not GLSL/ES compatible, missing precision specifier. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7770 To: bruns, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu

T7071: Fragment shader in UserDelegate.qml is not GLSL/ES compatible, missing precision specifier

bruns reassigned this task from bruns to plasma-devel. TASK DETAIL https://phabricator.kde.org/T7071 To: plasma-devel, bruns Cc: bruns, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

bruns updated this revision to Diff 19458. bruns added a comment. Remove erroneous const, takeFirst requires a mutable list REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7774?vs=19418&id=19458 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

bruns added a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7774 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterber

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns added a dependent revision: D7774: [solid/fstab] Add support for x-gvfs style options in fstab. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7773 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abett

D7774: [solid/fstab] Add support for x-gvfs style options in fstab

bruns created this revision. bruns added projects: Plasma, Frameworks. REVISION SUMMARY This fstab options allows an administrator to specify names and icons intended for the user, shown in a GUI For details, see https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/what-is-shown.txt REPO

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns removed a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterb

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns removed a dependent revision: D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7773 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jen

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns added a dependent revision: D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7773 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensr

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns added a dependency: D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterber

D7773: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns created this revision. bruns added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The fstab backend exposes server and sharename as product and vendor properties, but had the meaning backwards (the product is subordinate

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns abandoned this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7772 To: bruns, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7772: [solid/fstab] Swap vendor and product properties, allow i18n of description

bruns created this revision. bruns added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The fstab backend exposes server and sharename as product and vendor properties, but had the meaning backwards (the product is subordinate

D7770: [lookandfeel] Fix GLES incompatibilities in UserDelegate shader code

bruns created this revision. bruns added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 382668 The shader compilation currently fails on GLES with errors like: "0:6(2): error: No precision specified in this scope for type `vec4'" GLE

D5034: Add support for x-gvfs style options in fstab

bruns added inline comments. INLINE COMMENTS > fstabstorageaccess.cpp:48 > > +const QStringList &options = FstabHandling::options(device->device()); > +// GVFS by default doesn't show devices outside of /media, $HOME (and > some other locations) Another useless use of const QList&, Fs

D5034: Add support for x-gvfs style options in fstab

bruns added inline comments. INLINE COMMENTS > fstabdevice.cpp:47 > > -m_description = m_vendor + " on " + m_product; > +const QStringList &gvfsOptions = > FstabHandling::options(m_device).filter("x-gvfs-"); > + Why QStringList& instead of QStringList? > fstabdevice.cpp:51 > +

Re: Review Request 122653: Set permissions for links in remote:, necessary for correct visualization

. CCBUG: 339193 Diffs - kioslave/remote/remoteimpl.cpp 5d973c6c1b6c31b7f3107d0d15805ef04bfdd661 Diff: https://git.reviewboard.kde.org/r/122653/diff/ Testing --- dolphin remote: -> no lock icon on smb:, mtp:, ... links Thanks, Stefan Brüns

Re: Review Request 122653: Set permissions for links in remote:, necessary for correct visualization

create the list of overlay icons. CCBUG: 339193 Diffs - kioslave/remote/remoteimpl.cpp 5d973c6c1b6c31b7f3107d0d15805ef04bfdd661 Diff: https://git.reviewboard.kde.org/r/122653/diff/ Testing --- dolphin remote: -> no lock icon on smb:, mtp:, ... links Thanks, Stefan Br

Review Request: solid dataengine fires timer for hddtemp every 10 seconds

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4150/ --- Review request for Plasma. Summary --- https://bugs.kde.org/show_bug.cgi?id

<    1   2   3