D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. In D22740#513873 , @marten wrote: > @GB_2 thanks for testing; a desktop UUID is obviously not friendly to show to the user, so there needs to be

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

zzag added a comment. In D23849#534126 , @romangg wrote: > Thanks for the patch Jason. So the `GSendStr(nullptr)` is called on `m_password.isNull()` because this aborts the current PAM session? If this is correct, patch looks good to me.

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

zzag added a comment. This change looks good to me, however I know only general bits of KScreenLocker. Perhaps someone else from #KWin or #Plasma could review this patch. REPOSITORY R133 KScreenLocker

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

zzag added a comment. @jfranklin Ping me if you don't get any feedback in a day or two. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D18564: Remove support for KWin's QPA plugin for KWindowSystem

This revision was automatically updated to reflect the committed changes. Closed by commit R130:4a9ebaea1af7: Remove support for KWins QPA plugin for KWindowSystem (authored by graesslin, committed by zzag). REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST

D25201: Don't set X-Plasma-MainScript for wallpaper plugins

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The filename of the main script is hard-coded to ui/main.qml, so setting X-Plasma-MainScript is pointless.

D24743: Update GTK settings according to Plasma settings

zzag added a comment. Sweet! I wonder whether this KDED module can be used to synchronize the `gtk-decoration-layout` property with kwin's decoration button layout. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24743 To: gikari, #plasma, #vdg,

D25201: Don't set X-Plasma-MainScript for wallpaper plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cf54a3e77395: Dont set X-Plasma-MainScript for wallpaper plugins (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25201?vs=69411=69906

D25947: Add applet for controlling Night Color

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The new applet allows to temporarily disable Night Color, for example if one wants to edit a video or an

D25947: Add applet for controlling Night Color

zzag updated this revision to Diff 71438. zzag added a comment. Delete stray include. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=71433=71438 BRANCH nightcolor-applet REVISION DETAIL https://phabricator.kde.org/D25947 AFFECTED

D25947: Add applet for controlling Night Color

zzag added a comment. This patch depends on D25946 and D25786 . REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25947 To: zzag, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25947: Add applet for controlling Night Color

zzag updated this revision to Diff 71474. zzag added a comment. Nate's suggestion. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=71438=71474 BRANCH nightcolor-applet REVISION DETAIL https://phabricator.kde.org/D25947 AFFECTED FILES

D25947: Add applet for controlling Night Color

zzag updated this revision to Diff 71477. zzag added a comment. Display the applet in the system tray when Night Color is inhibited. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=71474=71477 BRANCH nightcolor-applet REVISION DETAIL

D25947: Add applet for controlling Night Color

zzag updated this revision to Diff 71479. zzag added a comment. Revert applet visibility changes. Unfortunately, this may cause unnecessary shuffling of system tray items. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=71477=71479

D25923: [KCMs/Night Color] Remove "manual location entry" mode

zzag added a comment. -1 This mode can be useful for people concerned about privacy. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25923 To: ngraham, #vdg, #plasma, davidedmundson Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25760: Unset X-Plasma-MainScript for wallpaper plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R114:e60c22ff27c6: Unset X-Plasma-MainScript for wallpaper plugins (authored by zzag). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25760?vs=70949=70956

D25760: Unset X-Plasma-MainScript for wallpaper plugins

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The file path of the main script is hard-coded to ui/main.qml. REPOSITORY R114 Plasma Addons BRANCH

D25947: Add applet for controlling Night Color

zzag updated this revision to Diff 71537. zzag added a comment. Nate's suggestion. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=71479=71537 BRANCH nightcolor-applet REVISION DETAIL https://phabricator.kde.org/D25947 AFFECTED FILES

D24813: [KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

zzag added inline comments. INLINE COMMENTS > main.qml:300 > } > - > -inputMethodHints: Qt.ImhDigitsOnly > -validator: IntValidator {bottom: 1; top: > 600;} // less than 12 hours (in minutes: 720)

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. Uh, I don't use Ukrainian locale. However, it doesn't matter that much. We format numbers practically the same way as in en_US. Given the current implementation of textFromValue and the

D24838: [KCMs/Night Color] Add a valueForText handler for the new SpinBox

zzag removed a reviewer: zzag. zzag added inline comments. INLINE COMMENTS > main.qml:319 > +valueFromText: function(text, locale) { > +return parseInt(text); > +} Hmm, does parseInt take the

D24683: [KWindowSystem] in icon() return realistic icon size

zzag added inline comments. INLINE COMMENTS > zzag wrote in windowsystem.cpp:188 > You forgot to assign the copied pixmap to something. However, I think you > could just return it from this point. edit: scaled pixmap REPOSITORY R130 Frameworks integration plugin using KWayland REVISION

D24683: [KWindowSystem] in icon() return realistic icon size

zzag added inline comments. INLINE COMMENTS > windowsystem.cpp:188 > +if (scale) { > +pixmap.scaled(width, height, Qt::IgnoreAspectRatio, > Qt::SmoothTransformation); > +} You forgot to assign the copied pixmap to something. However, I think you could just return

D24906: [KCMs/Night Color] Explain Night Color feature inline

zzag added a comment. > [KCMs/Night Color] Plasma folks don't use such scopes. They prefer, correct me if I'm wrong, something like "[Night Color KCM]". REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from master) REVISION DETAIL

D25047: [Night Color KCM] Reset seconds and milliseconds in provided timings

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY When a user tries to set operation mode to "Times", the Apply button remains enabled after it's been

D25624: Don't use qmlRegisterType with QT-5.14

zzag added inline comments. INLINE COMMENTS > kcm.cpp:55 > { > +#if QT_VERSION < 0x050140 > qmlRegisterType(); You could use `QT_VERSION_CHECK` to make the code more readable, e.g. #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0) qmlRegisterType(); qmlRegisterType(); #else

D25047: [Night Color KCM] Reset seconds and milliseconds in provided timings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:59e3003943da: [Night Color KCM] Reset seconds and milliseconds in provided timings (authored by zzag). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24283: Add clang format file

zzag added inline comments. INLINE COMMENTS > zzag wrote in .clang-format:83 > The Frameworks coding says not to indent case lables. s/coding/coding style/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24283 To: davidedmundson Cc: zzag, cullmann,

D24283: Add clang format file

zzag added inline comments. INLINE COMMENTS > .clang-format:55-56 > + > +# align trailing comments > +AlignTrailingComments: true > + I'd object to aligning trailing comments because a single line change may affect many other unrelated lines. However, if this .clang-format file serves just as

D24614: Micro optimizations

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. > Add some const & for things that return const & so there's no need to make a copy For what it's worth, copy elision is guaranteed starting from C++17. \o/ REPOSITORY R31 Breeze

D24283: Add clang format file

zzag added a comment. In D24283#545620 , @cullmann wrote: > For the alignment of comments, I am not sure, it makes the stuff a lot more readable in many cases and after the initial re-format you don't have a lot of jitter normally. As I

Re: Plasma 5.18 release post-mortem

On 2/13/20 8:11 PM, David Edmundson wrote: I'm also seeing a rising amount of pushing without review on the core repos. I would like for us all to (nicely) call that out if we see any instances. Reviews are super important, the best time to fix a bug is before it even happens. Even for small

Problems in KWayland causes by API and ABI compatibility promises

Hi, KWayland is a library that provides convenience wrappers for Wayland protocols. Usually, when we want to implement some Wayland protocol, first, we add corresponding wrappers in KWayland and after that we actually implement the protocol in KWin. Unfortunately, we made a bad design

D27869: Separate processcore/{formatter,unit} into its own library

zzag added inline comments. INLINE COMMENTS > ahiemstra wrote in unit.h:81 > Blame @zzag for that who wrote the original code. :P > > That said, we probably should consider how to deal with localization issues > like that at some point in the future. Oops, sorry. REPOSITORY R111 KSysguard

D26894: Enable publication of API dox on api.kde.org

zzag added a comment. +1 > So, is kdecoration still a non-deprecated lib? Yes, KDecoration2 is a non-deprecated lib. INLINE COMMENTS > metainfo.yaml:1 > -maintainer: graesslin > description: Plugin based library to create window decorations. I think Martin didn't step down

D26894: Enable publication of API dox on api.kde.org

zzag added inline comments. INLINE COMMENTS > zzag wrote in metainfo.yaml:1 > I think Martin didn't step down officially. "officially" REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D26894 To: kossebau, #kwin Cc: zzag, plasma-devel, Orage,

D26937: Add a convenience property to retrieve the size of the decorated client

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY It can be useful if we want to know both width and height or react to any changes in the size of the

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

zzag added a comment. Sorry, I know little to nothing about internals of KScreenLocker. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26986 To: tcanabrava Cc: zzag, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26985: [Panel Shadows] Un-constify QWindow parameters

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bb60002b1340: [Panel Shadows] Un-constify QWindow parameters (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26985?vs=74555=74585

D26985: [Panel Shadows] Un-constify QWindow parameters

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY It doesn't make sense to pass const `QWindow`s to `PanelShadows` because a `KWindowShadow` needs a

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

zzag updated this revision to Diff 74606. zzag added a comment. update REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26978?vs=74598=74606 BRANCH use-qx11info-is-compositing-manager-active REVISION DETAIL https://phabricator.kde.org/D26978 AFFECTED

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

zzag updated this revision to Diff 74598. zzag added a comment. Fix coding style. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26978?vs=74539=74598 BRANCH use-qx11info-is-compositing-manager-active REVISION DETAIL https://phabricator.kde.org/D26978

D27000: [kstyle] Drop Helper::connection()

zzag created this revision. zzag added a reviewer: hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Since Qt 4 style plugin had been dropped, we can use QX11Info::connection() directly.

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag created this revision. zzag added reviewers: KWin, Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY QWindow::startSystemMove() is a new feature in Qt 5.15 that provides a

D27004: [kstyle] Drop XCB and KWayland dependency

zzag created this revision. zzag added reviewers: Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY They are not used anywhere. REPOSITORY R31 Breeze REVISION DETAIL

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag updated this revision to Diff 74622. zzag added a comment. Drop UseWMMoveResize option. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27003?vs=74619=74622 REVISION DETAIL https://phabricator.kde.org/D27003 AFFECTED FILES kstyle/breeze.kcfg

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

zzag added a comment. In D26978#602655 , @hpereiradacosta wrote: > In principle, the removal of Helper::connection, although is a change unrelated to the commit purpose. Maybe put it in a different commit ? Will do. (I removed it as a

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag updated this revision to Diff 74619. zzag added a comment. Get rid of _cursorOverride REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27003?vs=74617=74619 REVISION DETAIL https://phabricator.kde.org/D27003 AFFECTED FILES

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

This revision was automatically updated to reflect the committed changes. Closed by commit R31:932e5dc45410: [kstyle] Use QX11Info::isCompositingManagerRunning() (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26978?vs=74606=74608 REVISION

D27000: [kstyle] Drop Helper::connection()

This revision was automatically updated to reflect the committed changes. Closed by commit R31:9b20726184e4: [kstyle] Drop Helper::connection() (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27000?vs=74605=74607 REVISION DETAIL

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag added a comment. https://www.youtube.com/watch?v=tPh7U9otpy4 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27003 To: zzag, #kwin, #plasma, hpereiradacosta Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27237: [Background Finder] Create a valid invocation token

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY According to Qt docs, QUuid() creates a null UUID object. TEST PLAN N/A, plasmashell is very unstable

D26967: [kstyle] Use guarded pointers to store shadows

zzag updated this revision to Diff 74503. zzag added a comment. Clean up _shadows upon a shadow emitting QObject::destroyed() REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26967?vs=74498=74503 BRANCH fix-crash REVISION DETAIL

D26967: [kstyle] Unregister a shadow when it's destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit R113:120fb3e01f22: [kstyle] Unregister a shadow when its destroyed (authored by zzag). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26967?vs=74503=74508

D26966: [kstyle] Unregister a shadow when it's destroyed

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R31:cf12bf4a077d: [kstyle] Unregister a shadow when its destroyed (authored by zzag). REPOSITORY R31 Breeze CHANGES

D26966: [kstyle] Use guarded pointers to store shadows

zzag created this revision. zzag added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Since a KWindowShadow is a child of QWindow, we need to use a guarded pointer to store the

D26967: [kstyle] Use guarded pointers to store shadows

zzag created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Since a KWindowShadow is a child of QWindow, we need to use a guarded pointer to store the shadow in order to prevent accessing or

D26966: [kstyle] Use guarded pointers to store shadows

zzag added inline comments. INLINE COMMENTS > apol wrote in breezeshadowhelper.h:157 > if this is a thing, maybe it would make sense to actually try and remove the > KWindowShadows upon destruction? > Something like `connect(newshadow, ::destroyed, this, [this, widget] > {

D26966: [kstyle] Use guarded pointers to store shadows

zzag updated this revision to Diff 74502. zzag added a comment. Connect to QObject::destroyed REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26966?vs=74497=74502 BRANCH fix-crash REVISION DETAIL https://phabricator.kde.org/D26966 AFFECTED FILES

D26966: [kstyle] Unregister a shadow when it's destroyed

zzag updated this revision to Diff 74504. zzag retitled this revision from "[kstyle] Use guarded pointers to store shadows" to "[kstyle] Unregister a shadow when it's destroyed". zzag edited the summary of this revision. zzag added a comment. Re-title and edit summary. REPOSITORY R31

D26966: [kstyle] Unregister a shadow when it's destroyed

zzag updated this revision to Diff 74506. zzag edited the summary of this revision. zzag added a comment. Edit summary. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26966?vs=74504=74506 BRANCH fix-crash REVISION DETAIL

D26937: Add a convenience property to retrieve the size of the decorated client

This revision was automatically updated to reflect the committed changes. Closed by commit R129:13e6459a3bae: Add a convenience property to retrieve the size of the decorated client (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26937?vs=74418=74515#toc REPOSITORY

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

zzag added a comment. > monitors compositing manager selections Only if XFIXES is present; otherwise it will fallback to `xcb_get_selection_owner` as Breeze does now. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26978 To: zzag, #plasma, hpereiradacosta Cc:

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Every time Breeze needs to check whether given widget has an alpha channel, it makes a synchronous X

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag added a comment. > WARNING: I have no idea whether KDE Plasma 5.19 is going to depend on Qt 5.15. KDE Plasma 5.19 will depend on Qt 5.14. :( REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27003 To: zzag, #kwin, #plasma, hpereiradacosta Cc: plasma-devel,

D27237: [Background Finder] Create a valid invocation token

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ae0fafe23700: [Background Finder] Create a valid invocation token (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27237?vs=75232=75435

D26476: [kstyle] Remove shadows in Qt 4 style plugin

zzag updated this revision to Diff 73387. zzag added a comment. Drop Qt 4 style plugin REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26476?vs=72925=73387 BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26476 AFFECTED FILES

D26458: [windowsystem] Provide a KWindowShadow implementation

zzag updated this revision to Diff 73380. zzag added a comment. Fix a typo REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26458?vs=73350=73380 BRANCH port-to-shadows-api REVISION DETAIL

D26621: [kstyle] Drop Qt 4 style plugin

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY KWindowSystem cannot be used in the Qt 4 style plugin. On the other hand, we need to use KWindowSystem

D26458: [windowsystem] Provide a KWindowShadow implementation

zzag updated this revision to Diff 73381. zzag added a comment. Update. REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26458?vs=73380=73381 BRANCH port-to-shadows-api REVISION DETAIL

D26688: WIP: [Night Color] Display time when the next transition will start

zzag created this revision. zzag added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Currently the applet displays "Night Color is active (%screen color temperature% K)" all the time

D26681: [TabBox] Thumbnail Grid window switcher

zzag added inline comments. INLINE COMMENTS > main.qml:1 > +/ > + KWin - the KDE window manager Bad file permissions. Needs to be 644. > main.qml:74-76 > +var c = Math.min(thumbnailGridView.count, >

D26583: [Application Style] Add GTK Application Style Page

zzag added inline comments. INLINE COMMENTS > gtkthemesmodel.h:36 > +GtkThemesModel(QObject *parent = nullptr); > +~GtkThemesModel() override = default; > + Whar's the purpose of this destructor? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26583

D26609: [kstyle] Port to KWindowSystem shadows API

zzag marked an inline comment as done. zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in oxygenshadowhelper.cpp:291 > I don't understand what this line is trying to do I presume that it acted as a sub-surface test, in either case we don't need it. REPOSITORY R113 Oxygen

D26583: [Application Style] Add GTK Application Style Page

zzag added inline comments. INLINE COMMENTS > gikari wrote in gtkthemesmodel.h:36 > No purpose, therefore can I just delete it? Yes, I don't see why one would want `~Class() override = default` in a header file. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26688: WIP: [Night Color] Display time when the next transition will start

zzag added inline comments. INLINE COMMENTS > anthonyfieroni wrote in main.qml:57 > The bigger todo is hardcoded 6500K ? 6500K is the neutral screen color temperature. Although I don't think that I follow you. Do you recommend not to hardcode this constant? > ngraham wrote in main.qml:59 >

D26475: [kstyle] Port to KWindowSystem shadows API

zzag updated this revision to Diff 73643. zzag added a comment. - Drop sub-surface test - Don't use obsolete QWidget::isTopLevel() REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26475?vs=73349=73643 REVISION DETAIL https://phabricator.kde.org/D26475

D26609: [kstyle] Port to KWindowSystem shadows API

zzag updated this revision to Diff 73644. zzag added a comment. - Drop sub-surface check - Don't use obsolete QWidget::isTopLevel() REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26609?vs=73351=73644 REVISION DETAIL

D26631: [kstyle] Update blur region even if Breeze has no X11 support

This revision was automatically updated to reflect the committed changes. Closed by commit R31:e1710bd6808b: [kstyle] Update blur region even if Breeze has no X11 support (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26631?vs=73430=73656

D26643: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem

This revision was automatically updated to reflect the committed changes. Closed by commit R130:3a6508dd350b: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem (authored by zzag). REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE

D26688: WIP: [Night Color] Display time when the next transition will start

zzag updated this revision to Diff 73685. zzag added a comment. - Add Monitor.NeutralTemperature constant - Display locale time - Nate's suggestion REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26688?vs=73616=73685 BRANCH

D26688: WIP: [Night Color] Display time when the next transition will start

zzag updated this revision to Diff 73686. zzag added a comment. - Use i18nc(). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26688?vs=73685=73686 BRANCH show-next-transition-timings REVISION DETAIL https://phabricator.kde.org/D26688 AFFECTED

D26631: [kstyle] Update blur region even if Breeze has no X11 support

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY KWindowEffects provides a platform-independent API for enabling blur, which requires neither Xlib nor

D26643: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY This change ensures that kwayland-integration can be built with a version of KWS that doesn't have any

D26643: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem

zzag added a comment. See D26633 REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D26643 To: zzag, #kwin Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

Hi, I'm writing to let you know that we've dropped Breeze and Oxygen Qt 4 builds. [1][2] Cheers, vlad [1] https://cgit.kde.org/breeze.git/commit/?id=2df91ac9a3287c0082f742c2cd10567ed0c5b001 [2] https://cgit.kde.org/oxygen.git/commit/?id=94c856314c163ac869a271a16729ed26c07276b3

D26823: Port connections to new syntax

zzag added a comment. ++ INLINE COMMENTS > breezeconfigwidget.cpp:49 > // track ui changes > connect( m_ui.titleAlignment, SIGNAL(currentIndexChanged(int)), > SLOT(updateChanged()) ); > connect( m_ui.buttonSize, SIGNAL(currentIndexChanged(int)), >

D26458: [windowsystem] Provide a KWindowShadow implementation

zzag updated this revision to Diff 74059. zzag added a comment. Update REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26458?vs=74057=74059 BRANCH port-to-shadows-api REVISION DETAIL

D26621: [kstyle] Drop Qt 4 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R113:94c856314c16: [kstyle] Drop Qt 4 style plugin (authored by zzag). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26621?vs=73391=74065 REVISION DETAIL

D26609: [kstyle] Port to KWindowSystem shadows API

This revision was automatically updated to reflect the committed changes. zzag marked an inline comment as done. Closed by commit R113:164dbdb334b8: [kstyle] Port to KWindowSystem shadows API (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26609?vs=73644=74066#toc

D26458: [windowsystem] Provide a KWindowShadow implementation

This revision was automatically updated to reflect the committed changes. Closed by commit R130:8b0244949229: [windowsystem] Provide a KWindowShadow implementation (authored by zzag). REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE

D26458: [windowsystem] Provide a KWindowShadow implementation

zzag updated this revision to Diff 74057. zzag added a comment. Use QWindow::requestUpdate() REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26458?vs=73729=74057 BRANCH port-to-shadows-api REVISION DETAIL

D26476: [kstyle] Drop Qt 4 style plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R31:2df91ac9a328: [kstyle] Drop Qt 4 style plugin (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26476?vs=73387=74063#toc REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D26475: [kstyle] Port to KWindowSystem shadows API

This revision was automatically updated to reflect the committed changes. Closed by commit R31:7f3ae29b1964: [kstyle] Port to KWindowSystem shadows API (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26475?vs=73643=74064 REVISION DETAIL

D26504: [Panel Shadows] Port to KWindowSystem shadows API

This revision was automatically updated to reflect the committed changes. Closed by commit R120:13a4e62336b3: [Panel Shadows] Port to KWindowSystem shadows API (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26504?vs=74097=74099

D26504: [Panel Shadows] Port to KWindowSystem shadows API

zzag updated this revision to Diff 74097. zzag added a comment. Pass PanelShadows to constructor REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26504?vs=73011=74097 BRANCH port-to-shadows-api REVISION DETAIL

D26823: Port connections to new syntax

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in breezeconfigwidget.cpp:49 > Effectively, yes. > > I've been slowly going through all of Plasma, but a lot remain. > > There's a combo of: > > - overloaded signals/slots > - Q_PRIVATE_SLOT (which probably could be

D26504: [Panel Shadows] Port to KWindowSystem shadows API

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in panelshadows.cpp:185 > you can pass a parent here, then we don't need to clean up in the destructor Do you mean `shadow = new KWindowShadow(this);`? REPOSITORY R120 Plasma Workspace BRANCH port-to-shadows-api REVISION

D26823: Port connections to new syntax

zzag added inline comments. INLINE COMMENTS > davidedmundson wrote in breezeconfigwidget.cpp:49 > Sort of. > It handles not doing anything bad. It detects it and prints a warning. > > There's about 24 left in this repo. Hmm, so one has to port them by hand, right? REPOSITORY R31 Breeze

D26823: Port connections to new syntax

zzag added a comment. In D26823#598999 , @hpereiradacosta wrote: > This breaks the KDE4 compilation of breeze style (of course !) Qt 4 build was dropped. https://mail.kde.org/pipermail/plasma-devel/2020-January/108585.html

  1   2   >