[Differential] [Closed] D4288: Add Kleopatra tray icon

guoyunhe closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4288 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #plasma, mart Cc: plasma-devel, guoyunhe, #frameworks, lesliezhai,

[Differential] [Closed] D3009: Fix logout translation message

guoyunhe closed this revision. REVISION DETAIL https://phabricator.kde.org/D3009 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #plasma_workspaces, mart Cc: davidedmundson, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[Differential] [Request, 0 lines] D4288: Add Kleopatra tray icon

guoyunhe created this revision. guoyunhe added a reviewer: Plasma. guoyunhe set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY

[Differential] [Updated] D4288: Add Kleopatra tray icon

guoyunhe updated the summary for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4288 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: guoyunhe, #plasma Cc: plasma-devel, guoyunhe, #frameworks,

Re: Review Request 129098: Add keyboard icons for kimpanel

/4f255109-99fa-41f7-aebb-ca92fb352598__keyboard.png Thanks, Yunhe Guo

Re: Review Request 129098: Add keyboard icons for kimpanel

-ca92fb352598__keyboard.png Thanks, Yunhe Guo

Re: Review Request 129091: Add icons for Fcitx

E > > engine instead of just per language? > > > > Having icons for specific fcitx plugins upstream seems like bad layering. > > Yunhe Guo wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > language code so they can al

Re: Review Request 129091: Add icons for Fcitx

E > > engine instead of just per language? > > > > Having icons for specific fcitx plugins upstream seems like bad layering. > > Yunhe Guo wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > language code so they can al

Re: Review Request 129091: Add icons for Fcitx

-6202423b6e64__Spectacle.AD8101.png Screenshot_20161006_201118.png https://git.reviewboard.kde.org/media/uploaded/files/2016/10/06/9b51635d-7461-40b4-9c59-27d07407a475__Screenshot_20161006_201118.png Thanks, Yunhe Guo

Re: Review Request 129098: Add keyboard icons for kimpanel

-ca92fb352598__keyboard.png Thanks, Yunhe Guo

Re: Review Request 129091: Add icons for Fcitx

://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png Thanks, Yunhe Guo

Re: Review Request 129091: Add icons for Fcitx

reply, visit: https://git.reviewboard.kde.org/r/129091/#review99774 ------- On 十月 3, 2016, 6:18 p.m., Yunhe Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129091/ &

Re: Review Request 129091: Add icons for Fcitx

https://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png Thanks, Yunhe Guo

Re: Review Request 129091: Add icons for Fcitx

E > > engine instead of just per language? > > > > Having icons for specific fcitx plugins upstream seems like bad layering. > > Yunhe Guo wrote: > > Instead of using fcitx-, would it be possible to make generic icons per > language code so they can al

Review Request 129098: Add input-keyboard icon to input.svgz

-d3443d226f51__Spectacle.Et8101.png https://git.reviewboard.kde.org/media/uploaded/files/2016/10/04/6647cc3d-3e86-43fa-aa20-a716d5af85d1__37e4e60f-d256-4799-a001-d3443d226f51__Spectacle.Et8101.png Thanks, Yunhe Guo

Review Request 129091: Add icons for Fcitx

://git.reviewboard.kde.org/media/uploaded/files/2016/10/03/5d052366-942b-4a83-a055-6202423b6e64__Spectacle.AD8101.png Thanks, Yunhe Guo

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

-81d0-151d2382e05c__icons.tar.gz Thanks, Yunhe Guo

Re: Review Request 129098: Add keyboard icons for kimpanel

-ac718ac3b0e0__input.png icons.tar.gz https://git.reviewboard.kde.org/media/uploaded/files/2016/11/08/db3e6d93-6861-491e-81a5-f39bf10b95fb__icons.tar.gz Thanks, Yunhe Guo

Re: Review Request 129329: Fix SVG icon ID prefix

push it. - Yunhe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129329/#review100687 --- On 十一月 4, 2016, 3:52 p.m

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

-2c16fc989e13__fcitx.svgz Thanks, Yunhe Guo

Re: Review Request 129329: Fix SVG icon ID prefix

-1abb076214e0__icons.tar.gz Thanks, Yunhe Guo

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

iew100188 --- On 十月 6, 2016, 6:03 p.m., Yunhe Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 129329: Fix SVG icon ID prefix

) icons.tar.gz https://git.reviewboard.kde.org/media/uploaded/files/2016/11/08/19629972-3a6d-4461-9cfe-1abb076214e0__icons.tar.gz Thanks, Yunhe Guo

Re: Review Request 129098: Add keyboard icons for kimpanel

-026c-4263-b383-22cef91820a5__keyboard.svgz input.svgz https://git.reviewboard.kde.org/media/uploaded/files/2016/11/08/dccf18d6-f8b0-42f9-901a-8c1f90c1d849__input.svgz Thanks, Yunhe Guo

Re: Review Request 129098: Add keyboard icons for kimpanel

-f39bf10b95fb__icons.tar.gz Thanks, Yunhe Guo

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

/files/2016/10/06/74a7126d-f917-4be0-864c-9f5f5253d448__Spectacle.Zb3480.png icons.tar.gz https://git.reviewboard.kde.org/media/uploaded/files/2016/11/08/e77ab204-7dc0-4b15-81d0-151d2382e05c__icons.tar.gz Thanks, Yunhe Guo

Review Request 129329: Fix SVG icon ID prefix

/icons/phone.svgz e3c35c8e8b61ddb2100af737bbb27cba7dca6179 src/desktoptheme/breeze/icons/touchpad.svgz d08f2ceaa0b5394e217965e0b00a697dceab1d98 Diff: https://git.reviewboard.kde.org/r/129329/diff/ Testing --- Thanks, Yunhe Guo

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

in system tray/widget. - Yunhe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review100083 --- On 十月 6, 2016, 6:03 p.m.,

D7047: Wallpaper blur background filling effect feature

guoyunhe updated this revision to Diff 17538. guoyunhe marked an inline comment as done. guoyunhe added a comment. Improve image transition animation. Image transition and blur background transition are now synchronous and smooth. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D7047: Wallpaper blur background filling effect feature

guoyunhe updated this revision to Diff 17518. guoyunhe added a comment. Solve some coding issue. Use two GaussianBlur to keep sync with image slideshow. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7047?vs=17517=17518 REVISION DETAIL

D7047: Wallpaper blur background filling effect feature

guoyunhe created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Add a checkbox to wallpaper configuration dialog. By checking this option, empty space surround image will be filled by blurred image rather

D7047: Wallpaper blur background filling effect feature

guoyunhe marked 2 inline comments as done. guoyunhe added inline comments. INLINE COMMENTS > broulik wrote in main.qml:213 > Is it possible to re-use the currentImage instead of creating yet another > `Image` item? I know with `ShaderEffect` you can do `hideSource: false` but I > don't see

D6813: Use customized font size for Digital Clock applet

guoyunhe added a comment. In https://phabricator.kde.org/D6813#127279, @davidedmundson wrote: > Thanks, FYI we've had another review with the same change this week: https://phabricator.kde.org/D6764 Good to know  REPOSITORY R120 Plasma Workspace REVISION DETAIL

D6813: Use customized font size for Digital Clock applet

guoyunhe created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY > This patch is not tested! I have some trouble to compile or run Plasma Workspace. Hope someone could help me test or give some build/test

D7436: kimpanel: change highlight color

guoyunhe created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Before: Highlighted candidate uses theme.highlightColor for text, but this color should only be used in background color, not text

D7436: kimpanel: change highlight color

guoyunhe edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: guoyunhe, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

guoyunhe added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: guoyunhe, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

guoyunhe added a comment. In https://phabricator.kde.org/D7436#138011, @xuetianweng wrote: > Can you try to make use of PlasmaComponents.Highlight instead of custom highlight like this? Tried and failed... So I have to leave it like this... REPOSITORY R119 Plasma Desktop

D7436: kimpanel: change highlight color

guoyunhe accepted this revision. guoyunhe added a comment. This revision is now accepted and ready to land. F3874133: Screenshot_20170823_225448.png It looks good. Only one small problem: when hovering mouse on selected candidate, its height will

D7047: Wallpaper blur background filling effect feature

guoyunhe added a comment. In https://phabricator.kde.org/D7047#158496, @ngraham wrote: > It occurs to me that only the "Scaled, Keep Proportions" and "Centered" positioning modes require any kind of background effect or color. With other positioning modes, the existing Background Color

D8441: Wallpaper: hide color or blur filling options for full filling mode

guoyunhe created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8441 AFFECTED FILES

D8441: Wallpaper: hide color or blur filling options for full filling mode

guoyunhe edited the summary of this revision. guoyunhe added a reviewer: ngraham. guoyunhe added a subscriber: ngraham. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8441 To: guoyunhe, ngraham Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff,

D8441: Wallpaper: hide color or blur filling options for full filling mode

guoyunhe added inline comments. INLINE COMMENTS > davidedmundson wrote in config.qml:161 > This used to be the case, then it was changed for some obscure use case with > transparaent images. Ah, I have never thought about this. Is this use case common? I have never seen people use transparent

D7047: Wallpaper blur background filling effect feature

guoyunhe closed this revision. guoyunhe added a comment. This patch has been committed to master branch. I will add the color/blur-image radio buttons in another patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7047 To: guoyunhe, #plasma_workspaces,

D8441: Wallpaper: hide color or blur filling options for full filling mode

This revision was automatically updated to reflect the committed changes. Closed by commit R120:72450a2a49d2: Wallpaper: hide color or blur filling options for full filling mode (authored by guoyunhe). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D8441: Wallpaper: hide color or blur filling options for full filling mode

guoyunhe added a comment. In https://phabricator.kde.org/D8441#164149, @broulik wrote: > You need to adjust the `config.xml` for that setting to persist. > > Also, it seems you have pushed an unfinished version of that feature [1] without approval. > > [1]

D8441: Wallpaper: hide color or blur filling options for full filling mode

guoyunhe updated this revision to Diff 21240. guoyunhe added a comment. - Wallpaper: change variable name from edgefilling to background REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8441?vs=21239=21240 BRANCH master REVISION DETAIL

D8441: Wallpaper: hide color or blur filling options for full filling mode

guoyunhe updated this revision to Diff 21241. guoyunhe added a comment. - Wallpaper: change label text of blur option REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8441?vs=21240=21241 BRANCH master REVISION DETAIL

D8441: Wallpaper: hide color or blur filling options for full filling mode

guoyunhe added a comment. In https://phabricator.kde.org/D8441#159329, @ngraham wrote: > Great, thanks! Much better. Any chance you can upload new screenshots? F5447565: Screenshot_20171024_165656.png REPOSITORY R120 Plasma Workspace

D8441: Wallpaper: hide color or blur filling options for full filling mode

guoyunhe updated this revision to Diff 21239. guoyunhe added a comment. - Wallpaper: change label name REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8441?vs=21218=21239 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8441

D8441: Wallpaper: hide color or blur filling options for full filling mode

guoyunhe added a comment. In https://phabricator.kde.org/D8441#159293, @ngraham wrote: > Can we change "Edge filling" to "Background"? I don't know which word is better because I am not a native English speaker. But yeah, I can change it. REPOSITORY R120 Plasma Workspace

D8441: Wallpaper: hide color or blur filling options for full filling mode

guoyunhe added a comment. Done. In https://phabricator.kde.org/D8441#159321, @ngraham wrote: > Here's how I would do it: > > Background: * Blur > * Solid color: [color chooser] > REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10633: Use 22px battery and keyboard icon in lock screen and sddm

guoyunhe created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY ToolButton and Battery components are using 16px icons but here is no 16px icons in Breeze theme

D10633: Use 22px battery and keyboard icon in lock screen and sddm

guoyunhe edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10633 To: guoyunhe, #plasma_workspaces Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10633: Use 22px battery and keyboard icon in lock screen and sddm

guoyunhe added a reviewer: Plasma: Workspaces. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10633 To: guoyunhe, #plasma_workspaces Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17704: Copy to clipboard always copy English texts

guoyunhe added a comment. In D17704#379978 , @cfeck wrote: > If I understand your patch correctly, you only forbid translating the order of text, not the actual text labels. Yes, the patch doesn't do what I want to do. I will update it.

D17704: Copy to clipboard always copy English texts

guoyunhe updated this revision to Diff 47897. guoyunhe added a comment. Use untranslated texts for clipboard label pairs REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17704?vs=47877=47897 BRANCH master REVISION DETAIL

D17704: Copy to clipboard always copy English texts

guoyunhe added a comment. In D17704#380016 , @ngraham wrote: > I recall in the original patch that copying translated text was something that various folks specifically asked for. Is it really that useless? @gregormi, do you remember the

D17773: Copy to Clipboard in English

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Add a new button to copy to clipboard in English for usage in bug report. This doesn't affect existing copy button which copy

D17704: Copy to clipboard always copy English texts

guoyunhe added a comment. Here is another solution. https://phabricator.kde.org/D17773 Don't affect current button but add a new one. Since here are only two buttons and enough space, I didn't use dropdown or split button. REPOSITORY R102 KInfoCenter REVISION DETAIL

D17773: Copy to Clipboard in English

guoyunhe updated this revision to Diff 48124. guoyunhe edited the summary of this revision. guoyunhe added a comment. Hide the "Copy to Clipboard in English" button when the system is already in English. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D17704: Copy to clipboard always copy English texts

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Usually users copy this info to report bugs or get help from community. English texts are more useful and readable. REPOSITORY

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. In D18890#419886 , @mart wrote: > In D18890#410144 , @guoyunhe wrote: > > > In D18890#410137 , @davidedmundson wrote: > > >

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Here are a lot of bug reports of Baloo crashing caused by corrupted database. This patch provide a button in KCM to quickly

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe updated this revision to Diff 51435. guoyunhe added a comment. - Add message box for Rebuild Index Database button REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51325=51435 BRANCH master REVISION DETAIL

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. Screenshot: F6608381: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890 To: guoyunhe, #plasma, #baloo Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ashaposhnikov,

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe updated this revision to Diff 51436. guoyunhe added a comment. - Make message box translatable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51435=51436 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18890

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added inline comments. INLINE COMMENTS > bruns wrote in kcm.cpp:197 > IMHO this whole block should be a single, blocking command in balooctl, i.e. > move the whole logic to balooctl. Will try. > bruns wrote in kcm.cpp:210 > Care to elaborate? If I run "balooctl start" in QProcess,

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. In D18890#410137 , @davidedmundson wrote: > If we know the DB is corrupted, and it's just a cache, why do we need a user facing button? It is also possible to move this function to database corruption handler.

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe updated this revision to Diff 51325. guoyunhe added a comment. - Reset index database button align right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51324=51325 BRANCH master REVISION DETAIL

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. In D18890#409270 , @ngraham wrote: > Great! Just one more UI suggestion: use the string "Rebuild Index Database" Updated :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe added a comment. In D18890#409258 , @ngraham wrote: > I wish this weren't necessary, but I think it's a good idea for the time being. > > Can you reduce the button width so it doesn't span the entire layout? It should be as small

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe updated this revision to Diff 51324. guoyunhe added a comment. - Reset index database button align right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18890?vs=51294=51324 BRANCH master REVISION DETAIL

D22426: Add Unsplash POTD Provider

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Add Unsplash Wallpaper as picture of the day provider. Unsplash provides high quality photos under public domain license.

D22426: Add Unsplash POTD Provider

guoyunhe added a comment. Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues. I do think it is good to show photographers' credits. But that will require changes to POTD class and wallpaper widget. REPOSITORY R114 Plasma Addons REVISION

D22426: Add Unsplash POTD Provider

guoyunhe updated this revision to Diff 61678. guoyunhe added a comment. Fix Unix new line format REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22426?vs=61673=61678 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22426 AFFECTED

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D22451 AFFECTED FILES

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

guoyunhe updated this revision to Diff 61727. guoyunhe added a comment. Enable smoothing for POTD wallpaper REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22451?vs=61726=61727 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22451

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

guoyunhe added a comment. In D22451#495272 , @ngraham wrote: > Instead of `smooth: true` doing this may achieve the same result with less memory usage: > > sourceSize.width: parent.width > sourceSize.height: parent.height > I

D22451: Unsplash POTD: filter out banner image and pick random photo from latest

guoyunhe added a comment. In D22451#495279 , @ngraham wrote: > Ah right, that's a property of `Image`, not `QImageItem`. > > https://doc.qt.io/qt-5/qml-qtquick-image.html#sourceSize-prop > > Can you use `Image` instead? I got a

D22925: Fix POTD doesn't update

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Previous patch for Unsplash Wallpapers changed the identifier format. So we can not simply detect whether an identifier contains

D22925: Fix POTD doesn't update

guoyunhe added a comment. In D22925#506462 , @ngraham wrote: > Have you tested to make sure this doesn't break other providers? I need several days to test because it only change once a day... (changing local time won't work) REPOSITORY

D22535: Make kimpanel a system tray applet

guoyunhe added a comment. I tried to merge @gpark 's branch. It is compiled but I cannot reproduce the UI as shown in demo video. I am not sure how it is connected. So I leave that part untouched for now. I hope I can get in touch with @gpark to understand how the code works. Then we can

D22535: Make kimpanel a system tray applet

guoyunhe added a comment. In D22535#509917 , @ngraham wrote: > Did you delete the old KCM first? If not, it will take precedence and you won't see the new one. The old one is located in the following location: > > - Ubuntu-based distros:

D22535: Make kimpanel a system tray applet

guoyunhe added a comment. Making the layout of status panel: F7203378: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22535 To: guoyunhe, ngraham, #vdg, #plasma Cc: xuetianweng, gpark, hein, mart,

D22535: Make kimpanel a system tray applet

guoyunhe added a comment. Uploaded latest code. It is unfinished. Just for anyone who may accidentally be interested. What works: 1. Make the widget a system tray icon. 2. The system tray icon can show current input method. 3. Right click the system tray icon, context menu allow

D22535: Make kimpanel a system tray applet

guoyunhe added a comment. Added context menu actions to configure keyboard and fcitx. @ngraham do we KCM of ibus or scim? F7204543: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22535 To: guoyunhe,

D22535: Make kimpanel a system tray applet

guoyunhe updated this revision to Diff 63561. guoyunhe added a comment. - UNFINISHED: show icon of current input method in system tray REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22535?vs=61998=63561 BRANCH master REVISION DETAIL

D22535: Make kimpanel a system tray applet

guoyunhe updated this revision to Diff 63579. guoyunhe added a comment. - avoid state jumping. lock state when opening kimpanel. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22535?vs=63561=63579 BRANCH master REVISION DETAIL

D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY I changed all QPainter functions to qreal functions. But this didn't make the line chart sharp in HiDPI. REPOSITORY R111

D23840: Enable HiDPI rendering for systemmonitor

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Make toolbar and menu icons sharp REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D23840: Enable HiDPI rendering for systemmonitor

guoyunhe added a comment. Fixed in https://phabricator.kde.org/D23846 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23840 To: guoyunhe, #plasma, ngraham Cc: kossebau, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23846: Fix build error of wrong function reference

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Fix build error caused by D23840 REPOSITORY R120 Plasma Workspace BRANCH master

D23868: kfontinst HiDPI icons

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Use QIcon instead of QPixmap for icons. Use QPushButton for the filter menu instead of a QLabel. REPOSITORY R119 Plasma

D23868: kfontinst HiDPI icons

guoyunhe updated this revision to Diff 65841. guoyunhe added a comment. Fix the font preview size in HiDPI REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=65827=65841 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23868

D23831: Unsuccessful attempt to make KSignalPlotter render sharp chart in HiDPI display

guoyunhe updated this revision to Diff 65765. guoyunhe added a comment. continue trying REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23831?vs=65748=65765 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23831 AFFECTED FILES

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66229. guoyunhe added a comment. Rename and move the find duplicate button REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66193=66229 BRANCH master REVISION DETAIL

D6764: Use a smaller font size for digital clock plasmoid

guoyunhe added a comment. I think we can make another applet called Small Digital Clock, which can be an alternative of Digital Clock. Just like we have different alternatives for launcher and task bar. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6764

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe added a comment. I changed it to QToolButton, but it still look different: F7352361: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23868 To: guoyunhe, #plasma, ngraham Cc: ngraham, plasma-devel,

D23868: kfontinst HiDPI icons

guoyunhe updated this revision to Diff 66074. guoyunhe added a comment. Change icon name. To match patch D23942 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=65841=66074 BRANCH master REVISION

  1   2   3   >