broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
According to Unity
broulik added inline comments.
INLINE COMMENTS
> FullRepresentation.qml:174
> case PlasmaCore.Types.LeftEdge:
> -return "left";
> +return Qt.application.layoutDirection == Qt.RightToLeft
> ? "right" : "left";
> case
broulik added inline comments.
INLINE COMMENTS
> input.cpp:488
> +if (event->buttons() == Qt::NoButton) {
> +if (event->button() == Qt::RightButton) {
> +cancel();
Can this happen? You check for buttons being NoButton and then for button being
broulik added a comment.
We could do the same hack we have with Kickoff, where the first task manager
it finds with a global shortcut will be invoked. But that's not really
discoverable how to change/why it broke when you created a new panel manually,
etc etc.
REPOSITORY
rPLASMADESKTOP
broulik added a comment.
Heh, you were quicker :)
Can we perhaps use the application name as summary in case none is set?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3425
EMAIL PREFERENCES
broulik created this revision.
broulik added reviewers: Plasma, mck182.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This ensures the
broulik added a comment.
Sorry for being late to the party
INLINE COMMENTS
> DashboardRepresentation.qml:102
> +if (tabBar.activeTab == 1 /* Widgets */ || tabBar.hoveredTab == 1) {
> +root.widgetExplorer = widgetExplorerComponent.createObject(root);
> +
broulik marked 3 inline comments as done.
broulik added inline comments.
INLINE COMMENTS
> graesslin wrote in abstract_client.cpp:75-77
> why carry the bool in the signal? That seems to make it way more complicated
> here
In DecoratedClient I do
connect(client, ::hasApplicationMenuChanged,
broulik updated this revision to Diff 7664.
broulik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- Rebase on master
- Implement ShellClient so it reads the property from Wayland windows
The menu button shows up on Wayland but the menu itself
broulik updated the test plan for this revision.
broulik updated this revision to Diff 7730.
broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- Cleanup a bit
- Listen to menuShown signal rather than assuming a showMenu call will be
successful
-
broulik updated the summary for this revision.
broulik updated the test plan for this revision.
broulik updated this revision to Diff 7726.
broulik added a comment.
- Move setWindowProperty to x11/wayland integration to unclutter the code a
bit
- Adds an Alt key listener which, on
broulik updated the summary for this revision.
broulik updated this revision to Diff 7727.
broulik added a comment.
- Remove GtkIcons, it's not like GTK applications support this stuff
anymore...
- Introduce showMenu signal so KWin can reliably know whether the menu
actually showed
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEf0e27ed71bcf: [Session Model] Show new session
entry only if we actually can (authored by broulik).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
broulik added inline comments.
INLINE COMMENTS
> main.qml:241
> +onDragEnter: {
> +if (event.mimeData.formats.indexOf("text/x-plasmoidservicename")
> < 0) {
> +event.ignore();
Can you split that into a function so we then have
onDragEnter: {
if
broulik added a comment.
Wtf phab
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2962
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta
Cc:
broulik retitled this revision from "RFC: Clean up KAppMenu" to "Clean up
KAppMenu".
broulik updated the test plan for this revision.
broulik updated this revision to Diff 7784.
broulik added a comment.
- Cache atom to avoid roundtrip to the x server
- Add "reconfigured" signal so
broulik added a reviewer: hpereiradacosta.
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D2962
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta
Cc: plasma-devel,
broulik added a comment.
Ping
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D2962
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #breeze, #plasma:_design, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed,
broulik reopened this revision.
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D2962
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai,
broulik closed this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2965
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, graesslin
Cc: plasma-devel, lesliezhai, ali-mohamed,
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPaad0a3e51d8e: [KAccess] Set componentDisplayName
(authored by broulik).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2959?vs=7142=7781
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEf12a62830e81: [Logout Greeter] Add
QtQuickSettings (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2962?vs=7151=7779#toc
REPOSITORY
rPLASMAWORKSPACE Plasma
broulik updated this revision to Diff 7785.
broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- Rebase on master
- Honor global menu setting (only show button if is "in window decoration")
and listen to kappmenu reconfigured signal
REPOSITORY
broulik changed the repository for this revision from rPLASMAWORKSPACE Plasma
Workspace to rBREEZE Breeze.
broulik updated this revision to Diff 7780.
broulik added a comment.
Restore original diff...
REPOSITORY
rBREEZE Breeze
CHANGES SINCE LAST UPDATE
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This restores
broulik added a comment.
Thanks, Hugo.
I just checked and resizing outside of windows works when I disable
compositing. On Wayland there were some changes/fixes going on there but I need
to check.{quote}I recal that "no borders" is not the default for the window
decorations borders, so
broulik updated this revision to Diff 7787.
broulik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- Don't blindly connect applicationMenu*Enabled*Changed to
hasApplicationMenuChanged because the former is just the setting but a client
doesn't
broulik abandoned this revision.
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D2962
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #breeze, #plasma:_design, #plasma, hpereiradacosta
Cc: plasma-devel, lesliezhai,
broulik added a comment.
How does that affect horizontal scrolling? Also, does that already take into
account scroll direction "natural"/normal (or was that maybe the case for it
being wrong in the first place?)?
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3247
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEd1133288c335: [Lock Screen] Don't assume last
user is "New Session" entry (authored by broulik).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
broulik updated this revision to Diff 7866.
broulik added a comment.
Take into account canSwitchUser
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3231?vs=7834=7866
REVISION DETAIL
https://phabricator.kde.org/D3231
AFFECTED FILES
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rKWIN KWin
BRANCH
internal-window-non-minimize-5.8
REVISION DETAIL
https://phabricator.kde.org/D3244
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Verified that horizontal scrolling also scrolls correctly (dragged one
TreeWidget colum super wide to have it scroll)
REPOSITORY
rKWIN KWin
BRANCH
broulik updated this revision to Diff 7832.
broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- Move comment
- Check for service name / object path being empty before finding a client
- Remove added empty line
REPOSITORY
rKWIN KWin
CHANGES
broulik created this revision.
broulik added reviewers: Plasma, subdiff.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Only the button
broulik created this revision.
broulik added reviewers: Plasma, subdiff.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Ask the model
broulik added inline comments.
INLINE COMMENTS
> x11windowed_backend.cpp:477-480
> +QVector ret;
> +for (auto it = m_windows.constBegin(); it != m_windows.constEnd(); ++it)
> {
> +ret << initialOutputScale();
> +}
QVector ::fill(const T , int size = -1)
Assigns value to
broulik retitled this revision from "WIP: Restore global menu support" to
"Restore global menu support".
broulik updated this revision to Diff 7732.
broulik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- Rebase to QtPlatformSupport cmake changes -
broulik added a comment.
While in principle the patch is fine, the only way this can be null is when
NotificationPopup.qml (which is a Plasma Dialog) failed to load, so I think
we're masking a deeper problem here.
var popup = notificationPopupComponent.createObject();
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
krunner-wayland-panel
REVISION DETAIL
https://phabricator.kde.org/D3038
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEb9a75d39cf86: [DrKonqi] Update URL to Wiki
page on how to create useful bug reports (authored by broulik).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This is part two in a
broulik added a comment.
It's not much code on our side because Qt has the code nowadays. :)
INLINE COMMENTS
> graesslin wrote in FindQt5PlatformSupport.cmake:1
> given that it has my copyright I assume you copied from kwin - that would be
> a reason to move it to ecm. We have two users.
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAINTEGRATION Integration
for Qt applications in Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rKDECORATION Window Decoration
Library.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
rKDECORATION Window
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rKWIN KWin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
TEST PLAN
Together with the other three patches gives you an
broulik retitled this revision from "RFC: Listen for broadcast notifications on
system bus" to "Listen for broadcast notifications on system bus".
broulik updated the summary for this revision.
broulik updated the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
broulik updated the test plan for this revision.
broulik updated this revision to Diff 8854.
broulik added a comment.
- Drop plasmashell from interface name and upper camel case
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3606?vs=8853=8854
broulik removed a subscriber: davidedmundson.
broulik updated this revision to Diff 8853.
broulik added a comment.
- Support passing "uids" as stringlist, my initial QVariantList with int
approach didnt really work
- Enable only if configured
REPOSITORY
R120 Plasma Workspace
CHANGES
broulik added a comment.
One thing we perhaps should do is add a kiosk restriction to globally disable
this button everywhere.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3616
EMAIL PREFERENCES
broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3607
EMAIL PREFERENCES
broulik added a comment.
What would be the best place to put a little utility (similar to notify-send
or kdialog --passivepopup) for this?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3606
EMAIL PREFERENCES
broulik added a comment.
A bunch of nitpicks below. Haven't tried it yet, though :)
Is there a chance we could serve the novice user usecase of Meta+P and then
*click* / choose the desired setup? As far as I can tell we only show "You now
use $setup" but not "You can choose: [Clone,
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:00d160aab929: [Kicker] Hide "Edit Applications..."
context menu entry if system immutable (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
broulik added a comment.
Overall I quite like it, especially the stylized 9 referencing Plasma 5.9
(not sure if that was fully intentional, though? ;)
The blurry jaggy, coronal mass ejection like edges of the yellow band, look
weird.
F708275: Screenshot_20161213_081935.png
broulik closed this revision.
broulik added a comment.
Committed into master in
https://cgit.kde.org/breeze.git/commit/?id=ab984d2ed689322c3b11be6042053bcfd33f3807
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3660
EMAIL PREFERENCES
broulik accepted this revision.
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3660
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, graesslin.
broulik set the repository for this revision to R133 KScreenLocker.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
... and
broulik updated this revision to Diff 9074.
broulik added a comment.
- Remove now unused icon qml plugin
- Drop cumbersome drop handling – if the user explicitly dropped some files
somewhere the application should just launch with them, shouting at the user if
unsupported
REPOSITORY
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3705
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sitter, broulik
Cc:
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:4440a0d0115f: [Runners] Register actions right away
(authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3688?vs=9043=9085
REVISION
broulik updated this revision to Diff 9043.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3688?vs=9042=9043
REVISION DETAIL
https://phabricator.kde.org/D3688
AFFECTED FILES
runners/baloo/baloosearchrunner.cpp
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design, hein.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Previously, they
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Thanks
INLINE COMMENTS
> servicerunner.cpp:124
> +qCDebug(RUNNER_SERVICES) << service->name() << "is an exact
> match!" << service->storageId() << service->exec();
> +
broulik added inline comments.
INLINE COMMENTS
> appmenuapplet.cpp:91
> +ctx->window()->mouseGrabberItem()->ungrabMouse();
> +}
> +
Somehow your indentation is a bit off?
> configGeneral.qml:44
> +id: fullRepresentationRadio
> +text:
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:caea0aa4ee22: [Icon Widget] Bring back properties dialog
(authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2687?vs=9074=9086#toc
REPOSITORY
R120 Plasma Workspace
broulik retitled this revision from "WIP: [Icon Widget] Bring back properties
dialog" to "[Icon Widget] Bring back properties dialog".
broulik updated the test plan for this revision.
broulik updated this revision to Diff 8967.
broulik added a comment.
- Ensure Link desktop file is actually
broulik added a comment.
> I wonder if it can take usernames instead of uids?
Perhaps not "instead" but in addition. The tool is mostly meant to be used by
background services and scripts, so remembering should not be an issue but we
can offer both. Will make a patch for the
broulik marked 9 inline comments as done.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2687
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, dfaure
Cc: mart, plasma-devel, lesliezhai, ali-mohamed,
broulik added a comment.
> could also be a property of an object that's inside instead of the root
object
I also need to access it from the style and didn't want to randomly do
control.someRandomObject.foo
REPOSITORY
R242 Plasma Frameworks
REVISION DETAIL
broulik updated this revision to Diff 8968.
broulik added a comment.
- Create context menu actions on demand, saves some cycles on startup and
more importantly allows us to follow SystemImmutable
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
broulik retitled this revision from "[Task Manager] Don't emit urls droppde on
drag enter" to "[Task Manager] Don't emit urls dropped on drag enter".
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3663
EMAIL PREFERENCES
broulik created this revision.
broulik added reviewers: Plasma, hein, davidedmundson.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Otherwise we'll
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:643e424d7f1e: [Task Manager] Don't emit urls dropped on
drag enter (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3663?vs=8969=8970
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:dcf8e3dca547: Listen for broadcast notifications on
system bus (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D3606?vs=8854=8943#toc
REPOSITORY
R120 Plasma Workspace
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R126 KDE CLI Utilities.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This adds a command-line utility
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This introduces a new
broulik updated the test plan for this revision.
REPOSITORY
R242 Plasma Frameworks
REVISION DETAIL
https://phabricator.kde.org/D3654
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2f9bfbc5e153: [Lock Screen / Login] Add "reveal password
button" (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3616?vs=8841=8947
broulik added a comment.
LGTM overall
"Prototype of redesigned taskbar" made me curious ;)
INLINE COMMENTS
> playercontainer.cpp:123
> +int secondaryInstancePid = -1;
> +int lastPoint = m_dbusAddress.lastIndexOf(".");
> +QString end =
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7585f2953635: [Folder View] Clear hover state when mouse
leaves view (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3593?vs=8767=8820
broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We don't want users in a
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Allows to show the
broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> BadgeOverlay.qml:31
> +id: badgeRect
> +x: Qt.application.layoutDirection === Qt.RightToLeft ? 0 :
> parent.width
broulik added a comment.
You forgot BadgeOverlay.qml
INLINE COMMENTS
> ConfigGeneral.qml:28
> +
> +signal configurationChanged
> +
Unused
> ConfigGeneral.qml:30-31
> +
> +width: childrenRect.width
> +height: childrenRect.height
> +implicitWidth: pageColumn.implicitWidth
broulik abandoned this revision.
broulik added a comment.
IMHO this feature is completely orthogonal to "proper" media controls. But I
respect your decision.
So, about proper media controls, would re-using the mpris data engine in
Plasma from QML be an option or should it rather be some
broulik added a comment.
> use apparmor at some future point
and from what I understand DBus access can be restricted on a
per-interface/service basis with that? Dunno if it can do wildcards, though.
> Kai, can you expand on your use cases
At Randa I was listening to music,
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This provides media
broulik updated this revision to Diff 9029.
broulik marked 2 inline comments as done.
broulik added a comment.
- update actions also in Component.onCompleted so the "configure" button in
applet handle works correctly the first time
- Set icon for properties dialog ("document-properties",
broulik marked 4 inline comments as done.
broulik added inline comments.
INLINE COMMENTS
> dfaure wrote in iconapplet.cpp:242
> Just wondering, why is the parent widget nullptr here, while it's
> QApplication::desktop() in other code further down? Not that it changes
> anything at runtime, I
broulik added a comment.
I think KWin's Wayland input mapping logic needs to be adjusted then?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3650
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sitter, plasma-devel
Cc:
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:008099974805: [Task Manager] Honor
activateTaskManagerEntry by plasmashell (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ea4579f312c6: [PlasmaShell] Introduce
activateTaskManagerEntry(index) method (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
broulik added a comment.
some minor minor nitpicks, +1 from me though
INLINE COMMENTS
> rootmodel.cpp:281
>
> -foreach (const AbstractEntry *groupEntry, m_entryList) {
> -AbstractModel *model = groupEntry->childModel();
> +for (int i = 0; i <
broulik updated the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3581
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed,
broulik abandoned this revision.
broulik added a comment.
Superseded by https://phabricator.kde.org/D3581 and
https://phabricator.kde.org/D3582
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2680
EMAIL PREFERENCES
broulik created this revision.
broulik added reviewers: Plasma: Design, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This adds a method
broulik added a comment.
Ping
> How would I tell the "primary monitor task manager" applet?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2680
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma,
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
It registers global shortcuts Meta+1
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b34601f0ef1a: [Lock Screen] Add keyboard icon for
keyboard layout switcher (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
801 - 900 of 1091 matches
Mail list logo
