Re: git-repositories-for-release

2023-11-06 Thread Antonio Rojas 
El lunes, 6 de noviembre de 2023 17:21:06 (CET) Jonathan Riddell escribió:
> Diff from 5.27

Hi,
 What about kglobalacceld?

[ksysguard] [Bug 421902] Package ksysguard5 cannot be installed on the current openSUSE Leap

2020-05-22 Thread Antonio Rojas 
https://bugs.kde.org/show_bug.cgi?id=421902

Antonio Rojas  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||aro...@archlinux.org
 Resolution|--- |DOWNSTREAM

--- Comment #1 from Antonio Rojas  ---
Please report packaging issues to your distribution bug tracker

-- 
You are receiving this mail because:
You are the assignee for the bug.

D29756: Remove kiconthemes dependency

2020-05-14 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:d608a414e411: Remove kiconthemes dependency (authored by 
arojas).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29756?vs=82852=82854

REVISION DETAIL
  https://phabricator.kde.org/D29756

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configvalueprovider.cpp
  kded/gtkconfig.cpp

To: arojas, #plasma, ngraham, gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29756: Remove kiconthemes dependency

2020-05-14 Thread Antonio Rojas 
arojas created this revision.
arojas added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  It is unused since 702607595599d028e449891f6cf84ae6337344d0 


TEST PLAN
  Builds

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D29756

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configvalueprovider.cpp
  kded/gtkconfig.cpp

To: arojas, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26474: Fix build with gpsd 3.20

2020-01-06 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0c4974d68804: Fix build with gpsd 3.20 (authored by 
arojas).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26474?vs=72919=72921

REVISION DETAIL
  https://phabricator.kde.org/D26474

AFFECTED FILES
  dataengines/geolocation/location_gps.cpp

To: arojas, rikmills, #plasma, ivan
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26474: Fix build with gpsd 3.20

2020-01-06 Thread Antonio Rojas 
arojas created this revision.
arojas added reviewers: rikmills, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  gps_data_t.online has changed type from double to struct timespec

TEST PLAN
  Builds with gpsd 3.20 and 3.19

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26474

AFFECTED FILES
  dataengines/geolocation/location_gps.cpp

To: arojas, rikmills, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Fwd: Plasma 5.17 beta Discover system updates regression

2019-09-23 Thread Antonio Rojas 
El domingo, 22 de septiembre de 2019 16:13:09 (CEST), Luca Beltrame 
escribió:
In data domenica 22 settembre 2019 14:20:21 CEST, Myriam Schweingruber ha 
scritto:


(this might come in twice, due to gmane seemingly eating a message)


FYI, this is now reported on both Arch and Neon, with several dozen
duplicates in this bug report: https://bugs.kde.org/show_bug.cgi?id=411286


According to what I was told, Arch ships Qt 5.13.1 so should be 
not affected 
by this bug. Can this be confirmed?


Besides that, the bug report is about a crash: it has nothing to do with 
the issue being reported here, which is about preventing the updated from 
autostarting.

D24096: Restore appstream integration in kicker

2019-09-19 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: bshah.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  This got lost in the move from plasma-desktop

TEST PLAN
  libkickerplugin.so links to appstream-qt, "Uninstall or Manage Add-ons" is 
available in kicker context menu

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24096

AFFECTED FILES
  CMakeLists.txt

To: arojas, bshah
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22832: Fix build with pango 1.44

2019-08-24 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:cf8db4ebe5ef: Fix build with pango 1.44 (authored by 
arojas).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22832?vs=62800=64505

REVISION DETAIL
  https://phabricator.kde.org/D22832

AFFECTED FILES
  cmake/modules/FindGTK3.cmake

To: arojas, #plasma, ngraham
Cc: ngraham, apol, sitter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D22832: Fix build with pango 1.44

2019-08-24 Thread Antonio Rojas 
arojas added a comment.


  Ping, can this go in for 5.16.5?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D22832

To: arojas, #plasma
Cc: apol, sitter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D22832: Fix build with pango 1.44

2019-07-30 Thread Antonio Rojas 
arojas added a comment.


  In D22832#504428 , @sitter wrote:
  
  > Shouldn't this somehow be handled via pkg-config? IIRC .pc files can 
indicate dependencies, so I would assume one could get the requirements somehow 
and resolve those using generic code instead of essentially replicating the 
dependency information in cmake.
  
  
  'pkgconf --cflags gtk+-3.0' and 'pkgconf --libs gtk+-3.0' will recursively 
return all required cflags and ldflags. But it doesn't look like this is 
exposed in cmake's pkg_check_modules - this just returns the first-level 
dependencies.
  
  Anyhow, this is just a hotfix to make the current FindGTK3 work with the 
latest release of pango. Any further changes towards simplifying it should go 
in a different commit IMO.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D22832

To: arojas, #plasma
Cc: apol, sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22832: Fix build with pango 1.44

2019-07-30 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  pango>=1.44 headers depend on herfbuzz ones, make sure cmake can find them 
and pass the right include dir to the compiler

TEST PLAN
  Builds

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D22832

AFFECTED FILES
  cmake/modules/FindGTK3.cmake

To: arojas, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22707: Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage

2019-07-24 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b0f1d6620d78: Properly initialize oldStart and oldEnd in 
PreviewImageProvider::requestImage (authored by arojas).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22707?vs=62448=62452

REVISION DETAIL
  https://phabricator.kde.org/D22707

AFFECTED FILES
  kcms/fonts/previewimageprovider.cpp

To: arojas, bshah, fvogt, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22707: Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage

2019-07-23 Thread Antonio Rojas 
arojas added a comment.


  Just noticed this is fixed in master already, so this is for 5.16 only

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22707

To: arojas, bshah, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22707: Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage

2019-07-23 Thread Antonio Rojas 
arojas created this revision.
arojas added reviewers: bshah, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Otherwise they may not get assigned any value if the xft exclude range is 
(0,0), which will make them write random values to the xft exclude range later.
  
  BUG: 409518

TEST PLAN
  Open the fonts KCM a few times, check that no random font size interval is 
being excluded from antialiasing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22707

AFFECTED FILES
  kcms/fonts/previewimageprovider.cpp

To: arojas, bshah, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21489: Add a case for mkinitcpio (Arch Linux) in helper.cpp - plymouthhelper

2019-05-30 Thread Antonio Rojas 
arojas added a comment.


  Just a FYI, Arch is going switch away from mkinitcpio 
https://lists.archlinux.org/pipermail/arch-dev-public/2019-May/029570.html (Not 
saying this wouldn't be useful for the time being)

REPOSITORY
  R258 Plymouth KCM

REVISION DETAIL
  https://phabricator.kde.org/D21489

To: xnick, #plasma
Cc: arojas, lavender, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21257: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:ce0dd71daa86: Move knsrc files to the new location 
(authored by arojas).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21257?vs=58204=58213

REVISION DETAIL
  https://phabricator.kde.org/D21257

AFFECTED FILES
  gui/CMakeLists.txt

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21259: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:d9eb33df36b0: Move knsrc files to the new location 
(authored by arojas).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21259?vs=58206=58211

REVISION DETAIL
  https://phabricator.kde.org/D21259

AFFECTED FILES
  CMakeLists.txt

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21256: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:268ed1db19d5: Move knsrc files to the new location 
(authored by arojas).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21256?vs=58203=58210

REVISION DETAIL
  https://phabricator.kde.org/D21256

AFFECTED FILES
  applets/comic/CMakeLists.txt

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21255: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:041a9b08d5f4: Move knsrc files to the new location 
(authored by arojas).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21255?vs=58201=58208

REVISION DETAIL
  https://phabricator.kde.org/D21255

AFFECTED FILES
  CMakeLists.txt

To: arojas, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21259: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Instead of the old legacy /etc/xdg location

TEST PLAN
  knsrc files are installed under share/knsrcfiles

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D21259

AFFECTED FILES
  CMakeLists.txt

To: arojas, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21257: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Instead of the old legacy /etc/xdg location

TEST PLAN
  knsrc files are installed under share/knsrcfiles

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21257

AFFECTED FILES
  gui/CMakeLists.txt

To: arojas, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21256: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Instead of the old legacy /etc/xdg location

TEST PLAN
  knsrc files are installed under share/knsrcfiles

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21256

AFFECTED FILES
  applets/comic/CMakeLists.txt

To: arojas, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21255: Move knsrc files to the new location

2019-05-17 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Instead of the old legacy /etc/xdg location

TEST PLAN
  knsrc files are installed under share/knsrcfiles

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D21255

AFFECTED FILES
  CMakeLists.txt

To: arojas, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21246: Search also legacy location for knsrc files

2019-05-17 Thread Antonio Rojas 
arojas abandoned this revision.
arojas added a comment.


  OK I see in https://phabricator.kde.org/D19340 this is intentional

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21246

To: arojas, leinir, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21246: Search also legacy location for knsrc files

2019-05-16 Thread Antonio Rojas 
arojas updated this revision to Diff 58177.
arojas added a comment.


  Actually remove the conditional since 5.16 depends on KF 5.58

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21246?vs=58176=58177

REVISION DETAIL
  https://phabricator.kde.org/D21246

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: arojas, leinir, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21246: Search also legacy location for knsrc files

2019-05-16 Thread Antonio Rojas 
arojas created this revision.
arojas added reviewers: leinir, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Discover 5.16 beta only searches for knrsc files in the new 
/usr/share/knsrcfiles location, but most applications still install them to the 
legacy /etc/xdg location, so search there too.

TEST PLAN
  All categories are displayed instead of only a few of them

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21246

AFFECTED FILES
  libdiscover/backends/KNSBackend/KNSBackend.cpp

To: arojas, leinir, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

2019-03-17 Thread Antonio Rojas 
arojas added a comment.


  Apparently tooltips need a fix too 
https://bbs.archlinux.org/viewtopic.php?pid=1837417#p1837417

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma
Cc: arojas, rikmills, asturmlechner, kde-frameworks-devel, plasma-devel, 
michaelh, ngraham, bruns

D19607: Remove unused dependencies

2019-03-08 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R994:58beeb4837da: Remove unused dependencies (authored by 
arojas).

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19607?vs=53418=53443

REVISION DETAIL
  https://phabricator.kde.org/D19607

AFFECTED FILES
  CMakeLists.txt

To: arojas, nicolasfella, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19607: Remove unused dependencies

2019-03-08 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  These seem to be leftovers from plasma-pa

TEST PLAN
  Builds

REPOSITORY
  R994 Pulseaudio Qt Bindings

REVISION DETAIL
  https://phabricator.kde.org/D19607

AFFECTED FILES
  CMakeLists.txt

To: arojas, nicolasfella
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3

2018-10-27 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:c255ac792a0d: Fix connecting to PulseAudio with Qt 5.12 
beta 3 (authored by arojas).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16443?vs=44268=44284

REVISION DETAIL
  https://phabricator.kde.org/D16443

AFFECTED FILES
  src/context.cpp

To: arojas, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3

2018-10-26 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  After this commit [1] in Qt, 
QAbstractEventDispatcher::instance()->metaObject()->className() returns 
"QXcbGlibEventDispatcher", so the glib event loop test fails

TEST PLAN
  Applet works with Qt 5.12 beta 3

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16443

AFFECTED FILES
  src/context.cpp

To: arojas, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16081: Fix build with gpsd 3.18

2018-10-15 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:81a0fe6db9ac: Fix build with gpsd 3.18 (authored by 
arojas).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16081?vs=43233=43676

REVISION DETAIL
  https://phabricator.kde.org/D16081

AFFECTED FILES
  dataengines/geolocation/location_gps.cpp

To: arojas, #plasma, davidedmundson
Cc: rdieter, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16081: Fix build with gpsd 3.18

2018-10-09 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  The signature of gps_read has changed in 3.18 to add an optional buffer 
parameter.
  Passing NULL, 0 should keep the previous behavior, see 
https://git.savannah.gnu.org/cgit/gpsd.git/commit?id=6bba8b329fc7687b15863d30471d5af402467802

TEST PLAN
  Builds with gpsd 3.17 and 3.18. Can't test if it works since I don't have a 
gps device.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16081

AFFECTED FILES
  dataengines/geolocation/location_gps.cpp

To: arojas, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13911: Sync MAX_UID with upstream

2018-08-28 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:1421359002d6: Sync MAX_UID with upstream (authored by 
arojas).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13911?vs=37222=40540

REVISION DETAIL
  https://phabricator.kde.org/D13911

AFFECTED FILES
  src/advanceconfig.cpp

To: arojas, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13911: Sync MAX_UID with upstream

2018-08-28 Thread Antonio Rojas 
arojas added a comment.


  Ping

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D13911

To: arojas, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13981: Honor BUILD_TESTING

2018-07-10 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:7dd3aa0b2a4b: Honor BUILD_TESTING (authored by arojas).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13981?vs=37355=37516

REVISION DETAIL
  https://phabricator.kde.org/D13981

AFFECTED FILES
  CMakeLists.txt

To: arojas, mart, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein

D13981: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Only build tests if BUILD_TESTING is on

TEST PLAN
  Builds

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D13981

AFFECTED FILES
  CMakeLists.txt

To: arojas, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D13911: Sync MAX_UID with upstream

2018-07-06 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Dynamic users are getting more widely used in latest versions of systemd, and 
some users are reporting them showing up in SDDM. These users get an UID in the 
61184–65519 range. Lower MAX_UID to 6 to make sure they are not displayed 
in SDDM by default. This also brings this value in sync with the default 
upstream MaximumUID

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D13911

AFFECTED FILES
  src/advanceconfig.cpp

To: arojas, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13186: Use HiddenStatus when keyboard indicator is inactive

2018-05-29 Thread Antonio Rojas 
arojas added a comment.


  Right, I guess if someone disables everything on the config there's no way to 
reenable them in systray-embedded mode (well, removing and readding the applet 
will reset the config, but that's not obvoius)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13186

To: arojas, apol
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13186: Use HiddenStatus when keyboard indicator is inactive

2018-05-29 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  This way it doesn't take space in the systray popup or in the panel when 
inactive, which is not useful since the applet is not interactive.

TEST PLAN
  Applet disappears from panel and from systray popup when inactive instead of 
taking space, appears again when active.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D13186

AFFECTED FILES
  applets/keyboardindicator/contents/ui/main.qml

To: arojas, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13123: Make .deb and .rpm mime type handling optional at build time

2018-05-27 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:0e851f2b6899: Make .deb and .rpm mime type handling 
optional at build time (authored by arojas).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13123?vs=34908=35005

REVISION DETAIL
  https://phabricator.kde.org/D13123

AFFECTED FILES
  discover/CMakeLists.txt

To: arojas, apol
Cc: mak, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13123: Make .deb and .rpm mime type handling optional at build time

2018-05-27 Thread Antonio Rojas 
arojas added a comment.


  In D13123#269385 , @mak wrote:
  
  > Checking for the dpkg and rpm binaries isn't really foolproof, because you 
can install rpm on Debian and dpkg on Fedora & Co. easily.
  >  The only issue proof thing that I can imagine would be checking for the 
distribution name in /etc/os-release, or maybe checking for the presence of 
/etc/debian_version.
  
  
  Most (all?) distros build packages in some sort of minimal container, so I 
don't think that will be an issue in practice. Using the distribution name 
would require maintaining an exhaustive list of distributions using each 
package management system, not really feasible.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13123

To: arojas, apol
Cc: mak, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13123: Make .deb and .rpm mime type handling optional at build time

2018-05-27 Thread Antonio Rojas 
arojas added a comment.


  5.13 or master?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13123

To: arojas, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13123: Make .deb and .rpm mime type handling optional at build time

2018-05-26 Thread Antonio Rojas 
arojas updated this revision to Diff 34908.
arojas added a comment.


  Check for the presence of the dpkg and rpm binaries to decide whether to 
install the mime type handlers

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13123?vs=34887=34908

REVISION DETAIL
  https://phabricator.kde.org/D13123

AFFECTED FILES
  discover/CMakeLists.txt

To: arojas, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13119: Abort transaction on PK dependency resolution error

2018-05-26 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:ee8e49422118: Abort transaction on PackageKit errors 
(authored by arojas).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13119?vs=34886=34907

REVISION DETAIL
  https://phabricator.kde.org/D13119

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PKTransaction.cpp

To: arojas, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13123: Make .deb and .rpm mime type handling optional at build time

2018-05-25 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Having discover handle .deb packages is useless in non-Debian based distros. 
Same for .rpm. Almost all the times someone clicks on a .deb or .rpm file in a 
distro with a different package format they expect the archive to be opened in 
an archive extractor. Having it open in discover is annoying -at the very 
least- and potentially dangerous (if, for some reason, the wrong PK backend is 
installed, Discover may try to install the package, which could wreck the 
system).
  
  This patch makes handling of .deb and .rpm optional at build time.

TEST PLAN
  Tested all possible combinations of HANDLE_DEB and HANDLE_RPM, MimeType field 
in org.kde.discover.desktop contains the expected value every time.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13123

AFFECTED FILES
  discover/CMakeLists.txt

To: arojas, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13119: Abort transaction on PK dependency resolution error

2018-05-25 Thread Antonio Rojas 
arojas updated this revision to Diff 34886.
arojas added a comment.


  Remove wrong check for !m_proceedFunctions.isEmpty()

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13119?vs=34881=34886

REVISION DETAIL
  https://phabricator.kde.org/D13119

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PKTransaction.cpp

To: arojas, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13119: Abort transaction on PK dependency resolution error

2018-05-25 Thread Antonio Rojas 
arojas updated this revision to Diff 34881.
arojas added a comment.


  Check for ExitStatus in cleanup() and move setStatus there

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13119?vs=34873=34881

REVISION DETAIL
  https://phabricator.kde.org/D13119

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PKTransaction.cpp

To: arojas, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13119: Abort transaction on PK dependency resolution error

2018-05-25 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  If PackageKit throws a dependency resolution error, abort the transaction 
instead of finishing it anyway (potentially breaking the user's installation). 
This is far from ideal, but prevents Discover from performing destructive 
operations while the PackageKit issues are fixed
  
  BUG: 394327

TEST PLAN
  Tried to remove a package which is an optional dependency of another one on 
Arch (which gives a warning that PK can't handle), the operation was aborted.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13119

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PKTransaction.cpp

To: arojas, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12999: Fix always empty memory bar

2018-05-20 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:f54bcde16302: Fix always empty memory bar (authored by 
arojas).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12999?vs=34521=34529

REVISION DETAIL
  https://phabricator.kde.org/D12999

AFFECTED FILES
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml

To: arojas, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12999: Fix always empty memory bar

2018-05-20 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Add back the memoryUsageProportionsChanged() call that was removed in 
6e753e6653ace887daceea2d05cf35661a7d0422 


TEST PLAN
  Memory bar shows actual memory usage instead of being empty

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12999

AFFECTED FILES
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml

To: arojas, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9960: Query os-release for distro name

2018-01-18 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:2f4f9a48fcb8: Query os-release for distro name (authored 
by arojas).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9960?vs=25587=25597#toc

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9960?vs=25587=25597

REVISION DETAIL
  https://phabricator.kde.org/D9960

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp

To: arojas, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9960: Query os-release for distro name

2018-01-18 Thread Antonio Rojas 
arojas added a comment.


  In https://phabricator.kde.org/D9960#192840, @apol wrote:
  
  > Works for me.
  >  Maybe use PRETTY_NAME? It's supposed to be prettier and it's used to 
display after all.
  
  
  According to https://www.freedesktop.org/software/systemd/man/os-release.html 
both NAME and PRETTY_NAME should be suitable for presentation to the user, the 
difference being that PRETTY_NAME may contain the distro version and codename. 
IMO NAME fits better here, but I don't mind changing it if you'd rather use 
PRETTY_NAME.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9960

To: arojas, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9960: Query os-release for distro name

2018-01-18 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Look for the distro name in /etc/os-release and /usr/lib/os-release instead 
of relying on the external lsb-release tool, which may not be installed on the 
system (it is not in Arch by default). The lsb-release method is kept as a 
fallback.

TEST PLAN
  Distro name is displayed correctly in the sources list in Arch Linux without 
lsb-release installed

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D9960

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp

To: arojas, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8455: Fix DBus startup notification

2017-10-27 Thread Antonio Rojas 
arojas added a comment.


  Shouldn't this come with a kconf_update script? Already existing icons will 
not be fixed by this, since they use a copy of the desktop file in 
.local/share/plamsa_icons

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D8455

To: fvogt, #plasma, davidedmundson
Cc: arojas, ngraham, broulik, rikmills, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7999: Drop workaround for QQC1 QGuiApplication crashes

2017-10-22 Thread Antonio Rojas 
arojas added a comment.


  In https://phabricator.kde.org/D7999#158351, @arojas wrote:
  
  > Ping, can this go in? AFAIK the QGUIApplication crashes only happen now 
when explicitely setting the QQC*2* style to org.kde.desktop, which is 
unrelated to this change (and should be properly fixed instead of worked around 
here IMO)
  
  
  Scratch that, kalgebramobile still crashes with 
QT_QUICK_CONTROLS_1_STYLE=Desktop. Still, I don't think this is the place to 
workaround issues caused by users doing weird stuff - this behavior has 
probably been around forever since Qt5 and it was noticed only when Plasma 
started setting this env variable in startkde.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7999

To: arojas, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7999: Drop workaround for QQC1 QGuiApplication crashes

2017-10-22 Thread Antonio Rojas 
arojas added a comment.


  Ping, can this go in? AFAIK the QGUIApplication crashes only happen now when 
explicitely setting the QQC*2* style to org.kde.desktop, which is unrelated to 
this change (and should be properly fixed instead of worked around here IMO)

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7999

To: arojas, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D8350: Add categories in gallery desktop file

2017-10-17 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:68382196a5ef: Add categories in gallery desktop file 
(authored by arojas).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8350?vs=20924=20930

REVISION DETAIL
  https://phabricator.kde.org/D8350

AFFECTED FILES
  examples/gallerydata/metadata.desktop

To: arojas, mart, apol
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D8350: Add categories in gallery desktop file

2017-10-17 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 385430

TEST PLAN
  The gallery application appears in the Development section instead of "Lost 
and Found"

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8350

AFFECTED FILES
  examples/gallerydata/metadata.desktop

To: arojas, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8219: Move the git find_package call to where it's used

2017-10-17 Thread Antonio Rojas 
arojas closed this revision.
arojas added a comment.


  Committed in 
https://phabricator.kde.org/R169:e4bd62964198cea6cb1ac24d8a5200556186edc1

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8219

To: arojas, mart, davidedmundson
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8219: Move the git find_package call to where it's used

2017-10-09 Thread Antonio Rojas 
arojas created this revision.
arojas added a reviewer: mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Prevents getting a misleading "Could not find Git" cmake warning with no 
explanation whatsoever of what it's needed for when compiling projects that 
depend on kirigami.

TEST PLAN
  Compiled qqc2-desktop-style, didn't get a "Could not find Git" cmake warning.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D8219

AFFECTED FILES
  KF5Kirigami2Macros.cmake

To: arojas, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D7998: Stop setting the QQC1 style in startkde

2017-10-03 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:335116210b7c: Stop setting the QQC1 style in startkde 
(authored by arojas).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7998?vs=19950=20314

REVISION DETAIL
  https://phabricator.kde.org/D7998

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake

To: arojas, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7998: Stop setting the QQC1 style in startkde

2017-10-03 Thread Antonio Rojas 
arojas added a comment.


  Ping. Would be nice to get this in 5.11 to reduce environment noise.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7998

To: arojas, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7999: Drop workaround for QQC1 QGuiApplication crashes

2017-09-27 Thread Antonio Rojas 
arojas added a comment.


  Actually I can't reproduce the QQC1 crashes anymore, even with 
QT_QUICK_CONTROLS_1_STYLE set to Desktop

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7999

To: arojas, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7999: Drop workaround for QQC1 QGuiApplication crashes

2017-09-26 Thread Antonio Rojas 
arojas created this revision.
arojas added reviewers: davidedmundson, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Now that QT_QUICK_CONTROLS_1_STYLE is not set in startkde anymore, drop the 
workaround for QGuiApplication crashes. Qt already takes care of setting the 
QQC1 style to Desktop for QApplications, so there's no reason why this should 
need to be set explicitely. If someone still does, we can assume that they know 
what they're doing and the consequences thereof, including QGuiApplication 
crashes.
  
  Depends on https://phabricator.kde.org/D7998.

TEST PLAN
  With this and https://phabricator.kde.org/D7998, run kalgebramobile -> 
doesn't crash

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7999

AFFECTED FILES
  src/platformtheme/kdeplatformtheme.cpp

To: arojas, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7998: Stop setting the QQC1 style in startkde

2017-09-26 Thread Antonio Rojas 
arojas added a dependent revision: D7999: Drop workaround for QQC1 
QGuiApplication crashes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7998

To: arojas, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7998: Stop setting the QQC1 style in startkde

2017-09-26 Thread Antonio Rojas 
arojas created this revision.
arojas added reviewers: davidedmundson, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The reason why this was added (https://phabricator.kde.org/D7257) is not 
valid anymore now that we set the QQC2 style in C++. Setting it causes crashes 
in QGuiApplications that need to be worked around with an ugly hack in 
plasma-integration.

TEST PLAN
  Launch a QQC1 application, there's no warning that the "org.kde.desktop" 
style can not be found.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7998

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake

To: arojas, davidedmundson, fvogt
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7953: Use QQuickStyle to set the QQC2 style

2017-09-25 Thread Antonio Rojas 
arojas added a comment.


  In https://phabricator.kde.org/D7953#148962, @fvogt wrote:
  
  > This is not as clear as it could be. What about just not setting 
QT_QUICK_CONTROLS_1_STYLE in the first place?
  >  QT_QUICK_CONTROLS_1_STYLE is only necessary because of 
QT_QUICK_CONTROLS_STYLE.
  
  
  If the only reason for settings QT_QUICK_CONTROLS_1_STYLE in startkde was 
fixing the warning when QT_QUICK_CONTROLS_STYLE was set, I guess you can stop 
setting it now. But as long as it's being set in startkde it needs to be unset 
here to stop crashes all over the place.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7953

To: arojas, davidedmundson, #plasma
Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

2017-09-25 Thread Antonio Rojas 
arojas abandoned this revision.
arojas added a comment.


  Superseded by https://phabricator.kde.org/D7953

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7943

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7953: Use QQuickStyle to set the QQC2 style

2017-09-25 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:059369d6b6a9: Use QQuickStyle to set the QQC2 style 
(authored by arojas).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7953?vs=19828=19914

REVISION DETAIL
  https://phabricator.kde.org/D7953

AFFECTED FILES
  CMakeLists.txt
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kdeplatformtheme.cpp

To: arojas, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7953: Use QQuickStyle to set the QQC2 style

2017-09-25 Thread Antonio Rojas 
arojas added a comment.


  so is this OK for 5.11?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7953

To: arojas, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7953: Use QQuickStyle to set the QQC2 style

2017-09-23 Thread Antonio Rojas 
arojas edited the test plan for this revision.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7953

To: arojas, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

2017-09-23 Thread Antonio Rojas 
arojas added a comment.


  Opened https://phabricator.kde.org/D7953 for the QQuickStyle approach. 
Keeping this open in case the new dependency is not acceptable for 5.11 at this 
stage.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7943

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7953: Use QQuickStyle to set the QQC2 style

2017-09-23 Thread Antonio Rojas 
arojas created this revision.
arojas added reviewers: davidedmundson, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Use QQuickStyle::setStyle instead of an environment variable to set the QQC2 
desktop style. This prevent the style from being inherited by plasmashell (or 
krunner) child processes, which makes QGuiApplications crash. The QQC1 style 
still needs to be set via an environment variable, so we explicitely unset it 
for non-QApplications to prevent them from crashing.
  
  This adds a new QtQuickControls dependency, I hope it's OK at this stage (as 
it's already a dependency of other Plasma repos)

TEST PLAN
  Run systemsettings5 -> it is correctly themed
  Run minuet (pure QQC2) -> it doesn't crash
  Run kalgebra-mobile (QQC1 + QQC2) -> it doesn't crash.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7953

AFFECTED FILES
  CMakeLists.txt
  src/platformtheme/CMakeLists.txt
  src/platformtheme/kdeplatformtheme.cpp

To: arojas, davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

2017-09-23 Thread Antonio Rojas 
arojas added a comment.


  Indeed, replacing the qputenv line with 
QQuickStyle::setStyle(QLatin1String("org.kde.desktop")) fixes the inheritance 
problem: minuet doesn't crash anymore and systemsettings is correctly themed. 
Unfortunately QQC1 (such as kalgebramobile) still crash, is there something 
equivalent for QQC1?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7943

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

2017-09-22 Thread Antonio Rojas 
arojas added a comment.


  In https://phabricator.kde.org/D7943#148121, @davidedmundson wrote:
  
  > Revert what?
  
  
  The move of the style setting from startkde to plasma-integration

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7943

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

2017-09-22 Thread Antonio Rojas 
arojas added a comment.


  This change would also fix the crashes if the style was set in startkde as it 
used to, does it make sense to revert the change or you prefer to leave it 
where it is?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7943

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

2017-09-22 Thread Antonio Rojas 
arojas added a comment.


  In https://phabricator.kde.org/D7943#148093, @davidedmundson wrote:
  
  > I don't see why we should be unsetting anything if a user has explicitly 
gone out of their way to set it.
  >
  > We're not doing it from startkde anymore.
  
  
  It's not the user who sets it, it's plasmashell. See my last comment in bug 
384481

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7943

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7943: Explicitely unset QtQuickControls desktop style for non-QApplications

2017-09-22 Thread Antonio Rojas 
arojas created this revision.
arojas added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  QGuiApplications will crash if the QtQuickControls style (either 1 or 2) is 
set to desktop, so make sure to unset it in that case.

TEST PLAN
  Login to Plasma session, make sure that 
QT_QUICK_CONTROLS_STYLE=org.kde.desktop and 
QT_QUICK_CONTROLS_1_STYLE=/whatever/Desktop, check that Minuet, KAlgebra Mobile 
and the mapviewer example from QtLocation run correctly and don't crash anymore

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D7943

AFFECTED FILES
  src/platformtheme/kdeplatformtheme.cpp

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7590: Don't search for and link to libcln when using libqalculate>=2.0

2017-08-29 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b915e5b4bab1: Don't search for and link to libcln when 
using libqalculate>=2.0 (authored by arojas).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7590?vs=18894=18907

REVISION DETAIL
  https://phabricator.kde.org/D7590

AFFECTED FILES
  cmake/FindQalculate.cmake

To: arojas, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7590: Don't search for and link to libcln when using libqalculate>=2.0

2017-08-28 Thread Antonio Rojas 
arojas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Plasma doesn't use any cln code directly, only via libqalculate. In version 
2.0, libqalculate dropped cln in favor of gmp, so the cln dependency becomes 
unnecessary.

TEST PLAN
  The calculator runner builds and works with libqalculate 1.0 (which uses cln) 
and 2.0 (which doesn't)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7590

AFFECTED FILES
  cmake/FindQalculate.cmake

To: arojas, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6749: Use CMAKE_INSTALL_FULL_LIBEXECDIR

2017-07-17 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R838:718029526e32: Use CMAKE_INSTALL_FULL_LIBEXECDIR (authored 
by arojas).

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6749?vs=16804=16805

REVISION DETAIL
  https://phabricator.kde.org/D6749

AFFECTED FILES
  data/org.freedesktop.impl.portal.desktop.kde.cmake.in

To: arojas, jgrulich, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6749: Use CMAKE_INSTALL_FULL_LIBEXECDIR

2017-07-17 Thread Antonio Rojas 
arojas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  With CMAKE_INSTALL_LIBEXECDIR the dbus service file could get a relative 
path, which would break library location at runtime.

TEST PLAN
  Compiled with CMAKE_INSTALL_LIBEXECDIR=lib, running xdg-desktop-portal 
doesn't crash anymore.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6749

AFFECTED FILES
  data/org.freedesktop.impl.portal.desktop.kde.cmake.in

To: arojas, jgrulich, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6221: Drop unused dependencies

2017-06-14 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R118:d63149e27caf: Drop unused dependencies (authored by 
arojas).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6221?vs=15442=15455

REVISION DETAIL
  https://phabricator.kde.org/D6221

AFFECTED FILES
  CMakeLists.txt

To: arojas, #plasma, sebas
Cc: plasma-devel, #plasma, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6221: Drop unused dependencies

2017-06-14 Thread Antonio Rojas 
arojas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Builds, works

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D6221

AFFECTED FILES
  CMakeLists.txt

To: arojas, #plasma
Cc: plasma-devel, #plasma, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

Re: plasma 5.10 tars

2017-05-26 Thread Antonio Rojas 
El Thu, 25 May 2017 23:29:34 +0100, Jonathan Riddell escribió:

> Plasma 5.10 tars are now available on racnoss for packagers
> 
> Release is due on Tuesday
> 
> Jonathan

Hi,
 Signatures are missing.

--Antonio

D5850: Fix duplicate Discover entry on the Application Menu

2017-05-14 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:13d96d15a177: Fix duplicate Discover entry on the 
Application Menu (authored by arojas).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5850?vs=14504=14528

REVISION DETAIL
  https://phabricator.kde.org/D5850

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/org.kde.discover-flatpak.desktop

To: arojas, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D5850: Fix duplicate Discover entry on the Application Menu

2017-05-14 Thread Antonio Rojas 
arojas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

TEST PLAN
  Only one Discover entry is shown on the menu

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5850

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/org.kde.discover-flatpak.desktop

To: arojas, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

[Differential] [Closed] D4853: Find correct version of kirigami

2017-03-01 Thread Antonio Rojas 
This revision was automatically updated to reflect the committed changes.
Closed by commit R118:930621daed56: Make cmake search for the right version of 
Kirigami (authored by arojas).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4853?vs=11989=12036

REVISION DETAIL
  https://phabricator.kde.org/D4853

AFFECTED FILES
  CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arojas, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

[Differential] [Request, 4 lines] D4853: Find correct version of kirigami

2017-02-28 Thread Antonio Rojas 
arojas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  look and feel explorer was ported to kirigami2 in 
https://phabricator.kde.org/R118:db66899283cf5dcbe133ee8786b7665361182955, make 
cmake search for the right version of kirigami

TEST PLAN
  Builds, cmake reports kirigami2 as found (using kirigami 2.0)

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D4853

AFFECTED FILES
  CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: arojas, #plasma, mart
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Re: Review Request 129309: Fix broken systemloadviewer tooltip

2016-11-02 Thread Antonio Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129309/
---

(Updated Nov. 2, 2016, 8:01 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, David Edmundson and Miklós Máté.


Changes
---

Submitted with commit 02ebdb543506ce308a8e3e819ccb7d95c4b9bab4 by Antonio Rojas 
to branch Plasma/5.8.


Repository: kdeplasma-addons


Description
---

Commit 346b492 broke the systemloadviewer tooltip, it's trying to use a 
variable that is not defined.


Diffs
-

  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml bf299b7 

Diff: https://git.reviewboard.kde.org/r/129309/diff/


Testing
---

Tooltip works again


Thanks,

Antonio Rojas

Review Request 129309: Fix broken systemloadviewer tooltip

2016-11-02 Thread Antonio Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129309/
---

Review request for Plasma, David Edmundson and Miklós Máté.


Repository: kdeplasma-addons


Description
---

Commit 346b492 broke the systemloadviewer tooltip, it's trying to use a 
variable that is not defined.


Diffs
-

  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml bf299b7 

Diff: https://git.reviewboard.kde.org/r/129309/diff/


Testing
---

Tooltip works again


Thanks,

Antonio Rojas

Re: Review Request 128919: Search for a Prison version that actually exists

2016-09-16 Thread Antonio Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128919/
---

(Updated Sept. 16, 2016, 1:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Martin Gräßlin and Leslie Zhai.


Changes
---

Submitted with commit 663c51632861188a4554c8e1e5f4f915930a3d3e by Antonio Rojas 
to branch Plasma/5.8.


Repository: plasma-workspace


Description
---

Prison is not yet in Frameworks, and its version number in git HEAD is still 
5.25


Diffs
-

  klipper/CMakeLists.txt 6db2d79 

Diff: https://git.reviewboard.kde.org/r/128919/diff/


Testing
---

Prison is detected and support is compiled again.


Thanks,

Antonio Rojas

Review Request 128919: Search for a Prison version that actually exists

2016-09-15 Thread Antonio Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128919/
---

Review request for Plasma, Martin Gräßlin and Leslie Zhai.


Repository: plasma-workspace


Description
---

Prison is not yet in Frameworks, and its version number in git HEAD is still 
5.25


Diffs
-

  klipper/CMakeLists.txt 6db2d79 

Diff: https://git.reviewboard.kde.org/r/128919/diff/


Testing
---

Prison is detected and support is compiled again.


Thanks,

Antonio Rojas

[Powerdevil] [Bug 366402] Closing the lid triggers Sleep

2016-08-04 Thread Antonio Rojas via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=366402

Antonio Rojas <aro...@archlinux.org> changed:

   What|Removed |Added

 CC||aro...@archlinux.org

--- Comment #1 from Antonio Rojas <aro...@archlinux.org> ---
logind.conf has LidSwitchIgnoreInhibited=yes by default. In systemd<231 this
setting was ignored because of a bug that has been fixed in 231 [1]. So this is
intended behavior, if you want the lid switch inhibitor to work you need to set
LidSwitchIgnoreInhibited=no in logind.conf

[1]
https://github.com/systemd/systemd/commit/8121f4d209eca85dcb11830800483cdfafbef9b7

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: versioned dependencies on breeze

2016-07-13 Thread Antonio Rojas 
Martin Graesslin wrote:

> Well if KWin depends on Breeze you cannot parallel build KWin and Breeze.
> That should be obvious.

It could be theoretically possible to build Kwin and Breeze 5.7.1 in 
parallel against 5.7.0 packages if the dependencies were not versioned 
(actually parallel build was just an example - our main issue is that this 
makes it harder to build packages in a clean chroot)
 
> It does not make sense to have KWin depend on a Breeze of the previous
> version. Neither plasma-integration. Thus I even think that from a
> technical point of view that would be wrong.
> 

Not sure if it makes sense or not, just pointing out that this makes things 
harder for packagers.

It just seems strange to me that the dependency on Breeze (which is used to 
set the default style and doesn't actually use any API) is versioned, while 
for instance the dependency on libKWorkspace in plasma-desktop or 
powerdevil, which should be much more sensitive to API changes, is not 
versioned.

Perhaps a compromise could be to depend on the latest major version of the 
modules (since it seems unlikely that a bug fix release would break things)


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 365103] "Icons Tint to Match Highlight" makes icons invisible when "draw a thin line to indicate focus" is activated

2016-07-12 Thread Antonio Rojas via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=365103

Antonio Rojas <aro...@archlinux.org> changed:

   What|Removed |Added

 CC||aro...@archlinux.org

--- Comment #4 from Antonio Rojas <aro...@archlinux.org> ---
Can we have this in 5.7 please?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

versioned dependencies on breeze

2016-07-12 Thread Antonio Rojas 
In Plasma 5.7 both kwin and plasma-integration added strict versioned 
dependencies on Breeze:

find_package(Breeze ${PROJECT_VERSION} CONFIG)

Can this please be changed to depend on the actual minimum version required? 
There is no other versioned dependency between Plasma modules and it is 
quite inconvenient for packaging (as eg. it prevents parallel building)

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re:Plasma 5.6.5

2016-06-14 Thread Antonio Rojas 
Jonathan Riddell  Wrote in message:
> Plasma 5.6.5 is out, the last of the current series
> 
> https://www.kde.org/announcements/plasma-5.6.5.php
> 
> The tars come with nifty new .sig files which are PGP signatures so
> you can verify they are made by the same person who put up the
> announce on the website and match the signature on the tars in Git.
> 
> Jonathan

plasma-workspace doesn't build, commit 767aa57 needs to be backported

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

  1   2   >