Re: qml controls and documentation

2014-08-01 Thread Aurélien Gâteau
On Mon, Jul 28, 2014, at 15:26, Aleix Pol wrote: On Mon, Jul 28, 2014 at 8:07 PM, Marco Martin notm...@gmail.com wrote: On Monday 28 July 2014, Aleix Pol wrote: does somebody knows if is possible with the markup used now for extracting documentation to still have comments to

Re: Review Request 118665: Avoid invalid read in ShadowHelper destructor

2014-06-19 Thread Aurélien Gâteau
desktop does not print any error about invalid reads in ~ShadowHelper anymore. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118662: fix plugin install target for phonon platform plugin

2014-06-18 Thread Aurélien Gâteau
now. - Aurélien Gâteau On June 11, 2014, 10:51 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118662

Re: Review Request 118665: Avoid invalid read in ShadowHelper destructor

2014-06-13 Thread Aurélien Gâteau
not print any error about invalid reads in ~ShadowHelper anymore. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118665: Avoid invalid read in ShadowHelper destructor

2014-06-11 Thread Aurélien Gâteau
, but the changes are much more invasive. Diffs - kstyle/oxygenstyle.cpp 972e4c8 Diff: https://git.reviewboard.kde.org/r/118665/diff/ Testing --- Running valgrind kcmshell5 desktop does not print any error about invalid reads in ~ShadowHelper anymore. Thanks, Aurélien Gâteau

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-28 Thread Aurélien Gâteau
97cd3c1 Diff: https://git.reviewboard.kde.org/r/117954/diff/ Testing --- Program starts and looks like it behaves correctly. Unit-test is failing, but was already failing before :/ Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-23 Thread Aurélien Gâteau
05e425a keditfiletype/typeslistitem.cpp 97cd3c1 Diff: https://git.reviewboard.kde.org/r/117954/diff/ Testing --- Program starts and looks like it behaves correctly. Unit-test is failing, but was already failing before :/ Thanks, Aurélien Gâteau

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-23 Thread Aurélien Gâteau
On May 20, 2014, 5:08 p.m., Alexander Potashev wrote: You probably need to check in CMakeLists.txt that version of shared-mime-info is at least 0.40. Aurélien Gâteau wrote: shared-mime-info is only required at run time so I am not sure it makes sense to check at build time

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-22 Thread Aurélien Gâteau
--- On May 20, 2014, 4:56 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117954

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-20 Thread Aurélien Gâteau
://git.reviewboard.kde.org/r/117954/diff/ Testing --- Program starts and looks like it behaves correctly. Unit-test is failing, but was already failing before :/ Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 117884: rename binaries for co-installability

2014-05-02 Thread Aurélien Gâteau
to KIO According to LXR KMimeTypeChooser is only used in KIO, so this change would work. The problem is this would break source compatibility, and now that we are close to the release date I don't think Kevin or David would allow that. - Aurélien Gâteau On April 29, 2014, 6:16 p.m., Jonathan

Review Request 117954: Port keditfiletype away from kde4support

2014-05-02 Thread Aurélien Gâteau
it behaves correctly. Unit-test is failing, but was already failing before :/ Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117464: [kglobalaccel] Remove notification support

2014-04-10 Thread Aurélien Gâteau
: does not exist in index - Aurélien Gâteau On April 10, 2014, 8:20 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117464

Re: Review Request 117464: [kglobalaccel] Remove notification support

2014-04-10 Thread Aurélien Gâteau
On April 10, 2014, 9:17 a.m., Aurélien Gâteau wrote: Looks good, but patch does not apply here. It fails with: error: kglobalaccel/CMakeLists.txt: does not exist in index error: kglobalaccel/globalshortcutsregistry.cpp: does not exist in index error: kglobalaccel

Re: Review Request 117464: [kglobalaccel] Remove notification support

2014-04-10 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117464/#review55327 --- Ship it! Ship It! - Aurélien Gâteau On April 10, 2014, 8

Plasma Next + Apps view on build.kde.org

2014-03-19 Thread Aurélien Gâteau
Just a quick note to let you know I created a new view on build.kde.org which groups the jobs from Plasma Next and the available KF5 applications. You can find it here: http://build.kde.org/view/Plasma%20Next%20+%20Apps/ I hope it helps you tracking the state of our code. Feel free to extend it

Re: Plasma Next + Apps view on build.kde.org

2014-03-19 Thread Aurélien Gâteau
On Wed, Mar 19, 2014, at 3:21, Martin Gräßlin wrote: On Wednesday 19 March 2014 03:07:27 Aurélien Gâteau wrote: Just a quick note to let you know I created a new view on build.kde.org which groups the jobs from Plasma Next and the available KF5 applications. You can find it here: http

Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

2014-03-12 Thread Aurélien Gâteau
/#review52657 --- On March 11, 2014, 3:12 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714

Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

2014-03-12 Thread Aurélien Gâteau
/ Testing --- Rebuilt kde-workspace, dbusmenu-qt5 is found. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116599: Set minimum version of Wayland to 1.2

2014-03-05 Thread Aurélien Gâteau
://git.reviewboard.kde.org/r/116598/ is applied. Diffs - CMakeLists.txt 41923b6 Diff: https://git.reviewboard.kde.org/r/116599/diff/ Testing --- Fixes the build for me (Kubuntu Saucy, libwayland-client 1.1, no libwayland-egl) Thanks, Aurélien Gâteau

Review Request 116599: Set minimum version of Wayland to 1.2

2014-03-04 Thread Aurélien Gâteau
://git.reviewboard.kde.org/r/116599/diff/ Testing --- Fixes the build for me (Kubuntu Saucy, libwayland-client 1.1, no libwayland-egl) Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114932: Use QExplicitlySharedDataPointer as the replacement of KSharedPtr

2014-01-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114932/#review47363 --- Ship it! OK, go for it then. - Aurélien Gâteau On Jan. 9

Re: Review Request 114912: KSharedPtr = QWeakPointer and QSharedPointer

2014-01-09 Thread Aurélien Gâteau
(). Diffs - CMakeLists.txt 8b60011 src/plasma/CMakeLists.txt aced599 src/plasma/private/svg_p.h 5fdebf3 src/plasma/svg.cpp 6542b34 Diff: https://git.reviewboard.kde.org/r/114912/diff/ Testing --- Ran a plasma-shell session, did not notice any crash. Thanks, Aurélien

Review Request 114912: KSharedPtr = QWeakPointer and QSharedPointer

2014-01-08 Thread Aurélien Gâteau
/private/svg_p.h 5fdebf3 src/plasma/svg.cpp 6542b34 Diff: https://git.reviewboard.kde.org/r/114912/diff/ Testing --- Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114912: KSharedPtr = QWeakPointer and QSharedPointer

2014-01-08 Thread Aurélien Gâteau
/CMakeLists.txt aced599 src/plasma/private/svg_p.h 5fdebf3 src/plasma/svg.cpp 6542b34 Diff: https://git.reviewboard.kde.org/r/114912/diff/ Testing (updated) --- Ran a plasma-shell session, did not notice any crash. Thanks, Aurélien Gâteau

Re: Review Request 113433: Use FindDBusMenuQt5.cmake

2013-10-30 Thread Aurélien Gâteau
is detected and the statusnotifieritem dataengine builds. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aurélien Gâteau
://git.reviewboard.kde.org/r/113086/#comment30235 This is not exactly the same: if I am not mistaken, qWarning() will add extra spaces and maybe quotes around the '\n'. - Aurélien Gâteau On Oct. 3, 2013, 10:02 p.m., Aleix Pol Gonzalez wrote

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

2013-09-25 Thread Aurélien Gâteau
On Wednesday 25 September 2013 11:22:57 Sebastian Kügler wrote: CMake-gods, can you confirm the below? (It's inconsistent with my understanding, and how we've done it in the past months, I'd like to have a specialist opinion before going around and changing every single CMakeLists.txt in

Re: [homerun] Repeated Entries

2013-07-23 Thread Aurélien Gâteau
Le jeudi 18 juillet 2013 16:12:32 Sebastian Kügler a écrit : On Wednesday, July 17, 2013 17:36:43 Jacky Alcine wrote: Hey Plasma developers, Jacky here. I'm curious about how Homerun goes about rendering entries. I've noticed constantly that entries shown in Applications would appear in

Re: [RFC] Disable DrKonqi for KWin in stable releases

2013-04-30 Thread Aurélien Gâteau
Le Tuesday 30 April 2013 13:37:51 Martin Gräßlin a écrit : The nice side effect would be that it would look like improved quality as normaly a user wouldn't notice a KWin crash. It's a short flicker during which the window decorations got recrated, but that's it. Has there been a crash if

Review Request 110208: Fix memleak: make ~DialogShadows delete DialogShadows::Private

2013-04-26 Thread Aurélien Gâteau
--- Ran Plasma, without crash, tooltips still work. Ran upcoming, Plasma::Dialog-based, Colibri: the change makes Valgrind a bit happier. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Review Request 109946: Fix crash in SortFilterModel::mapRowFromSource()

2013-04-10 Thread Aurélien Gâteau
. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Potential new component for Plasma QML components: ShadowEffect

2013-04-04 Thread Aurélien Gâteau
On Thursday 04 April 2013, Aurélien Gâteau wrote: Hi, I would like to propose a new component for Plasma QML components: ShadowEffect. This component has been created for Homerun and is used to show a shadow behind texts when Homerun is used as a containment. there should be as little

Preparing release of Homerun 0.2.0

2013-02-23 Thread Aurélien Gâteau
Hi, I am planning a release of Homerun 0.2.0 on Tuesday, February 26th. That's quite soon, but I need to get it out in time for Kubuntu Raring feature-freeze, which is on March 7th (and to make things a bit more challenging I am leaving for vacations on the first week of March, so next week

Re: QML Placces design discussion

2013-02-13 Thread Aurélien Gâteau
Le Tuesday 12 February 2013 23:55:39 Mark a écrit : On Tue, Feb 12, 2013 at 8:06 PM, Shaun Reich sre...@kde.org wrote: On Tue, Feb 12, 2013 at 10:40 AM, Martin Gräßlin mgraess...@kde.org wrote: Technical implementation aside: I think that makes absolute sense: * one vd by default * do

Homerun and single-runner runners

2013-02-13 Thread Aurélien Gâteau
Hi, I have been working lately on adding better support for single-runner runners to Homerun. The code is currently available in the wip/single-runner branch of Homerun. This code exposes all runners which advertise single-runner mode as sources. When a single-runner is used, Homerun uses the

Re: QML Placces design discussion

2013-02-13 Thread Aurélien Gâteau
Le Wednesday 13 February 2013 11:04:06 Martin Gräßlin a écrit : On Wednesday 13 February 2013 10:58:09 Mark wrote: On Wed, Feb 13, 2013 at 10:38 AM, Aurélien Gâteau agat...@kde.org wrote: Le Tuesday 12 February 2013 23:55:39 Mark a écrit : [snip] Why are you folks discarding my usecase

Review Request 108938: Make Kate session runner support single runner mode

2013-02-13 Thread Aurélien Gâteau
--- Tested with upcoming single-runner support in Homerun, as mentioned on plasma-devel mailing-list. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML Placces design discussion

2013-02-13 Thread Aurélien Gâteau
On Wed, 13 Feb 2013 11:40:15 +0100, Marco Martin wrote: On Wednesday 13 February 2013, Mark wrote: That would probably be the best way i guess. But then we still have an empty taskbar area occupied by the pager during the 4.10 cycle. I can hardly imagine that to be the intention? It's just

Re: Re: QML Placces design discussion

2013-02-13 Thread Aurélien Gâteau
On Wed, 13 Feb 2013 12:23:41 +0100, Martin Gräßlin wrote: On Wednesday 13 February 2013 06:17:45 Aurélien Gâteau wrote: Since the virtual desktop kcm is already shown from within the pager applet configuration dialog, maybe it can simply be removed from systemsettings? erm no, I'm using

Re: QML Placces design discussion

2013-02-13 Thread Aurélien Gâteau
On Wed, 13 Feb 2013 13:11:13 +0100, Mark wrote: On Wed, Feb 13, 2013 at 12:17 PM, Aurélien Gâteau agat...@kde.org wrote: On Wed, 13 Feb 2013 11:40:15 +0100, Marco Martin wrote: On Wednesday 13 February 2013, Mark wrote: That would probably be the best way i guess. But then we still have

Re: Homerun and single-runner runners

2013-02-13 Thread Aurélien Gâteau
On Wed, 13 Feb 2013 12:45:33 +0100, Marco Martin wrote: if (query.contains(placeHolder)) { return query.replace(placeHolder, term); } else { return query + ' ' + term; } } Is there a better way to do this? uhm... RunnerManager::launchQuery(const QString term,

Re: Re: Re: QML Placces design discussion

2013-02-13 Thread Aurélien Gâteau
On Wed, 13 Feb 2013 13:44:31 +0100, Martin Gräßlin wrote: On Wednesday 13 February 2013 06:43:47 Aurélien Gâteau wrote: On Wed, 13 Feb 2013 12:23:41 +0100, Martin Gräßlin wrote: On Wednesday 13 February 2013 06:17:45 Aurélien Gâteau wrote: Since the virtual desktop kcm is already shown from

Re: QML Placces design discussion

2013-02-13 Thread Aurélien Gâteau
On Wed, 13 Feb 2013 13:50:08 +0100, Mark wrote: I'm just going to assume you're making a joke here. In case you're not: bad idea! Do you have arguments to back this bold claim? Sure. I've opened this topic to improve the pager for default usage: - Show it even when you have just one VD to

Re: Homerun and single-runner runners

2013-02-13 Thread Aurélien Gâteau
Le Wednesday 13 February 2013 14:10:40 Marco Martin a écrit : On Wednesday 13 February 2013, Aurélien Gâteau wrote: 3. I noticed some runners advertise single-runner mode but do not define a default syntax. Is it a bug or is there a reason for that? hmm, example? that indeed

Re: Homerun and single-runner runners

2013-02-13 Thread Aurélien Gâteau
Le Wednesday 13 February 2013 15:02:33 Aaron J. Seigo a écrit : 2. The way single-runners are queried is not very elegant. It looks like this: this probably should be provided by RunnerManager and RunnerSyntax. sth like: QString RunnerSyntax::asQuery(const QString userInput = QString())

Review Request 108922: Fix off-by-one error in RunnerModel

2013-02-12 Thread Aurélien Gâteau
/diff/ Testing --- Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 107600: Keep placeholder text visible when empty and focused

2013-02-06 Thread Aurélien Gâteau
. Aurélien Gâteau wrote: Makes sense. I am planning on providing a patch for Qt anyway. In the long run we should even be able to replace KLineEdit::clickMessage implementation to QLineEdit::placeHolder. Aaron J. Seigo wrote: In the long run we should even be able to replace KLineEdit

Re: Review Request 108700: Make sure Menu.status is set to Closed when the menu closes itself

2013-02-05 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108700/#review26519 --- On Feb. 1, 2013, 4:04 p.m., Aurélien Gâteau wrote

Review Request 108700: Make sure Menu.status is set to Closed when the menu closes itself

2013-02-01 Thread Aurélien Gâteau
/diff/ Testing --- Run attached testmenu.qml program. Without the patch, the text says Opened even after closing the menu. File Attachments Test program http://git.reviewboard.kde.org/media/uploaded/files/2013/02/01/testmenu.qml Thanks, Aurélien Gâteau

Re: Screen Edge handling in 4.11

2013-01-21 Thread Aurélien Gâteau
Le Monday 21 January 2013 11:03:53 Martin Gräßlin a écrit : Hi workspace devs, I just finished a rewrite of the Screen Edge handling in KWin [1] and now I want to tackle one of the long standing issues: hidden panel activation. For those who do not know the plans first designed years ago:

Re: Screen Edge handling in 4.11

2013-01-21 Thread Aurélien Gâteau
Le Monday 21 January 2013 12:37:04 Marco Martin a écrit : On Monday 21 January 2013, Martin Graesslin wrote: I take it this system will be implemented in a library. Do you plan for a fallback plan, in case the system is using another window manager? For example when running on Gnome,

Review Request 108422: Add configuration page for QML-based containments

2013-01-15 Thread Aurélien Gâteau
regressions. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 108423: Call Applet::configChanged() in Containment::configChanged()

2013-01-15 Thread Aurélien Gâteau
--- Tested with the text-shadows branch of kde:homerun, settings are correctly applied when the Apply button is clicked. Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108422: Add configuration page for QML-based containments

2013-01-15 Thread Aurélien Gâteau
/diff/ Testing --- Tested with the text-shadows branch of kde:homerun. Also used and configured other non-QML containment like Folder View to ensure the change does not introduce regressions. Thanks, Aurélien Gâteau ___ Plasma-devel mailing

Re: Follow up on doxyqml

2012-12-23 Thread Aurélien Gâteau
Le Thursday 20 December 2012 19:09:39 Aurélien Gâteau a écrit : Hi, Doxyqml, the Doxygen input filter for QML, has been deployed on api.kde.org. I then converted the doc of most QML components of kde- runtime/plasma/declarativeimport to use Doxygen (You may have noticed a series of commits

Follow up on doxyqml

2012-12-20 Thread Aurélien Gâteau
Hi, Doxyqml, the Doxygen input filter for QML, has been deployed on api.kde.org. I then converted the doc of most QML components of kde- runtime/plasma/declarativeimport to use Doxygen (You may have noticed a series of commits with messages like Doxygenize Foo). The only components I haven't

Re: Review Request: Keep placeholder text visible when empty and focused

2012-12-14 Thread Aurélien Gâteau
, visit: http://git.reviewboard.kde.org/r/107600/#review23416 --- On Dec. 12, 2012, 5:11 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request: Keep placeholder text visible when empty and focused

2012-12-12 Thread Aurélien Gâteau
, as can be seen in attached screenshot. Screenshots --- TextField with placeholder from Widget Gallery http://git.reviewboard.kde.org/r/107600/s/872/ Thanks, Aurélien Gâteau ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request: Keep placeholder text visible when empty and focused

2012-12-10 Thread Aurélien Gâteau
. - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107600/#review23194 --- On Dec. 5, 2012, 4:11 p.m., Aurélien Gâteau wrote

Review Request: Keep placeholder text visible when empty and focused

2012-12-05 Thread Aurélien Gâteau
/107600/diff/ Testing --- Ran widgetgallery with the patch code, as can be seen in attached screenshot. Screenshots --- TextField with placeholder from Widget Gallery http://git.reviewboard.kde.org/r/107600/s/872/ Thanks, Aurélien Gâteau

Re: Homerun sources and Plasma runners

2012-11-26 Thread Aurélien Gâteau
Le jeudi 22 novembre 2012 13:29:06 Aaron J. Seigo a écrit : Homerun AbstractSource class is not a model. It inherits from QObject and provide virtual methods to create models. A source must implement at least: QAbstractItemModel *createModelFromConfigGroup(const KConfigGroup group)

Re: Homerun sources and Plasma runners

2012-11-22 Thread Aurélien Gâteau
Le mercredi 21 novembre 2012 20:52:30 Marco Martin a écrit : On Wednesday 21 November 2012, Aurélien Gâteau wrote: Trying to map the way sources work to runners, instead of having a runner calling RunnerContext::addMatches(), a runner would have a createModel() method which would be called

Re: Doxygen and QML on api.kde.org

2012-11-22 Thread Aurélien Gâteau
Le mercredi 21 novembre 2012 12:11:20 Allen Winter a écrit : You should announce this on the doxygen-users mailing list Or I can do that if you want. It probably makes more sense if I am the one to do it, so that I can answer questions. Will let you know when I'm finished installing on

Re: Homerun sources and Plasma runners

2012-11-21 Thread Aurélien Gâteau
Le mardi 20 novembre 2012 20:16:17 Aaron J. Seigo a écrit : On Tuesday, November 20, 2012 18:12:47 Aurélien Gâteau wrote: First, I am convinced using Qt models is the right API design for Homerun. I nobody is saying don't use Qt models in homerun. My mistake. Should have written Qt models

Doxygen and QML on api.kde.org

2012-11-21 Thread Aurélien Gâteau
Hi Allen, I wrote a Doxygen input filter for QML, making it possible to document QML classes just like we document C++ classes. You can find it here: http://agateau.com/projects/doxyqml/ Plasma developers are interested in using this to document Plasma QML components. Do you think we can get

Re: Homerun sources and Plasma runners

2012-11-20 Thread Aurélien Gâteau
Spent yesterday evening trying to think about this topic from all edges. First, I am convinced using Qt models is the right API design for Homerun. I have a very hard time giving up on them for the sake of not breaking source compatibility, to the point where I think it is better to do a clean

Re: Homerun sources and Plasma runners

2012-11-19 Thread Aurélien Gâteau
Le vendredi 16 novembre 2012 18:16:12 Marco Martin a écrit : Sources features missing in Runners: - model-based = more QML friendly I still think that wrapped in a model or not is a detail. still don't see what advantages would bring the api being a model, rather a model being a client?

Re: Homerun sources and Plasma runners

2012-11-19 Thread Aurélien Gâteau
Le lundi 19 novembre 2012 14:58:40 Aurélien Gâteau a écrit : Le vendredi 16 novembre 2012 18:16:12 Marco Martin a écrit : Sources features missing in Runners: - model-based = more QML friendly I still think that wrapped in a model or not is a detail. still don't see what advantages

Re: Homerun sources and Plasma runners

2012-11-19 Thread Aurélien Gâteau
Le samedi 17 novembre 2012 12:56:13 Aaron J. Seigo a écrit : On Friday, November 16, 2012 17:04:04 Aurélien Gâteau wrote: A preliminary subject is API compatibility: I don't think it is possible to extend the current AbstractRunner interface in a BC way to meet our needs. Would you be ready

Homerun sources and Plasma runners

2012-11-16 Thread Aurélien Gâteau
Hi all, Yesterday afternoon, Aaron, Alex and I discussed Homerun sources, Plasma runners (and a few other topics). We agreed it would be better to have Homerun use Runners instead of proposing its own plugin API and eliminate as much as possible of the forked code. # Closing the gap between

Re: Introducing Homerun

2012-11-15 Thread Aurélien Gâteau
Le jeudi 15 novembre 2012 10:19:11 Marco Martin a écrit : On Wednesday 14 November 2012, Aurélien Gâteau wrote: I see that listview has a section property that would be exactly what is needed, while gridview doesn't, meh Agreed, I wish listview had a section property

Re: Introducing Homerun

2012-11-14 Thread Aurélien Gâteau
Le mardi 13 novembre 2012 11:23:00 Aaron J. Seigo a écrit : One of the main differences between Homerun sources and Plasma runners is that sources can provide default content as can runners (for many releases now). a Runner can define its default syntax, and that can then be

Re: Introducing Homerun

2012-11-14 Thread Aurélien Gâteau
Le lundi 12 novembre 2012 17:21:17 Nuno Pinheiro a écrit : Don't take my criticism the wrong way. No worry :) [snip] With all of that said allot of people use their desktop in deeply different ways than what I do, so :) probably allot of people will like it so ;) take what I say the

Re: Introducing Homerun

2012-11-14 Thread Aurélien Gâteau
Le mardi 13 novembre 2012 17:58:24 Oliver Henshaw a écrit : This discussion reminded me of https://blog.mozilla.org/faaborg/2009/10/13/browsing-your-personal-web/which is about search browse interfaces. Hope it's food for thought for anyone who hasn't seen it before - it certainly struck a

Re: Introducing Homerun

2012-11-14 Thread Aurélien Gâteau
Le mercredi 14 novembre 2012 12:33:55 Aaron J. Seigo a écrit : On Wednesday, November 14, 2012 11:30:58 Aurélien Gâteau wrote: Le mardi 13 novembre 2012 11:23:00 Aaron J. Seigo a écrit : krunnermodel, a Qt model that comes with a QML component plugin (so you can just import and use

Re: Introducing Homerun

2012-11-14 Thread Aurélien Gâteau
Le mercredi 14 novembre 2012 12:53:11 Marco Martin a écrit : On Wednesday 14 November 2012, Aurélien Gâteau wrote: krunnermodel, a Qt model that comes with a QML component plugin (so you can just import and use it directly) is in kde-runtime/plasma/declarativeimports I know about

Re: Introducing Homerun

2012-11-14 Thread Aurélien Gâteau
Le mardi 13 novembre 2012 16:59:59 Alex Fiestas a écrit : I see that at the moment it has the same kickoff sections which makes sense for an initial release. Have you thought on any alternative? I would like the Files tab to become something which shows all recent document activity. Also,

Re: Introducing Homerun

2012-11-14 Thread Aurélien Gâteau
Le mercredi 14 novembre 2012 15:26:03 Marco Martin a écrit : On Wednesday 14 November 2012, Aurélien Gâteau wrote: if you need to be able to group by runners, add that to the existing implementation. how does the model in homerun facilitate grouping by runner? In a scary way... you

Re: Introducing Homerun

2012-11-14 Thread Aurélien Gâteau
Le mercredi 14 novembre 2012 16:31:19 Aaron J. Seigo a écrit : On Wednesday, November 14, 2012 15:05:09 Aurélien Gâteau wrote: Le mercredi 14 novembre 2012 12:33:55 Aaron J. Seigo a écrit : On Wednesday, November 14, 2012 11:30:58 Aurélien Gâteau wrote: Le mardi 13 novembre 2012 11:23:00

Re: Introducing Homerun

2012-11-12 Thread Aurélien Gâteau
Le dimanche 11 novembre 2012 12:02:58 Aaron J. Seigo a écrit : On Friday, November 9, 2012 23:09:35 Aurélien Gâteau wrote: As you can see, it is a fullscreen launcher with content organized in tabs. i find it to be a very interesting approach, and one that imho has potential

Introducing Homerun

2012-11-09 Thread Aurélien Gâteau
Hi all, Some of you have already heard about Homerun, but it has never been properly announced on this mailing list. Time to fix this. # What is Homerun? Homerun is an alternative launcher for KDE Plasma, built using QML Plasma Components. It has been developed by Shaun Reich and I during the

Re: QML style guide

2012-10-30 Thread Aurélien Gâteau
Le lundi 29 octobre 2012 21:42:18 Aaron J. Seigo a écrit : hi.. we have a style guide for our C++ code: the kdelibs style, which was mostly borrowed from Qt. unfortunately for us there was no QML guide we could similarly abscond with. and it shows. summary - i've started putting

Re: QML style guide

2012-10-30 Thread Aurélien Gâteau
Le mardi 30 octobre 2012 18:16:26 Aurélien Gâteau a écrit : The only part I don't really like is putting left curly brace on its own line for functions because: - having different conventions for event-handlers and function code blocks look inconsistent - it differs from many coding

Re: Doxyqml, supporting type

2012-10-23 Thread Aurélien Gâteau
Le mardi 23 octobre 2012 00:23:25 Aleix Pol a écrit : I think you are great Aurélien :D *blushes* :) More seriously though, I think that a patch on some current code would be really helpful. Sure. When this is deployed, I want to go through the current documentation and split it

Re: Doxygen for QML components

2012-10-17 Thread Aurélien Gâteau
Le mardi 16 octobre 2012 21:39:15 Marco Martin a écrit : On Tuesday 16 October 2012, Aurélien Gâteau wrote: - document class elements with comment blocks located next to the documented element The code is available from kde:scratch/gateau/doxyqml . It is just a hack right now, using

Re: Doxygen for QML components

2012-10-17 Thread Aurélien Gâteau
Le mercredi 17 octobre 2012 16:20:26 Aleix Pol a écrit : The crude, done in 10 minutes one: Define a custom comment to set on the property alias to document the type. Something like this: property alias text: label.text // doxyqml: type=string I consider the second option more in

Doxygen for QML components

2012-10-16 Thread Aurélien Gâteau
Hi, Currently documentation for QML components is done via a big comment at the beginning of the QML files, which leads to duplication of information and thus sometimes synchronization problems. For example right now the TabBar documentation states it inherits from DualStateButton. I have

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-15 Thread Aurélien Gâteau
considered bad practice. :/ Maybe we can show the xscreensaver part when it's enabled? **Aleix turns the agateau-sign on** (see bat-signal for further reference) Aurélien Gâteau wrote: Played a bit with the .ui file and came up with this: http://simplest-image

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-10-11 Thread Aurélien Gâteau
://codereview.qt-project.org/#change,36859 - Aurélien Gâteau On Sept. 21, 2012, 3:29 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Aurélien Gâteau
On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: just an idea: what about hiding the whole X screen saver stuff behind another configure dialog. Looking at the screenshot I find the design puts emphasis on the wrong part: what we want to remove takes more than 50 % of the available

Re: share-like-connect in 4.10

2012-10-05 Thread Aurélien Gâteau
Le jeudi 4 octobre 2012 13:22:38 Aaron J. Seigo a écrit : On Thursday, October 4, 2012 09:06:10 Aurélien Gâteau wrote: Le jeudi 4 octobre 2012 00:25:53 Aaron J. Seigo a écrit : I also want to see this discussed properly on kde-devel and kde-usability. why kde-devel? and since

Re: Display Configuration KCM design review

2012-10-05 Thread Aurélien Gâteau
Le jeudi 4 octobre 2012 14:44:40 Aaron J. Seigo a écrit : On Thursday, October 4, 2012 14:01:04 Aurélien Gâteau wrote: Yes, that happens to me when I use my laptop with an external monitor: the bottom of the two screens do not line up, in which case does one NOT want the bottoms to line up

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-04 Thread Aurélien Gâteau
On Oct. 4, 2012, 1:27 a.m., Aleix Pol Gonzalez wrote: plasma/declarativeimports/plasmacomponents/qml/Button.qml, line 104 http://git.reviewboard.kde.org/r/106717/diff/1/?file=88339#file88339line104 unneeded change :) It is actually good practice to systematically use semi-colons at

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-04 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106717/#review19873 --- Looks good to me. - Aurélien Gâteau On Oct. 3, 2012, 10:01

Re: Review Request: Activities support for Gwenview

2012-10-04 Thread Aurélien Gâteau
in DocumentView::setCurrent(bool). - Aurélien Gâteau On Oct. 3, 2012, 5:03 p.m., Ivan Čukić wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106687

Re: Review Request: Activities support for Gwenview

2012-10-04 Thread Aurélien Gâteau
On Oct. 4, 2012, 8:12 a.m., Aurélien Gâteau wrote: With this new version we are back to one ResourceInstance per DocumentView, which makes sense to me, but could you then move the ResourceInstance back to DocumentViewPrivate instead of maintaining a QHash in DocumentViewContainer

Re: Display Configuration KCM design review

2012-10-04 Thread Aurélien Gâteau
Le jeudi 4 octobre 2012 13:38:06 Christoph Feck a écrit : On Thursday 04 October 2012 13:23:18 Marco Martin wrote: On Thursday 04 October 2012, todd rme wrote: On Thu, Oct 4, 2012 at 12:07 AM, Aaron J. Seigo ase...@kde.org wrote: 2. Can users move the screens by small amounts using

Re: Button component width

2012-10-04 Thread Aurélien Gâteau
Le jeudi 4 octobre 2012 13:06:15 Marco Martin a écrit : Command Buttons in Windows: http://msdn.microsoft.com/en-us/library/windows/desktop/aa511453.aspx#gene r al OS X, no explicit mention of size but look at the button screenshots in the Push Button section:

Re: RFC: move krunnermodel in org.kde.plasma.core

2012-10-03 Thread Aurélien Gâteau
Le mercredi 3 octobre 2012 13:20:43 Marco Martin a écrit : Hi all, for some reason the krunner model ended up into its own import, that doesn't make much sense and causes that tad ov overhead of having one more so. its real place would be org.kde.plasma.core together the other libplasma

  1   2   3   >