caspermeijn added a comment.
Can I do anything for this to get merged?
REPOSITORY
R169 Kirigami
BRANCH
about_icon (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D23241
To: caspermeijn, mart, apol, #kirigami, hein
Cc: bcooksley, sitter, ngraham, plasma-devel,
caspermeijn marked an inline comment as done.
caspermeijn added inline comments.
INLINE COMMENTS
> apol wrote in settings.h:81
> It could make sense to include the REVISION part:
> https://doc.qt.io/qt-5/properties.html
I have no idea what the value would be for that and Kirigami doesn't have
caspermeijn updated this revision to Diff 64512.
caspermeijn added a comment.
Fixed since version number
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23241?vs=63975=64512
BRANCH
about_icon (branched from master)
REVISION DETAIL
caspermeijn added a comment.
I am not sure about the version numbers and the return type. Did I choose the
correct ones?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D23241
To: caspermeijn, mart, apol
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol,
caspermeijn created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
caspermeijn requested review of this revision.
REVISION SUMMARY
With this it is not nessecary to KAboutData::setProgramLogo. If the
QApplication::setWindowIcon is set, then the
