D29024: feat(wayland): support multiple protocol extensions through plugin system

dvratil added a comment. If I may add my two cents here, I agree with David that introducing a plugin for a plugin is a bit over the top. Whats the issue with contributing your backend into libkscreen upstream instead? If there's any code that could be shared between KWayland backend and

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil added a comment. Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21905 To: dvratil, #plasma Cc: broulik, apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil updated this revision to Diff 77838. dvratil added a comment. - Simplify a bit more REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27675?vs=77837=77838 BRANCH arcpatch-D27675 REVISION DETAIL https://phabricator.kde.org/D27675 AFFECTED FILES

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil updated this revision to Diff 77837. dvratil added a comment. - Make the lambda more explicit - Address review comments REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27675?vs=76457=77837 BRANCH arcpatch-D27675 REVISION DETAIL

D10042: feat: parse EDID on the backend side

dvratil added a comment. Agreed. deviceId is not actually used (it's stored in KDED config files, but the value doesn't seem to be used anywhere). I'll fix it in a separate commit (since it also needs adjusting a bunch of unit-tests in libkscreen and kscreen). REPOSITORY R110 KScreen

D27677: feat: fix build after EDID changes in libkscreen

dvratil updated this revision to Diff 77830. dvratil added a comment. - Fix commit message REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27677?vs=76460=77830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27677 AFFECTED FILES

D10042: feat: parse EDID on the backend side

dvratil added a comment. Here's kscreen-console output for one of my monitors under Wayland with this patch applied: [15:31:16.520] kscreen-console(422251:422251) unknown: Id: 3 [15:31:16.520] kscreen-console(422251:422251) unknown: Name: "Eizo Nanao Corporation

D10042: feat: parse EDID on the backend side

dvratil updated this revision to Diff 77825. dvratil edited the summary of this revision. dvratil added a comment. - Rebase on current master - Move Edid construction to WaylandOutput::edid REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D10042: feat: parse EDID on the backend side

dvratil marked an inline comment as done. dvratil added inline comments. INLINE COMMENTS > romangg wrote in waylandbackend.cpp:81 > Let the backend populate the Private here is unusual, or is it not? On the > other side it makes sense. Let the consumer only access the public interface > and

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil added a comment. The system makes sense on X11 where you get something like `HDMI-1 (Sony GigaTV-12345)` so you see which device it is and what physical output it's connected to. Since KWin does not use to output names but only the names of the actually connected devices, the needed

D27677: feat: fix build after EDID changes in libkscreen

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D27677 AFFECTED FILES

D10042: Parse EDID on the backend side

dvratil updated this revision to Diff 76459. dvratil added a comment. - Rebased on master REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10042?vs=25805=76459 BRANCH arcpatch-D10042 REVISION DETAIL https://phabricator.kde.org/D10042 AFFECTED

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil added a comment. This is needed for D10042 (which I'm rebasing right now) when even on KWayland the `KScreen::Output` will have EDID attached (assembled from information provided by KWayland/KWin). Since on KWayland the output name already is

D27675: feat: Avoid duplicated text when assembling user-facing output names

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The string format by default is `Vendor Model (output)`, where `Vendor` and `Model` are read

D27626: refactor: fix various compiler warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R104:51fd586686a8: refactor: fix various compiler warnings (authored by dvratil). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27626?vs=76302=76377 REVISION DETAIL

D27626: refactor: fix various compiler warnings

dvratil added a comment. Also note that `noexcept` is not a compile-time check, it's a hint to enable some optimizations. It makes a difference when using standard library containers, e.g. `std::vector` will perform a copy if `T`'s move constructor is not `noexcept` in order to guarantee

D27626: refactor: fix various compiler warnings

dvratil added a comment. A good rule of a thumb is that your move constructor and assignment operator should always be `noexcept` unless you have a very good reason for them not to be. Qt has most move constructors marked as noexcept - I found a few that are not marked but that looks more

D27625: fix: handle when backend fails to load/initialize

This revision was automatically updated to reflect the committed changes. Closed by commit R110:ff98585ea554: fix: handle when backend fails to load/initialize (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27625?vs=76295=76359

D27626: refactor: fix various compiler warnings

dvratil added inline comments. INLINE COMMENTS > romangg wrote in output_model.h:90 > Why to add and why noexcept? Because in `output_model.cpp:224` we do `m_outputs.insert(i, Output(output, pos))`, which can make use of move semantics. Making move operations `noexcept` is part of Cpp Core

D27096: Refactoring, improve validation in kcm, optimize

dvratil added inline comments. INLINE COMMENTS > config_keys.h:23 > > -#include > +static const char CONFIG_TRIGGERWORD[] = "triggerWord"; > +static const char CONFIG_ALIASES[] = "aliases"; You could use `static constexpr QStringView CONFIG_TRIGGERWORD = u"triggerWord"` to get something

D27626: refactor: fix various compiler warnings

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Fixes pessimizing move, implicit copy assignment operator, copies in range for loops,

D27625: fix: handle when backend fails to load/initialize

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Fixes a null pointer dereference in GetConfigOperation when BackendManager fails to load a

D27618: fix(kwayland): wait longer for connection timeout and retry

This revision was automatically updated to reflect the committed changes. Closed by commit R110:691c85879caf: fix(kwayland): wait longer for connection timeout and retry (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D27618: fix(kwayland): fix crash when KWayland connection times out

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY During login creating the connection to Wayland server may take longer than 1 second (KWin

D27537: Fix simpleWrite test in kwaylandbackendtest

This revision was automatically updated to reflect the committed changes. Closed by commit R110:2fcd093919b8: fix(autotests): fix simpleWrite test in kwaylandbackendtest (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

This revision was automatically updated to reflect the committed changes. Closed by commit R110:63cab28e74ee: fix(kwayland): remove code with side-effects from Q_ASSERT (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D27537: Fix simpleWrite test in kwaylandbackendtest

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The test still fails on removeOutput test, but that's fixed by D27536

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

dvratil updated this revision to Diff 76082. dvratil added a comment. - Add bug reference REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27536?vs=76080=76082 BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27536 AFFECTED

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

dvratil updated this revision to Diff 76080. dvratil added a comment. - Fix typo REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27536?vs=76079=76080 BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27536 AFFECTED FILES

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

dvratil created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REPOSITORY R110 KScreen Library BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27536 AFFECTED FILES

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil added a comment. Also, could someone take a look at https://phabricator.kde.org/D21902 please? :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21905 To: dvratil, #plasma Cc: broulik, apol, ngraham, plasma-devel, LeGast00n, jraleigh,

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil added inline comments. INLINE COMMENTS > apol wrote in CalendarView.qml:196 > Maybe it should only be enabled if there's events to show? This ListItem represents an event, so there's always an event :) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil updated this revision to Diff 62597. dvratil added a comment. - Implement Kai's suggestion REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21905?vs=60070=62597 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21905 AFFECTED

Re: plasma-thunderbolt

gt; Jonathan -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key: 0x4D69557AECB13683 Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683 signature.asc Description: This is a digitally signed message part.

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil added a comment. Nothing. Same will happen for example when users click on an event from the Holidays or Astronomical Events calendar plugins as there are no viewers for those events and KOrganizer can only open events provided by the PIM plugin. As far as I know, the agenda

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Note that this depends on API that will be available first in KDE Frameworks 5.60, so this

D19011: Thunderbolt KCM and KDED module

dvratil abandoned this revision. dvratil added a comment. The code has been moved to a standalone plasma-thunderbolt repository, passed through kde-review and will be included in Plasmas 5.17 release. Thanks everyone for your feedback and comments! REPOSITORY R119 Plasma Desktop

D21873: search lib paths for boltd for debian systems

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R1044 Plasma Thunderbolt Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D21873 To: sitter, dvratil Cc: plasma-devel, LeGast00n,

D21527: Fix the 'Report bug' button being always disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R871:dd95de337e30: Fix the Report bug button being always disabled (authored by dvratil). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21527?vs=58992=59019 REVISION

D21527: Fix the 'Report bug' button being always disabled

dvratil created this revision. dvratil added a reviewer: dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The commit d4ae04a7

Re: Review Request: plasma-thunderbolt

On Wednesday, 15 May 2019 23:08:57 CEST Albert Astals Cid wrote: > El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > > Hi all, > > > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt > > KCM for Plasma. I i

Re: Review Request: plasma-thunderbolt

On Wednesday, 15 May 2019 15:55:01 CEST Friedrich W. H. Kossebau wrote: > Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > > Thus I'd kindly ask you to take one more look at the codebase [1] and let > > me know if there are any more issues to fix, or if

Review Request: plasma-thunderbolt

://phabricator.kde.org/D19011 [1] https://cgit.kde.org/plasma-thunderbolt.git -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key: 0x4D69557AECB13683 Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683 signature.asc

D21184: Take the screen geometry into account when positioning popup notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1e175254dd8c: [Notifications] Take the screen geometry into account when positioning popup… (authored by dvratil). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21184: Take the screen geometry into account when positioning popup notifications

dvratil created this revision. dvratil added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The availableScreenRect is relative to the current screen, so if the notification applet is

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. @broulik I asked on plasma-devel where to put this and got no definitive answer, so I put it here. Separate repo is fine with me, too. What name for the repo would you prefer? plasma-thunderbolt? I already have kcm_bolt scratch repo, so I can just "backport" the

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 57147. dvratil added a comment. - Update the icon - Rebase on current master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=54625=57147 BRANCH arcpatch-D19011 REVISION DETAIL

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. I realized we still need an icon for Thunderbolt (and thus for this KCM) - @abetts, @andreask, @trickyricky26, @ndavis - could one of you help me out, please? I have no clue about icons... REPOSITORY R119 Plasma Desktop REVISION DETAIL

Re: CI system maintainability

On Thursday, March 28, 2019 3:39:54 PM CET Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 11:27:44 CET schrieb Daniel Vrátil: > > I'm completely fine with mandatory code review for everything and I'd be > > happy to have this in PIM. I think the biggest problem in

Re: CI system maintainability

o truly appreciate it, not only as a huge learning experience but so many times just having a second pair of eyes to glance over my code has revealed issues that sometimes almost make me question my career choice as a programmer :-) I think this is especially important for projects li

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 54625. dvratil added a comment. Remove 'Help', 'Default' and 'Apply' buttons as they serve no purpose here, there's no help at the moment, there's no default state to revert to and the changes to devices are applied immediately. REPOSITORY R119

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. Ping, VDG folks are OK with this, how about Plasma :)? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham,

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 53323. dvratil added a comment. - Wording: Trust this Device/Revoke Trust button labels REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=52775=53323 BRANCH arcpatch-D19011 REVISION DETAIL

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 52775. dvratil added a comment. - Use colors in device status indicators REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=52593=52775 BRANCH arcpatch-D19011 REVISION DETAIL

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 52593. dvratil added a comment. - Wording: improved trust button labels, thanks for suggestions, Nate. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=52568=52593 BRANCH arcpatch-D19011 REVISION

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 52568. dvratil added a comment. - Wording: replaced Stored with Trusted - Layout: centered all controls on device view page REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=52255=52568 BRANCH

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. "Stored" is a term for a remembered device. When you authorize a device, the authorization is "stored", or remembered, so you don't have to authorize it again next time. Maybe "Remember" would be a better term, then? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 52255. dvratil added a comment. - fix look of the device list REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=51737=52255 BRANCH arcpatch-D19011 REVISION DETAIL https://phabricator.kde.org/D19011

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. Thanks for the feedback, I'll look into it asap. In the meantime, could I ask the VDG to create a Breeze icon for Thunderbolt? @abetts, maybe? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc:

D19011: Thunderbolt KCM and KDED module

dvratil added inline comments. INLINE COMMENTS > broulik wrote in DeviceList.qml:11 > You might want to be using a `ScrollViewKCM` and put the enable checkbox in > the `header` and the `ListView` in `view`, see for instance KWin's virtual > desktop KCM Hmm, but then I couldn't push the device

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 51737. dvratil marked 9 inline comments as done. dvratil added a comment. - Fixed typos - Unified license - Addresses comments from kbroulik REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19011: Thunderbolt KCM and KDED module

dvratil created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The KCM allows user to authorize and store (or forget) the authorization of Thunderbolt 3 devices. This is done by communicating

Re: Thunderbolt KCM

ate-of-thunderbolt-3-in-fedora > -28/ [2] https://wiki.gnome.org/Design/Whiteboards/ThunderboltAccess -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key: 0x4D69557AECB13683 Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683 signature.asc Description: This is a digitally signed message part.

Thunderbolt KCM

for Breeze for me ;-) [0] https://cgit.kde.org/scratch/dvratil/kcm_bolt.git [1] https://www.youtube.com/watch?v=Ivx7RHH_LBE -- Daniel Vrátil www.dvratil.cz | dvra...@kde.org IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde) GPG Key: 0x4D69557AECB13683 Fingerprint: 0ABD FA55 A4E6

D18093: Calculate screen scaling dynamically, so it always fits to the page

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Looks good REPOSITORY R104 KScreen BRANCH dynamic_scale REVISION DETAIL https://phabricator.kde.org/D18093 To: amantia, #plasma, dvratil Cc: ngraham, plasma-devel, jraleigh,

D18101: Don't reset the moved display position

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Looks OK to me. REPOSITORY R104 KScreen BRANCH fix_reset_output_pos REVISION DETAIL https://phabricator.kde.org/D18101 To: amantia, dvratil Cc: plasma-devel, jraleigh, GB_2,

D17682: Show unconnected displays at the right side of the main screen

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Sorry for the delay, I did not notice the review. Looks good. INLINE COMMENTS > qmlscreen.cpp:178 > { > -return 1.0 / 8.0; > +return 1.0 / 12.0; > } Maybe the scale could

D17686: Redraw the slider if modes have changed

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. Looks good to me. This whole thing could probably use some cleanup, but that's for another day :-) REPOSITORY R104 KScreen BRANCH Plasma/5.12 REVISION DETAIL

D17657: Notify also if modes have changed

dvratil added inline comments. INLINE COMMENTS > amantia wrote in output.cpp:583-585 > Good point, missed it. @dvratil any reason why it emits outputChanged and not > modesChanged? Actually setModes emits both, so maybe indeed it is easier to > just put modesChnaged there as well. I'm still

D17685: Notify also if modes have changed

dvratil accepted this revision. dvratil added a comment. This revision is now accepted and ready to land. You can close the review for master and commit this to the stable branch, then merge stable to master. REPOSITORY R110 KScreen Library BRANCH Plasma/5.12 REVISION DETAIL

D16898: [kcm] Remove profiles code

dvratil added a subscriber: afiestas. dvratil added a comment. Profiles were supposed to allow various screen layouts per single setup, for instance, if you have your monitor and TV both connected to your PC, you may want to have "Monitor", "Monitor+TV" and "TV-only" profiles. The idea was

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil added a comment. In D10040#286064 , @davidedmundson wrote: > @dvratil want me to finish this? @davidedmundson Yes, I'd appreciate it. I won't have time to look into this any time soon, sorry :( REPOSITORY R127 KWayland

D13487: Fix build against static Qt without QLibrary

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8a473e6e9ef0: Fix build against static Qt without QLibrary (authored by dvratil). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13487?vs=36028=36408 REVISION

D13487: Fix build against static Qt without QLibrary

dvratil created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Sometimes when Qt is built statically it is also built without support for QLibrary and friends,

D12685: Fix calendar view: hide unused start/end time labels in day events list

dvratil added a comment. I could imagine using something like "14:00 →" to indicate that the event starts today at 2PM but does not end today, and "→ 16:00" to indicate that this is a multi-day event that didn't start today and ends today at 4PM. Not sure how to indicate a multi-day

D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

This revision was automatically updated to reflect the committed changes. Closed by commit R120:27854ca9f48a: NotifcationPopup: workaround crash in Qt when appending empty actions array (authored by dvratil). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

dvratil updated this revision to Diff 30041. dvratil added a comment. Update explanation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11519?vs=30030=30041 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11519 AFFECTED FILES

D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

dvratil updated this revision to Diff 30030. dvratil added a comment. Add comment with explanation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11519?vs=30020=30030 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11519 AFFECTED

D11518: Use model reset rather than beginRemoveRows() to clear font groups

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d97d360ba408: Use model reset rather than beginRemoveRows() to clear font groups (authored by dvratil). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11519: NotifcationPopup: workaround crash in Qt when appending empty actions array

dvratil created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Appending an empty array of actions to QQmlListModel triggers an assert in Qt when built in debug

D11518: Use model reset rather than beginRemoveRows() to clear font groups

dvratil created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Calling beginRemoveRows() when the model is empty hits an assert in QAbstractItemModel which

D10896: Show config selection OSD when display button is pressed

dvratil accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH sebas/displaybutton REVISION DETAIL https://phabricator.kde.org/D10896 To: sebas, #plasma, dvratil Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10896: Show config selection OSD when display button is pressed

dvratil requested changes to this revision. dvratil added a comment. This revision now requires changes to proceed. Hmm, I guess you can now kill `m_buttonTimer`, `m_iteration`, `resetDisplaySwitch()` and `applyGenericConfig()` as well, as those are used exclusively by the config iteration.

D9414: Implement OSD to select action when unknown monitors is connected

This revision was automatically updated to reflect the committed changes. Closed by commit R104:5feb84305560: Merge branch dvratil/osd (authored by dvratil). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9414?vs=25635=27873#toc REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D9414: Implement OSD to select action when unknown monitors is connected

dvratil added a comment. @ngraham Yes, the screenshot is still accurate. If you want a screenshot with more of background or another background, I can provide one. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc:

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil updated this revision to Diff 25806. dvratil marked an inline comment as done. dvratil added a comment. Fix versioning REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10040?vs=25802=25806 BRANCH master REVISION DETAIL

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil marked 2 inline comments as done. dvratil added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice_interface.cpp:450 > You're not actually sending the serial number or eisa anywhere.. > > The others do it in sendGeometry (including the manufacturer) > > When you do

D10042: Parse EDID on the backend side

dvratil added a dependency: D10040: Add serial number and EISA ID to OutputDevice interface. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D10042 To: dvratil, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil added a dependent revision: D10042: Parse EDID on the backend side. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: dvratil, graesslin, sebas Cc: davidedmundson, plasma-devel, #frameworks, schernikov, ZrenBot, ngraham, alexeymin, progwolff,

D10042: Parse EDID on the backend side

dvratil created this revision. dvratil added a reviewer: sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Parse EDID on the backend side so that backends that don't have

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil added a dependent revision: D10041: Improve EDID information on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: dvratil, graesslin, sebas Cc: plasma-devel, #frameworks, schernikov, ZrenBot, ngraham, alexeymin, progwolff, lesliezhai,

D10040: Add serial number and EISA ID to OutputDevice interface

dvratil created this revision. dvratil added reviewers: graesslin, sebas. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. dvratil requested review of this revision. REPOSITORY R127 KWayland BRANCH

D9414: Implement OSD to select action when unknown monitors is connected

dvratil updated this revision to Diff 25635. dvratil added a comment. Please disregard the noise in this patch, sebas merged master into the dvratil/osd branch so I can't generate a proper diff against the base revision without the noise from master. REPOSITORY R104 KScreen CHANGES SINCE

D9414: Implement OSD to select action when unknown monitors is connected

dvratil marked 15 inline comments as done. dvratil added inline comments. INLINE COMMENTS > broulik wrote in osdmanager.cpp:60 > Shouldn't it rather do that in the plugin's `registerTypes`? We don't have a QML plugin :( This is the only C++ class that is exposed to the OSD QML. > broulik

D9462: KCM: show scaled outputs correctly

dvratil added a comment. Indeed, I'll rework the whole scaling thing to abstract away the difference between scaling in Wayland and in X11 including the UI side (it's not related to the OSD changes, I'm just trying to work around my silly decision to get a hi-dpi monitor alongside a regular

D9414: Implement OSD to select action when unknown monitors is connected

dvratil added a comment. In https://phabricator.kde.org/D9414#191653, @broulik wrote: > I think `OnScreenDisplay` implies being non-interactive on Wayland I could interact with the dialog on Wayland, so either it's not implied, or there's a bug in KWin :-) REPOSITORY R104

D9908: Wayland: add support for output type detection

This revision was automatically updated to reflect the committed changes. Closed by commit R110:b1428d1381e8: Wayland: add support for output type detection (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9908?vs=25431=25486

D9906: Wayland: don't update output configuration if there are no changes

This revision was automatically updated to reflect the committed changes. Closed by commit R110:daf107948d58: Wayland: dont update output configuration if there are no changes (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D9905: Don't create multiple in-process backend instances

This revision was automatically updated to reflect the committed changes. Closed by commit R110:6e37f3034f6c: Dont create multiple in-process backend instances (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9905?vs=25427=25484

D9904: Wayland: don't share the same Config between backend and clients

This revision was automatically updated to reflect the committed changes. Closed by commit R110:4abdc5b134a3: Wayland: dont share the same Config between backend and clients (authored by dvratil). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

  1   2   3   >