konstantinshtepa added a comment.
In https://phabricator.kde.org/D4204#80553, @davidedmundson wrote:
> Though really any max > min on the client is undefined behaviour, so it's
hard to say any is "right".
You are right. It's undefined behaviour. At current state there is a hole
konstantinshtepa updated this revision to Diff 10599.
konstantinshtepa added a comment.
Fixed littke bug which would happend with code
plasmoid.Layout.minimumHeight = 150
plasmoid.Layout.maximumHeight = 130
plasmoid.Layout.maximumHeight = 150
Bug led to maximumHeight = 150
konstantinshtepa updated the summary for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4204
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel,
konstantinshtepa added inline comments.
INLINE COMMENTS
> davidedmundson wrote in AppletAppearance.qml:445
> Edit, maybe it won't - that's why you have the separate Binding.
>
> However changing this to:
> minimumWidth: Math.min(minimumSize.width, maximumSize.width);
>
> for all 4
>
> would
konstantinshtepa updated this revision to Diff 10593.
konstantinshtepa marked an inline comment as done.
konstantinshtepa added a comment.
Removed Bindings
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4204?vs=10453=10593
BRANCH
konstantinshtepa added a comment.
In https://phabricator.kde.org/D4204#80142, @mart wrote:
> what i would like to have logically splitted is the management of the
floating property (and having positionItem()/releasePosition used around)
>
> and on the other hand the signal handlers
konstantinshtepa added inline comments.
INLINE COMMENTS
> davidedmundson wrote in AppletAppearance.qml:445
> Edit, maybe it won't - that's why you have the separate Binding.
>
> However changing this to:
> minimumWidth: Math.min(minimumSize.width, maximumSize.width);
>
> for all 4
>
> would
konstantinshtepa added inline comments.
INLINE COMMENTS
> davidedmundson wrote in AppletAppearance.qml:445
> Edit, maybe it won't - that's why you have the separate Binding.
>
> However changing this to:
> minimumWidth: Math.min(minimumSize.width, maximumSize.width);
>
> for all 4
>
> would
konstantinshtepa added inline comments.
INLINE COMMENTS
> davidedmundson wrote in AppletAppearance.qml:101
> this is broken.
>
> if I'm an applet and do:
> Plasmoid.Layout.maximumWidth = 50
>
> this appletItem.maximumWidth == 58 (assuming 4px margins)
> which is correct
>
> Now if I do:
>
>
konstantinshtepa updated the summary for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4204
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel,
konstantinshtepa added a comment.
In https://phabricator.kde.org/D4204#80106, @mart wrote:
> can this be splitted in multiple reviews/commits?
It can be splitted into multiple commits inside one branch so you can view
what exactly fix what. But multiple reviews based on master? I
konstantinshtepa updated this revision to Diff 10453.
konstantinshtepa added a comment.
Rewrited some code to better understanding
Fixed background-handle animation in plasmoidBackground. It was a little bug,
but I don't see any sense to report it now when patch are ready. Fixed it by
konstantinshtepa added a comment.
A detailed explanation of bugs, fixes and mechanics changes
===
Before anything else I'd like to explain why I need this patch. At winter
holidays I had a free time and decided to rewrite
konstantinshtepa updated the summary for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4204
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: konstantinshtepa, #plasma
Cc: davidedmundson, plasma-devel,
konstantinshtepa updated this revision to Diff 10447.
konstantinshtepa added a comment.
Fix commit message
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4204?vs=10446=10447
BRANCH
plasmoid_size_restraints
REVISION DETAIL
konstantinshtepa updated this revision to Diff 10446.
konstantinshtepa added a comment.
Turn on background width animation again.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4204?vs=10408=10446
BRANCH
plasmoid_size_restraints
REVISION DETAIL
konstantinshtepa updated this revision to Diff 10408.
konstantinshtepa added a comment.
Rewrited commit message in according to kde commit polititcs
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4204?vs=10407=10408
BRANCH
konstantinshtepa updated the summary for this revision.
konstantinshtepa updated the test plan for this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4204
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
konstantinshtepa updated this revision to Diff 10407.
konstantinshtepa added a comment.
Summary: reworked set of patches to plasma-desktop/containments/desktop to
fix bugs in plasmoid.
Fix for
- plasmoid applet missing maximum size handler
- plasmoid can't be set to declared
konstantinshtepa added a comment.
WARNING: Found a bug with plasmoid don't free all his space in LayoutManager
when changed from compactRepresentation to fullRepresentation. Don't push this
patch before I fix this bug.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
konstantinshtepa added a comment.
In https://phabricator.kde.org/D4204#78701, @davidedmundson wrote:
> That's quite a huge patch.
> Can you give a much bigger explanation on exactly what it's doing and why.
> "Fixes bug N" doesn't really explain what the original problem was.
konstantinshtepa changed the visibility from "konstantinshtepa (Konstantin
Shtepa)" to "Public (No Login Required)".
konstantinshtepa changed the edit policy from "konstantinshtepa (Konstantin
Shtepa)" to "All Users".
REPOSITORY
R119
konstantinshtepa created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Signed-off-by: Konstantin Shtepa <oss.konstantin.sht...@yandex.ru>
first step
release commit. Bugs fixed, plasmoid b
23 matches
Mail list logo
