use better names. Ready and Active sound the same thing to
me if I do not dig into the source code to figure out how they work.
- Lamarque Vieira Souza
On March 25, 2013, 3:23 p.m., Oliver Henshaw wrote:
---
This is an automatically
On March 25, 2013, 7:09 p.m., Lamarque Vieira Souza wrote:
ksmserver/screenlocker/greeter/greeterapp.cpp, line 143
http://git.reviewboard.kde.org/r/109693/diff/1/?file=121351#file121351line143
Solid::PowerManagement::supportedSleepStates() is not a dbus call and
it already caches
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108797/#review26744
---
Ship it!
Ship It!
- Lamarque Vieira Souza
On Feb. 6, 2013
On Oct. 12, 2012, 1:34 p.m., Sebastian Kügler wrote:
Screenshot: Tooltip with mounted device
http://git.reviewboard.kde.org
This tooltip looks really odd and out of place this way.:/
The transparency effect does not look good here. I would like to know how to
disable it too, there
generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106123/
---
(Updated Aug. 22, 2012, 9:06 p.m.)
Review request for Plasma, Lamarque Vieira Souza and Martin Gräßlin.
Description
---
Fix for Kickoff-Widget
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106097/#review18065
---
Ship it!
Ship It!
- Lamarque Vieira Souza
On Aug. 20, 2012
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104431/#review12429
---
Ship it!
Ship It!
- Lamarque Vieira Souza
On April 6, 2012
.
- Lamarque Vieira Souza
On April 11, 2012, 8:27 p.m., makis marimpis wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104428
/globalshortcuts.cpp
http://git.reviewboard.kde.org/r/104428/#comment9660
same here. Besides, callWithArgumentList is synchronous and since you do
not care about the returned valued then it's better change this to asynchronous
call.
- Lamarque Vieira Souza
On April 4, 2012, 6:56 a.m., makis
On April 4, 2012, 5:13 p.m., Lamarque Vieira Souza wrote:
service/plugins/globalshortcuts/globalshortcuts.cpp, line 41
http://git.reviewboard.kde.org/r/104428/diff/4/?file=55580#file55580line41
Maybe the slowness has nothing to do with your patch. Last weekend I
was debugging
()));
}
According to Plugin.h the virtual init() should be explictitly called and
the way you did you are doing it automatically.
- Lamarque Vieira Souza
On April 11, 2012, 5:41 p.m., makis marimpis wrote
://git.reviewboard.kde.org/r/104428/#comment9678
There is a missing watcher-deleteLater() here.
Awesome, now we are moving forward :-)
- Lamarque Vieira Souza
On April 11, 2012, 8:06 p.m., makis marimpis wrote
/#review12037
---
On March 30, 2012, 6:57 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104417
to KDE/4.8
and encrypted activities is a new feature that has not (and will never be)
backported to KDE/4.8. Please uncomment the lines about encrypted activities.
- Lamarque Vieira Souza
On March 28, 2012, 1:56 a.m., David Edmundson wrote
*)),
this, SLOT(updateNextActivityName(QDBusPendingCallWatcher*)));
}
- Lamarque Vieira Souza
On March 31, 2012, 7:48 p.m., makis marimpis wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
the whole desktop freezes.
Usually the splash screen hides this problem, in my case there were no
splash screen since I restarted only kded4.
- Lamarque Vieira Souza
On April 4, 2012, 6:56 a.m., makis marimpis wrote
://git.reviewboard.kde.org/r/104428/#comment9507
Normalize this connect statement (just remove const word, char and
any space inside the parentesis in SIGNAL() and SLOT(). They are not needed and
cause QObject::connect to be a bit slower.
- Lamarque Vieira Souza
On March 31, 2012, 4:19 p.m., makis marimpis
statement. Read my old
review to know how to do that.
- Lamarque Vieira Souza
On March 31, 2012, 6:15 p.m., makis marimpis wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104428
.
- Lamarque Vieira
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104417/#review12037
---
On March 30, 2012, 6:57 p.m., Lamarque Vieira Souza
On March 30, 2012, 8:18 p.m., Thomas Lübking wrote:
service/jobs/nepomuk/Move.cpp, line 352
http://git.reviewboard.kde.org/r/104417/diff/5/?file=55320#file55320line352
!QUrl::isLocalFile()?
Lamarque Vieira Souza wrote:
isLocalFile() was introduced in Qt 4.8.0 and we still
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104422/#review11967
---
Ship it!
Ship It!
- Lamarque Vieira Souza
On March 27
of the file url when the
resource type is image.
Thanks,
Lamarque Vieira Souza
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
(updated)
-
service/jobs/nepomuk/Move.h 8a8afd1
service/jobs/nepomuk/Move.cpp 08a3cc2
Diff: http://git.reviewboard.kde.org/r/104417/diff/
Testing
---
Works on Meego devel image. The file is copied and no error message is shown.
Thanks,
Lamarque Vieira Souza
---
On March 26, 2012, 6:04 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104417
/nepomuk/Move.cpp 08a3cc2
Diff: http://git.reviewboard.kde.org/r/104417/diff/
Testing
---
Works on Meego devel image. The file is copied and no error message is shown.
Thanks,
Lamarque Vieira Souza
___
Plasma-devel mailing list
Plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104417/#review11909
---
On March 27, 2012, 2:22 p.m., Lamarque Vieira Souza wrote
(and for everyone else)
This does not sound as if the current move has a problem, but the design of
those private activities has (single user approach - fix that by logging
him in as root and watch the project fail ;-)
Lamarque Vieira Souza wrote:
Yes, the new patch silently skips
(and for everyone else)
This does not sound as if the current move has a problem, but the design of
those private activities has (single user approach - fix that by logging
him in as root and watch the project fail ;-)
Lamarque Vieira Souza wrote:
Yes, the new patch silently skips
Diff: http://git.reviewboard.kde.org/r/104417/diff/
Testing
---
Works on Meego devel image. The file is copied and no error message is shown.
Thanks,
Lamarque Vieira Souza
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
---
Thanks,
Lamarque Vieira Souza
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
.
Thanks,
Lamarque Vieira Souza
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
://git.reviewboard.kde.org/r/103469/#review9078
---
On Dec. 19, 2011, 2:02 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
,
Lamarque Vieira Souza
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103434/#review9030
---
On Dec. 16, 2011, 9:13 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail
-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103434/#review9031
---
On Dec. 16, 2011, 9:13 p.m., Lamarque Vieira Souza wrote:
---
This is an automatically generated e-mail
://git.reviewboard.kde.org/r/103434/diff/diff
Testing
---
Works in Plasma Active. In Plasma Desktop kcmlocale does not call
KGlobalSettings::self()-emitChange(KGlobalSettings::SettingsChanged) so it
does not take effect. Other kcm modules (e.g. keyboard), call emitChange.
Thanks,
Lamarque Vieira Souza
.
Thanks,
Lamarque Vieira Souza
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
37 matches
Mail list logo
