D22748: whitelist the "turn off screen" shortcut on the lock screen

This revision was automatically updated to reflect the committed changes. Closed by commit R133:5ed0dc17f3f9: Allow the turn off screen to be used from the lockscreen (authored by mblumenstingl). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

D22748: whitelist the "turn off screen" shortcut on the lock screen

mblumenstingl added a comment. In D22748#502337 , @mblumenstingl wrote: > I did some more digging and I now believe that I'm facing a problem that's related to me running wayland. > >

D22748: whitelist the "turn off screen" shortcut on the lock screen

mblumenstingl added a comment. I did some more digging and I now believe that I'm facing a problem that's related to me running wayland. https://github.com/KDE/kwindowsystem/blob/05f5379c24a59e1ded2f12a6fd09946617abd0ac/src/kkeyserver.h#L29 KKeyServer has a compile-time switch for

D22261: Add a global shortcut action to turn off the screen

mblumenstingl added a comment. In D22261#502044 , @broulik wrote: > Just checking, are you still up for making this kscreenlocker change? Given the heatwave right now I would have loved to be able to turn off my screens on the lock screen

D22748: whitelist the "turn off screen" shortcut on the lock screen

mblumenstingl created this revision. mblumenstingl added a reviewer: broulik. mblumenstingl added a project: Plasma. mblumenstingl requested review of this revision. REVISION SUMMARY This is a follow-up to D22261 unfortunately the test plan is not

D22261: Add a global shortcut action to turn off the screen

ommit access but I'm not sure if I still have. either way, I would be more comfortable with you committing this with the following author information: Martin Blumenstingl >> I tried adding |Turn Off Screen to the powerdevil QRegularExpression but I couldn't turn off the display fr

D22261: Add a global shortcut action to turn off the screen

mblumenstingl added a comment. In D22261#490660 , @broulik wrote: > Bonus points if you also make a patch for kscreenlocker globalaccel.cpp to whitelist this new action so that it also works on the lock screen. I tried adding `|Turn Off

D22261: Add a global shortcut action to turn off the screen

mblumenstingl added inline comments. INLINE COMMENTS > broulik wrote in powerdevildpmsaction.cpp:83 > I suppose there's no `Qt::Key_` enum for that, given laptops typically bypass > the operating system here anyway. I couldn't find any appropriate `Qt::Key_` so I'm leaving it up to the user to

D22261: Add a global shortcut action to turn off the screen

mblumenstingl updated this revision to Diff 61124. mblumenstingl marked 5 inline comments as done. mblumenstingl added a comment. updated patch to address the comments from @broulik REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22261?vs=61118=61124

D22261: Add a global shortcut action to turn off the screen

mblumenstingl created this revision. mblumenstingl added a reviewer: Plasma. mblumenstingl added a project: Plasma. Herald added a subscriber: plasma-devel. mblumenstingl requested review of this revision. REVISION SUMMARY PowerDevilDPMSAction already provides implementations for X11 and

Review Request: kdelibs: default-values in config files should be able to handle code-generated default values

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5525/ --- Review request for Plasma. Summary --- For some projects it's

Review Request: kdebase: add support for ScriptEngine::evaluate() in the JavaScript Engine (depends on 5525)

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5526/ --- Review request for Plasma. Summary --- This adds support for

Re: Review Request: kdelibs: default-values in config files should be able to handle code-generated default values

. To reply, visit: http://svn.reviewboard.kde.org/r/5525/#review7951 --- On 2010-10-03 18:10:47, Martin Blumenstingl wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request: Add an unit test for Plasma::ConfigLoader

On 2010-09-12 21:47:38, Martin Blumenstingl wrote: /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp, line 172 http://svn.reviewboard.kde.org/r/5329/diff/1/?file=35739#file35739line172 I am not sure why, but actual is always empty. I can't figure out the reason, because

Re: Review Request: Add an unit test for Plasma::ConfigLoader

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/ --- (Updated 2010-09-13 17:51:03.041714) Review request for Plasma. Changes

Review Request: Add an unit test for Plasma::ConfigLoader

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/ --- Review request for Plasma. Summary --- Currently I'm changing some of

Re: Review Request: Add an unit test for Plasma::ConfigLoader

in my test. - Martin On 2010-09-12 21:45:48, Martin Blumenstingl wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329