Re: Latte Dock Farewell

+1 Στις Σάβ, 30 Ιουλ 2022, 5:29 μ.μ. ο χρήστης Aleix Pol έγραψε: > On Sat, Jul 30, 2022 at 2:31 PM Nicolas Fella > wrote: > > > > On 7/27/22 13:14, Aleix Pol wrote: > > > On Wed, Jul 27, 2022 at 12:15 PM Jonathan Riddell > wrote: > > >> Michail has announced he's not going to be developing Lat

Improve Latte integration with Plasma

Hello, During the last KDE Sprint of June 2021 we decided that improving Latte integration with Plasma would be very appreciated. In that manner I had prepared some patches that need review and one, two more that I will send them in the future. The first one is looknfeel support for latte layouts

D29823: Increasing the zoom effect and adding "launcherBounceLevel" config option

mvourlakos added a comment. Sorry I don't like the idea adding such option. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D29823 To: parsa, mvourlakos Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, jraleigh, zachus, mbehrendt, fbam

D29823: Increasing the zoom effect and adding "launcherBounceLevel" config option

mvourlakos added a comment. if you want to increase the bouncing level the right line is at: https://invent.kde.org/plasma/latte-dock/-/blob/master/plasmoid/package/contents/ui/main.qml#L982 you just need to increase the value of 1.65 to something bigger. Otherwise the calculated masks

D29823: Increasing the zoom effect and adding "launcherBounceLevel" config option

mvourlakos requested changes to this revision. mvourlakos added a comment. This revision now requires changes to proceed. 5. this patch only increases the thickness of launcher animation I dont consider this an improvement. This is subjective REPOSITORY R878 Latte Dock REVISION DETAIL ht

D29823: Increasing the zoom effect and adding "launcherBounceLevel" config option

mvourlakos added a comment. 1. Provide videos with before and after 2. I dont think I am interested in adding a bounce slider in Tasks for this 3. You increase the max zoom factor to 500% this is out of scope 4. I can accept an improvement for bouncing animation but without [2] and [3] a

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mvourlakos added a comment. no prob, take your time... REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D27939 To: mbehrendt, mvourlakos Cc: plasma-devel, acemond, Orage, LeGast00n, The-Feren-OS-Dev, cblack, kkoma, jraleigh, zachus, mbehrendt, fbampaloukas, GB_2, n

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mvourlakos added a comment. The gap you see comes from the specific plasma theme, so this is plasma theme responsibility. That specific theme probably has that gap in its tasks svg. Having an option means that the user can always disable/enable that specific functionality if a plasma the

D27939: Rotate Grouping triangle for plasma indicator if revered option is enabled

mvourlakos added a comment. I think it is better to have an option for this in order to not be applied always when the user reverses the indicator.. And also are you sure that this way the growing circle animation of the indicator is still working correctly? REPOSITORY R878 Latte Dock

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

mvourlakos added a comment. For reference https://en.m.wikipedia.org/wiki/Golden_ratio REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27329 To: trmdi, #vdg, #plasma, ngraham Cc: mvourlakos, filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, c

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

mvourlakos added a comment. In D27329#611906 , @trmdi wrote: > How about this? > F8104781: image.png You can also try the GoldNumber/Ratio that is found in all real nature patterns and also at Anc

D26760: Update from Plasma for ToolTipInstance.qml

mvourlakos added a comment. I would prefer to be separate commits. Please commit this one and we can discuss in upcoming commit the highlight changes REPOSITORY R878 Latte Dock BRANCH update-ToolTipInstance-fromPlasma (branched from master) REVISION DETAIL https://phabricator.kde.org/

D26760: Update from Plasma for ToolTipInstance.qml

mvourlakos added a comment. @trmdi have you checked the previews still work OK after the patch? INLINE COMMENTS > ToolTipInstance.qml:159 > Layout.alignment: Qt.AlignRight | Qt.AlignTop > - > -height: units.iconSizes.smallMedium > -width: height > - > -

D26760: Update from Plasma for ToolTipInstance.qml

mvourlakos added a comment. Is there any improvement, or it is just a code update? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26760 To: trmdi, #latte_dock Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

mvourlakos added a comment. In D26399#587183 , @bcooksley wrote: > It was the Latte Dock code that needed adjusting to make use of ECM's `KDECompilerSettings` module. Oh, I had commented a line in cmake... I can not remember why... n

D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined

mvourlakos added a comment. In D26399#587161 , @jjazeix wrote: > In D26399#587133 , @bcooksley wrote: > > > Unfortunate, it definitely looked like QMLLint was the cause of the issues. > > > > Gi

D25807: Allow to set the available screen rect/region from outside through dbus

mvourlakos added a comment. In D25807#584697 , @trmdi wrote: > Thank you so much @davidedmundson! > > @mvourlakos: I think you can improve Latte now. :) of course! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabrica

D26266: Change remove action's icon to "edit-delete"

mvourlakos added a comment. What is ConfigOverlay for plasma panels is using at its tooltip? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26266 To: trmdi, #latte_dock, #vdg, mvourlakos Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampalouka

D26238: Improve context menu

mvourlakos added a comment. In D26238#583563 , @trmdi wrote: > In D26238#583556 , @mvourlakos wrote: > > > In D26238#583555 , @trmdi wrote: > > > > > I

D26238: Improve context menu

mvourlakos added a comment. In D26238#583555 , @trmdi wrote: > In D26238#583551 , @mvourlakos wrote: > > > @trmdi I used Cuttlefish app, it points to **"edit"** > > > Maybe it's `document-edit`

D26238: Improve context menu

mvourlakos added a comment. @trmdi I used Cuttlefish app, it points to **"edit"** REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg, mvourlakos Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jralei

D26238: Improve context menu

mvourlakos added a subscriber: ngraham. mvourlakos added a comment. In D26238#583529 , @trmdi wrote: > In D26238#583386 , @ndavis wrote: > > > This seems inconsistent with the Plasma panel context men

D26238: Improve context menu

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. looks ok... I am not that fond of the second line separator but we can discuss this again in the future. REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https:

D26238: Improve context menu

mvourlakos added a comment. look ok! Can you please provide also the three screenshots mentioned earlier for reference? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg, mvourlakos Cc: ndavis, plasma-devel, LeGast00n, The-Feren-O

D26238: Improve context menu

mvourlakos added inline comments. INLINE COMMENTS > manager.h:114 > void hideLatteSettingsDialog(); > -Q_INVOKABLE void showLatteSettingsDialog(int page = > Latte::Types::LayoutPage); > +Q_INVOKABLE void showLatteSettingsDialog(int firstPage = > Latte::Types::LayoutPage, bool toogl

D26238: Improve context menu

mvourlakos added a comment. @trmdi based on your last commit: 1. you have made all showLatteSettingsDialog callers as togglers, meaning that : IF Latte Layouts manager is already shown and the user tries Layouts->Manage Layouts then the settings tab will switch to Latte Preferences wind

D26238: Improve context menu

mvourlakos added inline comments. INLINE COMMENTS > manager.cpp:419 > > void Manager::showLatteSettingsDialog(int page) > { We could try to rename the function to: void Manager::showLatteSettingsDialog(int firstPage, bool cycleBetweenPages = false) when cycleBetweenPages = true then the

D26238: Improve context menu

mvourlakos added a comment. In D26238#583413 , @trmdi wrote: > 1. It still works for other cases. Do you cycle in settings tabs with Meta+W, between Layouts and Preferences ? > 3. "Configure Application" sounds a bit unclearly. And i

D26238: Improve context menu

mvourlakos added a comment. the [Verb+Noun] sounds logical, updated names in my last comment REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg, mvourlakos Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fb

D26238: Improve context menu

mvourlakos added a comment. This commit needs to be split in different commits. Based on the approach I wil describe the issues of the commit and in what changes I can approve or not. SPLITTED COMMITS 1. The showLatteSettingsDialog() is used from more places and you have changed i

D25807: Allow to set the available screen rect/region from outside through dbus

mvourlakos added inline comments. INLINE COMMENTS > shellcorona.h:94 > +// plasmashellCorona's value > +QRegion _availableScreenRegion(int id) const; > +QRect _availableScreenRect(int id) const; maybe concerning naming, plasmaAvailableScreenRegion would be better > shellcorona.h:95

D25807: Allow to set the available screen rect/region from outside through dbus

mvourlakos added a comment. In D25807#581178 , @trmdi wrote: > In D25807#581161 , @mvourlakos wrote: > > > In D25807#581126 , @trmdi wrote: > > > > > @

D25807: Allow to set the available screen rect/region from outside through dbus

mvourlakos added a comment. In D25807#581126 , @trmdi wrote: > @mvourlakos > Latte can guard that the order of screens within Latte is synced with plasmashell right? Because I see this: https://github.com/KDE/latte-dock/blob/master/app/scree

D25807: Allow to set the available screen rect/region from outside through dbus

mvourlakos added a comment. @trmdi this is a big change so it needs first to be approved theoretically from main plasma devs INLINE COMMENTS > shellcorona.cpp:1046 > > QRegion ShellCorona::availableScreenRegion(int id) const > +if > (!m_otherShellHelper->availableScreenRegion(static_cast

D25392: [414174] - Panel background transition color bug

mvourlakos added a comment. Nice! I will include it also for upcoming Latte v,0. 9.5 REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D25392 To: acemond, mvourlakos Cc: ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBo

D25392: [414174] - Panel background transition color bug

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. @acemond forget my previous comment... background transition works much better with your commit... do you have commit access? REPOSITORY R878 Latte Dock REVISION DETAIL https

D25392: [414174] - Panel background transition color bug

mvourlakos added a comment. The second behavior shouldn't be needed, it is already covered by the first one REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D25392 To: acemond, mvourlakos Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D15702: User can define margins for the desktop

mvourlakos added a comment. this is not needed any more... https://phabricator.kde.org/R120:328817b582fa is going to help to add transparent plasma panels below Latte docks/panels REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15702 To: mvourlakos, #plasma,

D25121: update panel shadows when background hints are changed

This revision was automatically updated to reflect the committed changes. Closed by commit R120:328817b582fa: update panel shadows when background hints are changed (authored by mvourlakos). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25121?vs=6919

D25121: update panel shadows when background hints are changed

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --when the containment background hints are updated then the panel shadows should be al

PanelView::backgroundHints

Hello everyone, I have a workaround for Latte and Plasma elements positioning issues discussed at: https://phabricator.kde.org/T10172 What I can not find is a way to set the backgroundHints for a Plasma::PanelView / Plasma::Containment. Is this possible through configuration files or dbus calls?

D22912: Fix build with clang 9.0

mvourlakos closed this revision. mvourlakos added a comment. this code has already been applied... https://phabricator.kde.org/source/latte-dock/browse/master/app/settings/delegates/persistentmenu.h REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D22912 To: bero

D22589: Embrace X-KDE-Wayland-Interfaces

mvourlakos added a comment. In D22589#499203 , @davidedmundson wrote: > > Thanks I will add it! > > And make sure your exec line is an absolute path OH!!! I would had missed that one REPOSITORY R120 Plasma Workspace BRANCH maste

D22589: Embrace X-KDE-Wayland-Interfaces

mvourlakos added a comment. In D22589#499012 , @zzag wrote: > @mvourlakos Perhaps Latte-Dock will need to set X-KDE-Wayland-Interfaces too (I assume that Latte-Dock uses libtaskmanager). Thanks I will add it! REPOSITORY R120 Plasma Wor

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

mvourlakos added a comment. In D22468#496123 , @ngraham wrote: > I guess I was thinking that it should be aligned to the slider itself, like this: > > Scale: |---o---| > 1x 1.5x2x > Yep

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

mvourlakos added a comment. In D22468#496052 , @ngraham wrote: > For the scale slider, I'd put the numbers underneath, and have threenumbers; one on each end and one in the middle. So if the maximum value was 2x, it would look like this: > >

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

mvourlakos added a subscriber: ngraham. mvourlakos added a comment. In D22468#495723 , @romangg wrote: > In D22468#495719 , @mvourlakos wrote: > > > This looks really nice, > > > > one question,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

mvourlakos added a comment. This looks really nice, one question, having current values under the Slider does it follow a HIG rule or is it a proposition? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin Cc: mvourlakos, knambiar

Re: Technical Advise for PlasmaQuick::ContainmentView [Latte]

ς 1:47 μ.μ., ο/η Marco Martin έγραψε: > On Mon, Jul 1, 2019 at 12:20 PM Michail Vourlakos > wrote: > > > > Thank for the response Martin, > > I ended up recreating the View and does the trick but that has some > downsides from accessibility and user point of

Re: Technical Advise for PlasmaQuick::ContainmentView [Latte]

> On Thu, Jun 20, 2019 at 11:15 AM Michail Vourlakos > wrote: > > > > Hello everyone, > > > > I need some help, Latte::Indicators ( > https://store.kde.org/browse/cat/563/) are standalone qml only packages > like plasma applets which are loaded in order to show

Technical Advise for PlasmaQuick::ContainmentView [Latte]

Hello everyone, I need some help, Latte::Indicators (https://store.kde.org/browse/cat/563/) are standalone qml only packages like plasma applets which are loaded in order to show Tasks indication/information My issue is that when an indicator's qml code is updated I would like the user to notice

Re: Plasma dialogs (and others?) disappearing on wayland + Qt 5.13

[1] this occurs in my system since always (even back to Qt 5.11) but I always thought that it might be a drivers issue (I have an optimus laptop so I can not trust it) probably with Qt 5.13 might hit more users. [2] in the same category one more major issue under wayland in my system is that the

D21013: [PanelView] remove outdated hack to support mask without compositing

mvourlakos added a comment. In D21013#460765 , @kossebau wrote: > Eek, sorry for breaking things. Will have some thoughts about it. > Though, hm, `item->window()->mask().isNull()` is really a random heuristic asking to break sooner or later,

D21013: [PanelView] remove outdated hack to support mask without compositing

mvourlakos added a subscriber: davidedmundson. mvourlakos added a comment. In D21013#460745 , @kossebau wrote: > In D21013#460743 , @mvourlakos wrote: > > > @kossebau one information please, with thi

D21013: [PanelView] remove outdated hack to support mask without compositing

mvourlakos added a comment. @kossebau one information please, with this set of paches the svg mask is also applied and in COMPOSITING state for the panels? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21013 To: kossebau, #plasma Cc: mvourlakos, plasma-de

D20774: Import QtGraphicalEffects 1.0 instead of 1.2 to fix dependency issue.

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. no prob, this is a new introduced code for scrolling tasks it shouldnt break something REPOSITORY R878 Latte Dock BRANCH qtgraphicaleffects-dependency (branched from master) R

D20130: Add option to show window title instead of app name when the window is maximized

mvourlakos added subscribers: ngraham, mvourlakos. mvourlakos added a comment. @ngraham I am not involved in AWC in any way REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D20130 To: kirstus, martinkostolny, #plasma, Zren Cc: mvourlakos

Re: More Love for Aether

maybe irrelevant but it has a bug concerning its panel shadows... The theme has a small bug. It misses a "shadow-center" element. Without this element plasma framework does not indicate that there is a full shadow element in the svgs. 1. This is the reason you do not see the shadow in plasma sys

D20249: Make the Configuration button more understandable

mvourlakos added a comment. Following the comments I have updated a bit the Rearrange button, these are some results with the new approach: normal: F6756477: image.png hovered: F6756481: image.png

D20249: Make the Configuration button more understandable

mvourlakos added inline comments. INLINE COMMENTS > HeaderSettings.qml:87 > +textColor: colorizerManager.buttonTextColor > +backgroundColor: containsMouse? colorizerManager.buttonHoverColor : > colorizerManager.buttonBackgroundColor > checkedTextColor: colorizerManager.h

D20249: Make the Configuration button more understandable

mvourlakos added a comment. he will be educated to do so REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D20249 To: trmdi, #latte_dock, rooty, mvourlakos Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D20249: Make the Configuration button more understandable

mvourlakos added a comment. I am not sure... I think would prefer a hovering mechanism, a rectangle with transparency e.g. 0.5 when this option is hovered REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D20249 To: trmdi, #latte_dock, rooty, mvourlakos Cc: mvourl

D20249: Make the Configuration button more understandable

mvourlakos added a comment. screenshots please REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D20249 To: trmdi, #latte_dock, rooty Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D20128: Center align shortcut badges when iconSize < 48

mvourlakos added a comment. From mathematical point of view, 58px. Is the first icon value that breaks the visual size we want for Badge, best fit is Badge to be 40% of height, but for 58px. is the first time that this is 41% going up to 50% when icon size 48px. But you are right icon

D19281: Highlight the hovered item in the task group tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R878:6f84812a537d: Highlight the hovered item in the task group tooltip (authored by nickguletskii, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kd

D19284: Close the window selected in the task group tooltip on middle click

This revision was automatically updated to reflect the committed changes. Closed by commit R878:0a3755dce570: Close the window selected in the task group tooltip on middle click (authored by nickguletskii, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https:/

D19281: Highlight the hovered item in the task group tooltip

mvourlakos added a comment. In D19281#440636 , @nickguletskii wrote: > Sorry, I don't believe I can land it myself since I don't have a developer account. ok, I will land it for you, can you provide your email? REPOSITORY R878 Latte D

D20128: Center align shortcut badges when iconSize < 48

mvourlakos added a comment. Oh, 0.4*60=24 No problem, it just was too clever! 1. Please set 58px. instead of 48px. for the checks 2. Please add a relevant comment why 58px. was chosen for the ckeck. 58px=23px so it is oversized when 24px. are applied afterwards it is ready to

D20128: Center align shortcut badges when iconSize < 48

mvourlakos added a comment. Checking the Badge height didn't work out well? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D20128 To: trmdi, #latte_dock Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D19281: Highlight the hovered item in the task group tooltip

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. I like it! can you apply it? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19281 To: nickguletskii, #latte_dock, mvourlakos Cc: mvourlakos, plasm

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mvourlakos added a comment. In D19822#435735 , @filipf wrote: > This is a good feature. I'd definitely add an option so it can be turned on/off regardless of how well we fix up the icon. Sometimes you need to dummy-proof installs so all that mat

Re: Plasma distro-specific installation path?

I am trying to find a way to access some application data. Examples are, plasma desktopthemes and kwin colorschemes... In the future this will also be needed because Latte will provide installable qml indicators (something like plasma qml applets currently do but these are going to be used only to

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

mvourlakos added a comment. I don't know if this can be of any help but this is supported by Latte dock, including scroll wheel to increase/decrease the specific audio stream volume REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #v

Plasma distro-specific installation path?

Hello, one question please: Is there any way to know from Qt/KDE frameworks side in which global installation path Plasma was installed? e.g. in Tumbleweed that is "/usr/share/plasma" but other distros there is a chance that use something different regards, michail Latte Dev Team

D19777: Apply changes for tooltip from upstream

mvourlakos accepted this revision. mvourlakos added a comment. I tested it and I like it a lot... I dont know how to show album art but it works just fine... big improvement!!! @trmdi please apply it REPOSITORY R878 Latte Dock BRANCH update-tooltip (branched from master) REVISION

D17073: Do not crop albumArt

mvourlakos added a comment. In D17073#431047 , @rooty wrote: > P.S. We could also implement this in latte-dock. Not just that, but also give latte's ToolTipInstance a makeover (the fonts are really huge). No problem... Concerning Latte, j

D19309: Improve Unity Indicator

This revision was automatically updated to reflect the committed changes. Closed by commit R878:cf0182e827c6: Improve Unity Indicator (authored by trmdi, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19309?vs=52545&id=53143 REVIS

D19284: Close the window selected in the task group tooltip on middle click

mvourlakos added a comment. I can commit this for you, but I need an email address REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19284 To: nickguletskii, #latte_dock, mvourlakos Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19309: Improve Unity Indicator

mvourlakos added a comment. @trmdi do you have commit access? If not you can apply for one and you can reference me REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19309 To: trmdi, #latte_dock, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zren

D19444: Make long menus scrollable instead of expanding horizontally

mvourlakos added a comment. This issue has an origin from : https://github.com/psifidotos/applet-window-appmenu/issues/45 menus dont respect the available screen size REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19444 To: ngraham, #breeze, broulik Cc: mvourla

D19279: Make the group activation action configurable

mvourlakos added a comment. In D19279#418826 , @nickguletskii wrote: > Hmm, sorry, I couldn't get the master branch to start on my machine, and since I've only used v0.8, I didn't realise this is already implemented. My mistake. why you

D19281: Highlight the hovered item in the task group tooltip

mvourlakos requested changes to this revision. mvourlakos added a comment. This revision now requires changes to proceed. 1. you must rebase it with master somehow otherwise I cant test/review this 2. I like the idea but I dont like how it looks, I find it too intrusive. I could accept the f

D19274: i18n: Do not refer to parent directory from Messages.sh

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. makes sense REPOSITORY R878 Latte Dock BRANCH messages-sh REVISION DETAIL https://phabricator.kde.org/D19274 To: aspotashev, mvourlakos Cc: plasma-devel, jraleigh, GB_2, rag

D19284: Close the window selected in the task group tooltip on middle click

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. this ok ... REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19284 To: nickguletskii, #latte_dock, mvourlakos Cc: mvourlakos, plasma-devel, jraleigh, GB_

D19279: Make the group activation action configurable

mvourlakos added a comment. I am sorry but this isnt already supported? F6633078: image.png REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19279 To: nickguletskii, #latte_dock Cc: mvourlakos, plasma-devel, jraleigh, GB_

D19126: block screen filtering for global menu applet

This revision was automatically updated to reflect the committed changes. Closed by commit R120:39d220b4b657: block screen filtering for global menu applet (authored by mvourlakos). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19126?vs=52168&id=5217

D19126: block screen filtering for global menu applet

mvourlakos added a comment. In D19126#415585 , @davidedmundson wrote: > David I followed your proposal, in case this is approved I believe that it should be provided also for plasma 5.15. Do you agree to cherry-pick it from master

D19126: block screen filtering for global menu applet

mvourlakos updated this revision to Diff 52168. mvourlakos added a comment. - follow David comment for devicePixelRation usage REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19126?vs=52000&id=52168 BRANCH bug404500 REVISION DETAIL https://pha

D19126: block screen filtering for global menu applet

mvourlakos added a comment. In D19126#415295 , @davidedmundson wrote: > > I tried to adjust to your proposal David but there is no qApp->scale() . What I found is, **QScreen::devicePixelRatio()** so we need to know first the screen

D19126: block screen filtering for global menu applet

mvourlakos added a comment. In D19126#415295 , @davidedmundson wrote: > The problem does not exist in wayland. nice, in that case I think that your proposal with a small comment why this is needed is good. I will update shortly. REPOSIT

D19126: block screen filtering for global menu applet

mvourlakos added a comment. In D19126#414995 , @davidedmundson wrote: > > For example if the user has set different scale factors between its screens is it going to work? > > It will not, but there is no UI option for that. one more

D19126: block screen filtering for global menu applet

mvourlakos added a comment. In D19126#414920 , @davidedmundson wrote: > If we're going to put in code, lets do: > > QPoint windowCentre = info.geometry().center(); > if (KWindowSystem::isPlatformX11()) { > windowCenter /= qApp->sc

D19126: block screen filtering for global menu applet

mvourlakos created this revision. mvourlakos added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY --when the user has enabled PLASMA_USE_QT_SCALING under X11 environment

Breeze Dark theme question ?

Hello dear plasma devs, one question in case you know the answer and can help. Breeze Dark plasma theme accomplishies the following: 1. For its applets does NOT show an active indicator line 2. For its PlasmaComponents2.TabBar it shows the active tab line just fine 3. In the plasma theme structur

D19002: Fix window thumbnails not working since frameworks 5.55

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. nice, can you commit it? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19002 To: mathiastillman, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen,

D18976: Improve Contextmenu

This revision was automatically updated to reflect the committed changes. Closed by commit R878:c893ab3d2281: Improve Contextmenu (authored by trmdi, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18976?vs=51613&id=51615 REVISION

D18976: Improve Contextmenu

mvourlakos added a comment. In D18976#411537 , @trmdi wrote: > Oh, wait... > I've just seen it is disabled unexpectedly. Do you know why ? yes, it comes from the setVisible(false) I dont know why, this is why I wanted to add in there:

D18976: Improve Contextmenu

mvourlakos added inline comments. INLINE COMMENTS > menu.cpp:85 > +m_configureAction->setVisible(!configuring); > +}); > + this bracket ident needs to be like the one from m_addWidgetsAction > menu.cpp:138 > > +m_configureAction->setText(i18nc("view settings window

D18918: Make the text of "View Settings" action more specific

mvourlakos added a comment. @trmdi please do me a favour: 1. close this review and open a clean new one because for some reason when trying to test it in my system includes also one old commit that I added the ViewType option 2. no problem with & characters you can add them 3. no pro

D18918: Make the text of "View Settings" action more specific

mvourlakos added inline comments. INLINE COMMENTS > menu.cpp:92 > +connect(this->containment(), > &Plasma::Containment::userConfiguringChanged, this, [&](bool configuring){ > +m_configureAction->setVisible(!configuring); > +}); in this slot is also needed: m_configure

  1   2   3   4   5   6   >