Hi,
+1 to what Carl said. Right now my Elisa barely needs any time to read my
music library, presumably because Baloo already has it indexed. It'll be
quite a shame if apps did their own indexing, wasting time and power.
The effects (of removing Baloo support) are even more pronounced if we
of the new scenario.
Thanks,
Shantanu Tushar
ease it anymore with Plasma/5.8.
>
> Thanks
>
> --
> Bhushan Shah
>
> http://bhush9.github.io
> IRC Nick : bshah on Freenode
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https:
they removed.
libs/mediacenter/lastfmimagefetcher.cpp (line 155)
<https://git.reviewboard.kde.org/r/125993/#comment60828>
remove the extra whitespace
- Shantanu Tushar
On Nov. 22, 2015, 2:23 p.m., Aditya Dev Sharma
absoluteFilePath instead of
doing a string concatenate.
- Shantanu Tushar
On April 22, 2015, 1:44 p.m., Ashish Madeti wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123467
not planning more
releases
since then we can just remove the l10n handlong in kde4 land altogether.
No, the kdelibs4 based version will not see a new release. We are focusing
all our efforts on the kf5/Plasma5 version now.
Cheers,
--
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122745/#review76752
---
Ship it!
Ship It!
- Shantanu Tushar
On Feb. 27, 2015, 4
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121144/#review70498
---
Ship it!
Ship It!
- Shantanu Tushar
On Nov. 17, 2014, 5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121130/#review70417
---
Ship it!
Ship It!
- Shantanu Tushar
On Nov. 15, 2014, 4
use auto
libs/mediacenter/abstractbrowsingbackend.cpp
https://git.reviewboard.kde.org/r/120980/#comment48874
return QStringList();
- Shantanu Tushar
On Nov. 4, 2014, 1:44 p.m., Bhushan Shah wrote:
---
This is an automatically
?
- Shantanu Tushar
On Nov. 2, 2014, 3:34 p.m., Ashish Bansal wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120855
?f=285t=121705#p316799
--
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
://git.reviewboard.kde.org/r/120298/#comment46833
In addition to this, can you qDebug the error message so that when this
fails in non-test scenarios, there is something to debug.
- Shantanu Tushar
On Sept. 20, 2014, 3:04 p.m., Bhushan Shah wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119218/#review67101
---
Ship it!
Ship It!
- Shantanu Tushar
On Sept. 20, 2014, 1
Sept. 20, 2014, 3:04 p.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith
Haridasan.
Repository: plasma-mediacenter
Description
---
This enables lastfmimagefetchertest again with error handling
Diffs
-
libs/mediacenter
Diff: https://git.reviewboard.kde.org/r/118866/diff/
Testing
---
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
://git.reviewboard.kde.org/r/118406/#comment44341
Video should not know about playlistModel
mediaelements/playlist/Playlist.qml
https://git.reviewboard.kde.org/r/118406/#comment44342
what is this for? it won't do anything
- Shantanu Tushar
On Aug. 1, 2014, 4:03 p.m., R.Harish Navnit wrote
/listinfo/plasma-devel
--
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/metadatamusicbackend.cpp
8b8e149
Diff: https://git.reviewboard.kde.org/r/118866/diff/
Testing
---
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/mediaplayer2player.h 203d681
libs/mpris2/mpris2.h 0df64f4
libs/mpris2/mpris2.cpp a8ad3ef
shells/newshell/main.cpp bab6915
shells/newshell/mainwindow.cpp d2d71d4
Diff: https://git.reviewboard.kde.org/r/116898/diff/
Testing
---
Thanks,
Shantanu Tushar
/2014/07/12/a4ed7663-64b6-4963-aed3-5e41cc8e51ee__showing-event.png
Editing dates of an existing event
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/965b667b-e209-44a3-bc64-95f81b18913e__editing-event.png
Thanks,
Shantanu Tushar
/a4ed7663-64b6-4963-aed3-5e41cc8e51ee__showing-event.png
Editing dates of an existing event
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/965b667b-e209-44a3-bc64-95f81b18913e__editing-event.png
Thanks,
Shantanu Tushar
___
Plasma-devel
,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Hi,
On Mon, Jul 14, 2014 at 2:16 PM, Marco Martin notm...@gmail.com wrote:
On Saturday 12 July 2014, Shantanu Tushar Jha wrote:
Hi folks,
The frameworks branch of PMC now contains a Plasma Shell which basically
loads the required QML components and looks/works exactly the same[1]. So
screen, by pressing a key instead of going to home screen every
time and going to settings menu.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
--
Shantanu Tushar(UTC +0530)
http
://git.reviewboard.kde.org/r/119250/#review62215
---
On July 12, 2014, 6:13 p.m., Shantanu Tushar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
or something).
* The device is a dedicated mediacenter device - the user tells Plasma to
always load mediacenter instead of deskop
Any other ideas? Thoughts?
[1] http://i.imgur.com/J16niw7.jpg
Cheers!
--
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com
://git.reviewboard.kde.org/r/119250/diff/
Testing
---
Seems to work as expected, I will be attaching screenshots.
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/07/12/965b667b-e209-44a3-bc64-95f81b18913e__editing-event.png
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On July 10, 2014, 6:36 p.m., Shantanu Tushar wrote:
My only problem with this is that its inconsistent with the Up/Down arrow
key combination that we have in MediaPlayer. Also, you can't make the
player also use Ctrl+Arrow keys because then a remote control won't work.
I'd suggest
://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
--
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com
On Thu, Jul 10, 2014 at 8:33 PM, Devanshu Jain devanshu.jain...@gmail.com
wrote:
Hi Shantanu,
I am using Ubuntu 14.04 and yes I have Qt installed.
On Thu, Jul 10, 2014 at 8:26 PM, Shantanu Tushar Jha shant...@kde.org
wrote:
Hi Devanshu,
What distro are you using? Also, how have you
try running this and pastebin the output -
VERBOSE=1 make
On Thu, Jul 10, 2014 at 9:57 PM, Devanshu Jain devanshu.jain...@gmail.com
wrote:
I started from scratch but make command is again giving the same error.
On Thu, Jul 10, 2014 at 9:45 PM, Shantanu Tushar Jha shant...@kde.org
wrote
...@gmail.com
wrote:
Here is the link to the output: http://paste.kde.org/pjyrnmzag
On Thu, Jul 10, 2014 at 10:33 PM, Shantanu Tushar Jha shant...@kde.org
wrote:
try running this and pastebin the output -
VERBOSE=1 make
On Thu, Jul 10, 2014 at 9:57 PM, Devanshu Jain
devanshu.jain...@gmail.com
a phone call. To
control the volume they can always press Esc and Up/Down.
- Shantanu Tushar
On July 10, 2014, 6:16 p.m., R.Harish Navnit wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On July 10, 2014, 6:36 p.m., Shantanu Tushar wrote:
My only problem with this is that its inconsistent with the Up/Down arrow
key combination that we have in MediaPlayer. Also, you can't make the
player also use Ctrl+Arrow keys because then a remote control won't work.
I'd suggest
and this can go in.
browsingbackends/utility/exit/exitbackend.cpp
https://git.reviewboard.kde.org/r/119015/#comment42806
this should not be needed anymore
- Shantanu Tushar
On June 29, 2014, 3:53 p.m., Sujith Haridasan wrote
/mediacontroller/MediaController.qml
https://git.reviewboard.kde.org/r/116874/#comment42305
runtimeData.playing || runtimeData.paused should work better, thats usually
the case in other media players
- Shantanu Tushar
On June 19, 2014, 9:04 p.m., R.Harish Navnit wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review60669
---
Ship it!
Ship It!
- Shantanu Tushar
On June 21, 2014, 3
/
Testing
---
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/diff/
Testing
---
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On June 19, 2014, 8:16 a.m., Shantanu Tushar wrote:
Good analysis and fix. It is still broken if you do the following-
1. Have multiple playlists
2. Remove a playlist
3. Add a playlist
After this the highlight again stops to work, can you check?
Hmm I can no longer reproduce
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118824/#review60517
---
Ship it!
Ship It!
- Shantanu Tushar
On June 19, 2014, 6
and this can go in.
libs/mediacenter/playlistmodel.cpp
https://git.reviewboard.kde.org/r/118767/#comment42270
The explicit call to QVariant should not be needed
- Shantanu Tushar
On June 19, 2014, 4:30 p.m., Ashish Madeti wrote
. To reply, visit:
https://git.reviewboard.kde.org/r/118767/
On June 19th, 2014, 4:48 p.m. UTC, *Shantanu Tushar* wrote:
libs/mediacenter/playlistmodel.cpp
https://git.reviewboard.kde.org/r/118767/diff/2/?file=282626#file282626line56
(Diff
revision 2)
public:
56
d-playlistName
one you prefer.
For folks who don't have the code running, here's a before[2] and after[3].
Cheers!
[1]
commits.kde.org/plasma-mediacenter/1e77bc1e19fb9f59ebb82aad9e95ff7ad966f130
[2] http://i.imgur.com/DO5cCA3.jpg
[3] http://i.imgur.com/CNxPWiz.jpg
--
Shantanu Tushar(UTC +0530)
http
://git.reviewboard.kde.org/r/118759/#comment41879
I'd prefer
QDir(getPlaylistPath()).absoluteFilePath(d-playlistName)
- Shantanu Tushar
On June 15, 2014, 10:14 a.m., Ashish Madeti wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118759/#review60126
---
Ship it!
Ship It!
- Shantanu Tushar
On June 15, 2014, 12
://git.reviewboard.kde.org/r/118734/#comment41816
not needed (see above)
- Shantanu Tushar
On June 13, 2014, 5:13 p.m., Ashish Madeti wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118734/#review60073
---
Ship it!
Ship It!
- Shantanu Tushar
On June 14, 2014, 8
request for Plasma, Shantanu Tushar and Sinny Kumari.
Repository: plasma-mediacenter
Description
---
Change the currentIndex of playlistModel to -1 when a media is played from
somewhere other than playlist.
Diffs
-
libs/mediacenter/playlistmodel.h 0de7c56
libs
/medialibrarytest.cpp e1a8c9b
libs/test/mediatest.cpp 8fde60b
libs/test/pmcalbumtest.cpp 9f2b4c8
Diff: https://git.reviewboard.kde.org/r/118697/diff/
Testing
---
Unit tests pass. Added test to take care of the new scenario.
Thanks,
Shantanu Tushar
://git.reviewboard.kde.org/r/118691/#comment41712
currentIndex is not writable from QML so that PlaylistModel can have
complete control over it.
A better way is to create a slot called resetCurrentIndex in PlaylistModel
which will set it to -1.
- Shantanu Tushar
On June 12, 2014, 8:58 a.m., Ashish Madeti
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118691/#review59891
---
Ship it!
Ship It!
- Shantanu Tushar
On June 12, 2014, 5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118657/#review59816
---
Ship it!
Ship It!
- Shantanu Tushar
On June 11, 2014, 5
/
---
(Updated June 5, 2014, 8:47 a.m.)
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Bugs: 333764
http://bugs.kde.org/show_bug.cgi?id=333764
Repository: plasma-mediacenter
Description
---
If a media(in a playlist) is located
://git.reviewboard.kde.org/r/118406/
---
(Updated June 5, 2014, 8:47 a.m.)
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Bugs: 333764
http://bugs.kde.org/show_bug.cgi?id=333764
Repository: plasma-mediacenter
/#comment41222
instead of guessing, why not use the error property of QML Video?
http://doc.qt.digia.com/qtmobility-1.2.0/qml-video.html#error-prop
- Shantanu Tushar
On June 3, 2014, 5:05 p.m., R.Harish Navnit wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118468/#review59005
---
Ship it!
Hmm, looks good to me.
- Shantanu Tushar
On June
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118092/#review58089
---
Ship it!
Ship It!
- Shantanu Tushar
On May 16, 2014, 6:36
) {
buttons.get(1).button.clicked();
}
- Shantanu Tushar
On May 16, 2014, 3:18 a.m., Sujith Haridasan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118092
request for Plasma, Shantanu Tushar and Sinny Kumari.
Bugs: 334148
http://bugs.kde.org/show_bug.cgi?id=334148
Repository: plasma-mediacenter
Description
---
Left and right movement in All Music - Songs section. Now user can navigate
left and right when in the songs section
/baloosearch/videosearchresulthandler.h 146efca
plugins/baloosearch/videosearchresulthandler.cpp 1295b30
Diff: https://git.reviewboard.kde.org/r/117984/diff/
Testing
---
Photos are fetched, the ones from my recent trip to Kashmir show up first ;)
Thanks,
Shantanu Tushar
://git.reviewboard.kde.org/r/118092/#comment40236
As this only puts focus on the tab bar, you have to press left/right twice
to make it work. Instead one press of the key should work.
- Shantanu Tushar
On May 12, 2014, 4:29 a.m., Sujith Haridasan wrote
---
Adding songs to playlist, local pictures previews, local videos previews etc
work fine.
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/118022/diff/
Testing
---
Adding songs to playlist, local pictures previews, local videos previews etc
work fine.
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
that
looks less confusing if it has the same number as frameworks and Qt
--
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
--
Shantanu Tushar(UTC +0530)
http
On May 4, 2014, 5:40 a.m., Bhushan Shah wrote:
Same should be applied to baloo mediasource. Nepomuk mediasource is kind of
deprecated.
I'm working on it and will be submitting a patch soon.
- Shantanu
---
This is an automatically
the following things-
* Album and Artist cover art
* Cover in MusicStats.qml when playing from a file
* Thumbnails in All Videos
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/videosearchresulthandler.cpp 1295b30
Diff: https://git.reviewboard.kde.org/r/117984/diff/
Testing
---
Photos are fetched, the ones from my recent trip to Kashmir show up first ;)
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
/kdedesktopsearch/kdemetadatamediasource.cpp
https://git.reviewboard.kde.org/r/117981/#comment39881
const QUrl
plugins/kdedesktopsearch/kdemetadatamediasource.cpp
https://git.reviewboard.kde.org/r/117981/#comment39880
Leftover?
- Shantanu Tushar
On May 4, 2014, 5:22 a.m., Sinny Kumari
764b228
Diff: https://git.reviewboard.kde.org/r/117983/diff/
Testing
---
Tested the following things-
* Album and Artist cover art
* Cover in MusicStats.qml when playing from a file
* Thumbnails in All Videos
Thanks,
Shantanu Tushar
___
Plasma
---
On May 1, 2014, 6:06 a.m., Shantanu Tushar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117915
size.
Diffs
-
mediaelements/imageviewer/ImageViewer.qml b182bf2
Diff: https://git.reviewboard.kde.org/r/117931/diff/
Testing
---
works with both portrait and landscape
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel
three types of media, works fine. Unit tests for the new code
to follow.
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
three types of media, works fine. Unit tests for the new code
to follow.
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On May 1, 2014, 6:06 a.m., Commit Hook wrote:
This review has been submitted with commit
121e51d74ff50a3644f275d5cfb571326c7a7286 by Shantanu Tushar to branch
master.
Had pushed this by mistake when trying to fix a bug, reverted it. The review is
still open.
- Shantanu
in with a minor fix-
libs/mediacenter/CMakeLists.txt
https://git.reviewboard.kde.org/r/117923/#comment39738
NEPOMUK_CORE_LIBRARY is not required
- Shantanu Tushar
On May 1, 2014, 7:32 a.m., Sinny Kumari wrote
once more before pushing to
master.
- Shantanu Tushar
On April 27, 2014, 7:12 p.m., Ashish Madeti wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117801
://git.reviewboard.kde.org/r/117931/diff/
Testing
---
works with both portrait and landscape
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
://git.reviewboard.kde.org/r/117867/diff/
Testing
---
Unit tests pass, functionality works as expected.
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/baloosearch/videosearchresulthandler.h PRE-CREATION
plugins/baloosearch/videosearchresulthandler.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/117915/diff/
Testing
---
Tested with all three types of media, works fine. Unit tests for the new code
to follow.
Thanks,
Shantanu
/singletonfactorytest.cpp b9fc987
libs/test/testhelpers.h
Diff: https://git.reviewboard.kde.org/r/117800/diff/
Testing
---
compiles, all unit tests pass
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org
as expected.
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/pmcmediatest.cpp 4bdcae6
libs/test/singletonfactorytest.h 79e4197
libs/test/singletonfactorytest.cpp b9fc987
libs/test/testhelpers.h 9825e85
Diff: https://git.reviewboard.kde.org/r/117800/diff/
Testing
---
compiles, all unit tests pass
Thanks,
Shantanu Tushar
/singletonfactorytest.h
libs/test/singletonfactorytest.cpp b9fc987
libs/test/testhelpers.h
Diff: https://git.reviewboard.kde.org/r/117800/diff/
Testing
---
compiles, all unit tests pass
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma
and choose
KDElibs. Then you can use Format files on your code to auto format it.
Otherwise you can use astyle.
- Shantanu Tushar
On April 27, 2014, 2:33 p.m., Ashish Madeti wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117732/#review56364
---
Ship it!
Ship It!
- Shantanu Tushar
On April 24, 2014, 6
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117691/#review56459
---
Ship it!
Ship It!
- Shantanu Tushar
On April 24, 2014, 5
?
- If yes, how exactly do you do it?
Help appreciated, so that our users can play their audio and video again ;)
Cheers,
[1]
http://cgit.freedesktop.org/gstreamer/gstreamer/tree/docs/random/porting-to-1.0.txtsection
Troubleshooting
[2] http://i.imgur.com/0k1TTwW.png
--
Shantanu Tushar(UTC
sure that all tests pass
before pushing.
libs/mediacenter/mediacenter.cpp
https://git.reviewboard.kde.org/r/117368/#comment38361
const QString pmc_path
- Shantanu Tushar
On April 4, 2014, 11:42 a.m., Nikolaos Chatzidakis wrote
/mediacenter/medialibrary.cpp
https://git.reviewboard.kde.org/r/117365/#comment38364
same as above
plugins/kdedesktopsearch/kdemetadatamediasource.cpp
https://git.reviewboard.kde.org/r/117365/#comment38365
Just for consistency, move this to the line after CreatedAtRole
- Shantanu Tushar
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117365/#review55005
---
Ship it!
Ship It!
- Shantanu Tushar
On April 4, 2014, 1
/
---
(Updated March 27, 2014, 11:22 a.m.)
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Bugs: 330990 and Bug
http://bugs.kde.org/show_bug.cgi?id=330990
http://bugs.kde.org/show_bug.cgi?id=Bug
Repository
Also, I think the right fix for these things is to use one of
PlasmaExtras.Heading, PlasmaExtras.Title (or PlasmaExtras.Paragraph when
applicable). Can someone else comment on whether making the font depend on
window size is a good idea?
- Shantanu Tushar
On March 26, 2014, 9:29 p.m., Nikolaos
26, 2014, 6:46 a.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith
Haridasan.
Repository: plasma-mediacenter
Description
---
Implemented Player DBus adaptor of MPRIS specifications for Plasma
Mediacenter.
Specification reference:
http
shells/newshell/main.cpp bab6915
shells/newshell/mainwindow.cpp d2d71d4
Diff: https://git.reviewboard.kde.org/r/116898/diff/
Testing
---
Thanks,
Shantanu Tushar
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman
://git.reviewboard.kde.org/r/116554/#comment37583
This processCommandLineArgs call (only the call) is still needed, otherwise
media passed as cmd line args wont play.
Please test before updating diff.
- Shantanu Tushar
On March 19, 2014, 6:30 a.m., Harshit Agarwal wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116554/#review53472
---
Ship it!
Ship It!
- Shantanu Tushar
On March 19, 2014, 6
1 - 100 of 483 matches
Mail list logo
