Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2017-02-08 Thread Uri Herrera
- Diff: https://git.reviewboard.kde.org/r/125568/diff/ Testing --- ![Before](http://i.imgur.com/Cz2JNee.png) ![After](http://i.imgur.com/hiZlyrb.png) ![Elements after](http://i.imgur.com/uMFsMzp.png) ![Elements before](http://i.imgur.com/pIs1CZ2.png) Thanks, Uri Herrera

Re: Review Request 126373: change the taskbar color from blue to gray

2015-12-20 Thread Uri Herrera
-- > > (Updated Dic. 16, 2015, 7:23 p.m.) > > > Review request for Plasma, Marco Martin and Uri Herrera. > > > Repository: plasma-framework > > > Description > --- > > Problem > === > with the new taskb

Re: Review Request 126166: use stylesheets in breeze icons

2015-11-26 Thread Uri Herrera
> On Nov. 26, 2015, 5 p.m., Marco Martin wrote: > > *please* VDG people, take a look at this asap. I already seen that new > > changes have been done to icons in master, which means that i'll have to > > redo this from scratch. > > Uri Herrera wrote: > Thi

Re: Review Request 126166: use stylesheets in breeze icons

2015-11-26 Thread Uri Herrera
-- > > (Updated Nov. 25, 2015, 1:54 p.m.) > > > Review request for Plasma, andreas kainz and Uri Herrera. > > > Repository: breeze-icons > > > Description > --- > > unfortunately the diff was about 35 megabytes, so was too big for reviewboa

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

2015-10-25 Thread Uri Herrera
> On Oct. 25, 2015, 11:08 p.m., Uri Herrera wrote: > > I agree with Thomas that having the button inside the thumbnail is > > confusing. > > > > ![](http://i.imgur.com/JlZveha.png) > > > > On this image I moved the button outside the thumbnail,

Re: Review Request 125793: [Task Manager] Add proper close button to tooltip

2015-10-25 Thread Uri Herrera
background. - Uri Herrera On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-16 Thread Uri Herrera
g5tsNs6 > > > > so it seems feasible, maybe ~1 day work to get all of it done, how do we > > go, plasma-framework branch? > > Uri Herrera wrote: > I think that if it's not going to be included as the main theme because > it needs to be fixed or whatever else that

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-14 Thread Uri Herrera
: https://git.reviewboard.kde.org/r/125568/#review86801 ------- On Oct. 11, 2015, 9:17 p.m., Uri Herrera wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125568/ > ---

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-11 Thread Uri Herrera
. Diffs - Diff: https://git.reviewboard.kde.org/r/125568/diff/ Testing --- ![Before](http://i.imgur.com/Cz2JNee.png) ![After](http://i.imgur.com/hiZlyrb.png) ![Elements after](http://i.imgur.com/uMFsMzp.png) ![Elements before](http://i.imgur.com/pIs1CZ2.png) Thanks, Uri Herrera

Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
- Diff: https://git.reviewboard.kde.org/r/125568/diff/ Testing (updated) --- ![Before](http://i.imgur.com/Cz2JNee.png) ![After](http://i.imgur.com/hiZlyrb.png) ![Elements after](http://i.imgur.com/uMFsMzp.png) ![Elements before](http://i.imgur.com/pIs1CZ2.png) Thanks, Uri Herrera

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
ther than vice-versa as it is now. > > Martin Klapetek wrote: > I agree with the icon. I feel like it's changing every release or so. > > Uri Herrera wrote: > Yeah, the shadows.. I was intending on having the shadows the same way > they're in the actual windows but I f

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
ther than vice-versa as it is now. > > Martin Klapetek wrote: > I agree with the icon. I feel like it's changing every release or so. > > Uri Herrera wrote: > Yeah, the shadows.. I was intending on having the shadows the same way > they're in the actual windows but I f

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
ther than vice-versa as it is now. > > Martin Klapetek wrote: > I agree with the icon. I feel like it's changing every release or so. > > Uri Herrera wrote: > Yeah, the shadows.. I was intending on having the shadows the same way > they're in the actual windows but I f

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
ther than vice-versa as it is now. > > Martin Klapetek wrote: > I agree with the icon. I feel like it's changing every release or so. > > Uri Herrera wrote: > Yeah, the shadows.. I was intending on having the shadows the same way > they're in the actual windows but I f

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
ther than vice-versa as it is now. > > Martin Klapetek wrote: > I agree with the icon. I feel like it's changing every release or so. > > Uri Herrera wrote: > Yeah, the shadows.. I was intending on having the shadows the same way > they're in the actual windows but I f

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
://git.reviewboard.kde.org/r/125568/diff/ Testing --- ![Before](http://i.imgur.com/Cz2JNee.png) ![After](http://i.imgur.com/hiZlyrb.png) ![Elements after](http://i.imgur.com/uMFsMzp.png) ![Elements before](http://i.imgur.com/pIs1CZ2.png) Thanks, Uri Herrera ___ Plasma

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
ther than vice-versa as it is now. > > Martin Klapetek wrote: > I agree with the icon. I feel like it's changing every release or so. > > Uri Herrera wrote: > Yeah, the shadows.. I was intending on having the shadows the same way > they're in the actual windows but I f

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
> convert monochrome icons to using stylesheets so even when icons from theme > and from plasma are mixed the colors would be correct > > Marco Martin wrote: > made a simple tool that applies the stylesheets to svgs replacing some > colors that come from the breeze palett

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
> convert monochrome icons to using stylesheets so even when icons from theme > and from plasma are mixed the colors would be correct > > Marco Martin wrote: > made a simple tool that applies the stylesheets to svgs replacing some > colors that come from the breeze palett

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
68/#review86527 --- On Oct. 9, 2015, 8:28 a.m., Uri Herrera wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
branding wise, to use the Plasma logo. But well I can change it... - Uri --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125568/#review86528 -----------

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
atically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125568/#review86531 ------- On Oct. 9, 2015, 8:28 a.m., Uri Herrera wrote: > > --- > This is an autom

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
icons. - Uri --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125568/#review86532 --- On Oct. 9, 2015, 8:28 a.m

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-09 Thread Uri Herrera
> On Oct. 9, 2015, 8:42 a.m., Marco Martin wrote: > > I would need to look at the file to see if the stylesheet are all fine. > > does it adapt correctly to breeze-dark without need for other svg files? > > Uri Herrera wrote: > I made a dark version too. It works f