dmitryshachnev added a comment.
> in KXMLGui applications you still get a traditional menu bar in addition to
the global menu, it seems it explicitly sets visible true on the menu bar - in
VLC it hides its own menu bar.
This will be fixed in Qt 5.7.1, see this commit
graesslin added inline comments.
INLINE COMMENTS
> CMakeLists.txt:10-13
> + find_package(XCB COMPONENTS XCB)
> + set_package_properties(XCB PROPERTIES DESCRIPTION "Required for exposing
> the global menu on X11"
> + TYPE REQUIRED
> +)
HAVE_X11
graesslin added a comment.
Trying to apply the patch results in conflicts in autotests/CMakeLists.txt
Trying to compile nevertheless without autotests gives me a compile error:
/home/martin/src/kf5/kde/workspace/plasma-integration/src/platformtheme/kdeplatformtheme.cpp:47:36:
graesslin added a comment.
In https://phabricator.kde.org/D3085#57496, @broulik wrote:
> To expose the menu id and object path as X/Wayland properties on the window
I would need to implement QDBusMenuBar myself as I need to implement
handleReparent as well as access m_objectPath which
broulik added a comment.
To expose the menu id and object path as X/Wayland properties on the window I
would need to implement QDBusMenuBar myself as I need to implement
handleReparent as well as access m_objectPath which is private. I'll see how it
goes.
REPOSITORY
rPLASMAINTEGRATION
graesslin added inline comments.
INLINE COMMENTS
> broulik wrote in kdeplatformtheme.cpp:59
> That's what Qt does and I don't think Qt is equipped to re-create a platform
> menu at runtime; at least that's what I was told when I raised the very same
> concern in the upstream Qt codereview that
broulik added a comment.
It's not much code on our side because Qt has the code nowadays. :)
INLINE COMMENTS
> graesslin wrote in FindQt5PlatformSupport.cmake:1
> given that it has my copyright I assume you copied from kwin - that would be
> a reason to move it to ecm. We have two users.
graesslin added a comment.
Overall significant less code than I expected - nice :-)
INLINE COMMENTS
> CMakeLists.txt:46
>
> +find_package(Qt5PlatformSupport REQUIRED)
> +
version 5.7?
> FindQt5PlatformSupport.cmake:1
> +#.rst:
> +# FindQt5PlatformSupport
given that it has my copyright I
