D26065: [KCM/Access] Port to use KConfigXT

2019-12-18 Thread Nathaniel Graham
ngraham added a comment. Sorry to invalidate your work. :/ Please feel free to review that patch! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26065 To: meven, ervin, #plasma, crossi Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26065: [KCM/Access] Port to use KConfigXT

2019-12-18 Thread Méven Car
meven abandoned this revision. meven added a comment. In D26065#579715 , @ngraham wrote: > FYI this KCM is also being rewritten in QML+KConfigXT somewhere else: D25375 Since the other diff seems quite

D26065: [KCM/Access] Port to use KConfigXT

2019-12-18 Thread Nathaniel Graham
ngraham added a comment. FYI this KCM is also being rewritten in QML+KConfigXT somewhere else: D25375 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26065 To: meven, ervin, #plasma, crossi Cc: ngraham, broulik,

D26065: [KCM/Access] Port to use KConfigXT

2019-12-18 Thread Méven Car
meven updated this revision to Diff 71757. meven added a comment. Remove unconvenient white space, add a else to a if block REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26065?vs=71756=71757 BRANCH kaccess-kconfigxt REVISION DETAIL

D26065: [KCM/Access] Port to use KConfigXT

2019-12-18 Thread Méven Car
meven updated this revision to Diff 71756. meven added a comment. Remove unconvenient white space, add a else to a if block REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26065?vs=71734=71756 BRANCH kaccess-kconfigxt REVISION DETAIL

D26065: [KCM/Access] Port to use KConfigXT

2019-12-17 Thread Méven Car
meven updated this revision to Diff 71734. meven marked 12 inline comments as done. meven added a comment. Address review REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26065?vs=71719=71734 BRANCH kaccess-kconfigxt REVISION DETAIL

D26065: [KCM/Access] Port to use KConfigXT

2019-12-17 Thread Kai Uwe Broulik
broulik added a comment. I read kaccess.cpp and commented on where the defaults diverge, there could be more. There's also some keys that have typos and/or don't match. This shows quite impressively why having this stuff in a central place is useful :) Given kaccess.cpp is what does the

D26065: [KCM/Access] Port to use KConfigXT

2019-12-17 Thread Méven Car
meven updated this revision to Diff 71719. meven added a comment. Fix some default values REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26065?vs=71716=71719 BRANCH kaccess-kconfigxt REVISION DETAIL https://phabricator.kde.org/D26065 AFFECTED

D26065: [KCM/Access] Port to use KConfigXT

2019-12-17 Thread Méven Car
meven created this revision. meven added reviewers: ervin, Plasma, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Tested changing settings REPOSITORY R119 Plasma Desktop BRANCH kaccess-kconfigxt REVISION