D26773: Added option to blur background on active window

niccolove added a comment. Sorry, forgot I was on a arc feature already! Forget the last commit REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26773 To: niccolove, #plasma Cc: mart, Zren, ngraham, anthonyfieroni, davidedmundson, plasma-devel, Orage,

D26773: Added option to blur background on active window

niccolove updated this revision to Diff 74439. niccolove added a comment. Set all proper leftMargins to smallSpacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26773?vs=73894=74439 BRANCH master REVISION DETAIL

D26773: Added option to blur background on active window

mart added a comment. I'm not sure about this. this looks like a nice playful addon i would expect from the KDE store, but not something in the default at all. As usual, this actually shows the need to have a nice framework for a "base" image wallpaper that then can be expanded in many

D26773: Added option to blur background on active window

Zren added a comment. I don't care if Inactive Blur is upstreamed or not as all my code is GPL. I didn't upstream it since I thought the feature was niche enough I shouldn't burden others with it's maintenance. This doesn't blur the desktop widgets,

D26773: Added option to blur background on active window

niccolove added a comment. Yes, I *DID* take some code from Zren plugin and wrote some other. My intention was absolutely not to steal his code, I want to be clear about that: I had opened an issue on his repo asking him to upstream the code, but then I thought that it was probably simple

D26773: Added option to blur background on active window

ngraham added a comment. There are legitimate questions regarding whether or not we should add this feature, and if this is the right place for it (a KWin effect intuitively seems more appropriate to me, if we upstream it). However aside from that, is this your code? The absence of a

D26773: Added option to blur background on active window

niccolove added a comment. Mh, but this is specifically to blur just the wallpaper, as you might want to get information from other windows. At that point, it would be weird for it to be a kwin effect, as it's much more related to just the wallpaper, and the user would expect it to be in

D26773: Added option to blur background on active window

anthonyfieroni added a comment. That's look interesting but indeed it should be a KWin feature, say it has effect `dim inactive` this should be `blur inactive` then wallpaper and any other inactive window will be blurred. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26773: Added option to blur background on active window

niccolove added a comment. I've tried to ask some users, and I received generally positive feedback on the idea, as many considered it pretty. There's a plugin that does this (with many positive reviews on the store), but I think it's not a good idea to fork very similar codebases, and this

D26773: Added option to blur background on active window

davidedmundson added a comment. What's the use case? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26773 To: niccolove, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26773: Added option to blur background on active window

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Create an option, off by default, that blurs the wallpaper when it detecs an open window. Currently it broke the transition