D28107: Fix overlayIcon sometimes not visible

davidre abandoned this revision. davidre added a comment. See D28208 for making things less complicated REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28107 To: davidre, kmaterka, #plasma, broulik, davidedmundson Cc:

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. In D28107#631804 , @kmaterka wrote: > In D28107#630144 , @davidre wrote: > > > It seems it is possible to do this (removing stuff from the data engine) after all. I will

D28107: Fix overlayIcon sometimes not visible

kmaterka added a comment. In D28107#630144 , @davidre wrote: > It seems it is possible to do this (removing stuff from the data engine) after all. I will try to work on this in the next time IMO, ideally `StatusNotifierItemSource` should

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. It seems it is possible to do this (removing stuff from the data engine) after all. I will try to work on this in the next time REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28107 To: davidre, kmaterka, #plasma, broulik,

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. In D28107#629521 , @kmaterka wrote: > Yep, icons in SNI are a mess... > Icons are processed in `StatusNotifierItemSource`, including overlay - that's were this should be fixed. From you comment I see it won't be

D28107: Fix overlayIcon sometimes not visible

kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. Yep, icons in SNI are a mess... Icons are processed in `StatusNotifierItemSource`, including overlay - that's were this should be fixed. From you comment I see it won't be

D28107: Fix overlayIcon sometimes not visible

davidre updated this revision to Diff 77866. davidre added a comment. Only set the role conditionally REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28107?vs=77853=77866 BRANCH workaround (branched from master) REVISION DETAIL

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. In D28107#629446 , @anthonyfieroni wrote: > Can we just set/clear OverlayIconName depends of icon presence then `overlays: model.OverlayIconName` ? Of course thats much easier! Thank you! REPOSITORY R120

D28107: Fix overlayIcon sometimes not visible

anthonyfieroni added a comment. Can we just set/clear OverlayIconName depends of icon presence then `overlays: model.OverlayIconName` ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28107 To: davidre, kmaterka, #plasma, broulik, davidedmundson Cc:

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. I don't think the described behavior is not a bug in IconItem but rather a quirk in the interaction of all three (data engine, IconItem and KIconEngine) components. SO nothing to fix on that side. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28107: Fix overlayIcon sometimes not visible

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Workaround a specific behavior in IconItem if the source is a QIcon with a name and pixmaps. IconItem will use the name to find