D9323: Use ScreenMapper everywhere as a singleton

2017-12-22 Thread Andras Mantia 
amantia closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D9323

To: amantia, #plasma, mwolff, hein
Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9323: Use ScreenMapper everywhere as a singleton

2017-12-18 Thread Milian Wolff 
mwolff accepted this revision.
This revision is now accepted and ready to land.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9323

To: amantia, #plasma, mwolff, hein
Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9323: Use ScreenMapper everywhere as a singleton

2017-12-18 Thread Laurent Montel 
mlaurent added a comment.


  Seems ok for me.

REVISION DETAIL
  https://phabricator.kde.org/D9323

To: amantia, #plasma, mwolff, hein
Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9323: Use ScreenMapper everywhere as a singleton

2017-12-14 Thread Andras Mantia 
amantia updated this revision to Diff 23897.
amantia added a comment.


  Connect to screenammper only if used as a containment

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9323?vs=23894=23897

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9323

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/autotests/positionertest.cpp
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h
  containments/desktop/plugins/folder/folderplugin.cpp
  containments/desktop/plugins/folder/screenmapper.h

To: amantia, #plasma, mwolff, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9323: Use ScreenMapper everywhere as a singleton

2017-12-14 Thread Andras Mantia 
amantia added inline comments.

INLINE COMMENTS

> broulik wrote in foldermodel.cpp:124
> Why have this member then?

For convenience

> broulik wrote in foldermodel.cpp:194
> I think we shouldn't connect to the signals if we're not a containment?

Yes, that makes sense, I will fix it

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9323

To: amantia, #plasma, mwolff, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9323: Use ScreenMapper everywhere as a singleton

2017-12-14 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> foldermodel.cpp:124
> +m_complete(false),
> +m_screenMapper(ScreenMapper::instance())
>  {

Why have this member then?

> foldermodel.cpp:194
>  
> +connect(m_screenMapper, ::screensChanged, this, 
> ::invalidateFilterIfComplete);
> +connect(m_screenMapper, ::screenMappingChanged, this, 
> ::invalidateFilterIfComplete);

I think we shouldn't connect to the signals if we're not a containment?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9323

To: amantia, #plasma, mwolff, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9323: Use ScreenMapper everywhere as a singleton

2017-12-14 Thread Andras Mantia 
amantia added reviewers: Plasma, mwolff, hein.
amantia set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D9323

To: amantia, #plasma, mwolff, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart