D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

graesslin added a comment. In D10816#233128 , @fvogt wrote: > In D10816#233088 , @graesslin wrote: > > > In D10816#233074 , @fvogt wrote: > > > > >

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

fvogt added a comment. In D10816#233088 , @graesslin wrote: > In D10816#233074 , @fvogt wrote: > > > `XDG_SESSION_TYPE` is not set if you run `startplasmacompositor` from a tty - so should this

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

graesslin added a comment. In D10816#233074 , @fvogt wrote: > `XDG_SESSION_TYPE` is not set if you run `startplasmacompositor` from a tty - so should this also check for `WAYLAND_DISPLAY` or `startplasmacompositor` set

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

fvogt added a comment. `XDG_SESSION_TYPE` is not set if you run `startplasmacompositor` from a tty - so should this also check for `WAYLAND_DISPLAY` or `startplasmacompositor` set `XDG_SESSION_TYPE=wayland`? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b5c326996309: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM (authored by graesslin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

romangg added a comment. Well we need to stop exporting the QT_QPA_PLATFORM value in startup script in any case, right? Or when we depend on Qt 5.11 and then set it to "wayland;x11" does it not break apps depending on Qt 5.y, y<11? So the question is just if we want to wait till we depend

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

davidedmundson added a comment. > interest to other apps as well, which can't yet rely on Qt 5.11 The 5.11 changes are about runtime Qt, not any new API. Apps will have to do nothing. The app itself can still rely on Qt5.0. - We discussed in the meeting, I still think

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

graesslin added a comment. In D10816#221084 , @romangg wrote: > Hmm, what about application distributed as distro packages? Anyways,if you think this is a non-issue, feel free to push. Let's be realistic. Many applications we ship don't

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Hmm, what about application distributed as distro packages? Anyways,if you think this is a non-issue, feel free to push. REPOSITORY R120 Plasma Workspace BRANCH platform-detection

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

graesslin added a comment. In D10816#220991 , @romangg wrote: > Shouldn't this function go directly in KWayland as some utily function `xdgSessionToQpaPlatform`? I believe it's generic enough for that and even though Qt 5.11 will have detection

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

romangg added a comment. Shouldn't this function go directly in KWayland as some utily function `xdgSessionToQpaPlatform`? I believe it's generic enough for that and even though Qt 5.11 will have detection for QT_QPA_PLATFORM the function could be of interest to other apps as well, which

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

graesslin updated this revision to Diff 28556. graesslin added a comment. - Reword documentation to make it more clear when it has to be called - rename to detectPlatform REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10816?vs=27985=28556

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

graesslin marked 2 inline comments as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10816 To: graesslin, #plasma Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

graesslin added a comment. In D10816#213801 , @broulik wrote: > Also I think all of this will become obsolete with Qt 5.11 where it supports multiple platform plugins as a fallback chain: https://codereview.qt-project.org/#/c/220294/

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

broulik added a comment. Also I think all of this will become obsolete with Qt 5.11 where it supports multiple platform plugins as a fallback chain: https://codereview.qt-project.org/#/c/220294/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10816 To:

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

broulik added inline comments. INLINE COMMENTS > kworkspace.h:161 > +* > +* This function must be invoked before the QGuiApplication instance is > constructed. > +* @since 5.13 Can you `assert` this? > kworkspace.h:164 > +**/ > + KWORKSPACE_EXPORT void platformDetection(int

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

romangg added a task: T8077: Do not set QT_QPA_PLATFORM to wayland at session startup. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10816 To: graesslin, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY This is a preparation step to unset QT_QPA_PLATFORM from