D11292: [RFC] Ordered system tray v2

Pitel abandoned this revision. Pitel added a comment. Replaced by D11352 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11292 To: Pitel, #plasma, #vdg Cc: mart, zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham,

D11292: [RFC] Ordered system tray v2

Pitel added a comment. To compare with auto ordering (as @mart would like) see D11352 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11292 To: Pitel, #plasma, #vdg Cc: mart, zzag, davidedmundson, anthonyfieroni,

D11292: [RFC] Ordered system tray v2

mart added a comment. i'm still against this, but in favor of just forcing sort by type and alphabetic REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11292 To: Pitel, #plasma, #vdg Cc: mart, zzag, davidedmundson, anthonyfieroni, wsdfhjxc, ngraham,

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. Currently dragging active items into the trash bin and saving changes results in setting auto visibility and displaying them at the end of both the system tray and configuration list, so it's not really deleting them from user's point of view. I was wondering,

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. I can no longer reproduce the issue with incorrect visibility state in checkboxes. It seems to be working correctly after last patch. Also, I've added some minor styling suggestions, so it looks a little bit more polished in my opinion. INLINE COMMENTS >

D11292: [RFC] Ordered system tray v2

Pitel updated this revision to Diff 29457. Pitel added a comment. - modified `onConfigurationChanged` so it triggers updates of properties depending on `cfg_shownItems` and `cfg_hiddenItems` - make trash bin not draggable - removed `ComboBox` hack (which was not working anyway) and added

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. I think it would be better to place new items on the left side of the system tray, as this is closer to default behavior. Also, sometimes the visibility state is updated incorrectly after moving items back and forth (showing hidden state for visible items). Other

D11292: [RFC] Ordered system tray v2

Pitel added a comment. In D11292#225006 , @davidedmundson wrote: > FWIW, the crash you're referring to is also fixed with an up-to-date (not released yet) Qt. If you are referring to https://codereview.qt-project.org/#/c/50/ I tried

D11292: [RFC] Ordered system tray v2

davidedmundson added a comment. FWIW, the crash you're referring to is also fixed with an up-to-date (not released yet) Qt. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11292 To: Pitel, #plasma, #vdg Cc: davidedmundson, anthonyfieroni, wsdfhjxc,

D11292: [RFC] Ordered system tray v2

anthonyfieroni added inline comments. INLINE COMMENTS > ConfigEntries.qml:110-119 > + /* for (var i = 0; i < statusNotifierModel_cfg.count; ++i) { > +var item = statusNotifierModel.get(i); > +itemInfo[item.Id] = { > "taskId": item.Id, >

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. In D11292#224949 , @Pitel wrote: > I am aware of `getFixedItemId`, only forgot to mention it in summary. Right now it is not included mostly because it is another hack (but fixing stupid behavior of someone else so

D11292: [RFC] Ordered system tray v2

Pitel added a comment. I am aware of `getFixedItemId`, only forgot to mention it in summary. Right now it is not included mostly because it is another hack (but fixing stupid behavior of someone else so unavoidable) and I do not use DropBox, but if this gets any closer to landing, we should

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. As for the getFixedItemId function (which was connected to an id trimming method in my example), it was because of Dropbox client's StatusNotifier item having some random number suffix. Without this, at every boot it was duplicated in the new config list-type

D11292: [RFC] Ordered system tray v2

Pitel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Pitel requested review of this revision. REVISION SUMMARY My try at ordered system try heavily inspired by D11233 .