D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf updated this revision to Diff 54460. filipf added a comment. Initial implementation of twinFormLayouts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19873?vs=54288=54460 BRANCH fix-hor-alignment (branched from master) REVISION DETAIL

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

mart added a comment. So, FormLayout has api to align two or more of them with each other, which is the list property FormLayout.twinFormLayouts I wonder if there is a way to make the parent and child formlayouts visible ot each other to use such property. the parent is in

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. In D19873#434571 , @davidre wrote: > It seems it was changed in this commit to explicitly use Kirigami units: 98d9f681a37e2ac2feb6bf5cb5e8a54f4c7e874e

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

davidre added a comment. It seems it was changed in this commit to explicitly use Kirigami units: 98d9f681a37e2ac2feb6bf5cb5e8a54f4c7e874e Was the Color wallpaper forgotten or did this reason not apply to it?

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. In D19873#434568 , @davidre wrote: > Mhm if I change it to use units like Color instead of Kirigami units it seems aligned properly: > F6702138: grafik.png The spacing in

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

davidre added a comment. Mhm if I change it to use units like Color instead of Kirigami units it seems aligned properly: F6702138: grafik.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf,

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

davidre added a comment. Maybe it would be worth it to check out how the other wallpaper plugins that don't suffer from this issue align their controls ? potd: F6702121: grafik.png color: F6702124: grafik.png

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a subscriber: mart. filipf added a comment. @mart would you happen to know how to trick one FormLayout into thinking its content is as wide as another FormLayout's content? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf,

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. In D19873#434468 , @ngraham wrote: > In D19873#434441 , @filipf wrote: > > > I just have to figure out how trick the image wallpaper's FormLayout into thinking its form is as

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

ngraham added a comment. In D19873#434441 , @filipf wrote: > I just have to figure out how trick the image wallpaper's FormLayout into thinking its form is as wide as the main one's. That's why. :) They come from different sources, so

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. In D19873#434426 , @ngraham wrote: > In D19873#434232 , @filipf wrote: > > > This is just theoretical, but what are the obstacles with adding this whole row to the actual

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

ngraham added a comment. In D19873#434232 , @filipf wrote: > This is just theoretical, but what are the obstacles with adding this whole row to the actual FormLayout file and just setting `visible: when_image_wallpaper_is_used` ?

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

abetts added a comment. +1 visually REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf, #plasma, ngraham Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. This is just theoretical, but what are the obstacles with adding this whole row to the actual FormLayout file and just setting `visible: when_image_wallpaper_is_used` ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To:

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. The spacing change is clearly correct. As for the width change, we should match the exact calculation used for the other combobox we're trying to match, which is `width:

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. I think I'm still off by a pixel, will test better tomorrow. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf, #plasma, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Master currently has bad horizontal alignment of the "Positioning:" row since it's not a part of the FormLayout as everything else.