This revision was automatically updated to reflect the committed changes.
Closed by commit R169:57266693f2fc: Replace the custom overflow button with
PrivateActionToolButton in ActionToolBar (authored by ahiemstra).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
ahiemstra marked 2 inline comments as done.
ahiemstra added inline comments.
INLINE COMMENTS
> ahiemstra wrote in ActionToolBar.qml:183
> Ah, I didn't know about `concat()`. I actually looked for something like that
> but seem to have missed it.
Of course, things weren't as simple as that
ahiemstra updated this revision to Diff 64810.
ahiemstra added a comment.
- Address review comments
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23502?vs=64755=64810
BRANCH
actionbutton_overflow
REVISION DETAIL
https://phabricator.kde.org/D23502
ahiemstra added inline comments.
INLINE COMMENTS
> apol wrote in ActionToolBar.qml:183
> it could be `children: [].concat(root.actions).concat(hiddenActions);` no?
Ah, I didn't know about `concat()`. I actually looked for something like that
but seem to have missed it.
REPOSITORY
R169
apol added inline comments.
INLINE COMMENTS
> ActionToolBar.qml:183
> +}
> +return result;
> }
it could be `children: [].concat(root.actions).concat(hiddenActions);` no?
> ActionToolBar.qml:207
>
> -onObjectAdded:
ahiemstra created this revision.
ahiemstra added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.
REVISION SUMMARY
With the fixes done to PrivateActionToolBar it now behaves a lot nicer
and we
