ngraham added a comment.
Landed this on the 5.17 branch just now to make sure it gets in for Plasma
5.17.2.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D24985
To: davidedmundson, #plasma, ngraham, davidre
Cc: davidre, apol, anthonyfieroni, plasma-devel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:868a6a9f6254: [wallpapers/image] Seed random number
generator (authored by davidedmundson, committed by ngraham).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
davidre accepted this revision.
davidre added a comment.
I think this is fine. Imo we can address the comments on master
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24985
To: davidedmundson, #plasma, ngraham, davidre
Cc: davidre, apol,
apol added a comment.
Let's use KCoreAddons/KRandom?
These things don't happen there.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24985
To: davidedmundson, #plasma, ngraham
Cc: apol, anthonyfieroni, plasma-devel, LeGast00n,
anthonyfieroni added inline comments.
INLINE COMMENTS
> slidefiltermodel.cpp:140
> std::iota(m_randomOrder.begin(), m_randomOrder.end(), 0);
> std::random_shuffle(m_randomOrder.begin(), m_randomOrder.end());
> }
random_shuffle is removed in C++17, so maybe we can change
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Otherwise when we randomise the wallpaper order we will always get the
