D25086: [WIP] Port to KGlobalAccel

davidre updated this revision to Diff 69483. davidre added a comment. update application for migration based on the one I did for spectacle REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69279=69483 BRANCH globalaccel (branched from

D25086: [WIP] Port to KGlobalAccel

davidre added a comment. In D25086#559109 , @mlaurent wrote: > For me it seems ok > > Did you finish it ? is it work ? or still in progress ? Shortcut setting and displaying works so far in my testing. I still need to do the

D25086: [WIP] Port to KGlobalAccel

mlaurent added a comment. For me it seems ok Did you finish it ? is it work ? or still in progress ? REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson, mlaurent Cc: apol, mlaurent, plasma-devel, LeGast00n,

D25086: [WIP] Port to KGlobalAccel

davidre updated this revision to Diff 69279. davidre marked an inline comment as done. davidre added a comment. Thanks for spotting! REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69107=69279 BRANCH globalaccel (branched from master)

D25086: [WIP] Port to KGlobalAccel

mlaurent added inline comments. INLINE COMMENTS > basictab.cpp:38 > > #ifndef Q_OS_WIN > +#include "globalaccel.h" still necessary to #ifndef ? REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson, mlaurent Cc: apol,

D25086: [WIP] Port to KGlobalAccel

davidre added inline comments. INLINE COMMENTS > globalaccel.cpp:50 > + > +QKeySequence GlobalAccel::getMenuEntryShortcut(const QString ) > +{ I think the list that is returned can have up to 2 entries. The shortcut and the alternate shortcut. However the currently Gui shows/configures only

D25086: [WIP] Port to KGlobalAccel

apol added inline comments. INLINE COMMENTS > globalaccel.cpp:50 > + > +QKeySequence GlobalAccel::getMenuEntryShortcut(const QString ) > +{ Why just return one if it can be a list? > globalaccel.h:27 > +public: > +static QKeySequence getMenuEntryShortcut(const QString ); > +static void

D25086: [WIP] Port to KGlobalAccel

davidre updated this revision to Diff 69107. davidre marked 4 inline comments as done. davidre added a comment. - comments REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69105=69107 BRANCH globalaccel (branched from master) REVISION

D25086: [WIP] Port to KGlobalAccel

mlaurent added inline comments. INLINE COMMENTS > globalaccel.cpp:55 > +const QList shortcut = > KGlobalAccel::self()->globalShortcut(desktopFile, QStringLiteral("_launch")); > +if (shortcut.size() > 0) { > +return shortcut[0]; if (!shortcut.isEmpty()) { > menuinfo.cpp:180 >

D25086: [WIP] Port to KGlobalAccel

davidre marked an inline comment as done. davidre added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:39 > Why removing it ? Accidentally REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson, mlaurent

D25086: [WIP] Port to KGlobalAccel

davidre updated this revision to Diff 69105. davidre added a comment. - Don't delete disabled - Remove guards REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69095=69105 BRANCH globalaccel (branched from master) REVISION DETAIL

D25086: [WIP] Port to KGlobalAccel

mlaurent added inline comments. INLINE COMMENTS > CMakeLists.txt:39 > -find_package(KHotKeysDBusInterface QUIET) > -if (EXISTS "${CMAKE_SOURCE_DIR}/.git") > - add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) Why removing it ? REPOSITORY R103 KMenu Editor REVISION DETAIL

D25086: [WIP] Port to KGlobalAccel

davidedmundson added a comment. Concept We don't need WITH_GLOBALACCEL guards. It's a dep of kxmlgui which we link against anyway. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson Cc: plasma-devel, LeGast00n,

D25086: [WIP] Port to KGlobalAccel

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Replace KHotkeys with KGlobalAccel WIP because of missing migration REPOSITORY R103 KMenu Editor BRANCH globalaccel