This revision was automatically updated to reflect the committed changes.
Closed by commit R103:507bc58bf3e8: Port to KGlobalAccel (authored by davidre).
REPOSITORY
R103 KMenu Editor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25086?vs=69577=69913
REVISION DETAIL
davidre added a comment.
No, I wanted to let David take a second look. But I can commit later.
REPOSITORY
R103 KMenu Editor
BRANCH
globalaccel (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25086
To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent,
mlaurent added a comment.
Did you have some problem for commiting it ?
Regards
REPOSITORY
R103 KMenu Editor
BRANCH
globalaccel (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25086
To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel,
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
for me all is ok.
REPOSITORY
R103 KMenu Editor
BRANCH
globalaccel (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25086
To: davidre, #plasma,
davidre updated this revision to Diff 69577.
davidre marked 2 inline comments as done.
davidre added a comment.
QLatin1String
REPOSITORY
R103 KMenu Editor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25086?vs=69483=69577
BRANCH
globalaccel (branched from master)
REVISION
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
After that it seems ok for me
INLINE COMMENTS
> globalaccel.cpp:25
> +kmenueditGroup = KConfigGroup(,
> QStringLiteral("Data_%1").arg(i));
> +if
