D25086: Port to KGlobalAccel

2019-11-18 Thread David Redondo 
This revision was automatically updated to reflect the committed changes.
Closed by commit R103:507bc58bf3e8: Port to KGlobalAccel (authored by davidre).

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25086?vs=69577&id=69913

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  kconf_update/CMakeLists.txt
  kconf_update/globalaccel.cpp
  kconf_update/globalaccel.upd
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25086: Port to KGlobalAccel

2019-11-16 Thread David Redondo 
davidre added a comment.


  No, I wanted to let David take a second look. But I can commit later.

REPOSITORY
  R103 KMenu Editor

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25086: Port to KGlobalAccel

2019-11-16 Thread Laurent Montel 
mlaurent added a comment.


  Did you have some problem for commiting it ?
  Regards

REPOSITORY
  R103 KMenu Editor

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25086: Port to KGlobalAccel

2019-11-11 Thread Laurent Montel 
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  for me all is ok.

REPOSITORY
  R103 KMenu Editor

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25086: Port to KGlobalAccel

2019-11-11 Thread David Redondo 
davidre updated this revision to Diff 69577.
davidre marked 2 inline comments as done.
davidre added a comment.


  QLatin1String

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25086?vs=69483&id=69577

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  kconf_update/CMakeLists.txt
  kconf_update/globalaccel.cpp
  kconf_update/globalaccel.upd
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25086: Port to KGlobalAccel

2019-11-09 Thread Laurent Montel 
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  After that it seems ok for me

INLINE COMMENTS

> globalaccel.cpp:25
> +kmenueditGroup = KConfigGroup(&khotkeysrc, 
> QStringLiteral("Data_%1").arg(i));
> +if (kmenueditGroup.readEntry("Name", QString()) == 
> QStringLiteral("KMenuEdit")) {
> +foundKmenuedit = true;

QLatin1String("...") it's a minor optimization
--

> globalaccel.cpp:38
> +// only migrate the launch actions for now, not the default search 
> action
> +if (KConfigGroup(&khotkeysrc, groupName).readEntry("Type") != 
> QStringLiteral("MENUENTRY_SHORTCUT_ACTION_DATA")) {
> +continue;

same here

REPOSITORY
  R103 KMenu Editor

REVISION DETAIL
  https://phabricator.kde.org/D25086

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart