D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

davidre updated this revision to Diff 69301. davidre marked an inline comment as done. davidre added a comment. - const - System services REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25144?vs=69287=69301 BRANCH categorize (branched from

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kglobalshortcutseditor.cpp:436 > +// Do we have an application with that name? > +KService::List apps = >

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

ngraham added a comment. Oh I see lol. Well I guess my only complaint is with the name chosen for the Plasma category. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25144 To: davidre, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

davidre added a comment. In D25144#558670 , @ngraham wrote: > Hmm, I think that would be confusing. "Session" isn't the name of any user-facing applications. That stuff is really a part of Plasma, both technically speaking, and also in terms of

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

ngraham added a comment. Hmm, I think that would be confusing. "Session" isn't the name of any user-facing applications. That stuff is really a part of Plasma, both technically speaking, and also in terms of the user expectation. Is there any way we could force it to live in the

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

davidre added a comment. In D25144#558665 , @ngraham wrote: > In D25144#558663 , @davidre wrote: > > > In D25144#558630 , @ngraham wrote: > > > > >

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

ngraham added a comment. In D25144#558663 , @davidre wrote: > In D25144#558630 , @ngraham wrote: > > > However I see a problem with changing "Application Launchers" to "Applications": It implies

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

davidre added a comment. In D25144#558630 , @ngraham wrote: > However I see a problem with changing "Application Launchers" to "Applications": It implies that the items in that category will give you access to change all the shortcuts for those

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

ngraham added a comment. Instead of "Plasma", how about "System Services"? That would match the categories in the Notifications KCM's similar list. However I see a problem with changing "Application Launchers" to "Applications": It implies that the items in that category will give you

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Currently the shortcuts are divided into two lists. "Application Launchers" for shortcuts added via .desktop files (actually