D26039: [Plasma Style KCM] Add search filter

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b25a0d41985e: [Plasma Style KCM] Add search filter 
(authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=72088=72106

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> davidre wrote in themesmodel.cpp:237
> Is it also needed in a const member method?

Not strictly speaking indeed.

Now C++ being what it is you're never safe of someone introducing a member as 
mutable though. ;-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> themesmodel.cpp:161
> +QStringList themes;
> +const QStringList  = 
> QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, 
> QStringLiteral("plasma/desktoptheme"), QStandardPaths::LocateDirectory);
> +for(const QString  : packs) {

Yeah that doesn't look right. The load method is a straight copy from the old 
load method.

> themesmodel.cpp:237
> +
> +for (const auto  : m_data) {
> +if (item.pendingDeletion) {

Is it also needed in a const member method?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[David Redondo]

davidre updated this revision to Diff 72088.
davidre added a comment.


  Diff against master, somehow this branch is screwed up when using arc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=72087=72088

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[David Redondo]

davidre updated this revision to Diff 72087.
davidre marked 7 inline comments as done.
davidre added a comment.


  - ervin's comments
  - remove unused method declaration

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71760=72087

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  applets/icontasks/metadata.desktop
  applets/kicker/package/metadata.desktop
  applets/kickoff/package/contents/config/main.xml
  applets/kickoff/package/contents/ui/Header.qml
  applets/kimpanel/backend/ibus/CMakeLists.txt
  applets/kimpanel/backend/ibus/README
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/ibus15/README
  applets/kimpanel/backend/ibus/ibus15/panel.cpp
  applets/minimizeall/package/metadata.desktop
  applets/showActivityManager/package/metadata.desktop
  applets/showdesktop/package/metadata.desktop
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/package/metadata.desktop
  applets/window-list/metadata.desktop
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/ConfigOverlay.qml
  kaccess/kaccess.notifyrc
  kcms/access/kcmaccess.desktop
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/autostart/autostart.desktop
  kcms/baloo/kcm_baloofile.desktop
  kcms/baloo/package/metadata.desktop
  kcms/componentchooser/EXAMPLE.desktop
  kcms/componentchooser/componentchooser.desktop
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h
  kcms/icons/main.cpp
  kcms/kfontinst/dbus/fontinst.actions
  kcms/launch/launchfeedback.cpp
  kcms/launch/launchfeedback.h
  kcms/launch/launchfeedbacksettings.kcfgc
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/metadata.desktop
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/nightcolor/kcm_nightcolor.desktop
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml
  kcms/nightcolor/package/metadata.desktop
  kcms/notifications/package/contents/ui/main.qml
  kcms/solid_actions/device-actions/solid-device-Battery.desktop
  kcms/spellchecking/spellchecking.desktop
  kcms/style/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc
  org.kde.plasmashell.metainfo.xml
  toolboxes/desktoptoolbox/metadata.desktop
  toolboxes/paneltoolbox/metadata.desktop
  toolboxes/plasma-toolbox-paneltoolbox.desktop

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filterproxymodel.cpp:110
> +
> +bool FilterProxyModel::filterAcceptsRow(int source_row, const QModelIndex 
> _parent) const
> +{

Ditto

> filterproxymodel.h:61
> +
> +bool filterAcceptsRow(int source_row, const QModelIndex _parent) 
> const override;
> +

s/source_row/sourceRow/ same for source_parent

> ThemePreview.qml:180
>  Kirigami.Icon {
> -visible: model.followsSystemColors
> +visible: model.colorType == Private.ThemesModel.FollowsColorTheme
>  source: "color-profile"

Better use === with this bloody javascript

> themesmodel.cpp:161
> +QStringList themes;
> +const QStringList  = 
> QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, 
> QStringLiteral("plasma/desktoptheme"), QStandardPaths::LocateDirectory);
> +for(const QString  : packs) {

A ref on a temporary sounds like a bad idea to me.

> themesmodel.cpp:165
> +const QStringList  = cd.entryList(QDir::Dirs | QDir::Hidden 
> | QDir::NoDotAndDotDot);
> +Q_FOREACH (const QString , entries) {
> +const QString _metadata = ppath + QLatin1Char('/') + pack + 
> QStringLiteral("/metadata.desktop");

Don't use Q_FOREACH but a proper for in new code

> themesmodel.cpp:173
> +
> +for (const QString  : themes) {
> +int themeSepIndex = theme.lastIndexOf(QLatin1Char('/'), -1);

qAsConst(themes)

> themesmodel.cpp:237
> +
> +for (const auto  : m_data) {
> +if (item.pendingDeletion) {

qAsConst(m_data)

> themesmodel.h:65
> +
> +int rowCount(const QModelIndex ) const override;
> +QVariant data(const QModelIndex , int role) const override;

This one and the two following are missing the default values for their 
parameters (which parents have, I wish override would check for that too).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis, ngraham, ervin
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[Cyril Rossi]

crossi added a comment.


  In D26039#579546 , @davidre wrote:
  
  > - Only move to the next theme if the current selected one is marked for 
deletion
  >
  >   FYI I could spot this same bug in the colors kcm. Will fix after this
  
  
  Looks good to me.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[David Redondo]

davidre updated this revision to Diff 71760.
davidre added a comment.


  - Only move to the next theme if the current selected one is marked for 
deletion
  
  FYI I could spot this same bug in the colors kcm. Will fix after this

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71724=71760

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik, ndavis
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[Cyril Rossi]

crossi added a comment.


  In D26039#579253 , @davidre wrote:
  
  > - Reinstate isSaveNeeded
  > - Fix initial index and pendingDeletion
  
  
  I can confirm these issue are fixed.
  
  Still one concern, when setting an item for pending deletion, it moves the 
current index to the next item after the one marked for deletion. See the 
attachement below.
  
  Current style is Breeze Dark, I want to delete Nordic style.
  F7823665: D26039_before_delete.png 
  
  Once marked for deletion, Oxygen style is now selected
  F7823668: D26039_pending_delete.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Visually LGTM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[David Redondo]

davidre updated this revision to Diff 71724.
davidre added a comment.


  I think this signal is not needed

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71723=71724

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[David Redondo]

davidre updated this revision to Diff 71723.
davidre added a comment.


  Don't have a overly long line

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71722=71723

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[David Redondo]

davidre updated this revision to Diff 71722.
davidre marked an inline comment as done.
davidre added a comment.


  - better string

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71721=71722

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[David Redondo]

davidre updated this revision to Diff 71721.
davidre added a comment.


  Diff against master

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71720=71721

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[David Redondo]

davidre updated this revision to Diff 71720.
davidre marked 2 inline comments as done.
davidre added a comment.


  - Reinstate isSaveNeeded
  - Fix initial index and pendingDeletion

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26039?vs=71654=71720

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  applets/icontasks/metadata.desktop
  applets/kicker/package/metadata.desktop
  applets/kickoff/package/contents/config/main.xml
  applets/kickoff/package/contents/ui/Header.qml
  applets/kimpanel/backend/ibus/CMakeLists.txt
  applets/kimpanel/backend/ibus/README
  applets/kimpanel/backend/ibus/emojier/emojier.cpp
  applets/kimpanel/backend/ibus/ibus15/README
  applets/kimpanel/backend/ibus/ibus15/panel.cpp
  applets/minimizeall/package/metadata.desktop
  applets/showActivityManager/package/metadata.desktop
  applets/showdesktop/package/metadata.desktop
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/package/metadata.desktop
  applets/window-list/metadata.desktop
  containments/desktop/package/contents/ui/ActionButton.qml
  containments/desktop/package/contents/ui/ConfigOverlay.qml
  containments/panel/contents/ui/ConfigOverlay.qml
  kaccess/kaccess.notifyrc
  kcms/access/kcmaccess.desktop
  kcms/activities/kcm_activities.desktop
  kcms/activities/qml/activitiesTab/ActivitiesView.qml
  kcms/autostart/autostart.desktop
  kcms/baloo/kcm_baloofile.desktop
  kcms/baloo/package/metadata.desktop
  kcms/componentchooser/EXAMPLE.desktop
  kcms/componentchooser/componentchooser.desktop
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h
  kcms/icons/main.cpp
  kcms/kfontinst/dbus/fontinst.actions
  kcms/launch/launchfeedback.cpp
  kcms/launch/launchfeedback.h
  kcms/launch/launchfeedbacksettings.kcfgc
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/metadata.desktop
  kcms/mouse/kcm/libinput/main.qml
  kcms/mouse/kcm/libinput/main_deviceless.qml
  kcms/nightcolor/kcm_nightcolor.desktop
  kcms/nightcolor/package/contents/ui/LocationsAutoView.qml
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/TimingsView.qml
  kcms/nightcolor/package/contents/ui/main.qml
  kcms/nightcolor/package/metadata.desktop
  kcms/notifications/package/contents/ui/main.qml
  kcms/solid_actions/device-actions/solid-device-Battery.desktop
  kcms/spellchecking/spellchecking.desktop
  kcms/style/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc
  org.kde.plasmashell.metainfo.xml
  toolboxes/desktoptoolbox/metadata.desktop
  toolboxes/paneltoolbox/metadata.desktop
  toolboxes/plasma-toolbox-paneltoolbox.desktop

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[David Redondo]

davidre added a comment.


  In D26039#579200 , @crossi wrote:
  
  > Some concern here as I tested the patch. The filter is working but the 
implementation breaks some functionality.
  >
  > - At initialization, the current theme is not selected in the grid view.
  > - When settings a theme for deletion, it does not activate the apply button 
and the theme is no longer greyed out in the grid view.
  
  
  Curious every issue you describe works for me. It would surprise me because 
the relevant code should be copied as is from the colors kcm.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[Cyril Rossi]

crossi added a comment.


  Some concern here as I tested the patch. The filter is working but the 
implementation breaks some functionality.
  
  - At initialization, the current theme is not selected in the grid view.
  - When settings a theme for deletion, it does not activate the apply button 
and the theme is no longer greyed out in the grid view.

INLINE COMMENTS

> kcm.cpp:72
> +
> +connect(m_model, ::pendingDeletionsChanged, this, [this] {
> +setNeedsSave(true);

Should connect to KCMDesktopTheme::settingsChanged slot to request 
ManagedConfigModule to reassess isSaveNeeded().

> kcm.cpp:313
>  
> -bool KCMDesktopTheme::isSaveNeeded() const
> -{

Why removing this ?

It is necessary for ManagedConfigModule to enable the apply button when items 
are marked for deletion.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik
Cc: ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> main.qml:106
> +{text: i18n("Dark Themes"), filter: 
> Private.FilterProxyModel.DarkThemes},
> +{text: i18n("Themes following color scheme"), filter: 
> Private.FilterProxyModel.ThemesFollowingColors}
> +]

"Color scheme compatible" is a bit better because it won't get shortened and 
even if it does, it'll be easier to see what the filter does.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik
Cc: ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26039: [Plasma Style KCM] Add search filter

[David Redondo]

davidre created this revision.
davidre added reviewers: Plasma, VDG, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Addsm the ability to filter themes by name by typing in the search line or
  whether they use the current color scheme or if they are light or dark if they
  do not. To enable this the model is extracted out into its own class and a
  QSortFilterProxyModel is added for the Filtering. This is mostly based on the
  same functionality of the Colors KCM and uses the same heuristic to decide if 
a
  theme is light or dark.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

AFFECTED FILES
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/filterproxymodel.cpp
  kcms/desktoptheme/filterproxymodel.h
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/themesmodel.cpp
  kcms/desktoptheme/themesmodel.h

To: davidre, #plasma, #vdg, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart