D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo added a comment. before F8106544: Screenshot_20200216_100603.png after F8106545: Screenshot_20200216_102852.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26861

D26861: [Applet/Task Manager] Move audio indicator to the corner

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a35d2b9adf40: [Applet/Task Manager] Move audio indicator to the corner (authored by gvgeo, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham added a comment. Landing on master to be safe, but if Plasma people take a look later and like what they see, we can backport this to the stable branch. REPOSITORY R119 Plasma Desktop BRANCH pos2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26861 To:

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham added a comment. No response, assuming that means it's good. :) REPOSITORY R119 Plasma Desktop BRANCH pos2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26861 To: gvgeo, #vdg, #plasma, hein, ngraham Cc: broulik, Fuchs, ndavis, filipf, cblack,

D26861: [Applet/Task Manager] Move audio indicator to the corner

filipf added a comment. Well I tested this with several themes and it looks just fine on all of them except Sweet. A #plasma person should have a look at the code, but visually and usability-wise this is pretty good. REPOSITORY R119 Plasma Desktop

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham accepted this revision. ngraham added a comment. Yeah, it won't be perfect for everything, but I think it's better than what we have right now and fixes the bug. Is everyone okay with this? REPOSITORY R119 Plasma Desktop BRANCH pos2 (branched from master) REVISION DETAIL

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo added a comment. Never going to be correct. Sometimes the highlight touches the edges, other times have big margins. The aim was to avoid getting out of the svg frame. These changes focus even more on the breeze theme. Sweet theme has some issues. F7927628:

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo updated this revision to Diff 74298. gvgeo added a comment. Change line order. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26861?vs=74297=74298 BRANCH pos2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26861

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo updated this revision to Diff 74297. gvgeo added a comment. This revision is now accepted and ready to land. Increase right margins by 1.2 when need, to avoid highlight area been drawn out of the frame. Various little changes. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham added a comment. In D26861#599957 , @Fuchs wrote: > - Icon wise, given that it can still overlap with the app icon, I would prefer something that has a contrasting border, so e.g. a dark audio indicator is still visible on a dark app

D26861: [Applet/Task Manager] Move audio indicator to the corner

Fuchs added a comment. Looks good to me, thank you very much for the work :-) Sidesnotes that I mentioned in the group, just so they are documented here: - I think for a clickable action it can become too small, so it takes too much aiming. However, it doesn't get in the way, and

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo planned changes to this revision. gvgeo added a comment. In D26880#599939 , @filipf wrote: > I also just noticed a pre-existing bug - that the hover effect filling the mouse area doesn't work well when the icon is smaller: > >

D26861: [Applet/Task Manager] Move audio indicator to the corner

filipf added a comment. I don't use IOTM, but this looks quite alright to me. REPOSITORY R119 Plasma Desktop BRANCH audioshrink (branched from master) REVISION DETAIL https://phabricator.kde.org/D26861 To: gvgeo, #vdg, #plasma, hein, ngraham Cc: broulik, Fuchs, ndavis, filipf,

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham accepted this revision. ngraham added subscribers: cblack, filipf, ndavis, Fuchs, broulik. ngraham added a comment. This revision is now accepted and ready to land. I was working on a patch to improve things here and it was almost identical to this one. I think this is a good fix.

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo added a comment. Could not pin point a specific size to disable mute function. If it is still a problem with this patch, maybe need to disable it for 5.18, and add a config option in the next release. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, hein, ngraham. gvgeo added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY When vertical or Icon-only task manager, shrink click area 10% and indicator 30%.