keithzg requested changes to this revision.
keithzg added a comment.
This revision now requires changes to proceed.
Compiles when included in an Android Debug build but when attempting to run
an application I hit an immediate crash on startup with:
name=Android logcat
mart added inline comments.
INLINE COMMENTS
> broulik wrote in kirigamiplugin.h:58
> You sure a `qrc` URL turns into a local path (or rather Qt's internal `:/`
> magic path) like this?
i think only :/ works?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D28068
To:
broulik added inline comments.
INLINE COMMENTS
> kirigamiplugin.h:51
> #elif defined(KIRIGAMI_BUILD_TYPE_STATIC)
> -return filePath;
> +return QStringLiteral(":/org/kde/kirigami/") + path;
> #else
Doesn't that have to be `qrc` to be a valid URL?
> kirigamiplugin.h:58
> +{
nicolasfella created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
The current code is ... a mess. resolveFileUrl and resolveFilePath do very
similar things, except that one returns a
