D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham abandoned this revision. ngraham added a comment. Moved to Invent: https://invent.kde.org/plasma/breeze/-/merge_requests/3 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: cblack, ndavis, niccolove, The-Feren-OS-Dev,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a subscriber: cblack. ngraham added a comment. In D28317#660094 , @ndavis wrote: > In D28317#639653 , @ndavis wrote: > > > Do we really still need Breeze Light to be separate from

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#639653 , @ndavis wrote: > Do we really still need Breeze Light to be separate from Breeze? I think it would make more sense to have just Breeze Light and Breeze Dark colorschemes (delete Breeze Light, rename

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Forgot to change a few more of the selection colors. I might as well post the updated Breeze Dark version too. F8271896: Breeze10.colors F8271897: BreezeDark10.colors REPOSITORY

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#659952 , @ngraham wrote: > Thanks, that's fixed now. Is the tooltip background supposed to be this grayish color though? > > F8271573: Screenshot_20200429_124914.png

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Thanks, that's fixed now. Is the tooltip background supposed to be this grayish color though? F8271573: Screenshot_20200429_124914.png If we're go with a light tooltip, I think I'd prefer it to look like the current

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Oops, that's a leftover bit from when I was testing my changes to the Breeze QStyle. This color scheme is something I've been slowly working on for a while. New version with fixed selection color and darker titlebar: F8271489: Breeze10.colors

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. In D28317#659659 , @ndavis wrote: > Try this colorscheme for a while and see what you think of it: F8270901: Breeze10.colors Not bad! I like that the buttons are lighter

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Try this colorscheme for a while and see what you think of it: F8270896: BreezeDark10.colors REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81153. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81135=81153 BRANCH tools-area-color-changes-v3 REVISION DETAIL https://phabricator.kde.org/D28317 AFFECTED FILES

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81135. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81039=81135 BRANCH tools-area-color-changes REVISION DETAIL https://phabricator.kde.org/D28317 AFFECTED FILES

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Anyway color-wise, here's an example of using a darker tools area color to improve the at-a-glance detectability of the active window: F8256343: vokoscreenNG-2020-04-23_13-26-00.webm Thoughts? REPOSITORY R31 Breeze

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81039. ngraham added a comment. Hopefully fix it REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81027=81039 BRANCH tools-area-color-changes-v2 REVISION DETAIL https://phabricator.kde.org/D28317 AFFECTED

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. No wait, that would be half a gigabyte of stuff. Maybe not the best idea to zip it up. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#655922 , @ngraham wrote: > I mean, how to fix it with `arc`. :) I don't know what the branch looks like on your end. Maybe just zip up the whole repo and send it to me? REPOSITORY R31 Breeze REVISION

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. I mean, how to fix it with `arc`. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, LeGast00n, cblack, jraleigh,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. The event filter in `breezetoolsareamanager.cpp` already exists in the tools area patch and the other changes are incompatible with the current version of the tools area patch. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To:

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Definitely not sure. If you have an idea of what went wrong or how to fix it, I'm all ears. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Never mind, I was wrong, I see it in arcpatch-D27669. However, just to see what would happen, I made my arcpatch-D27669 branch the upstream of arcpatch-D28317 and it said that arcpatch-D28317 was behind a commit. Are you sure you've rebased against the tools area

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. `kstyle/breezetoolsareamanager.cpp` is added in D27669 . Maybe the problem is that D27669 has three commits in it, so arc gets confused? REPOSITORY R31 Breeze REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. It's the change to `kstyle/breezetoolsareamanager.cpp` that causes this patch to fail to apply. That file doesn't exist anywhere. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. How are you guys feeling about the colors here? The Tools Area color currently used in this patch and the mockups demos well, but I'm starting to wonder if we're regressing usability in the process. I'm starting to think that the color isn't dark enough to

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81027. ngraham added a comment. Oh lord REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81026=81027 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabricator.kde.org/D28317

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81026. ngraham added a comment. Arc, you are the worst REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81025=81026 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81024. ngraham added a comment. Remove merge conflict REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81023=81024 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81025. ngraham added a comment. Change the patch base, again REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81024=81025 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81023. ngraham added a comment. Rebase against tools area patch REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81022=81023 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81022. ngraham added a comment. Remove leftover CMake bit REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81021=81022 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81021. ngraham added a comment. Rebase on e9d658fcb1f9751a39180e79ccc66aff3a18599d REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=80762=81021 BRANCH tools-area-color-changes (branched from master) REVISION

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. the cmake file in `colors/` also needs to be updated for the patch to build. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Ugh REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. This time when I try to apply the patch, it fails. I have the most up to date version of D27669 too. ╭ …/src/kde/workspace/breeze   master  ╰ arc patch D28317 INFO Base commit is not in local repository; trying

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 80762. ngraham added a comment. Don't include merge conflict bits lol REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=80760=80762 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. I think we may need a kconf update script to migrate people to the new colors, since the colors in the current color scheme get cached in their config files. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 80760. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=80759=80760 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabricator.kde.org/D28317

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 80759. ngraham added a comment. Remove Breeze Light color scheme, per @ndavis's suggestion (I came to agree that it doesn't make sense to keep it around here; we can put it on GHNS along with "Breeze Classic" REPOSITORY R31 Breeze CHANGES SINCE LAST

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 80598. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79070=80598 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabricator.kde.org/D28317

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. It's not a terrible idea, I just need to think about it a bit. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#639693 , @ngraham wrote: > But would we still have Breeze, Breeze Light, and Breeze Dark Plasma themes? If we're going to get rid of the Breeze color scheme and just have light and dark, it might be a bit odd

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. But would we still have Breeze, Breeze Light, and Breeze Dark Plasma themes? If we're going to get rid of the Breeze color scheme and just have light and dark, it might be a bit odd to still have a Breeze Plasma theme. Also maybe we should discuss that after

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Do we really still need Breeze Light to be separate from Breeze? I think it would make more sense to have just Breeze Light and Breeze Dark. After that, we should refer to all light versions of Breeze as Breeze Light instead of just Breeze. Breeze should then only be

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. it succeeds. It probably doesn't need whatever commit it's trying to use. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. If you tell it to proceed after that, does it succeed or fail? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#639599 , @ngraham wrote: > You don't need to already be on the other branch, just apply this on top of master. If all goes well, `arc` should first apply D27669 , then this

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. You don't need to already be on the other branch, just apply this on top of master. If all goes well, `arc` should first apply D27669 , then this one. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. When I try to get this patch with `arc patch` on top of the branch for D27669 , git says a cherry pick failed. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. In D28317#639589 , @ndavis wrote: > yes Done. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#638344 , @ngraham wrote: > @ndavis like this? > > F8206344: Screenshot_20200330_123644.png yes REPOSITORY R31 Breeze REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79070. ngraham added a comment. Make the Tools Area patch the base commit, again REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79069=79070 BRANCH tools-area-color-changes (branched from master) REVISION

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79069. ngraham added a comment. Lighten the button when the window is inactive REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79066=79069 BRANCH tools-area-color-changes (branched from master) REVISION

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79066. ngraham added a comment. Make 86851917557ea7deeaaac05b3d62e021d93041e9 the base commit REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79063=79066 BRANCH tools-area-color-changes (branched from master)

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79063. ngraham added a comment. Make the close button red REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79062=79063 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Damn, that didn't work. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79062. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78686=79062 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabricator.kde.org/D28317

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. @ndavis like this? F8206344: Screenshot_20200330_123644.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added inline comments. INLINE COMMENTS > breeze.kcfg:36 > > -true > +false > Maybe instead of disabling this, we should make its color red? I like the circle and making it red would be more consistent with our icons. REPOSITORY R31 Breeze REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78686. ngraham added a comment. Don't forget to update `breeze.kcfg` too REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78676=78686 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78676. ngraham added a comment. Also change Breeze light (large diff because it was super inconsistent with the old Breeze, which is fixed here as a part of making it consistent with the new Breeze except for the titlebar color not changing)

D28317: Adjust default color scheme and titlebar appearance for Tools Area

davidre added a comment. In D28317#636115 , @ngraham wrote: > This isn't really a new version of Breeze Light. I see Breeze Light as the light version of Breeze Dark; both are unibody (titlebar is same color as window background), but one is

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. This isn't really a new version of Breeze Light. I see Breeze Light as the light version of Breeze Dark; both are unibody (titlebar is same color as window background), but one is light and the other is dark. That said, yeah, I wonder how many people will still

D28317: Adjust default color scheme and titlebar appearance for Tools Area

The-Feren-OS-Dev added a comment. In my honest opinion, it'd probably be good to also get rid of Breeze Light in a separate patch as TBH as I see it right now Breeze will make Breeze Light redundant by default post-this-patch since they'll both be Breeze Light in a sense. It just seems

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78666. ngraham added a comment. Also turn off the close button circle by default REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78665=78666 BRANCH tools-area-color-changes (branched from master) REVISION

D28317: Adjust default color scheme and titlebar appearance for Tools Area

niccolove added a comment. I also think that the circle around x should be removed :-) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, LeGast00n,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78665. ngraham added a comment. Complete colorscheme changes REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78584=78665 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. I don't think we're planning on changing Breeze Light or Breeze dark as a part of this Tools Area change. IMO they both become more coherent, implementing a unibody look that's entirely light or dark, while the new Breeze color scheme implements the color split

D28317: Adjust default color scheme and titlebar appearance for Tools Area

The-Feren-OS-Dev added a comment. In D28317#635865 , @ngraham wrote: > Sure, that seems reasonable. I guess the question is whether we should ship it in this repo, or make it a GHNS thing, as with the other old colorschemes like Norway, Wonton

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Some comparisons with and without the filled circle: F8201574: Kate - circle.png F8201576: Kate - no circle.png F8201578: Plasma config window - circle.png

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a subscriber: manueljlin. ngraham added a comment. In D28317#635580 , @broulik wrote: > You are not changing the close button to not be a filled circle, are you? Heh, I forgot to undo that change in my screenshots; I turn it

D28317: Adjust default color scheme and titlebar appearance for Tools Area

davidre added a comment. Will we ship a "Breeze classic" colorscheme/or decoration? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: davidre, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

broulik added a comment. You are not changing the close button to not be a filled circle, are you? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham created this revision. ngraham added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch adjusts the default Breeze color scheme to produce the final Tools Area