This revision was automatically updated to reflect the committed changes.
Closed by commit R114:2e0fd299caba: Port the dict applet to KF5 and QtQuick 2
(authored by dfaure).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8421?vs=22860=23273
REVISION
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R114 Plasma Addons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8421
To: dfaure, #plasma, davidedmundson
Cc: ngraham, anthonyfieroni, broulik, davidedmundson, plasma-devel,
dfaure edited the test plan for this revision.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D8421
To: dfaure, #plasma
Cc: ngraham, anthonyfieroni, broulik, davidedmundson, plasma-devel, #plasma,
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
dfaure added a dependent revision: D9003: Dict applet: implement config dialog
for choosing a dictionary.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D8421
To: dfaure, #plasma
Cc: anthonyfieroni, broulik, davidedmundson, plasma-devel, #plasma, ZrenBot,
dfaure updated this revision to Diff 22860.
dfaure added a comment.
Use a signal instead of invokeMethod
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8421?vs=22855=22860
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8421
dfaure added a comment.
In https://phabricator.kde.org/D8421#171420, @davidedmundson wrote:
> > What should happen when I do? Surely a webview won't fit there...
>
> We should show an icon (like a dictionary or something)
> which will show the popup with the relevant plasmoid.
>
anthonyfieroni added inline comments.
INLINE COMMENTS
> dict_object.cpp:42
> +// different thread -> use invokeMethod
> +QMetaObject::invokeMethod(m_dict, "lookup", Q_ARG(QString, word));
> + }
Why you prefer invoke rather than a signal ?
REPOSITORY
R114 Plasma Addons
davidedmundson added a comment.
> What should happen when I do? Surely a webview won't fit there...
We should show an icon (like a dictionary or something)
which will show the popup with the relevant plasmoid.
In theory this should all happen automatically if the minimum size hints
dfaure updated this revision to Diff 22855.
dfaure added a comment.
Remove old code, not used anymore.
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8421?vs=22852=22855
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8421
AFFECTED
dfaure updated this revision to Diff 22852.
dfaure edited the test plan for this revision.
dfaure added a comment.
clean up TODO
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8421?vs=21473=22852
BRANCH
master
REVISION DETAIL
dfaure edited the test plan for this revision.
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D8421
To: dfaure, #plasma
Cc: broulik, davidedmundson, plasma-devel, #plasma, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
dfaure added a comment.
In https://phabricator.kde.org/D8421#158352, @davidedmundson wrote:
> Have you added it to the panel?
What should happen when I do? Surely a webview won't fit there...
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D8421
dfaure updated this revision to Diff 21473.
dfaure added a comment.
Add support for clicking on links; improve layout a bit
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8421?vs=21127=21473
BRANCH
master
REVISION DETAIL
dfaure added inline comments.
INLINE COMMENTS
> dfaure wrote in main.qml:33
> `Layout.fillHeight: true` led to a 1-pixel-high webview, not good.
>
> `Layout.fillWidth: true` is good, it means I don't duplicate the width
> anymore.
>
> OK, and doing that in the TextField makes the applet
dfaure marked an inline comment as done.
dfaure added inline comments.
INLINE COMMENTS
> broulik wrote in main.qml:4
> Unused?
Ah, yes. That was for "formFactor" as in
https://techbase.kde.org/Development/Tutorials/Plasma5/QML2/GettingStarted#Minimum_size
(which I had to fix so the syntax
broulik added inline comments.
INLINE COMMENTS
> main.qml:4
> +import org.kde.plasma.components 2.0 as PlasmaComponents
> +import org.kde.plasma.plasmoid 2.0
> +import org.kde.plasma.core 2.0 as PlasmaCore
Unused?
> main.qml:22
> +implicitWidth: 400
> +Keys.onReturnPressed: {
>
davidedmundson added a comment.
Cool, thanks!
> Adding dict applet to desktop, works.
Have you added it to the panel?
INLINE COMMENTS
> main.qml:20
> +placeholderText: i18n("Enter word to define here")
> +// If this was widgets, I'd use QFontMetrics...
> +
dfaure created this revision.
dfaure added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
My wife was missing this applet, after migrating to Plasma 5.
Therefore I had to learn how to write
18 matches
Mail list logo
