This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b706bc73fa63: qPort to new connect api + use
constref (authored by mlaurent).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8476?vs=21324=21357
REVISION
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
port_to_new_connect_api
REVISION DETAIL
https://phabricator.kde.org/D8476
To: mlaurent, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
mlaurent updated this revision to Diff 21324.
mlaurent added a comment.
- Perhaps that qml doesn't support const QUrl &
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8476?vs=21315=21324
BRANCH
port_to_new_connect_api
REVISION DETAIL
mlaurent added inline comments.
INLINE COMMENTS
> broulik wrote in foldermodel.h:256
> Did you check whether QML can cope with `const &`? The `urls` is used in an
> `onMove` QML handler (I recall it not handling `const *` well)
I didn't see an error here, but perhaps I didn't test action which
broulik added inline comments.
INLINE COMMENTS
> foldermodel.h:256
> void requestRename() const;
> -void move(int x, int y, QList urls);
> +void move(int x, int y, const QList );
> void popupMenuAboutToShow(KIO::DropJob *dropJob, QMimeData
> *mimeData, int x,
mlaurent added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8476
To: mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mlaurent created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
BRANCH
port_to_new_connect_api
REVISION DETAIL
https://phabricator.kde.org/D8476
AFFECTED FILES
