amantia closed this revision.
REVISION DETAIL
https://phabricator.kde.org/D9323
To: amantia, #plasma, mwolff, hein
Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
mwolff accepted this revision.
This revision is now accepted and ready to land.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9323
To: amantia, #plasma, mwolff, hein
Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts,
mlaurent added a comment.
Seems ok for me.
REVISION DETAIL
https://phabricator.kde.org/D9323
To: amantia, #plasma, mwolff, hein
Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
amantia updated this revision to Diff 23897.
amantia added a comment.
Connect to screenammper only if used as a containment
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9323?vs=23894=23897
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9323
AFFECTED FILES
amantia added inline comments.
INLINE COMMENTS
> broulik wrote in foldermodel.cpp:124
> Why have this member then?
For convenience
> broulik wrote in foldermodel.cpp:194
> I think we shouldn't connect to the signals if we're not a containment?
Yes, that makes sense, I will fix it
REPOSITORY
broulik added inline comments.
INLINE COMMENTS
> foldermodel.cpp:124
> +m_complete(false),
> +m_screenMapper(ScreenMapper::instance())
> {
Why have this member then?
> foldermodel.cpp:194
>
> +connect(m_screenMapper, ::screensChanged, this,
> ::invalidateFilterIfComplete);
> +
amantia added reviewers: Plasma, mwolff, hein.
amantia set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
